Verify the injection error buffer is null-termined.

[cycript.git] / sig / ffi_type.cpp

diff --git a/sig/ffi_type.cpp b/sig/ffi_type.cpp
index 7d552ba9d77c7161af49b2c07d19f964d5b66d70..96f39bbbfaaa564a3575e308a8b7bd5e1893f4df 100644 (file)
--- a/sig/ffi_type.cpp
+++ b/sig/ffi_type.cpp
@@ -64,7 +64,7 @@ ffi_type *ObjectiveC(CYPool &pool, struct Type *type) {
 
         case array_P: {
             // XXX: this is really lame
-            ffi_type *aggregate(reinterpret_cast<ffi_type *>(pool(sizeof(ffi_type))));
+            ffi_type *aggregate(new(pool) ffi_type());
             aggregate->size = 0;
             aggregate->alignment = 0;
             aggregate->type = FFI_TYPE_STRUCT;
@@ -72,7 +72,7 @@ ffi_type *ObjectiveC(CYPool &pool, struct Type *type) {
             ffi_type *element(ObjectiveC(pool, type->data.data.type));
             size_t size(type->data.data.size);
 
-            aggregate->elements = reinterpret_cast<ffi_type **>(pool((size + 1) * sizeof(ffi_type *)));
+            aggregate->elements = new(pool) ffi_type *[size + 1];
             for (size_t i(0); i != size; ++i)
                 aggregate->elements[i] = element;
             aggregate->elements[size] = NULL;
@@ -98,12 +98,12 @@ ffi_type *ObjectiveC(CYPool &pool, struct Type *type) {
         case void_P: return &ffi_type_void;
 
         case struct_P: {
-            ffi_type *aggregate(reinterpret_cast<ffi_type *>(pool(sizeof(ffi_type))));
+            ffi_type *aggregate(new(pool) ffi_type());
             aggregate->size = 0;
             aggregate->alignment = 0;
             aggregate->type = FFI_TYPE_STRUCT;
 
-            aggregate->elements = reinterpret_cast<ffi_type **>(pool((type->data.signature.count + 1) * sizeof(ffi_type *)));
+            aggregate->elements = new(pool) ffi_type *[type->data.signature.count + 1];
             sig_ffi_types(pool, &ObjectiveC, &type->data.signature, aggregate->elements);
             aggregate->elements[type->data.signature.count] = NULL;
 
@@ -119,7 +119,7 @@ ffi_type *ObjectiveC(CYPool &pool, struct Type *type) {
 ffi_type *Java(CYPool &pool, struct Type *type) {
     switch (type->primitive) {
         case typename_P: return &ffi_type_pointer;
-        case union_P: return &ffi_type_pointer;
+        case union_P: _assert(false); break;
         case string_P: return &ffi_type_pointer;
         case selector_P: return &ffi_type_pointer;
         case block_P: return &ffi_type_pointer;
@@ -132,10 +132,7 @@ ffi_type *Java(CYPool &pool, struct Type *type) {
         case ushort_P: return &ffi_type_ushort;
         case array_P: return &ffi_type_pointer;
         case pointer_P: return &ffi_type_pointer;
-
-        /* XXX: bit type */
-        case bit_P: return &ffi_type_uint;
-
+        case bit_P: _assert(false); break;
         case char_P: return &ffi_type_schar;
         case double_P: return &ffi_type_double;
         case float_P: return &ffi_type_double;
@@ -162,7 +159,7 @@ void sig_ffi_cif(
     size_t offset
 ) {
     if (types == NULL)
-        types = reinterpret_cast<ffi_type **>(pool((signature->count - 1) * sizeof(ffi_type *)));
+        types = new(pool) ffi_type *[signature->count - 1];
     ffi_type *type = (*sig_ffi_type)(pool, signature->elements[0].type);
     sig_ffi_types(pool, sig_ffi_type, signature, types, 1 + skip, offset);
     ffi_status status = ffi_prep_cif(cif, FFI_DEFAULT_ABI, signature->count - 1 - skip + offset, type, types);