Removed a null-termination usage in Replace for concatenation of strings.

[cycript.git] / Replace.cpp

diff --git a/Replace.cpp b/Replace.cpp
index 5a2ed376d8da5a54a2ec217c51e6a69e8f0e3875..df67f44ad229f7cfb2b9f779266cefc2249f41ec 100644 (file)
--- a/Replace.cpp
+++ b/Replace.cpp
@@ -171,6 +171,10 @@ void CYDeclaration::Replace(CYContext &context) {
     context.Replace(initialiser_);
 }
 
+CYProperty *CYDeclarations::Property(CYContext &context) { $T(NULL)
+    return $ CYProperty(declaration_->identifier_, declaration_->initialiser_ ?: $U, next_->Property(context));
+}
+
 void CYDeclarations::Replace(CYContext &context) { $T()
     declaration_->Replace(context);
     next_->Replace(context);
@@ -259,13 +263,12 @@ CYStatement *CYForInComprehension::Replace(CYContext &context, CYStatement *stat
 CYStatement *CYForEachIn::Replace(CYContext &context) {
     CYVariable *cys($V("$cys")), *cyt($V("$cyt"));
 
-    return $ CYWith($ CYObject($ CYProperty($S("$cys"), $D(0), $ CYProperty($S("$cyt"), $D(0)))), $ CYBlock($$->*
-        $E($ CYAssign(cys, set_))->*
+    return $ CYLet($L2($L($I("$cys"), set_), $L($I("$cyt"))), $$->*
         $ CYForIn(cyt, cys, $ CYBlock($$->*
             $E($ CYAssign(initialiser_->ForEachIn(context), $M(cys, cyt)))->*
             code_
         ))
-    ));
+    );
 }
 
 CYFunctionParameter *CYForEachInComprehension::Parameter(CYContext &context) const {
@@ -334,6 +337,10 @@ CYStatement *CYLabel::Replace(CYContext &context) {
     return NULL;
 }
 
+CYStatement *CYLet::Replace(CYContext &context) {
+    return $ CYWith($ CYObject(declarations_->Property(context)), &code_);
+}
+
 void CYMember::Replace_(CYContext &context) {
     context.Replace(object_);
     context.Replace(property_);
@@ -409,7 +416,7 @@ CYString *CYString::Concat(CYContext &context, CYString *rhs) const {
     memcpy(value, value_, size_);
     memcpy(value + size_, rhs->value_, rhs->size_);
     value[size] = '\0';
-    return $S(value);
+    return $S(value, size);
 }
 
 CYNumber *CYString::Number(CYContext &context) {