tests: style changes in the Makefile.

* tests/local.mk: Prefer passing variable assignment by
the command line, instead of the environment, so that it
is reported in the logs.
Prefer single quotes for shell literal strings.

diff --git a/tests/local.mk b/tests/local.mk
index 12668c4187e6b0bfcc776eaacbdc37a5bdfee598..2cb1f3c1862e5fa2fbd5d96cd8ffdcc302c963fa 100644 (file)
--- a/tests/local.mk
+++ b/tests/local.mk
@@ -93,7 +93,7 @@ check-local: $(RUN_TESTSUITE_deps)
 
 # Run the test suite on the *installed* tree.
 installcheck-local: $(RUN_TESTSUITE_deps)
-       $(RUN_TESTSUITE) AUTOTEST_PATH="$(bindir)"
+       $(RUN_TESTSUITE) AUTOTEST_PATH='$(bindir)'
 
 # Be real mean with it.
 .PHONY: maintainer-check-g++
@@ -106,17 +106,20 @@ maintainer-check-posix: $(RUN_TESTSUITE_deps)
 
 .PHONY: maintainer-check-valgrind
 maintainer-check-valgrind: $(RUN_TESTSUITE_deps)
-       test -z '$(VALGRIND)' || \
-          VALGRIND_OPTS='--leak-check=full --show-reachable=yes' \
-          $(RUN_TESTSUITE) PREBISON='$(VALGRIND) -q' PREPARSER='$(VALGRIND) -q'
+       test -z '$(VALGRIND)' ||                                        \
+         $(RUN_TESTSUITE)                                              \
+           PREBISON='$(VALGRIND) -q' PREPARSER='$(VALGRIND) -q'        \
+           VALGRIND_OPTS='--leak-check=full --show-reachable=yes'
 
 .PHONY: maintainer-check
 maintainer-check: maintainer-check-posix maintainer-check-valgrind maintainer-check-g++
 
 .PHONY: maintainer-push-check
 maintainer-push-check:
-       BISON_USE_PUSH_FOR_PULL=1 $(MAKE) $(AM_MAKEFLAGS) maintainer-check
+       $(MAKE) $(AM_MAKEFLAGS) maintainer-check                        \
+         TESTSUITEFLAGS='BISON_USE_PUSH_FOR_PULL=1 $(TESTSUITEFLAGS)'
 
 .PHONY: maintainer-xml-check
 maintainer-xml-check:
-       BISON_TEST_XML=1 $(MAKE) $(AM_MAKEFLAGS) maintainer-check
+       $(MAKE) $(AM_MAKEFLAGS) maintainer-check                \
+         TESTSUITEFLAGS='BISON_TEST_XML=1 $(TESTSUITEFLAGS)'