From: Akim Demaille <akim@lrde.epita.fr>
Date: Sat, 24 Mar 2012 13:26:24 +0000 (+0100)
Subject: tests: style changes in the Makefile.
X-Git-Tag: v2.7.90~469
X-Git-Url: https://git.saurik.com/bison.git/commitdiff_plain/24d84dd26c24a33adf1ae4ba245c53901507e650?hp=--cc

tests: style changes in the Makefile.

* tests/local.mk: Prefer passing variable assignment by
the command line, instead of the environment, so that it
is reported in the logs.
Prefer single quotes for shell literal strings.
---

24d84dd26c24a33adf1ae4ba245c53901507e650
diff --git a/tests/local.mk b/tests/local.mk
index 12668c41..2cb1f3c1 100644
--- a/tests/local.mk
+++ b/tests/local.mk
@@ -93,7 +93,7 @@ check-local: $(RUN_TESTSUITE_deps)
 
 # Run the test suite on the *installed* tree.
 installcheck-local: $(RUN_TESTSUITE_deps)
-	$(RUN_TESTSUITE) AUTOTEST_PATH="$(bindir)"
+	$(RUN_TESTSUITE) AUTOTEST_PATH='$(bindir)'
 
 # Be real mean with it.
 .PHONY: maintainer-check-g++
@@ -106,17 +106,20 @@ maintainer-check-posix: $(RUN_TESTSUITE_deps)
 
 .PHONY: maintainer-check-valgrind
 maintainer-check-valgrind: $(RUN_TESTSUITE_deps)
-	test -z '$(VALGRIND)' || \
-	   VALGRIND_OPTS='--leak-check=full --show-reachable=yes' \
-	   $(RUN_TESTSUITE) PREBISON='$(VALGRIND) -q' PREPARSER='$(VALGRIND) -q'
+	test -z '$(VALGRIND)' ||					\
+	  $(RUN_TESTSUITE)						\
+	    PREBISON='$(VALGRIND) -q' PREPARSER='$(VALGRIND) -q'	\
+	    VALGRIND_OPTS='--leak-check=full --show-reachable=yes'
 
 .PHONY: maintainer-check
 maintainer-check: maintainer-check-posix maintainer-check-valgrind maintainer-check-g++
 
 .PHONY: maintainer-push-check
 maintainer-push-check:
-	BISON_USE_PUSH_FOR_PULL=1 $(MAKE) $(AM_MAKEFLAGS) maintainer-check
+	$(MAKE) $(AM_MAKEFLAGS) maintainer-check			\
+	  TESTSUITEFLAGS='BISON_USE_PUSH_FOR_PULL=1 $(TESTSUITEFLAGS)'
 
 .PHONY: maintainer-xml-check
 maintainer-xml-check:
-	BISON_TEST_XML=1 $(MAKE) $(AM_MAKEFLAGS) maintainer-check
+	$(MAKE) $(AM_MAKEFLAGS) maintainer-check		\
+	  TESTSUITEFLAGS='BISON_TEST_XML=1 $(TESTSUITEFLAGS)'