]>
Commit | Line | Data |
---|---|---|
2ed0e35f | 1 | This file attempts to describe the rules to use when hacking Bison. |
9126263e | 2 | Don't put this file into the distribution. |
2ed0e35f | 3 | |
f414d77d AD |
4 | Everything related to the development of Bison is on Savannah: |
5 | ||
26fccd4d | 6 | http://savannah.gnu.org/projects/bison/ |
f414d77d AD |
7 | |
8 | ||
2ed0e35f AD |
9 | * Administrivia |
10 | ||
11 | ** If you incorporate a change from somebody on the net: | |
12 | First, if it is a large change, you must make sure they have signed | |
13 | the appropriate paperwork. Second, be sure to add their name and | |
14 | email address to THANKS. | |
15 | ||
7de42e52 | 16 | ** If a change fixes a test, mention the test in the commit message. |
2ed0e35f AD |
17 | |
18 | ** Bug reports | |
7de42e52 | 19 | If somebody reports a new bug, mention his name in the commit message |
2ed0e35f AD |
20 | and in the test case you write. Put him into THANKS. |
21 | ||
22 | The correct response to most actual bugs is to write a new test case | |
23 | which demonstrates the bug. Then fix the bug, re-run the test suite, | |
24 | and check everything in. | |
25 | ||
f414d77d | 26 | |
427c0dda AD |
27 | * Hacking |
28 | ||
2ed0e35f AD |
29 | ** Visible changes |
30 | Which include serious bug fixes, must be mentioned in NEWS. | |
427c0dda AD |
31 | |
32 | ** Translations | |
33 | Only user visible strings are to be translated: error messages, bits | |
34 | of the .output file etc. This excludes impossible error messages | |
35 | (comparable to assert/abort), and all the --trace output which is | |
36 | meant for the maintainers only. | |
2ed0e35f AD |
37 | |
38 | ||
26fccd4d AD |
39 | * Working from the repository |
40 | ||
41 | These notes intend to help people working on the checked-out sources. | |
42 | These requirements do not apply when building from a distribution tarball. | |
43 | ||
44 | ** Requirements | |
45 | ||
a029e56f AD |
46 | We've opted to keep only the highest-level sources in the repository. This |
47 | eases our maintenance burden, (fewer merges etc.), but imposes more | |
26fccd4d AD |
48 | requirements on anyone wishing to build from the just-checked-out sources. |
49 | For example, you have to use the latest stable versions of the maintainer | |
50 | tools we depend upon, including: | |
51 | ||
26fccd4d | 52 | - Autoconf <http://www.gnu.org/software/autoconf/> |
a029e56f | 53 | - Automake <http://www.gnu.org/software/automake/> |
26fccd4d AD |
54 | - Flex <http://www.gnu.org/software/flex/> |
55 | - Gettext <http://www.gnu.org/software/gettext/> | |
a029e56f | 56 | - Graphviz <http://www.graphviz.org> |
26fccd4d AD |
57 | - Gzip <http://www.gnu.org/software/gzip/> |
58 | - Perl <http://www.cpan.org/> | |
59 | - Rsync <http://samba.anu.edu.au/rsync/> | |
60 | - Tar <http://www.gnu.org/software/tar/> | |
61 | ||
bcbbf654 AD |
62 | Valgrind <http://valgrind.org/> is also highly recommended, if it supports |
63 | your architecture. | |
26fccd4d | 64 | |
a029e56f AD |
65 | Bison is written using Bison grammars, so there are bootstrapping issues. |
66 | The bootstrap script attempts to discover when the C code generated from the | |
67 | grammars is out of date, and to bootstrap with an out-of-date version of the | |
68 | C code, but the process is not foolproof. Also, you may run into similar | |
69 | problems yourself if you modify Bison. | |
26fccd4d | 70 | |
a029e56f AD |
71 | Only building the initial full source tree will be a bit painful. Later, |
72 | after synchronizing from the repository a plain 'make' should be sufficient. | |
73 | Note, however, that when gnulib is updated, running './bootstrap' again | |
74 | might be needed. | |
26fccd4d AD |
75 | |
76 | ** First checkout | |
77 | ||
78 | Obviously, if you are reading these notes, you did manage to check out | |
79 | this package from the repository. For the record, you will find all the | |
80 | relevant information on: | |
81 | ||
82 | http://savannah.gnu.org/git/?group=bison | |
83 | ||
84 | Bison uses Git submodules: subscriptions to other Git repositories. | |
85 | In particular it uses gnulib, the GNU portability library. To ask Git | |
86 | to perform the first checkout of the submodules, run | |
87 | ||
88 | $ git submodule update --init | |
89 | ||
90 | Git submodule support is weak before versions 1.6 and later, you | |
91 | should probably upgrade Git if your version is older. | |
92 | ||
93 | The next step is to get other files needed to build, which are | |
94 | extracted from other source packages: | |
95 | ||
96 | $ ./bootstrap | |
97 | ||
98 | And there you are! Just | |
99 | ||
100 | $ ./configure | |
101 | $ make | |
102 | $ make check | |
103 | ||
104 | At this point, there should be no difference between your local copy, | |
105 | and the master copy: | |
106 | ||
107 | $ git diff | |
108 | ||
109 | should output no difference. | |
110 | ||
111 | Enjoy! | |
112 | ||
113 | ** Updating | |
114 | ||
115 | The use of submodules make things somewhat different because git does | |
116 | not support recursive operations: submodules must be taken care of | |
117 | explicitly by the user. | |
118 | ||
119 | *** Updating Bison | |
120 | ||
4d4777c7 AD |
121 | If you pull a newer version of a branch, say via "git pull", you might |
122 | import requests for updated submodules. A simple "git diff" will | |
26fccd4d AD |
123 | reveal if the current version of the submodule (i.e., the actual |
124 | contents of the gnulib directory) and the current request from the | |
125 | subscriber (i.e., the reference of the version of gnulib that the | |
bcbbf654 | 126 | Bison repository requests) differ. To upgrade the submodules (i.e., |
26fccd4d | 127 | to check out the version that is actually requested by the subscriber, |
4d4777c7 | 128 | run "git submodule update". |
26fccd4d AD |
129 | |
130 | $ git pull | |
131 | $ git submodule update | |
132 | ||
133 | *** Updating a submodule | |
134 | To update a submodule, say gnulib, do as follows: | |
135 | ||
136 | Get the most recent version of the master branch from git. | |
137 | ||
138 | $ cd gnulib | |
139 | $ git fetch | |
140 | $ git checkout -b master --track origin/master | |
141 | ||
142 | Make sure Bison can live with that version of gnulib. | |
143 | ||
144 | $ cd .. | |
145 | $ ./bootstrap | |
146 | $ make distcheck | |
147 | ||
148 | Register your changes. | |
149 | ||
150 | $ git checkin ... | |
151 | ||
a898435b JD |
152 | For a suggestion of what gnulib commit might be stable enough for a |
153 | formal release, see the ChangeLog in the latest gnulib snapshot at: | |
154 | ||
155 | http://erislabs.net/ianb/projects/gnulib/ | |
156 | ||
bcbbf654 | 157 | The Autoconf files we use are currently: |
a898435b JD |
158 | |
159 | m4/m4.m4 | |
160 | lib/m4sugar/m4sugar.m4 | |
161 | lib/m4sugar/foreach.m4 | |
162 | ||
e2eb03d4 | 163 | These files don't change very often in Autoconf, so it should be |
a898435b JD |
164 | relatively straight-forward to examine the differences in order to |
165 | decide whether to update. | |
26fccd4d | 166 | |
2ed0e35f AD |
167 | * Test suite |
168 | ||
169 | ** make check | |
170 | Use liberally. | |
171 | ||
ec78bdab AD |
172 | ** Typical errors |
173 | If the test suite shows failures such as the following one | |
174 | ||
175 | .../bison/lib/getopt.h:196:8: error: redefinition of 'struct option' | |
176 | /usr/include/getopt.h:54:8: error: previous definition of 'struct option' | |
177 | ||
178 | it probably means that some file was compiled without | |
10b009fa AD |
179 | AT_DATA_SOURCE_PROLOGUE. This error is due to the fact that our -I options |
180 | pick up gnulib's replacement headers, such as getopt.h, and this will go | |
181 | wrong if config.h was not included first. | |
ec78bdab AD |
182 | |
183 | See tests/local.at for details. | |
184 | ||
bcbbf654 AD |
185 | ** make maintainer-check-valgrind |
186 | This target uses valgrind both to check bison, and the generated parsers. | |
187 | ||
188 | This is not mature on Mac OS X. First, Valgrind does support the way bison | |
189 | calls m4, so Valgrind cannot be used to check bison on Mac OS X. | |
190 | ||
191 | Second, there are many errors that come from the platform itself, not from | |
192 | bison. build-aux/darwin11.4.0.valgrind addresses some of them. | |
193 | ||
194 | Third, valgrind issues warnings such as: | |
195 | ||
196 | --99312:0:syswrap- WARNING: Ignoring sigreturn( ..., UC_RESET_ALT_STACK ); | |
197 | ||
198 | which cause the test to fail uselessly. It is hard to ignore these errors | |
199 | with a major overhaul of the way instrumentation is performed in the test | |
200 | suite. So currently, do not try to run valgrind on Mac OS X. | |
201 | ||
2ed0e35f AD |
202 | ** Release checks |
203 | Try to run the test suite with more severe conditions before a | |
204 | release: | |
205 | ||
206 | - Configure the package with --enable-gcc-warnings, so that one checks | |
207 | that 1. Bison compiles cleanly, 2. the parsers it produces compile | |
208 | cleanly too. | |
209 | ||
4d4777c7 AD |
210 | - Maybe build with -DGNULIB_POSIXCHECK, which suggests gnulib modules |
211 | that can fix portability issues. See if you really want to pay | |
212 | attention to its warnings; there's no need to obey blindly to it | |
213 | (<http://lists.gnu.org/archive/html/bison-patches/2012-05/msg00057.html>). | |
fb9a3976 | 214 | |
4d4777c7 | 215 | - Check with "make syntax-check" if there are issues diagnosed by |
a0cd287e AD |
216 | gnulib. |
217 | ||
4d4777c7 AD |
218 | - run "make maintainer-check" which: |
219 | - runs "valgrind -q bison" to run Bison under Valgrind. | |
1f1b791b | 220 | - runs the parsers under Valgrind. |
f377f69f | 221 | - runs the test suite with G++ as C compiler... |
2ed0e35f | 222 | |
4d4777c7 | 223 | - run "make maintainer-push-check", which runs "make maintainer-check" |
9126263e JD |
224 | while activating the push implementation and its pull interface wrappers |
225 | in many test cases that were originally written to exercise only the | |
226 | pull implementation. This makes certain the push implementation can | |
227 | perform every task the pull implementation can. | |
228 | ||
4d4777c7 | 229 | - run "make maintainer-xml-check", which runs "make maintainer-check" |
9126263e JD |
230 | while checking Bison's XML automaton report for every working grammar |
231 | passed to Bison in the test suite. The check just diffs the output of | |
232 | Bison's included XSLT style sheets with the output of --report=all and | |
233 | --graph. | |
234 | ||
4d4777c7 | 235 | - running "make maintainer-release-check" takes care of running |
a0cd287e AD |
236 | maintainer-check, maintainer-push-check and maintainer-xml-check. |
237 | ||
2ed0e35f | 238 | - Change tests/atlocal/CFLAGS to add your preferred options. For |
4d4777c7 AD |
239 | instance, "-traditional" to check that the parsers are K&R. Note |
240 | that it does not make sense for glr.c, which should be ANSI, but | |
241 | currently is actually GNU C, nor for lalr1.cc. | |
2ed0e35f | 242 | |
2ed0e35f AD |
243 | |
244 | * Release Procedure | |
4d4777c7 AD |
245 | This section needs to be updated to take into account features from |
246 | gnulib. In particular, be sure to read README-release. | |
2ed0e35f | 247 | |
a898435b JD |
248 | ** Update the submodules. See above. |
249 | ||
845346b3 JD |
250 | ** Update maintainer tools, such as Autoconf. See above. |
251 | ||
d67e37a7 JD |
252 | ** Try to get the *.pot files to the Translation Project at least one |
253 | week before a stable release, to give them time to translate them. | |
254 | Before generating the *.pot files, make sure that po/POTFILES.in and | |
255 | runtime-po/POTFILES.in list all files with translatable strings. | |
256 | This helps: grep -l '\<_(' * | |
ddc65ffd | 257 | |
2ed0e35f AD |
258 | ** Tests |
259 | See above. | |
260 | ||
261 | ** Update the foreign files | |
4d4777c7 | 262 | Running "./bootstrap" in the top level should update them all for you. |
e476c87d PE |
263 | This covers PO files too. Sometimes a PO file contains problems that |
264 | causes it to be rejected by recent Gettext releases; please report | |
265 | these to the Translation Project. | |
2ed0e35f | 266 | |
548e2104 | 267 | ** Update README |
8ebc7dca JD |
268 | Make sure the information in README is current. Most notably, make sure |
269 | it recommends a version of GNU M4 that is compatible with the latest | |
270 | Bison sources. | |
271 | ||
272 | ** Check copyright years. | |
273 | We update years in copyright statements throughout Bison once at the | |
4d4777c7 | 274 | start of every year by running "make update-copyright". However, before |
8ebc7dca JD |
275 | a release, it's good to verify that it's actually been run. Besides the |
276 | copyright statement for each Bison file, check the copyright statements | |
277 | that the skeletons insert into generated parsers, and check all | |
278 | occurrences of PACKAGE_COPYRIGHT_YEAR in configure.ac. | |
548e2104 | 279 | |
6733d024 | 280 | ** Update NEWS, commit and tag. |
a59a6dde AD |
281 | See do-release-commit-and-tag in README-release. For a while, we used |
282 | beta names such as "2.6_rc1". Now that we use gnulib in the release | |
283 | procedure, we must use "2.5.90", which has the additional benefit of | |
284 | being properly sorted in "git tag -l". | |
2ed0e35f | 285 | |
6733d024 | 286 | ** make alpha, beta, or stable |
4d4777c7 | 287 | See README-release. |
548e2104 | 288 | |
4d4777c7 AD |
289 | ** Upload |
290 | There are two ways to upload the tarballs to the GNU servers: using | |
291 | gnupload (from gnulib), or by hand. Obviously prefer the former. But | |
292 | in either case, be sure to read the following paragraph. | |
293 | ||
294 | *** Setup | |
295 | You need "gnupg". | |
2ed0e35f | 296 | |
4d4777c7 AD |
297 | Make sure your public key has been uploaded at least to |
298 | keys.gnupg.net. You can upload it with: | |
548e2104 | 299 | |
4d4777c7 | 300 | gpg --keyserver keys.gnupg.net --send-keys F125BDF3 |
2ed0e35f | 301 | |
4d4777c7 | 302 | where F125BDF3 should be replaced with your key ID. |
2ed0e35f | 303 | |
4d4777c7 AD |
304 | *** Using gnupload |
305 | You need "ncftp". | |
306 | ||
6537c71f | 307 | At the end "make stable" (or alpha/beta) will display the procedure to |
6733d024 | 308 | run. Just copy and paste it in your shell. |
4d4777c7 AD |
309 | |
310 | *** By hand | |
2ed0e35f | 311 | |
548e2104 | 312 | The generic GNU upload procedure is at: |
2ed0e35f | 313 | |
548e2104 JD |
314 | http://www.gnu.org/prep/maintain/maintain.html#Automated-FTP-Uploads |
315 | ||
015e86a7 | 316 | Follow the instructions there to register your information so you're permitted |
4d4777c7 | 317 | to upload. |
015e86a7 JD |
318 | |
319 | Here's a brief reminder of how to roll the tarballs and upload them: | |
548e2104 JD |
320 | |
321 | *** make distcheck | |
322 | *** gpg -b bison-2.3b.tar.gz | |
4d4777c7 | 323 | *** In a file named "bison-2.3b.tar.gz.directive", type: |
548e2104 JD |
324 | |
325 | version: 1.1 | |
326 | directory: bison | |
327 | filename: bison-2.3b.tar.gz | |
328 | ||
329 | *** gpg --clearsign bison-2.3b.tar.gz.directive | |
330 | *** ftp ftp-upload.gnu.org # Log in as anonymous. | |
331 | *** cd /incoming/alpha # cd /incoming/ftp for full release. | |
332 | *** put bison-2.3b.tar.gz # This can take a while. | |
333 | *** put bison-2.3b.tar.gz.sig | |
334 | *** put bison-2.3b.tar.gz.directive.asc | |
abd189e8 | 335 | *** Repeat all these steps for bison-2.3b.tar.xz. |
2ed0e35f | 336 | |
5bc993d9 JD |
337 | ** Update Bison manual on www.gnu.org. |
338 | ||
339 | *** You need a non-anonymous checkout of the web pages directory. | |
340 | ||
341 | $ cvs -d YOUR_USERID@cvs.savannah.gnu.org:/web/bison checkout bison | |
342 | ||
343 | *** Get familiar with the instructions for web page maintainers. | |
344 | http://www.gnu.org/server/standards/readme_index.html | |
345 | http://www.gnu.org/server/standards/README.software.html | |
346 | especially the note about symlinks. | |
347 | ||
348 | *** Build the web pages. | |
349 | Assuming BISON_CHECKOUT refers to a checkout of the Bison dir, and | |
350 | BISON_WWW_CHECKOUT refers to the web directory created above, do: | |
351 | ||
352 | $ cd $BISON_CHECKOUT/doc | |
353 | $ make stamp-vti | |
354 | $ ../build-aux/gendocs.sh -o "$BISON_WWW_CHECKOUT/manual" \ | |
355 | bison "Bison - GNU parser generator" | |
356 | $ cd $BISON_WWW_CHECKOUT | |
357 | ||
358 | Verify that the result looks sane. | |
359 | ||
360 | *** Commit the modified and the new files. | |
361 | ||
362 | *** Remove old files. | |
363 | Find the files which have not been overwritten (because they belonged to | |
364 | sections that have been removed or renamed): | |
365 | ||
366 | $ cd manual/html_node | |
367 | $ ls -lt | |
368 | ||
369 | Remove these files and commit their removal to CVS. For each of these | |
370 | files, add a line to the file .symlinks. This will ensure that | |
371 | hyperlinks to the removed files will redirect to the entire manual; this | |
372 | is better than a 404 error. | |
373 | ||
374 | There is a problem with 'index.html' being written twice (once for POSIX | |
375 | function 'index', once for the table of contents); you can ignore this | |
376 | issue. | |
377 | ||
2ed0e35f | 378 | ** Announce |
6733d024 AD |
379 | The "make stable" (or alpha/beta) command just created a template, |
380 | $HOME/announce-bison-X.Y. Otherwise, to generate it, run: | |
548e2104 JD |
381 | |
382 | make RELEASE_TYPE=alpha gpg_key_ID=F125BDF3 announcement | |
383 | ||
5a3c69f1 | 384 | where alpha can be replaced by beta or stable and F125BDF3 should be |
83e34842 JD |
385 | replaced with your key ID. |
386 | ||
387 | Complete/fix the announcement file. The generated list of recipients | |
388 | (info-gnu@gnu.org, bug-bison@gnu.org, help-bison@gnu.org, | |
389 | bison-patches@gnu.org, and coordinator@translationproject.org) is | |
4d4777c7 AD |
390 | appropriate for a stable release or a "serious beta". For any other |
391 | release, drop at least info-gnu@gnu.org. For an example of how to | |
392 | fill out the rest of the template, search the mailing list archives | |
393 | for the most recent release announcement. | |
83e34842 JD |
394 | |
395 | For a stable release, send the same announcement on the comp.compilers | |
396 | newsgroup by sending email to compilers@iecc.com. Do not make any Cc as | |
397 | the moderator will throw away anything cross-posted or Cc'ed. It really | |
398 | needs to be a separate message. | |
43a91d61 | 399 | |
6733d024 AD |
400 | ** Prepare NEWS |
401 | So that developers don't accidentally add new items to the old NEWS | |
402 | entry, create a new empty entry in line 3 (without the two leading | |
403 | spaces): | |
548e2104 | 404 | |
6733d024 | 405 | * Noteworthy changes in release ?.? (????-??-??) [?] |
548e2104 JD |
406 | |
407 | Push these changes. | |
408 | ||
2ed0e35f AD |
409 | ----- |
410 | ||
c932d613 | 411 | Copyright (C) 2002-2005, 2007-2012 Free Software Foundation, Inc. |
2ed0e35f AD |
412 | |
413 | This file is part of GNU Bison. | |
414 | ||
f16b0819 | 415 | This program is free software: you can redistribute it and/or modify |
2ed0e35f | 416 | it under the terms of the GNU General Public License as published by |
f16b0819 PE |
417 | the Free Software Foundation, either version 3 of the License, or |
418 | (at your option) any later version. | |
2ed0e35f | 419 | |
f16b0819 | 420 | This program is distributed in the hope that it will be useful, |
2ed0e35f AD |
421 | but WITHOUT ANY WARRANTY; without even the implied warranty of |
422 | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
423 | GNU General Public License for more details. | |
424 | ||
425 | You should have received a copy of the GNU General Public License | |
f16b0819 | 426 | along with this program. If not, see <http://www.gnu.org/licenses/>. |
bcbbf654 AD |
427 | |
428 | LocalWords: Automake Autoconf Gettext Gzip Rsync Valgrind gnulib submodules | |
429 | LocalWords: submodule init cd distcheck checkin ChangeLog valgrind sigreturn | |
430 | LocalWords: UC gcc DGNULIB POSIXCHECK xml XSLT glr lalr README po runtime rc | |
431 | LocalWords: gnupload gnupg gpg keyserver BDF ncftp filename clearsign cvs dir | |
432 | LocalWords: symlinks vti html lt POSIX Cc'ed | |
433 | ||
434 | Local Variables: | |
435 | mode: outline | |
436 | fill-column: 76 | |
437 | End: |