Michael Vogt [Fri, 11 Oct 2013 17:27:23 +0000 (19:27 +0200)]
first iteration of install progress refactor
Michael Vogt [Wed, 9 Oct 2013 20:37:46 +0000 (22:37 +0200)]
Merge branch 'debian/sid' of ssh://git.debian.org/git/apt/apt into debian/sid
Michael Vogt [Wed, 9 Oct 2013 19:20:57 +0000 (21:20 +0200)]
fix typo
Michael Vogt [Wed, 9 Oct 2013 19:20:57 +0000 (21:20 +0200)]
fix typo
Michael Vogt [Wed, 9 Oct 2013 18:50:13 +0000 (20:50 +0200)]
releasing package apt version 0.9.12
Michael Vogt [Wed, 9 Oct 2013 13:02:49 +0000 (15:02 +0200)]
update changelog
Michael Vogt [Wed, 9 Oct 2013 12:55:01 +0000 (14:55 +0200)]
Merge remote-tracking branch 'mvo/feature/limit-default-pdiffs' into debian/sid
Michael Vogt [Wed, 9 Oct 2013 12:51:09 +0000 (14:51 +0200)]
Merge remote-tracking branch 'mvo/feature/add-upgrade-mode-test' into debian/sid
Michael Vogt [Wed, 9 Oct 2013 12:02:42 +0000 (14:02 +0200)]
fixup various UI issues in the test
Michael Vogt [Wed, 9 Oct 2013 10:37:52 +0000 (12:37 +0200)]
really fix test
Michael Vogt [Wed, 9 Oct 2013 09:01:18 +0000 (11:01 +0200)]
use "insertpackage" instead of "buildsimplenativepackage"
Michael Vogt [Wed, 9 Oct 2013 08:27:11 +0000 (10:27 +0200)]
update Uploaders to match recent uploaders better
Michael Vogt [Wed, 9 Oct 2013 05:58:31 +0000 (07:58 +0200)]
add test for upgrade, upgrade --with-new-pkgs, dist-upgrade
Michael Vogt [Tue, 8 Oct 2013 19:48:14 +0000 (21:48 +0200)]
apt-pkg/deb/dpkgpm.cc: fix off-by-one in SetupTerminalScrollArea reset
Michael Vogt [Tue, 8 Oct 2013 18:39:03 +0000 (20:39 +0200)]
prepare new release
Michael Vogt [Tue, 8 Oct 2013 17:59:26 +0000 (19:59 +0200)]
Merge remote-tracking branch 'mvo/feature/dpkg-progress-fancy' into debian/sid
Michael Vogt [Tue, 8 Oct 2013 17:59:04 +0000 (19:59 +0200)]
Merge remote-tracking branch 'mvo/feature/upgrade-with-new' into debian/sid
Michael Vogt [Tue, 8 Oct 2013 17:57:42 +0000 (19:57 +0200)]
Merge remote-tracking branch 'mvo/feature/dpkg-progress-docs' into debian/sid
Michael Vogt [Tue, 8 Oct 2013 17:46:39 +0000 (19:46 +0200)]
debian/apt.postinst: use --compare-versions lt instead of lt-nl, to ensure the apt-auto-removal file is correctly create, thanks to Ben Hutchings
Michael Vogt [Mon, 7 Oct 2013 11:46:30 +0000 (13:46 +0200)]
fix off-by-one error in pkgDPkgPM::SetupTerminalScrollArea()
Michael Vogt [Mon, 7 Oct 2013 11:42:50 +0000 (13:42 +0200)]
fix libapt-inst for >2G debs (closes: #725483)
Michael Vogt [Mon, 7 Oct 2013 11:37:28 +0000 (13:37 +0200)]
use Dpkg::Progress-Fancy to be consitent with Dpkg::Progress
Michael Vogt [Mon, 7 Oct 2013 08:26:50 +0000 (10:26 +0200)]
add -o DpkgPM::Progress-Fancy for better dpkg progress output on vt100+ terminals
Michael Vogt [Sat, 5 Oct 2013 08:49:34 +0000 (10:49 +0200)]
Merge remote-tracking branch 'donkult/debian/sid' into debian/sid
Michael Vogt [Sat, 5 Oct 2013 08:49:26 +0000 (10:49 +0200)]
Merge remote-tracking branch 'mvo/bugfix/dpkg-progress-multiarch' into debian/sid
David Kalnischkies [Thu, 3 Oct 2013 20:58:55 +0000 (22:58 +0200)]
tests: install --no-install-recommends and stunnel4 for travis
stunnel4 is required for https tests
Git-Dch: Ignore
David Kalnischkies [Thu, 3 Oct 2013 20:49:58 +0000 (22:49 +0200)]
test: use a multiarch capable dpkg rather than workaround
The tests require nowadays a (somewhat) multiarch-capable dpkg, so
replace the workaround as marked in the FIXME with a proper install as
the workaround isn't working always correctly, letting the test fail.
Git-Dch: Ignore
David Kalnischkies [Thu, 3 Oct 2013 20:23:11 +0000 (22:23 +0200)]
do not ++ on erased package pointers in autoremove
Symptom: In an Ubuntu precise chroot (like on travis-ci)
test-bug-613420-new-garbage-dependency segfaults in a std::set
operator++ on an iterator we have erased previously
(but not if run under gdb of course)
David Kalnischkies [Thu, 3 Oct 2013 19:34:52 +0000 (21:34 +0200)]
fix lzma-support detection via xz binary
Clear() only clears a config option, not removing it and an empty
setting still exists. Hence we set the option instead to the xz path
so that the later existance check can find a binary for the test
David Kalnischkies [Thu, 3 Oct 2013 13:11:21 +0000 (15:11 +0200)]
use pkgAcqArchive in 'download' for proper errors
With a bit of trickery we can reuse the usual infrastructure we have in
place to acquire deb files for the 'download' operation as well, which
gains us authentification check & display, error messages, correct
filenames and "downloads" from the root-owned archives.
David Kalnischkies [Thu, 3 Oct 2013 12:45:41 +0000 (14:45 +0200)]
put fetch errors in 'source' on our errorstack
refactor the fetching process so that it looks more like the
others we have in the hope that we can reuse code in the future.
This is a soft interface change as 'source' previously printed
errors directly on stderr, while it will now push it onto our usual
error stack.
David Kalnischkies [Wed, 2 Oct 2013 23:12:18 +0000 (01:12 +0200)]
refactor onError relabeling of DestFile as '.FAILED'
This helps ensure three things:
- each error is reported via ReportMirrorFailure
- if DestFile doesn't exist, do not attempt rename
- renames happen for every error
The last one wasn't the case for Size mismatches, which isn't nice, but
not a exploitable problem per-se as the file isn't picked up and remains
in partial/ where the following download-try will at most take it for a
partial request which fails the hashsum verification later on
Git-Dch: Ignore
David Kalnischkies [Wed, 2 Oct 2013 11:34:59 +0000 (13:34 +0200)]
tests: fix some problems travis encounters
Git-Dch: Ignore
Michael Vogt [Wed, 2 Oct 2013 08:15:52 +0000 (10:15 +0200)]
Merge remote-tracking branch 'origin/bugfix/dpkg-progress-multiarch' into bugfix/dpkg-progress-multiarch
Michael Vogt [Wed, 2 Oct 2013 08:15:28 +0000 (10:15 +0200)]
make dpkg progress slightly nicer
Michael Vogt [Tue, 1 Oct 2013 10:38:03 +0000 (12:38 +0200)]
change maxsplit default from "0" to maxint
Michael Vogt [Tue, 1 Oct 2013 10:03:37 +0000 (12:03 +0200)]
improve documentation for StringSplit()
Michael Vogt [Tue, 1 Oct 2013 09:30:56 +0000 (11:30 +0200)]
rename "--dpkg-progress" to "--show-progress" and document it in apt-get.8
David Kalnischkies [Mon, 30 Sep 2013 16:51:40 +0000 (18:51 +0200)]
don't consider holds for autoremoval
We can't remove packages which are held back by the user with a hold, so
marking them (or its dependencies) as garbage will lead our autoremover
into madness – and given that the package is important enough that the
user has held it back it can't be garbage (at least at the moment), so
even if a front-end wants to use the info just for information display
its a good idea to not consider it garbage for them.
Closes: 724995
David Kalnischkies [Mon, 30 Sep 2013 14:41:16 +0000 (16:41 +0200)]
handle complete responses to https range requests
Servers might respond with a complete file either because they don't
support Ranges at all or the If-Range condition isn't statisfied, so we
have to parse the headers curl gets ourself to seek or truncate the file
we have so far.
This also finially adds the testcase testing a bunch of partial
situations for both, http and https - which is now all green.
Closes: 617643, 667699
LP:
1157943
David Kalnischkies [Mon, 30 Sep 2013 11:42:33 +0000 (13:42 +0200)]
fix partial (206 and 416) support in https
As lengthy discussed in lp:
1157943 partial https support was utterly
broken as a 206 response was handled as an (unhandled) error. This is
the first part of fixing it by supporting a 206 response and starting to
deal with 416.
David Kalnischkies [Tue, 17 Sep 2013 20:35:44 +0000 (22:35 +0200)]
refactor http client implementation
No effective behavior change, just shuffling big junks of code between
methods and classes to split them into those strongly related to our
client implementation and those implementing HTTP.
The idea is to get HTTPS to a point in which most of the implementation
can be shared even though the client implementations itself is
completely different. This isn't anywhere near yet though, but it should
beenough to reuse at least a few lines from http in https now.
Git-Dch: Ignore
David Kalnischkies [Mon, 16 Sep 2013 22:41:58 +0000 (00:41 +0200)]
replace "filesize - 1" trick in http with proper 416 handling
Our http client requests the "filesize - 1" for the small edgecase of
handling a file which was completely downloaded, but not yet moved to
the correct place as we get 416 errors in that case, but as we can
handle 416 returns now we just special-case the situation of requesting
the exact filesize and handle it as a 200 without content instead.
David Kalnischkies [Mon, 16 Sep 2013 21:21:11 +0000 (23:21 +0200)]
retry without partial data after a 416 response
If we get a 416 from the server it means the Range we asked for is above
the real filesize of the file on the server. Mostly this happens if the
server isn't supporting If-Range, but regardless of how we end up with
the partial data, the data is invalid so we discard it and retry with a
fresh plate and hope for the best.
Old behavior was to consider 416 an error and retry with a different
compression until we ran out of compression and requested the
uncompressed file (which doesn't exist on most mirrors) with an accept
line which server answered with "406 Not Acceptable".
Closes: 710924
David Kalnischkies [Sun, 15 Sep 2013 22:02:21 +0000 (00:02 +0200)]
add Range and If-Range support in the webserver
Git-Dch: Ignore
David Kalnischkies [Sun, 15 Sep 2013 20:54:04 +0000 (22:54 +0200)]
access _config via GET requests in the webserver
Git-Dch: Ignore
David Kalnischkies [Mon, 30 Sep 2013 07:08:33 +0000 (09:08 +0200)]
APT has no bugs
Okay, maybe it does have a "few", but the DDTP issues mentioned in this
file are long since gone, so lets just drop the file and look at the PTS
instead: http://bugs.debian.org/cgi-bin/pkgreport.cgi?src=apt
Git-Dch: Ignore
David Kalnischkies [Thu, 26 Sep 2013 14:25:11 +0000 (16:25 +0200)]
test: apt-get source with more than one argument
Closes: 722549
Git-Dch: Ignore
David Kalnischkies [Thu, 26 Sep 2013 12:56:45 +0000 (14:56 +0200)]
print-uris prints regardless of quiet-level again
While the InstallPackages code was moved from apt-get into the private
library the output was moved from (std::)cout to c1out which isn't shown
in quiet level 2 (and above), so we flip back to std::cout to ensure
that it is always printed as you are not going to use --print-uris if
you don't want to see the uris…
Closes: 722207
David Kalnischkies [Thu, 26 Sep 2013 12:06:25 +0000 (14:06 +0200)]
compression-neutral message for missing data.tar member
It even reuses the message used for the other check-for members, so one
less message to translate (good, as not that many people will ever see it).
Closes: 722710
David Kalnischkies [Thu, 26 Sep 2013 11:32:49 +0000 (13:32 +0200)]
pkg from only trusted sources keeps being trusted
--allow-unauthenticated switches the download to a pre-0.6 system in
which a package can come from any source, rather than that trusted
packages can only come from trusted sources.
To allow this the flag used to set all packages as untrusted, which is a
bit much, so we check now if the package can be acquired via an
untrusted source and only if this is the case set it as untrusted.
As APT nowadays supports setting sources as trusted via a flag in the
sources.list this mode shouldn't be used that much anymore though.
[Note that this is not the patch from the BTS]
Closes: 617690
David Kalnischkies [Sat, 21 Sep 2013 12:23:02 +0000 (14:23 +0200)]
don't strip :any from dependencies in single-arch
The parser goes a bit to far by stripping :any from dependencies in a
single architecture environment. the flag "Multi-Arch: allowed" doesn't
care any architecture restrictions in that case (as in single arch
everything is native), but it still limits the possible versions
statisfying the dependency so stripping :any over-simplifies in upgrade
situations from "Multi-Arch: none" to "Multi-Arch: allowed".
Closes: 723586
Christian PERRIER [Mon, 23 Sep 2013 05:06:18 +0000 (07:06 +0200)]
Fix typo in apt-private/private-show.cc. Thanks to Benjamin Keresa. Closes: #724073
Michael Vogt [Fri, 20 Sep 2013 12:11:48 +0000 (14:11 +0200)]
releasing package apt version 0.9.11.4
David Kalnischkies [Fri, 20 Sep 2013 11:34:22 +0000 (13:34 +0200)]
do not trust FileFd::Eof() in pkgTagFile::Fill()
The Eof check was added (by me of course) in
0aae6d14390193e25ab6d0fd49295bd7b131954f
as part of a fix up ~a month ago (at DebConf).
The idea was not that bad, but doesn't make that much sense either
as this bit is set by the FileFd based on Actual as well, so this is
basically doing the same check again – with the difference that the
HitEof bit can still linger from a previous Read we did at the end of
the file, but have seek'd away from it now.
Combined with the length of entries, entry order and other not that
easily controllable conditions you can be 'lucky' enough to hit this
problem in a way which even visible (truncating of other fields might
not be visible easily, like 'Tags' and others).
Closes: 723705
Thanks: Cyril Brulebois
David Kalnischkies [Thu, 12 Sep 2013 11:42:37 +0000 (13:42 +0200)]
add a testcase for 100 char long path truncate bug #689582
Git-Dch: Ignore
Oskari Saarenmaa [Thu, 12 Sep 2013 11:20:01 +0000 (13:20 +0200)]
don't truncate 100 char long paths in tar extraction
When a data.tar.{gz,xz} contains a path name that is exactly
100 characters long, it will get truncated to 99 chars upon
extraction in ExtractTar::Go().
Using all of the 100 available characters for the filename
seems to be new behaviour in gnu tar.
Closes: #689582
Thanks: Mika Eloranta for the testcase!
Michael Vogt [Tue, 10 Sep 2013 15:41:01 +0000 (17:41 +0200)]
Fix regression of "apt-cache unmet -i", thanks to Daniel Schepler (closes: #722324)
Michael Vogt [Tue, 10 Sep 2013 15:32:50 +0000 (17:32 +0200)]
prepare upload
Michael Vogt [Sat, 7 Sep 2013 14:16:49 +0000 (16:16 +0200)]
doc update
Michael Vogt [Sat, 7 Sep 2013 11:30:48 +0000 (13:30 +0200)]
fix multiarch status-fd progress calculation
Michael Vogt [Sat, 7 Sep 2013 11:12:50 +0000 (13:12 +0200)]
add maxsplit parameter to StringSplit
Michael Vogt [Sat, 7 Sep 2013 10:19:51 +0000 (12:19 +0200)]
implement StringSplit() as we need this to fix the dpkg status-fd output parsing
David Kalnischkies [Tue, 3 Sep 2013 21:00:37 +0000 (23:00 +0200)]
use FileFd in HashSum test to unbreak non-linux ports
The testcode happily mixes FILE* operations and direct access to fds
which is even a bit suprising that it works on linux and worked so
long for non-linux ports, so we switch to usage of FileFd instead
which provides us with simple fd-only operations. Its overkill for this
test as its a bare file and we ask for the descriptor all the time, but
it shouldn't hurt to implicitly test it a bit this way.
Closes: 721723
Thanks: Aaron M. Ucko
David Kalnischkies [Fri, 30 Aug 2013 15:18:20 +0000 (17:18 +0200)]
fix vim-style foldmarker
Git-Dch: Ignore
Michael Vogt [Sun, 1 Sep 2013 16:34:34 +0000 (18:34 +0200)]
Remove invalid "-f" option for apt-get check
Thanks to Philipp Weis (closes: #721477)
Michael Vogt [Sun, 1 Sep 2013 16:33:26 +0000 (18:33 +0200)]
Merge branch 'debian/sid' of ssh://git.debian.org/git/apt/apt into debian/sid
Michael Vogt [Sat, 31 Aug 2013 15:05:23 +0000 (17:05 +0200)]
fix typo (mkostemp->mkstemp)
Michael Vogt [Sat, 31 Aug 2013 14:31:53 +0000 (16:31 +0200)]
prepare upload of 0.9.12
Michael Vogt [Wed, 28 Aug 2013 10:46:49 +0000 (12:46 +0200)]
Merge remote-tracking branch 'upstream/debian/sid' into feature/upgrade-with-new
Michael Vogt [Wed, 28 Aug 2013 09:36:44 +0000 (11:36 +0200)]
its --with-new-pkgs
Michael Vogt [Wed, 28 Aug 2013 09:28:40 +0000 (11:28 +0200)]
add man-page, improve option, use --with-new-pkgs as the flag
Michael Vogt [Wed, 28 Aug 2013 08:59:54 +0000 (10:59 +0200)]
Merge remote-tracking branch 'mvo/feature/install-progress' into debian/sid
Michael Vogt [Wed, 28 Aug 2013 07:15:26 +0000 (09:15 +0200)]
Merge remote-tracking branch 'mvo/feature/upgrade-with-cmdline' into debian/sid
Michael Vogt [Wed, 28 Aug 2013 07:12:41 +0000 (09:12 +0200)]
Merge remote-tracking branch 'donkult/debian/sid' into debian/sid
Christian PERRIER [Wed, 28 Aug 2013 04:54:13 +0000 (06:54 +0200)]
Complete Italian translation
David Kalnischkies [Tue, 27 Aug 2013 22:24:32 +0000 (00:24 +0200)]
configurable compression for testcases
Compressing files in 4 different styles eats test-time for no practical
gain if we don't test them explicitly, so default to just building 'gz'
compressed files as it is the simplest compression algorithm supported
Git-Dch: Ignore
David Kalnischkies [Tue, 27 Aug 2013 21:14:49 +0000 (23:14 +0200)]
old-style dpkg foreign architecture adding for tests
Looks like the travis service runs on Ubuntu in a version which has dpkg
with an earlier interface implementation, so lets try if we can't make
the framework work with this dpkg version as well.
Git-Dch: Ignore
David Kalnischkies [Tue, 27 Aug 2013 19:50:22 +0000 (21:50 +0200)]
use mkstemp instead of mkostemp in FileFd::Open()
FileFd currently supports no fileflags which would make sense to provide
via mkostemp, so we can just use mkstemp here which is a standard
function compared to glib extension mkostemp.
O_CREAT (Create) and O_TRUNC (Empty) are implied by O_EXCL, which is the
mode mkstemp uses by default. The file description is opened ReadWrite,
but that used to be the default for FileFd in the old times and not a
problem as the difference is needed by FileFd to decide in which way the
compressor pipeline needs to be created (if any).
Git-Dch: Ignore
Angel Guzman Maeso [Tue, 27 Aug 2013 19:29:01 +0000 (21:29 +0200)]
replace usage of potential dangerous mktemp with mkstemp
Avoid the warning "the use of `mktemp' is dangerous,
better use `mkstemp' or `mkdtemp'". It is not strictly necessary to
change the usage from a security point of view here, but mktemp is
also removed from the standard since POSIX.1-2008.
The mkostemp call returns a file descriptor the logic for
TemporaryFileName has been changed accordingly to get the same results.
The file permissions are corrected by using fchmod() as the default for
FileFd is 666 while mkstemp creates files with 600 by default.
Christian PERRIER [Tue, 27 Aug 2013 17:01:46 +0000 (19:01 +0200)]
Update Italian translation. Closes: #721030
Michael Vogt [Tue, 27 Aug 2013 12:07:52 +0000 (14:07 +0200)]
add new "apt-get upgrade --with-allow-new" option
The --with-allow-new option maps to APT::Get::UpgradeAllowNew and
will allow "apt-get upgrade" to install new packages (but not to
delete existing packages)
Michael Vogt [Tue, 27 Aug 2013 06:50:06 +0000 (08:50 +0200)]
allow pkg manipulation in the upgrade/dist-upgrade commandline, e.g. apt-get dist-upgrade 2vcard- 4g8+
Michael Vogt [Tue, 27 Aug 2013 06:38:05 +0000 (08:38 +0200)]
use SPtr<pkgProblemResolver> to simply code
Michael Vogt [Mon, 26 Aug 2013 19:09:33 +0000 (21:09 +0200)]
set Acquire::PDiffs::FileLimit to 20 to avoid needless huge fetches
Michael Vogt [Mon, 26 Aug 2013 16:52:13 +0000 (18:52 +0200)]
update changelog
Michael Vogt [Mon, 26 Aug 2013 16:52:06 +0000 (18:52 +0200)]
apt-private/private-cmndline.cc: fix typo: s/deselect-upgrade/dselect-upgrade/
Michael Vogt [Mon, 26 Aug 2013 16:51:40 +0000 (18:51 +0200)]
dselect/install: add new DSELECT_UPGRADE_OPTS="-f"
Michael Vogt [Mon, 26 Aug 2013 16:45:32 +0000 (18:45 +0200)]
dselect/install:
* dselect/install:
- remove "-f" option for apt-get dselect-upgrade (closes: #720532)
Michael Vogt [Mon, 26 Aug 2013 16:42:58 +0000 (18:42 +0200)]
Merge branch 'debian/sid' of ssh://git.debian.org/git/apt/apt into debian/sid
Conflicts:
debian/changelog
Christian PERRIER [Sun, 25 Aug 2013 13:40:44 +0000 (15:40 +0200)]
Changelog entry for Vietnamese translation
Tran Ngoc Quan [Sun, 25 Aug 2013 07:20:31 +0000 (14:20 +0700)]
Update Vietnamese translation to 0.9.11
Signed-off-by: Tran Ngoc Quan <vnwildman@gmail.com>
Michael Vogt [Sat, 24 Aug 2013 07:13:57 +0000 (09:13 +0200)]
update changelog for update
Michael Vogt [Sat, 24 Aug 2013 07:07:37 +0000 (09:07 +0200)]
Merge remote-tracking branch 'mvo/debian/sid' into debian/sid
Michael Vogt [Fri, 23 Aug 2013 11:44:21 +0000 (13:44 +0200)]
dselect/update: remove "-f" option as its not being used in the context of apt-get update
Michael Vogt [Fri, 23 Aug 2013 07:15:00 +0000 (09:15 +0200)]
ftparchive/override.cc: fix "skip empty lines" code, the pointer needs to get de-referenced first
Michael Vogt [Thu, 22 Aug 2013 21:00:31 +0000 (23:00 +0200)]
Merge branch 'debian/sid' of ssh://git.debian.org/git/apt/apt into debian/sid
Michael Vogt [Thu, 22 Aug 2013 20:30:20 +0000 (22:30 +0200)]
do chdir("/") after chroot()
Michael Vogt [Thu, 22 Aug 2013 20:26:05 +0000 (22:26 +0200)]
Merge remote-tracking branch 'donkult/debian/sid' into debian/sid
Ángel Guzmán Maeso [Wed, 21 Aug 2013 17:38:35 +0000 (19:38 +0200)]
apt-pkg:contrib Avoid compiler warning about sign-compare
The fix avoid the warning "comparison between signed and
unsigned integer expressions [-Wsign-compare]"· The index for the loop needs
to be unsigned for compare with globbuf.gl_pathc structure
member