for these helpers we don't need too much checks,

but no warnings from gcc helps

diff --git a/test/interactive-helper/extract-control.cc b/test/interactive-helper/extract-control.cc
index a1b3600aad922662c9568cdb73da30560609a644..3f7feabcba95b52902236feffd603a8df37b1dfe 100644 (file)
--- a/test/interactive-helper/extract-control.cc
+++ b/test/interactive-helper/extract-control.cc
@@ -21,8 +21,7 @@ bool ExtractMember(const char *File,const char *Member)
    if (Extract.Control == 0)
       return true;
    
    if (Extract.Control == 0)
       return true;
    

-   write(STDOUT_FILENO,Extract.Control,Extract.Length);
-   return true;
+   return write(STDOUT_FILENO,Extract.Control,Extract.Length) != -1;

 }
 
 int main(int argc, const char *argv[])
 }
 
 int main(int argc, const char *argv[])

diff --git a/test/interactive-helper/testextract.cc b/test/interactive-helper/testextract.cc
index f7ddb72f05878bf849e24a6d28e92ef02eb28d5c..8dfe68fc91e5dd3c74a648c8b38818b8efaef61a 100644 (file)
--- a/test/interactive-helper/testextract.cc
+++ b/test/interactive-helper/testextract.cc
@@ -66,7 +66,8 @@ bool Go(int argc,char *argv[])
         while (feof(F) == 0)
         {
            char Line[300];
         while (feof(F) == 0)
         {
            char Line[300];

-           fgets(Line,sizeof(Line),F);
+           if (fgets(Line,sizeof(Line),F) == NULL)
+              return false;

            Itm.Name = _strstrip(Line);
            Itm.Type = pkgDirStream::Item::File;
            if (Line[strlen(Line)-1] == '/')
            Itm.Name = _strstrip(Line);
            Itm.Type = pkgDirStream::Item::File;
            if (Line[strlen(Line)-1] == '/')