add inline DumpError() to avoid subtle API break

diff --git a/apt-pkg/contrib/error.h b/apt-pkg/contrib/error.h
index d395004279ab9bb5f2455a5dd37896166c35959c..4af0302c093dc488b03e62853bbea4265e361c9b 100644 (file)
--- a/apt-pkg/contrib/error.h
+++ b/apt-pkg/contrib/error.h
@@ -217,10 +217,22 @@ public:                                                                   /*{{{*/
         *
         *  \param threshold minimum level printed
         */
         *
         *  \param threshold minimum level printed
         */

-       void inline DumpErrors(MsgType const &threshold = WARNING) {
+       void inline DumpErrors(MsgType const &threshold) {

                DumpErrors(std::cerr, threshold);
        }
 
                DumpErrors(std::cerr, threshold);
        }
 

+        // mvo: we do this instead of using a default parameter in the
+        //      previous declaration to avoid a (subtle) API break for
+        //      e.g. sigc++ and mem_fun0
+       /** \brief dumps the messages of type WARNING or higher to std::cerr
+        *
+        *  Note that all messages are discarded, displayed or not.
+        *
+        */
+       void inline DumpErrors() {
+                DumpErrors(WARNING);
+       }
+

        /** \brief put the current Messages into the stack
         *
         *  All "old" messages will be pushed into a stack to
        /** \brief put the current Messages into the stack
         *
         *  All "old" messages will be pushed into a stack to

diff --git a/debian/changelog b/debian/changelog
index 5457036031feef46da828ee74d59e93f6cb36e29..c526df66cfb71a571d840d183d2d4ac97d335607 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -35,6 +35,7 @@ apt (0.7.26~exp11) experimental; urgency=low
   [ Michael Vogt ]
   * apt-pkg/contrib/error.{cc,h}
     - docstring cleanup
   [ Michael Vogt ]
   * apt-pkg/contrib/error.{cc,h}
     - docstring cleanup

+    - add inline DumpError() to avoid subtle API break

 
  -- David Kalnischkies <kalnischkies@gmail.com>  Mon, 26 Jul 2010 12:40:44 +0200
 
 
  -- David Kalnischkies <kalnischkies@gmail.com>  Mon, 26 Jul 2010 12:40:44 +0200