do not hang on piped input in PipedFileFdPrivate

This effects only compressors configured on the fly (rather then the
inbuilt ones as they use a library).

diff --git a/apt-pkg/contrib/fileutl.cc b/apt-pkg/contrib/fileutl.cc
index 9990b753ab365bccf4ec4861b44919a3eb5e5ea0..6bfa5ca9285ffd7ff2e572c682930531efed16ca 100644 (file)
--- a/apt-pkg/contrib/fileutl.cc
+++ b/apt-pkg/contrib/fileutl.cc
@@ -1978,6 +1978,11 @@ public:
    virtual bool InternalClose(std::string const &) APT_OVERRIDE
    {
       bool Ret = true;
    virtual bool InternalClose(std::string const &) APT_OVERRIDE
    {
       bool Ret = true;

+      if (filefd->iFd != -1)
+      {
+        close(filefd->iFd);
+        filefd->iFd = -1;
+      }

       if (compressor_pid > 0)
         Ret &= ExecWait(compressor_pid, "FileFdCompressor", true);
       compressor_pid = -1;
       if (compressor_pid > 0)
         Ret &= ExecWait(compressor_pid, "FileFdCompressor", true);
       compressor_pid = -1;

diff --git a/test/integration/framework b/test/integration/framework
index b7bee8a57bc67eab33a91445e81cc684dc95bb99..3f7101170ced769a2dcbe2a15f69bd3416a2bb65 100644 (file)
--- a/test/integration/framework
+++ b/test/integration/framework
@@ -539,6 +539,10 @@ EOF
        testempty --nomsg gcc -Wall -Wextra -fPIC -shared -o noopchroot.so noopchroot.c -ldl
 }
 configcompression() {
        testempty --nomsg gcc -Wall -Wextra -fPIC -shared -o noopchroot.so noopchroot.c -ldl
 }
 configcompression() {

+       if [ "$1" = 'ALL' ]; then
+               configcompression '.' $(aptconfig dump APT::Compressor --format '%t %v%n' | sed -n 's#^Extension \.\(.*\)$#\1#p')
+               return
+       fi

        local CMD='apthelper cat-file -C'
        while [ -n "$1" ]; do
                case "$1" in
        local CMD='apthelper cat-file -C'
        while [ -n "$1" ]; do
                case "$1" in


@@ -963,7 +967,7 @@ buildaptarchivefromfiles() {
 }
 
 compressfile() {
 }
 
 compressfile() {

-       cat "${TMPWORKINGDIRECTORY}/rootdir/etc/testcase-compressor.conf" | while read compressor extension command; do
+       while read compressor extension command; do

                if [ "$compressor" = '.' ]; then
                        if [ -n "$2" ]; then
                                touch -d "$2" "$1"
                if [ "$compressor" = '.' ]; then
                        if [ -n "$2" ]; then
                                touch -d "$2" "$1"


@@ -974,7 +978,7 @@ compressfile() {
                if [ -n "$2" ]; then
                        touch -d "$2" "${1}.${extension}"
                fi
                if [ -n "$2" ]; then
                        touch -d "$2" "${1}.${extension}"
                fi

-       done
+       done < "${TMPWORKINGDIRECTORY}/rootdir/etc/testcase-compressor.conf"

 }
 
 # can be overridden by testcases for their pleasure
 }
 
 # can be overridden by testcases for their pleasure

diff --git a/test/integration/test-apt-helper-cat-file b/test/integration/test-apt-helper-cat-file
new file mode 100755 (executable)
index 0000000..f7c94a2
--- /dev/null
+++ b/test/integration/test-apt-helper-cat-file
@@ -0,0 +1,30 @@
+#!/bin/sh
+set -e
+
+TESTDIR="$(readlink -f "$(dirname "$0")")"
+. "$TESTDIR/framework"
+setupenvironment
+
+cat >rootdir/etc/apt/apt.conf.d/rev-as-compressor <<EOF
+APT::Compressor::rev {
+       Name "rev";
+       Extension ".rev";
+       Binary "rev";
+       Cost "1";
+};
+EOF
+
+configcompression 'ALL'
+cat >./test.txt <<EOF
+This is a test.
+EOF
+
+compressfile ./test.txt
+while read compressor extension command; do
+       if [ "$compressor" = '.' ]; then
+               FILE='./test.txt'
+       else
+               FILE="./test.txt.${extension}"
+       fi
+       testsuccessequal "$(cat ./test.txt)" apthelper cat-file "$FILE"
+done < "${TMPWORKINGDIRECTORY}/rootdir/etc/testcase-compressor.conf"

diff --git a/test/integration/test-compressed-indexes b/test/integration/test-compressed-indexes
index d544ac89f804a4f72649a8c2e0c8d0beb2ab612d..b8bb589533dac334907c8c0cfbe0a1d476154112 100755 (executable)
--- a/test/integration/test-compressed-indexes
+++ b/test/integration/test-compressed-indexes
@@ -5,7 +5,7 @@ TESTDIR="$(readlink -f "$(dirname "$0")")"
 . "$TESTDIR/framework"
 
 setupenvironment
 . "$TESTDIR/framework"
 
 setupenvironment

-configcompression '.' $(aptconfig dump APT::Compressor --format '%t %v%n' | sed -n 's#^Extension \.\(.*\)$#\1#p')
+configcompression 'ALL'

 configarchitecture 'i386'
 LOWCOSTEXT='lz4'
 
 configarchitecture 'i386'
 LOWCOSTEXT='lz4'