make --allow-insecure-repositories message an error

Not using this option, but using unsigned (and co) repositories will
cause these repositories to be ignored and data acquiring from them
fails, so this is very well in the realms of an error and helps in
making 'apt-get update' fail with a non-zero error code as well.

diff --git a/apt-pkg/acquire-item.cc b/apt-pkg/acquire-item.cc
index 65c260f3a671924a89321fb0bcb11fa8122001b1..3e4016ac628921e9ece07ef96cc72cb863ee8606 100644 (file)
--- a/apt-pkg/acquire-item.cc
+++ b/apt-pkg/acquire-item.cc
@@ -1782,7 +1782,7 @@ void pkgAcqMetaSig::Failed(string Message,pkgAcquire::MethodConfig *Cnf)/*{{{*/
    } 
    else 
    {
    } 
    else 
    {

-      _error->Warning("Use --allow-insecure-repositories to force the update");
+      _error->Error("Use --allow-insecure-repositories to force the update");

    }
 
    Item::Failed(Message,Cnf);
    }
 
    Item::Failed(Message,Cnf);


@@ -2161,7 +2161,7 @@ void pkgAcqMetaIndex::Failed(string Message,
       QueueIndexes(false);
    } else {
       // warn if the repository is unsinged
       QueueIndexes(false);
    } else {
       // warn if the repository is unsinged

-      _error->Warning("Use --allow-insecure-repositories to force the update");
+      _error->Error("Use --allow-insecure-repositories to force the update");

       TransactionManager->AbortTransaction();
       Status = StatError;
       return;
       TransactionManager->AbortTransaction();
       Status = StatError;
       return;


@@ -2298,7 +2298,7 @@ void pkgAcqMetaClearSig::Failed(string Message,pkgAcquire::MethodConfig *Cnf) /*
          QueueIndexes(false);
       } else {
          // warn if the repository is unsigned
          QueueIndexes(false);
       } else {
          // warn if the repository is unsigned

-         _error->Warning("Use --allow-insecure-repositories to force the update");
+         _error->Error("Use --allow-insecure-repositories to force the update");

          TransactionManager->AbortTransaction();
          Status = StatError;
       }
          TransactionManager->AbortTransaction();
          Status = StatError;
       }