Remap another (non-parameter) StringView

I only looked at parameters in the previous commit, which was
not enough: One place also generated local string views. In this
case, we only need to make ArchA dynamic, as NameA is not used
after the FindPkg() call.

Gbp-Dch: ignore

diff --git a/apt-pkg/pkgcachegen.cc b/apt-pkg/pkgcachegen.cc
index d8f161e6de44b1998a345db6a85f65e8ff3f0007..55d1ee89de2c27e4fcffa825758a4e87c42a97a6 100644 (file)
--- a/apt-pkg/pkgcachegen.cc
+++ b/apt-pkg/pkgcachegen.cc
@@ -661,10 +661,12 @@ bool pkgCacheGenerator::NewPackage(pkgCache::PkgIterator &Pkg, StringView Name,
    {
       size_t const found = Name.find(':');
       StringView const NameA = Name.substr(0, found);
-      StringView const ArchA = Name.substr(found + 1);
+      StringView ArchA = Name.substr(found + 1);
       pkgCache::PkgIterator PkgA = Cache.FindPkg(NameA, ArchA);
       if (PkgA.end() == false)
       {
+        // ArchA is used inside the loop which might remap (NameA is not used)
+        Dynamic<StringView> DynArchA(ArchA);
         Dynamic<pkgCache::PkgIterator> DynPkgA(PkgA);
         pkgCache::PrvIterator Prv = PkgA.ProvidesList();
         for (; Prv.end() == false; ++Prv)