* cmdline/apt-get.cc, apt-pkg/cdrom.cc:

 - fix memory leaks in error conditions in DoSource()

diff --git a/apt-pkg/cdrom.cc b/apt-pkg/cdrom.cc
index 96d4e9c91c2f95ef56a3a851e68a9dd7a1e51347..783ffc43069338c169a79654599378222409c970 100644 (file)
--- a/apt-pkg/cdrom.cc
+++ b/apt-pkg/cdrom.cc
@@ -289,7 +289,8 @@ bool pkgCdrom::DropRepeats(vector<string> &List,const char *Name)
         List[J] = string();
       }
    }  
         List[J] = string();
       }
    }  

- 
+   delete[] Inodes;
+

    // Wipe erased entries
    for (unsigned int I = 0; I < List.size();)
    {
    // Wipe erased entries
    for (unsigned int I = 0; I < List.size();)
    {

diff --git a/cmdline/apt-get.cc b/cmdline/apt-get.cc
index ea236676b819504703fa841c94fe5f08776b36ca..0bc8fc5716ed25f2a5017fd910492a2c8ba134c0 100644 (file)
--- a/cmdline/apt-get.cc
+++ b/cmdline/apt-get.cc
@@ -2315,6 +2315,7 @@ bool DoSource(CommandLine &CmdL)
    {
       for (unsigned I = 0; I != J; I++)
         ioprintf(cout,_("Fetch source %s\n"),Dsc[I].Package.c_str());
    {
       for (unsigned I = 0; I != J; I++)
         ioprintf(cout,_("Fetch source %s\n"),Dsc[I].Package.c_str());

+      delete[] Dsc;

       return true;
    }
    
       return true;
    }
    


@@ -2325,6 +2326,7 @@ bool DoSource(CommandLine &CmdL)
       for (; I != Fetcher.UriEnd(); I++)
         cout << '\'' << I->URI << "' " << flNotDir(I->Owner->DestFile) << ' ' << 
               I->Owner->FileSize << ' ' << I->Owner->HashSum() << endl;
       for (; I != Fetcher.UriEnd(); I++)
         cout << '\'' << I->URI << "' " << flNotDir(I->Owner->DestFile) << ' ' << 
               I->Owner->FileSize << ' ' << I->Owner->HashSum() << endl;

+      delete[] Dsc;

       return true;
    }
    
       return true;
    }
    


@@ -2350,6 +2352,7 @@ bool DoSource(CommandLine &CmdL)
    if (_config->FindB("APT::Get::Download-only",false) == true)
    {
       c1out << _("Download complete and in download only mode") << endl;
    if (_config->FindB("APT::Get::Download-only",false) == true)
    {
       c1out << _("Download complete and in download only mode") << endl;

+      delete[] Dsc;

       return true;
    }
 
       return true;
    }
 


@@ -2411,7 +2414,8 @@ bool DoSource(CommandLine &CmdL)
       
       _exit(0);
    }
       
       _exit(0);
    }

-   
+   delete[] Dsc;
+

    // Wait for the subprocess
    int Status = 0;
    while (waitpid(Process,&Status,0) != Process)
    // Wait for the subprocess
    int Status = 0;
    while (waitpid(Process,&Status,0) != Process)

diff --git a/debian/changelog b/debian/changelog
index bf07b9f30e5f7649f8741f9491aa340deec73720..5f5a43098b21f11469275802b78c9f47c9d85a44 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,8 @@ apt (0.7.25.3ubuntu4) UNRELEASED; urgency=low
   * apt-pkg/deb/debversion.cc:
     - consider absent of debian revision equivalent to 0 (Closes: #573592)
       LP: #540228
   * apt-pkg/deb/debversion.cc:
     - consider absent of debian revision equivalent to 0 (Closes: #573592)
       LP: #540228

+  * cmdline/apt-get.cc, apt-pkg/cdrom.cc:
+   - fix memory leaks in error conditions in DoSource()

   
  -- Michael Vogt <michael.vogt@ubuntu.com>  Fri, 26 Mar 2010 16:57:49 +0100
 
   
  -- Michael Vogt <michael.vogt@ubuntu.com>  Fri, 26 Mar 2010 16:57:49 +0100