update: Check if the cache could be opened, don't just assume it

This seems to cause Bug#756162, as in that case the depcache
was NULL.

I'm not entirely sure how that happens, but it's better to
be check here rather then crash later on.

Closes: #756162

diff --git a/apt-private/private-update.cc b/apt-private/private-update.cc
index 73a82e988f2e468a3ded13e413d03cba44511b46..1323771f0b8747417f23739f38070b51249965b5 100644 (file)
--- a/apt-private/private-update.cc
+++ b/apt-private/private-update.cc
@@ -84,7 +84,8 @@ bool DoUpdate(CommandLine &CmdL)
    if (_config->FindB("APT::Cmd::Show-Update-Stats", false) == true)
    {
       int upgradable = 0;
    if (_config->FindB("APT::Cmd::Show-Update-Stats", false) == true)
    {
       int upgradable = 0;

-      Cache.Open();
+      if (Cache.Open() == false)
+         return false;

       for (pkgCache::PkgIterator I = Cache->PkgBegin(); I.end() != true; ++I)
       {
          pkgDepCache::StateCache &state = Cache[I];
       for (pkgCache::PkgIterator I = Cache->PkgBegin(); I.end() != true; ++I)
       {
          pkgDepCache::StateCache &state = Cache[I];