rename packageset into cacheset while it is not too late
authorDavid Kalnischkies <kalnischkies@gmail.com>
Mon, 31 May 2010 19:00:09 +0000 (21:00 +0200)
committerDavid Kalnischkies <kalnischkies@gmail.com>
Mon, 31 May 2010 19:00:09 +0000 (21:00 +0200)
apt-pkg/cacheset.cc [new file with mode: 0644]
apt-pkg/cacheset.h [new file with mode: 0644]
apt-pkg/makefile
apt-pkg/packageset.cc [deleted file]
apt-pkg/packageset.h [deleted file]
cmdline/apt-cache.cc
cmdline/apt-get.cc
debian/changelog

diff --git a/apt-pkg/cacheset.cc b/apt-pkg/cacheset.cc
new file mode 100644 (file)
index 0000000..b49b365
--- /dev/null
@@ -0,0 +1,103 @@
+// -*- mode: cpp; mode: fold -*-
+// Description                                                         /*{{{*/
+/* ######################################################################
+
+   Simple wrapper around a std::set to provide a similar interface to
+   a set of cache structures as to the complete set of all structures
+   in the pkgCache. Currently only Package is supported.
+
+   ##################################################################### */
+                                                                       /*}}}*/
+// Include Files                                                       /*{{{*/
+#include <apt-pkg/aptconfiguration.h>
+#include <apt-pkg/error.h>
+#include <apt-pkg/cacheset.h>
+#include <apt-pkg/strutl.h>
+
+#include <apti18n.h>
+
+#include <vector>
+
+#include <regex.h>
+                                                                       /*}}}*/
+namespace APT {
+// FromRegEx - Return all packages in the cache matching a pattern     /*{{{*/
+PackageSet PackageSet::FromRegEx(pkgCache &Cache, std::string pattern, std::ostream &out) {
+       PackageSet pkgset;
+       std::string arch = "native";
+       static const char * const isregex = ".?+*|[^$";
+
+       if (pattern.find_first_of(isregex) == std::string::npos)
+               return pkgset;
+
+       size_t archfound = pattern.find_last_of(':');
+       if (archfound != std::string::npos) {
+               arch = pattern.substr(archfound+1);
+               if (arch.find_first_of(isregex) == std::string::npos)
+                       pattern.erase(archfound);
+               else
+                       arch = "native";
+       }
+
+       regex_t Pattern;
+       int Res;
+       if ((Res = regcomp(&Pattern, pattern.c_str() , REG_EXTENDED | REG_ICASE | REG_NOSUB)) != 0) {
+               char Error[300];
+               regerror(Res, &Pattern, Error, sizeof(Error));
+               _error->Error(_("Regex compilation error - %s"), Error);
+               return pkgset;
+       }
+
+       for (pkgCache::GrpIterator Grp = Cache.GrpBegin(); Grp.end() == false; ++Grp)
+       {
+               if (regexec(&Pattern, Grp.Name(), 0, 0, 0) != 0)
+                       continue;
+               pkgCache::PkgIterator Pkg = Grp.FindPkg(arch);
+               if (Pkg.end() == true) {
+                       if (archfound == std::string::npos) {
+                               std::vector<std::string> archs = APT::Configuration::getArchitectures();
+                               for (std::vector<std::string>::const_iterator a = archs.begin();
+                                    a != archs.end() && Pkg.end() != true; ++a)
+                                       Pkg = Grp.FindPkg(*a);
+                       }
+                       if (Pkg.end() == true)
+                               continue;
+               }
+
+               ioprintf(out, _("Note, selecting %s for regex '%s'\n"),
+                        Pkg.FullName(true).c_str(), pattern.c_str());
+
+               pkgset.insert(Pkg);
+       }
+
+       regfree(&Pattern);
+
+       return pkgset;
+}
+                                                                       /*}}}*/
+// FromCommandLine - Return all packages specified on commandline      /*{{{*/
+PackageSet PackageSet::FromCommandLine(pkgCache &Cache, const char **cmdline, std::ostream &out) {
+       PackageSet pkgset;
+       for (const char **I = cmdline + 1; *I != 0; I++) {
+               pkgCache::PkgIterator Pkg = Cache.FindPkg(*I);
+               if (Pkg.end() == true) {
+                       std::vector<std::string> archs = APT::Configuration::getArchitectures();
+                       for (std::vector<std::string>::const_iterator a = archs.begin();
+                            a != archs.end() || Pkg.end() != true; ++a) {
+                               Pkg = Cache.FindPkg(*I, *a);
+                       }
+                       if (Pkg.end() == true) {
+                               PackageSet regex = FromRegEx(Cache, *I, out);
+                               if (regex.empty() == true)
+                                       _error->Warning(_("Unable to locate package %s"),*I);
+                               else
+                                       pkgset.insert(regex.begin(), regex.end());
+                               continue;
+                       }
+               }
+               pkgset.insert(Pkg);
+       }
+       return pkgset;
+}
+                                                                       /*}}}*/
+}
diff --git a/apt-pkg/cacheset.h b/apt-pkg/cacheset.h
new file mode 100644 (file)
index 0000000..7c05fac
--- /dev/null
@@ -0,0 +1,96 @@
+// -*- mode: cpp; mode: fold -*-
+// Description                                                         /*{{{*/
+/** \file cacheset.h
+   Wrappers around std::set to have set::iterators which behave
+   similar to the Iterators of the cache structures.
+
+   Provides also a few helper methods which work with these sets */
+                                                                       /*}}}*/
+#ifndef APT_CACHESET_H
+#define APT_CACHESET_H
+// Include Files                                                       /*{{{*/
+#include <iostream>
+#include <fstream>
+#include <set>
+#include <string>
+
+#include <apt-pkg/pkgcache.h>
+                                                                       /*}}}*/
+namespace APT {
+/** \class APT::PackageSet
+
+    Simple wrapper around a std::set to provide a similar interface to
+    a set of packages as to the complete set of all packages in the
+    pkgCache. */
+class PackageSet : public std::set<pkgCache::PkgIterator> {            /*{{{*/
+public:                                                                        /*{{{*/
+       /** \brief smell like a pkgCache::PkgIterator */
+       class const_iterator : public std::set<pkgCache::PkgIterator>::const_iterator {
+       public:
+               const_iterator(std::set<pkgCache::PkgIterator>::const_iterator x) :
+                        std::set<pkgCache::PkgIterator>::const_iterator(x) {}
+
+               operator pkgCache::PkgIterator(void) { return **this; }
+
+               inline const char *Name() const {return (**this).Name(); }
+               inline std::string FullName(bool const &Pretty) const { return (**this).FullName(Pretty); }
+               inline std::string FullName() const { return (**this).FullName(); }
+               inline const char *Section() const {return (**this).Section(); }
+               inline bool Purge() const {return (**this).Purge(); }
+               inline const char *Arch() const {return (**this).Arch(); }
+               inline pkgCache::GrpIterator Group() const { return (**this).Group(); }
+               inline pkgCache::VerIterator VersionList() const { return (**this).VersionList(); }
+               inline pkgCache::VerIterator CurrentVer() const { return (**this).CurrentVer(); }
+               inline pkgCache::DepIterator RevDependsList() const { return (**this).RevDependsList(); }
+               inline pkgCache::PrvIterator ProvidesList() const { return (**this).ProvidesList(); }
+               inline pkgCache::PkgIterator::OkState State() const { return (**this).State(); }
+               inline const char *CandVersion() const { return (**this).CandVersion(); }
+               inline const char *CurVersion() const { return (**this).CurVersion(); }
+               inline pkgCache *Cache() const { return (**this).Cache(); };
+               inline unsigned long Index() const {return (**this).Index();};
+               // we have only valid iterators here
+               inline bool end() const { return false; };
+
+               friend std::ostream& operator<<(std::ostream& out, const_iterator i) { return operator<<(out, (*i)); }
+
+               inline pkgCache::Package const * operator->() const {
+                       return &***this;
+               };
+       };
+       // 103. set::iterator is required to be modifiable, but this allows modification of keys
+       typedef typename APT::PackageSet::const_iterator iterator;
+
+       /** \brief returns all packages in the cache whose name matchs a given pattern
+
+           A simple helper responsible for executing a regular expression on all
+           package names in the cache. Optional it prints a a notice about the
+           packages chosen cause of the given package.
+           \param Cache the packages are in
+           \param pattern regular expression for package names
+           \param out stream to print the notice to */
+       static APT::PackageSet FromRegEx(pkgCache &Cache, std::string pattern, std::ostream &out);
+       static APT::PackageSet FromRegEx(pkgCache &Cache, std::string const &pattern) {
+               std::ostream out (std::ofstream("/dev/null").rdbuf());
+               return APT::PackageSet::FromRegEx(Cache, pattern, out);
+       }
+
+       /** \brief returns all packages specified on the commandline
+
+           Get all package names from the commandline and executes regex's if needed.
+           No special package command is supported, just plain names.
+           \param Cache the packages are in
+           \param cmdline Command line the package names should be extracted from
+           \param out stream to print various notices to */
+       static APT::PackageSet FromCommandLine(pkgCache &Cache, const char **cmdline, std::ostream &out);
+       static APT::PackageSet FromCommandLine(pkgCache &Cache, const char **cmdline) {
+               std::ostream out (std::ofstream("/dev/null").rdbuf());
+               return APT::PackageSet::FromCommandLine(Cache, cmdline, out);
+       }
+
+
+
+                                                                       /*}}}*/
+};
+                                                                       /*}}}*/
+}
+#endif
index 968275c5c1fe1b5e6a27bde9e8e6b42eccec30a6..1a7078693e0ad0abfecf0284c034d5105c4eb861 100644 (file)
@@ -35,7 +35,7 @@ SOURCE+= pkgcache.cc version.cc depcache.cc \
         srcrecords.cc cachefile.cc versionmatch.cc policy.cc \
         pkgsystem.cc indexfile.cc pkgcachegen.cc acquire-item.cc \
         indexrecords.cc vendor.cc vendorlist.cc cdrom.cc indexcopy.cc \
-        aptconfiguration.cc packageset.cc
+        aptconfiguration.cc cacheset.cc
 HEADERS+= algorithms.h depcache.h pkgcachegen.h cacheiterators.h \
          orderlist.h sourcelist.h packagemanager.h tagfile.h \
          init.h pkgcache.h version.h progress.h pkgrecords.h \
@@ -43,7 +43,7 @@ HEADERS+= algorithms.h depcache.h pkgcachegen.h cacheiterators.h \
          clean.h srcrecords.h cachefile.h versionmatch.h policy.h \
          pkgsystem.h indexfile.h metaindex.h indexrecords.h vendor.h \
           vendorlist.h cdrom.h indexcopy.h aptconfiguration.h \
-         packageset.h
+         cacheset.h
 
 # Source code for the debian specific components
 # In theory the deb headers do not need to be exported..
diff --git a/apt-pkg/packageset.cc b/apt-pkg/packageset.cc
deleted file mode 100644 (file)
index f296b7c..0000000
+++ /dev/null
@@ -1,103 +0,0 @@
-// -*- mode: cpp; mode: fold -*-
-// Description                                                         /*{{{*/
-/* ######################################################################
-
-   Simple wrapper around a std::set to provide a similar interface to
-   a set of packages as to the complete set of all packages in the
-   pkgCache.
-
-   ##################################################################### */
-                                                                       /*}}}*/
-// Include Files                                                       /*{{{*/
-#include <apt-pkg/aptconfiguration.h>
-#include <apt-pkg/error.h>
-#include <apt-pkg/packageset.h>
-#include <apt-pkg/strutl.h>
-
-#include <apti18n.h>
-
-#include <vector>
-
-#include <regex.h>
-                                                                       /*}}}*/
-namespace APT {
-// FromRegEx - Return all packages in the cache matching a pattern     /*{{{*/
-PackageSet PackageSet::FromRegEx(pkgCache &Cache, std::string pattern, std::ostream &out) {
-       PackageSet pkgset;
-       std::string arch = "native";
-       static const char * const isregex = ".?+*|[^$";
-
-       if (pattern.find_first_of(isregex) == std::string::npos)
-               return pkgset;
-
-       size_t archfound = pattern.find_last_of(':');
-       if (archfound != std::string::npos) {
-               arch = pattern.substr(archfound+1);
-               if (arch.find_first_of(isregex) == std::string::npos)
-                       pattern.erase(archfound);
-               else
-                       arch = "native";
-       }
-
-       regex_t Pattern;
-       int Res;
-       if ((Res = regcomp(&Pattern, pattern.c_str() , REG_EXTENDED | REG_ICASE | REG_NOSUB)) != 0) {
-               char Error[300];
-               regerror(Res, &Pattern, Error, sizeof(Error));
-               _error->Error(_("Regex compilation error - %s"), Error);
-               return pkgset;
-       }
-
-       for (pkgCache::GrpIterator Grp = Cache.GrpBegin(); Grp.end() == false; ++Grp)
-       {
-               if (regexec(&Pattern, Grp.Name(), 0, 0, 0) != 0)
-                       continue;
-               pkgCache::PkgIterator Pkg = Grp.FindPkg(arch);
-               if (Pkg.end() == true) {
-                       if (archfound == std::string::npos) {
-                               std::vector<std::string> archs = APT::Configuration::getArchitectures();
-                               for (std::vector<std::string>::const_iterator a = archs.begin();
-                                    a != archs.end() && Pkg.end() != true; ++a)
-                                       Pkg = Grp.FindPkg(*a);
-                       }
-                       if (Pkg.end() == true)
-                               continue;
-               }
-
-               ioprintf(out, _("Note, selecting %s for regex '%s'\n"),
-                        Pkg.FullName(true).c_str(), pattern.c_str());
-
-               pkgset.insert(Pkg);
-       }
-
-       regfree(&Pattern);
-
-       return pkgset;
-}
-                                                                       /*}}}*/
-// FromCommandLine - Return all packages specified on commandline      /*{{{*/
-PackageSet PackageSet::FromCommandLine(pkgCache &Cache, const char **cmdline, std::ostream &out) {
-       PackageSet pkgset;
-       for (const char **I = cmdline + 1; *I != 0; I++) {
-               pkgCache::PkgIterator Pkg = Cache.FindPkg(*I);
-               if (Pkg.end() == true) {
-                       std::vector<std::string> archs = APT::Configuration::getArchitectures();
-                       for (std::vector<std::string>::const_iterator a = archs.begin();
-                            a != archs.end() || Pkg.end() != true; ++a) {
-                               Pkg = Cache.FindPkg(*I, *a);
-                       }
-                       if (Pkg.end() == true) {
-                               PackageSet regex = FromRegEx(Cache, *I, out);
-                               if (regex.empty() == true)
-                                       _error->Warning(_("Unable to locate package %s"),*I);
-                               else
-                                       pkgset.insert(regex.begin(), regex.end());
-                               continue;
-                       }
-               }
-               pkgset.insert(Pkg);
-       }
-       return pkgset;
-}
-                                                                       /*}}}*/
-}
diff --git a/apt-pkg/packageset.h b/apt-pkg/packageset.h
deleted file mode 100644 (file)
index 9f80d60..0000000
+++ /dev/null
@@ -1,92 +0,0 @@
-// -*- mode: cpp; mode: fold -*-
-// Description                                                         /*{{{*/
-/** \class APT::PackageSet
-
-    Simple wrapper around a std::set to provide a similar interface to
-    a set of packages as to the complete set of all packages in the
-    pkgCache.
-*/
-                                                                       /*}}}*/
-#ifndef APT_PACKAGESET_H
-#define APT_PACKAGESET_H
-// Include Files                                                       /*{{{*/
-#include <iostream>
-#include <fstream>
-#include <set>
-#include <string>
-
-#include <apt-pkg/pkgcache.h>
-                                                                       /*}}}*/
-namespace APT {
-class PackageSet : public std::set<pkgCache::PkgIterator> {            /*{{{*/
-public:                                                                        /*{{{*/
-       /** \brief smell like a pkgCache::PkgIterator */
-       class const_iterator : public std::set<pkgCache::PkgIterator>::const_iterator {
-       public:
-               const_iterator(std::set<pkgCache::PkgIterator>::const_iterator x) :
-                        std::set<pkgCache::PkgIterator>::const_iterator(x) {}
-
-               operator pkgCache::PkgIterator(void) { return **this; }
-
-               inline const char *Name() const {return (**this).Name(); }
-               inline std::string FullName(bool const &Pretty) const { return (**this).FullName(Pretty); }
-               inline std::string FullName() const { return (**this).FullName(); }
-               inline const char *Section() const {return (**this).Section(); }
-               inline bool Purge() const {return (**this).Purge(); }
-               inline const char *Arch() const {return (**this).Arch(); }
-               inline pkgCache::GrpIterator Group() const { return (**this).Group(); }
-               inline pkgCache::VerIterator VersionList() const { return (**this).VersionList(); }
-               inline pkgCache::VerIterator CurrentVer() const { return (**this).CurrentVer(); }
-               inline pkgCache::DepIterator RevDependsList() const { return (**this).RevDependsList(); }
-               inline pkgCache::PrvIterator ProvidesList() const { return (**this).ProvidesList(); }
-               inline pkgCache::PkgIterator::OkState State() const { return (**this).State(); }
-               inline const char *CandVersion() const { return (**this).CandVersion(); }
-               inline const char *CurVersion() const { return (**this).CurVersion(); }
-               inline pkgCache *Cache() const { return (**this).Cache(); };
-               inline unsigned long Index() const {return (**this).Index();};
-               // we have only valid iterators here
-               inline bool end() const { return false; };
-
-               friend std::ostream& operator<<(std::ostream& out, const_iterator i) { return operator<<(out, (*i)); }
-
-               inline pkgCache::Package const * operator->() const {
-                       return &***this;
-               };
-       };
-       // 103. set::iterator is required to be modifiable, but this allows modification of keys
-       typedef typename APT::PackageSet::const_iterator iterator;
-
-       /** \brief returns all packages in the cache whose name matchs a given pattern
-
-           A simple helper responsible for executing a regular expression on all
-           package names in the cache. Optional it prints a a notice about the
-           packages chosen cause of the given package.
-           \param Cache the packages are in
-           \param pattern regular expression for package names
-           \param out stream to print the notice to */
-       static APT::PackageSet FromRegEx(pkgCache &Cache, std::string pattern, std::ostream &out);
-       static APT::PackageSet FromRegEx(pkgCache &Cache, std::string const &pattern) {
-               std::ostream out (std::ofstream("/dev/null").rdbuf());
-               return APT::PackageSet::FromRegEx(Cache, pattern, out);
-       }
-
-       /** \brief returns all packages specified on the commandline
-
-           Get all package names from the commandline and executes regex's if needed.
-           No special package command is supported, just plain names.
-           \param Cache the packages are in
-           \param cmdline Command line the package names should be extracted from
-           \param out stream to print various notices to */
-       static APT::PackageSet FromCommandLine(pkgCache &Cache, const char **cmdline, std::ostream &out);
-       static APT::PackageSet FromCommandLine(pkgCache &Cache, const char **cmdline) {
-               std::ostream out (std::ofstream("/dev/null").rdbuf());
-               return APT::PackageSet::FromCommandLine(Cache, cmdline, out);
-       }
-
-
-
-                                                                       /*}}}*/
-};
-                                                                       /*}}}*/
-}
-#endif
index d8e14617a20a6e86b43890c0fd653c27b91bc927..891b108734fa9aa3330e0b0bb6692ef268c62ae1 100644 (file)
@@ -29,7 +29,7 @@
 #include <apt-pkg/tagfile.h>
 #include <apt-pkg/algorithms.h>
 #include <apt-pkg/sptr.h>
-#include <apt-pkg/packageset.h>
+#include <apt-pkg/cacheset.h>
 
 #include <config.h>
 #include <apti18n.h>
index 1cffd67303d3bac0a41d3244f4faae62bf3f85c2..9894747f4210bd1e55c6b6af9bd2d952827b174f 100644 (file)
@@ -40,7 +40,7 @@
 #include <apt-pkg/sptr.h>
 #include <apt-pkg/md5.h>
 #include <apt-pkg/versionmatch.h>
-#include <apt-pkg/packageset.h>
+#include <apt-pkg/cacheset.h>
 
 #include <config.h>
 #include <apti18n.h>
index 054088ec26bc0a455e93f6ce49d913b812e06276..6b9057ae3927dd2d8a44675372beb5e98ab10273 100644 (file)
@@ -22,7 +22,7 @@ apt (0.7.26~exp6) UNRELEASED; urgency=low
     - correct "Dangerous iterator usage." pointed out by cppcheck
   * ftparchive/writer.h:
     - add a virtual destructor to FTWScanner class (for cppcheck)
-  * apt-pkg/packageset.h:
+  * apt-pkg/cacheset.h:
     - add a simple wrapper around std::set for packages with it
     - move regex magic from apt-get to new FromRegEx method
     - move cmdline parsing from apt-cache to new FromCommandLine method