http: clear content before reporting the failure

[Comment from commiter:] I have the feeling that the issue itself is
fixed for a while already as nowadays we have testcases involving a
webserver closing the connection on error (look for "closeOnError") and
no even remotely recent reports about it, but moving the content
clearance above the failure report is a valid change and shouldn't hurt.

Closes: #465572

diff --git a/methods/server.cc b/methods/server.cc
index af7276badd7a9f2ca2b7670b78ebb14b4f4f2efc..0408dddfd3f8dfbb8ef395f1b3d8935e8cac712e 100644 (file)
--- a/methods/server.cc
+++ b/methods/server.cc
@@ -770,8 +770,8 @@ int ServerMethod::Loop()
         // We need to flush the data, the header is like a 404 w/ error text
         case ERROR_WITH_CONTENT_PAGE:
         {
         // We need to flush the data, the header is like a 404 w/ error text
         case ERROR_WITH_CONTENT_PAGE:
         {

-           Fail();

            Server->RunDataToDevNull();
            Server->RunDataToDevNull();

+           Fail();

            break;
         }
 
            break;
         }