(error) va_list 'args' was opened but not closed by va_end()

Reported-By: cppcheck
Gbp-Dch: Ignore

diff --git a/apt-pkg/contrib/error.cc b/apt-pkg/contrib/error.cc
index 8a87e16e9e1fbdb404bfb289f936152fbaad2f07..c06ea8364992f3ebf8a4c52d7b0b2119d49b43f8 100644 (file)
--- a/apt-pkg/contrib/error.cc
+++ b/apt-pkg/contrib/error.cc
@@ -68,13 +68,12 @@ bool GlobalError::NAME (const char *Function, const char *Description,...) { \
        va_list args; \
        size_t msgSize = 400; \
        int const errsv = errno; \
        va_list args; \
        size_t msgSize = 400; \
        int const errsv = errno; \

-       while (true) { \
+       bool retry; \
+       do { \

                va_start(args,Description); \
                va_start(args,Description); \

-               bool const retry = InsertErrno(TYPE, Function, Description, args, errsv, msgSize); \
+               retry = InsertErrno(TYPE, Function, Description, args, errsv, msgSize); \

                va_end(args); \
                va_end(args); \

-               if (retry == false) \
-                       break; \
-       } \
+       } while (retry); \

        return false; \
 }
 GEMessage(FatalE, FATAL)
        return false; \
 }
 GEMessage(FatalE, FATAL)


@@ -90,13 +89,12 @@ bool GlobalError::InsertErrno(MsgType const &type, const char *Function,
        va_list args;
        size_t msgSize = 400;
        int const errsv = errno;
        va_list args;
        size_t msgSize = 400;
        int const errsv = errno;

-       while (true) {
+       bool retry;
+       do {

                va_start(args,Description);
                va_start(args,Description);

-               bool const retry = InsertErrno(type, Function, Description, args, errsv, msgSize);
+               retry = InsertErrno(type, Function, Description, args, errsv, msgSize);

                va_end(args);
                va_end(args);

-               if (retry == false)
-                  break;
-       }
+       } while (retry);

        return false;
 }
                                                                        /*}}}*/
        return false;
 }
                                                                        /*}}}*/


@@ -127,12 +125,12 @@ bool GlobalError::InsertErrno(MsgType type, const char* Function,
 bool GlobalError::NAME (const char *Description,...) { \
        va_list args; \
        size_t msgSize = 400; \
 bool GlobalError::NAME (const char *Description,...) { \
        va_list args; \
        size_t msgSize = 400; \

-       while (true) { \
+       bool retry; \
+       do { \

                va_start(args,Description); \
                va_start(args,Description); \

-               if (Insert(TYPE, Description, args, msgSize) == false) \
-                       break; \
+               retry = Insert(TYPE, Description, args, msgSize); \

                va_end(args); \
                va_end(args); \

-       } \
+       } while (retry); \

        return false; \
 }
 GEMessage(Fatal, FATAL)
        return false; \
 }
 GEMessage(Fatal, FATAL)


@@ -147,12 +145,12 @@ bool GlobalError::Insert(MsgType const &type, const char *Description,...)
 {
        va_list args;
        size_t msgSize = 400;
 {
        va_list args;
        size_t msgSize = 400;

-       while (true) {
+       bool retry;
+       do {

                va_start(args,Description);
                va_start(args,Description);

-               if (Insert(type, Description, args, msgSize) == false)
-                       break;
+               retry = Insert(type, Description, args, msgSize);

                va_end(args);
                va_end(args);

-       }
+       } while (retry);

        return false;
 }
                                                                        /*}}}*/
        return false;
 }
                                                                        /*}}}*/

diff --git a/apt-pkg/contrib/fileutl.cc b/apt-pkg/contrib/fileutl.cc
index fc578cd23b1381deb8b4d2f56d51e1daed7d9914..8fd0ac6177a1a23828d6ca1cdf6bca6bab5712fd 100644 (file)
--- a/apt-pkg/contrib/fileutl.cc
+++ b/apt-pkg/contrib/fileutl.cc
@@ -2682,13 +2682,12 @@ bool FileFd::FileFdErrno(const char *Function, const char *Description,...)
    va_list args;
    size_t msgSize = 400;
    int const errsv = errno;
    va_list args;
    size_t msgSize = 400;
    int const errsv = errno;

-   while (true)
-   {
+   bool retry;
+   do {

       va_start(args,Description);
       va_start(args,Description);

-      if (_error->InsertErrno(GlobalError::ERROR, Function, Description, args, errsv, msgSize) == false)
-        break;
+      retry = _error->InsertErrno(GlobalError::ERROR, Function, Description, args, errsv, msgSize);

       va_end(args);
       va_end(args);

-   }
+   } while (retry);

    return false;
 }
                                                                        /*}}}*/
    return false;
 }
                                                                        /*}}}*/


@@ -2697,13 +2696,12 @@ bool FileFd::FileFdError(const char *Description,...) {
    Flags |= Fail;
    va_list args;
    size_t msgSize = 400;
    Flags |= Fail;
    va_list args;
    size_t msgSize = 400;

-   while (true)
-   {
+   bool retry;
+   do {

       va_start(args,Description);
       va_start(args,Description);

-      if (_error->Insert(GlobalError::ERROR, Description, args, msgSize) == false)
-        break;
+      retry = _error->Insert(GlobalError::ERROR, Description, args, msgSize);

       va_end(args);
       va_end(args);

-   }
+   } while (retry);

    return false;
 }
                                                                        /*}}}*/
    return false;
 }
                                                                        /*}}}*/

diff --git a/apt-pkg/edsp.cc b/apt-pkg/edsp.cc
index 47b914fd58592dd9d11d20594aab884282387d29..740eb0a0d6fcd50ef4ee8e20c3dadc4d36640e7d 100644 (file)
--- a/apt-pkg/edsp.cc
+++ b/apt-pkg/edsp.cc
@@ -340,7 +340,7 @@ static bool WriteScenarioLimitedDependency(FileFd &output,
 static bool SkipUnavailableVersions(pkgDepCache &Cache, pkgCache::PkgIterator const &Pkg, pkgCache::VerIterator const &Ver)/*{{{*/
 {
    /* versions which aren't current and aren't available in
 static bool SkipUnavailableVersions(pkgDepCache &Cache, pkgCache::PkgIterator const &Pkg, pkgCache::VerIterator const &Ver)/*{{{*/
 {
    /* versions which aren't current and aren't available in

-      any "online" source file are bad, expect if they are the choosen
+      any "online" source file are bad, expect if they are the chosen

       candidate: The exception is for build-dep implementation as it creates
       such pseudo (package) versions and removes them later on again.
       We filter out versions at all so packages in 'rc' state only available
       candidate: The exception is for build-dep implementation as it creates
       such pseudo (package) versions and removes them later on again.
       We filter out versions at all so packages in 'rc' state only available

diff --git a/test/integration/test-releasefile-verification b/test/integration/test-releasefile-verification
index 500c7b0bdaf9b7bfc00f3654ff41c5a08758af31..82e48ffa8d69304a978a9ac2b60e7cfc43449537 100755 (executable)
--- a/test/integration/test-releasefile-verification
+++ b/test/integration/test-releasefile-verification
@@ -379,7 +379,7 @@ cat > rootdir/etc/apt/apt.conf.d/weaken-security <<EOF
 Acquire::AllowInsecureRepositories "1";
 Acquire::AllowDowngradeToInsecureRepositories "1";
 EOF
 Acquire::AllowInsecureRepositories "1";
 Acquire::AllowDowngradeToInsecureRepositories "1";
 EOF

-# the hash marked as configureable in our gpgv method
+# the hash marked as configurable in our gpgv method

 export APT_TESTS_DIGEST_ALGO='SHA224'
 
 successfulaptgetupdate() {
 export APT_TESTS_DIGEST_ALGO='SHA224'
 
 successfulaptgetupdate() {