restore pinning to min/max value of short

[apt.git] / test / integration / test-releasefile-verification

diff --git a/test/integration/test-releasefile-verification b/test/integration/test-releasefile-verification
index e558b83e8384fa639a3fd9666b7c6fc197aa8368..c349c44283b5de8d434c01b1face6b8a4ff0ee93 100755 (executable)
--- a/test/integration/test-releasefile-verification
+++ b/test/integration/test-releasefile-verification
@@ -1,8 +1,8 @@
 #!/bin/sh
 set -e
 
 #!/bin/sh
 set -e
 

-TESTDIR=$(readlink -f $(dirname $0))
-. $TESTDIR/framework
+TESTDIR="$(readlink -f "$(dirname "$0")")"
+. "$TESTDIR/framework"

 
 setupenvironment
 configarchitecture "i386"
 
 setupenvironment
 configarchitecture "i386"


@@ -23,222 +23,301 @@ prepare() {
                fi
        fi
        for release in $(find rootdir/var/lib/apt/lists 2> /dev/null); do
                fi
        fi
        for release in $(find rootdir/var/lib/apt/lists 2> /dev/null); do

-               touch -d 'now - 1 year' $release
+               touch -d 'now - 1 year' "$release"

        done
        aptget clean
        done
        aptget clean

-       cp $1 aptarchive/Packages
+       cp "$1" aptarchive/Packages

        find aptarchive -name 'Release' -delete
        compressfile 'aptarchive/Packages' "$DATE"
        generatereleasefiles "$DATE"
 }
 
 installaptold() {
        find aptarchive -name 'Release' -delete
        compressfile 'aptarchive/Packages' "$DATE"
        generatereleasefiles "$DATE"
 }
 
 installaptold() {

-       testequal 'Reading package lists...
+       testsuccessequal "Reading package lists...

 Building dependency tree...
 Suggested packages:
 Building dependency tree...
 Suggested packages:

-  aptitude synaptic wajig dpkg-dev apt-doc bzip2 lzma python-apt
+  aptitude | synaptic | wajig dpkg-dev apt-doc bzip2 lzma python-apt

 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5370 kB of additional disk space will be used.
 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5370 kB of additional disk space will be used.

-Get:1 http://localhost:8080/  apt 0.7.25.3
-Download complete and in download only mode' aptget install apt -dy
+Get:1 http://localhost:${APTHTTPPORT}  apt 0.7.25.3
+Download complete and in download only mode" aptget install apt -dy

 }
 
 installaptnew() {
 }
 
 installaptnew() {

-       testequal 'Reading package lists...
+       testsuccessequal "Reading package lists...

 Building dependency tree...
 Suggested packages:
 Building dependency tree...
 Suggested packages:

-  aptitude synaptic wajig dpkg-dev apt-doc bzip2 lzma python-apt
+  aptitude | synaptic | wajig dpkg-dev apt-doc bzip2 lzma python-apt

 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5808 kB of additional disk space will be used.
 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5808 kB of additional disk space will be used.

-Get:1 http://localhost:8080/  apt 0.8.0~pre1
-Download complete and in download only mode' aptget install apt -dy
+Get:1 http://localhost:${APTHTTPPORT}  apt 0.8.0~pre1
+Download complete and in download only mode" aptget install apt -dy

 }
 
 failaptold() {
 }
 
 failaptold() {

-       testequal 'Reading package lists...
+       testfailureequal 'Reading package lists...

 Building dependency tree...
 Suggested packages:
 Building dependency tree...
 Suggested packages:

-  aptitude synaptic wajig dpkg-dev apt-doc bzip2 lzma python-apt
+  aptitude | synaptic | wajig dpkg-dev apt-doc bzip2 lzma python-apt

 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5370 kB of additional disk space will be used.
 WARNING: The following packages cannot be authenticated!
   apt
 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5370 kB of additional disk space will be used.
 WARNING: The following packages cannot be authenticated!
   apt

-E: There are problems and -y was used without --force-yes' aptget install apt -dy
+E: There were unauthenticated packages and -y was used without --allow-unauthenticated' aptget install apt -dy

 }
 
 failaptnew() {
 }
 
 failaptnew() {

-       testequal 'Reading package lists...
+       testfailureequal 'Reading package lists...

 Building dependency tree...
 Suggested packages:
 Building dependency tree...
 Suggested packages:

-  aptitude synaptic wajig dpkg-dev apt-doc bzip2 lzma python-apt
+  aptitude | synaptic | wajig dpkg-dev apt-doc bzip2 lzma python-apt

 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5808 kB of additional disk space will be used.
 WARNING: The following packages cannot be authenticated!
   apt
 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5808 kB of additional disk space will be used.
 WARNING: The following packages cannot be authenticated!
   apt

-E: There are problems and -y was used without --force-yes' aptget install apt -dy
+E: There were unauthenticated packages and -y was used without --allow-unauthenticated' aptget install apt -dy

 }
 
 # fake our downloadable file
 touch aptarchive/apt.deb
 
 }
 
 # fake our downloadable file
 touch aptarchive/apt.deb
 

-PKGFILE="${TESTDIR}/$(echo "$(basename $0)" | sed 's#^test-#Packages-#')"
+PKGFILE="${TESTDIR}/$(echo "$(basename "$0")" | sed 's#^test-#Packages-#')"

 
 

-updatesuccess() {
-       local LOG='update.log'
-       if aptget update >$LOG 2>&1 || grep -q -E '^(W|E): ' $LOG; then
-               msgpass
-       else
-               cat $LOG
-               msgfail
-       fi
-}
-
-updatefailure() {
-       local LOG='update.log'
-       aptget update >$LOG 2>&1 || true
-       if grep -q -E "$1" $LOG; then
-               msgpass
-       else
-               cat $LOG
-               msgfail
-       fi
+updatewithwarnings() {
+       testwarning aptget update -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
+       testsuccess grep -E "$1" rootdir/tmp/testwarning.output

 }
 
 runtest() {
 }
 
 runtest() {

-       prepare ${PKGFILE}
+       local DELETEFILE="$1"
+       msgmsg 'Cold archive signed by' 'Joe Sixpack'
+       prepare "${PKGFILE}"

        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Cold archive signed by' 'Joe Sixpack'
-       updatesuccess
-       testequal "$(cat ${PKGFILE})
+       successfulaptgetupdate
+       testsuccessequal "$(cat "${PKGFILE}")

 " aptcache show apt
        installaptold
 
 " aptcache show apt
        installaptold
 

-       prepare ${PKGFILE}-new
+       msgmsg 'Good warm archive signed by' 'Joe Sixpack'
+       prepare "${PKGFILE}-new"

        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Good warm archive signed by' 'Joe Sixpack'
-       updatesuccess
-       testequal "$(cat ${PKGFILE}-new)
+       successfulaptgetupdate
+       testsuccessequal "$(cat "${PKGFILE}-new")

 " aptcache show apt
        installaptnew
 
 " aptcache show apt
        installaptnew
 

-       prepare ${PKGFILE}
+       msgmsg 'Cold archive signed by' 'Rex Expired'
+       prepare "${PKGFILE}"

        rm -rf rootdir/var/lib/apt/lists
        cp keys/rexexpired.pub rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg
        signreleasefiles 'Rex Expired'
        find aptarchive/ -name "$DELETEFILE" -delete
        rm -rf rootdir/var/lib/apt/lists
        cp keys/rexexpired.pub rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg
        signreleasefiles 'Rex Expired'
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Cold archive signed by' 'Rex Expired'
-       updatefailure '^W: .* KEYEXPIRED'
-       testequal "$(cat ${PKGFILE})
+       updatewithwarnings '^W: .* KEYEXPIRED'
+       testsuccessequal "$(cat "${PKGFILE}")

 " aptcache show apt
        failaptold
        rm rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg
 
 " aptcache show apt
        failaptold
        rm rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg
 

-       prepare ${PKGFILE}
+       msgmsg 'Cold archive signed by' 'Marvin Paranoid'
+       prepare "${PKGFILE}"

        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Marvin Paranoid'
        find aptarchive/ -name "$DELETEFILE" -delete
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Marvin Paranoid'
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Cold archive signed by' 'Marvin Paranoid'
-       updatefailure '^W: .* NO_PUBKEY'
-       testequal "$(cat ${PKGFILE})
+       updatewithwarnings '^W: .* NO_PUBKEY'
+       testsuccessequal "$(cat "${PKGFILE}")

 " aptcache show apt
        failaptold
 
 " aptcache show apt
        failaptold
 

-       prepare ${PKGFILE}-new
-       # weborf doesn't support If-Range
-       for release in $(find rootdir/var/lib/apt/lists/partial/ -name '*Release'); do
-               rm $release
-               touch $release
-       done
+       msgmsg 'Bad warm archive signed by' 'Joe Sixpack'
+       prepare "${PKGFILE}-new"

        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Bad warm archive signed by' 'Joe Sixpack'
-       updatesuccess
-       testequal "$(cat ${PKGFILE}-new)
+       successfulaptgetupdate
+       testsuccessequal "$(cat "${PKGFILE}-new")

 " aptcache show apt
        installaptnew
 
 " aptcache show apt
        installaptnew
 

-
-       prepare ${PKGFILE}
+       msgmsg 'Cold archive signed by' 'Joe Sixpack'
+       prepare "${PKGFILE}"

        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Cold archive signed by' 'Joe Sixpack'
-       updatesuccess
-       testequal "$(cat ${PKGFILE})
+       successfulaptgetupdate
+       testsuccessequal "$(cat "${PKGFILE}")

 " aptcache show apt
        installaptold
 
 " aptcache show apt
        installaptold
 

-       prepare ${PKGFILE}-new
+       msgmsg 'Good warm archive signed by' 'Marvin Paranoid'
+       prepare "${PKGFILE}-new"

        signreleasefiles 'Marvin Paranoid'
        find aptarchive/ -name "$DELETEFILE" -delete
        signreleasefiles 'Marvin Paranoid'
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Good warm archive signed by' 'Marvin Paranoid'
-       updatefailure '^W: .* NO_PUBKEY'
-       testequal "$(cat ${PKGFILE})
+       updatewithwarnings '^W: .* NO_PUBKEY'
+       testsuccessequal "$(cat "${PKGFILE}")

 " aptcache show apt
        installaptold
 
 " aptcache show apt
        installaptold
 

-       prepare ${PKGFILE}-new
+       msgmsg 'Good warm archive signed by' 'Rex Expired'
+       prepare "${PKGFILE}-new"

        cp keys/rexexpired.pub rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg
        signreleasefiles 'Rex Expired'
        find aptarchive/ -name "$DELETEFILE" -delete
        cp keys/rexexpired.pub rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg
        signreleasefiles 'Rex Expired'
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Good warm archive signed by' 'Rex Expired'
-       updatefailure '^W: .* KEYEXPIRED'
-       testequal "$(cat ${PKGFILE})
+       updatewithwarnings '^W: .* KEYEXPIRED'
+       testsuccessequal "$(cat "${PKGFILE}")

 " aptcache show apt
        installaptold
        rm rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg
 
 " aptcache show apt
        installaptold
        rm rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg
 

-       prepare ${PKGFILE}-new
+       msgmsg 'Good warm archive signed by' 'Joe Sixpack'
+       prepare "${PKGFILE}-new"

        signreleasefiles
        find aptarchive/ -name "$DELETEFILE" -delete
        signreleasefiles
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Good warm archive signed by' 'Joe Sixpack'
-       updatesuccess
-       testequal "$(cat ${PKGFILE}-new)
+       successfulaptgetupdate
+       testsuccessequal "$(cat "${PKGFILE}-new")

 " aptcache show apt
        installaptnew
 " aptcache show apt
        installaptnew

+
+       msgmsg 'Cold archive signed by good keyring' 'Marvin Paranoid'
+       prepare "${PKGFILE}"
+       rm -rf rootdir/var/lib/apt/lists
+       signreleasefiles 'Marvin Paranoid'
+       find aptarchive/ -name "$DELETEFILE" -delete
+       local MARVIN="$(readlink -f keys/marvinparanoid.pub)"
+       sed -i "s#^\(deb\(-src\)\?\) #\1 [signed-by=$MARVIN] #" rootdir/etc/apt/sources.list.d/*
+       successfulaptgetupdate
+       testsuccessequal "$(cat "${PKGFILE}")
+" aptcache show apt
+       installaptold
+
+       msgmsg 'Cold archive signed by bad keyring' 'Joe Sixpack'
+       rm -rf rootdir/var/lib/apt/lists
+       signreleasefiles 'Joe Sixpack'
+       find aptarchive/ -name "$DELETEFILE" -delete
+       updatewithwarnings '^W: .* NO_PUBKEY'
+
+       sed -i "s#^\(deb\(-src\)\?\) \[signed-by=$MARVIN\] #\1 #" rootdir/etc/apt/sources.list.d/*
+       local MARVIN="$(aptkey --keyring $MARVIN finger | grep 'Key fingerprint' | cut -d'=' -f 2 | tr -d ' ')"
+
+       msgmsg 'Cold archive signed by good keyid' 'Marvin Paranoid'
+       prepare "${PKGFILE}"
+       rm -rf rootdir/var/lib/apt/lists
+       signreleasefiles 'Marvin Paranoid'
+       find aptarchive/ -name "$DELETEFILE" -delete
+       sed -i "s#^\(deb\(-src\)\?\) #\1 [signed-by=$MARVIN] #" rootdir/etc/apt/sources.list.d/*
+       cp keys/marvinparanoid.pub rootdir/etc/apt/trusted.gpg.d/marvinparanoid.gpg
+       successfulaptgetupdate
+       testsuccessequal "$(cat "${PKGFILE}")
+" aptcache show apt
+       installaptold
+       rm -f rootdir/etc/apt/trusted.gpg.d/marvinparanoid.gpg
+
+       msgmsg 'Cold archive signed by bad keyid' 'Joe Sixpack'
+       rm -rf rootdir/var/lib/apt/lists
+       signreleasefiles 'Joe Sixpack'
+       find aptarchive/ -name "$DELETEFILE" -delete
+       updatewithwarnings '^W: .* be verified because the public key is not available: .*'
+
+       sed -i "s#^\(deb\(-src\)\?\) \[signed-by=$MARVIN\] #\1 #" rootdir/etc/apt/sources.list.d/*

 }
 
 runtest2() {
 }
 
 runtest2() {

-       prepare ${PKGFILE}
+       msgmsg 'Cold archive signed by' 'Joe Sixpack'
+       prepare "${PKGFILE}"

        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'

-       msgtest 'Cold archive signed by' 'Joe Sixpack'
-       updatesuccess
+       successfulaptgetupdate

 
        # New .deb but now an unsigned archive. For example MITM to circumvent
        # package verification.
 
        # New .deb but now an unsigned archive. For example MITM to circumvent
        # package verification.

-       prepare ${PKGFILE}-new
+       msgmsg 'Warm archive signed by' 'nobody'
+       prepare "${PKGFILE}-new"

        find aptarchive/ -name InRelease -delete
        find aptarchive/ -name Release.gpg -delete
        find aptarchive/ -name InRelease -delete
        find aptarchive/ -name Release.gpg -delete

-       msgtest 'Warm archive signed by' 'nobody'
-       updatesuccess
-       testequal "$(cat ${PKGFILE}-new)
+       updatewithwarnings 'W: .* no longer signed.'
+       testsuccessequal "$(cat "${PKGFILE}-new")

 " aptcache show apt
        failaptnew
 
        # Unsigned archive from the beginning must also be detected.
 " aptcache show apt
        failaptnew
 
        # Unsigned archive from the beginning must also be detected.

+       msgmsg 'Cold archive signed by' 'nobody'

        rm -rf rootdir/var/lib/apt/lists
        rm -rf rootdir/var/lib/apt/lists

-       msgtest 'Cold archive signed by' 'nobody'
-       updatesuccess
-       testequal "$(cat ${PKGFILE}-new)
+       updatewithwarnings 'W: .* is not signed.'
+       testsuccessequal "$(cat "${PKGFILE}-new")

 " aptcache show apt
        failaptnew
 }
 " aptcache show apt
        failaptnew
 }

-runtest2

 
 

+runtest3() {
+       echo "APT::Hashes::$APT_TESTS_DIGEST_ALGO::$1 \"yes\";" > rootdir/etc/apt/apt.conf.d/truststate
+       msgmsg "Running base test with $1 digest"
+       runtest2
+
+       for DELETEFILE in 'InRelease' 'Release.gpg'; do
+               msgmsg "Running test with deletion of $DELETEFILE and $1 digest"
+               runtest "$DELETEFILE"
+       done
+}
+
+# diable some protection by default and ensure we still do the verification
+# correctly
+cat > rootdir/etc/apt/apt.conf.d/weaken-security <<EOF
+Acquire::AllowInsecureRepositories "1";
+Acquire::AllowDowngradeToInsecureRepositories "1";
+EOF
+# the hash marked as configureable in our gpgv method
+export APT_TESTS_DIGEST_ALGO='SHA224'
+
+successfulaptgetupdate() {
+       testsuccess aptget update -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
+}
+runtest3 'Trusted'
+
+successfulaptgetupdate() {
+       testwarning aptget update -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
+       testsuccess grep 'uses weak digest algorithm' rootdir/tmp/testwarning.output
+}
+runtest3 'Weak'
+
+msgmsg "Running test with apt-untrusted digest"
+echo "APT::Hashes::$APT_TESTS_DIGEST_ALGO::Untrusted \"yes\";" > rootdir/etc/apt/apt.conf.d/truststate
+runfailure() {
+       for DELETEFILE in 'InRelease' 'Release.gpg'; do
+               msgmsg 'Cold archive signed by' 'Joe Sixpack'
+               prepare "${PKGFILE}"
+               rm -rf rootdir/var/lib/apt/lists
+               signreleasefiles 'Joe Sixpack'
+               find aptarchive/ -name "$DELETEFILE" -delete
+               testfailure aptget update --no-allow-insecure-repositories -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
+               testsuccess grep 'The following signatures were invalid' rootdir/tmp/testfailure.output
+               testnopackage 'apt'
+               testwarning aptget update --allow-insecure-repositories -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
+               failaptold
+
+               msgmsg 'Cold archive signed by' 'Marvin Paranoid'
+               prepare "${PKGFILE}"
+               rm -rf rootdir/var/lib/apt/lists
+               signreleasefiles 'Marvin Paranoid'
+               find aptarchive/ -name "$DELETEFILE" -delete
+               testfailure aptget update --no-allow-insecure-repositories -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
+               testnopackage 'apt'
+               updatewithwarnings '^W: .* NO_PUBKEY'
+               testsuccessequal "$(cat "${PKGFILE}")
+" aptcache show apt
+               failaptold
+       done
+}
+runfailure

 
 

-DELETEFILE="InRelease"
-runtest
-DELETEFILE="Release.gpg"
-runtest
+msgmsg "Running test with gpgv-untrusted digest"
+export APT_TESTS_DIGEST_ALGO='MD5'
+runfailure