cppcheck complains about some possible speed improvements which could be

[apt.git] / apt-pkg / contrib / error.cc

diff --git a/apt-pkg/contrib/error.cc b/apt-pkg/contrib/error.cc
index 18810d2a47f6234dbcbf2c90f3eb0678224fa567..edb290f3468fe9e52035780451b1513be2b4071c 100644 (file)
--- a/apt-pkg/contrib/error.cc
+++ b/apt-pkg/contrib/error.cc
@@ -193,7 +193,7 @@ bool GlobalError::PopMessage(std::string &Text) {
 
        // check if another error message is pending
        for (std::list<Item>::const_iterator m = Messages.begin();
 
        // check if another error message is pending
        for (std::list<Item>::const_iterator m = Messages.begin();

-            m != Messages.end(); m++)
+            m != Messages.end(); ++m)

                if (m->Type == ERROR || m->Type == FATAL)
                        return Ret;
 
                if (m->Type == ERROR || m->Type == FATAL)
                        return Ret;
 


@@ -210,7 +210,7 @@ void GlobalError::DumpErrors(std::ostream &out, MsgType const &threshold,
                        Messages.insert(Messages.begin(), s->Messages.begin(), s->Messages.end());
 
        for (std::list<Item>::const_iterator m = Messages.begin();
                        Messages.insert(Messages.begin(), s->Messages.begin(), s->Messages.end());
 
        for (std::list<Item>::const_iterator m = Messages.begin();

-            m != Messages.end(); m++)
+            m != Messages.end(); ++m)

                if (m->Type >= threshold)
                        out << (*m) << std::endl;
        Discard();
                if (m->Type >= threshold)
                        out << (*m) << std::endl;
        Discard();


@@ -231,7 +231,7 @@ bool GlobalError::empty(MsgType const &trashhold) const {
                return true;
 
        for (std::list<Item>::const_iterator m = Messages.begin();
                return true;
 
        for (std::list<Item>::const_iterator m = Messages.begin();

-            m != Messages.end(); m++)
+            m != Messages.end(); ++m)

                if (m->Type >= trashhold)
                        return false;
 
                if (m->Type >= trashhold)
                        return false;