apply various suggestions made by cppcheck

[apt.git] / methods / mirror.cc

diff --git a/methods/mirror.cc b/methods/mirror.cc
index 977eddcf55a236cde7f9a6f2b3fd99e77bc0c878..56362d317a9dfc499f56f3fa5803456fbfbbe197 100644 (file)
--- a/methods/mirror.cc
+++ b/methods/mirror.cc
@@ -16,18 +16,18 @@
 #include <apt-pkg/acquire-item.h>
 #include <apt-pkg/acquire.h>
 #include <apt-pkg/error.h>
 #include <apt-pkg/acquire-item.h>
 #include <apt-pkg/acquire.h>
 #include <apt-pkg/error.h>

-#include <apt-pkg/hashes.h>

 #include <apt-pkg/sourcelist.h>
 #include <apt-pkg/configuration.h>
 #include <apt-pkg/metaindex.h>
 #include <apt-pkg/sourcelist.h>
 #include <apt-pkg/configuration.h>
 #include <apt-pkg/metaindex.h>

+#include <apt-pkg/strutl.h>

 
 

+#include <stdlib.h>
+#include <string.h>
+#include <unistd.h>

 #include <algorithm>
 #include <algorithm>

-#include <fstream>

 #include <iostream>
 #include <iostream>

-
-#include <stdarg.h>
+#include <fstream>

 #include <sys/stat.h>
 #include <sys/stat.h>

-#include <sys/types.h>

 #include <sys/utsname.h>
 #include <dirent.h>
 
 #include <sys/utsname.h>
 #include <dirent.h>
 


@@ -122,7 +122,7 @@ bool MirrorMethod::Clean(string Dir)
       }
       // nothing found, nuke it
       if (I == list.end())
       }
       // nothing found, nuke it
       if (I == list.end())

-        unlink(Dir->d_name);
+        RemoveFile("mirror", Dir->d_name);

    }
 
    closedir(D);
    }
 
    closedir(D);


@@ -132,7 +132,7 @@ bool MirrorMethod::Clean(string Dir)
 }
 
 
 }
 
 

-bool MirrorMethod::DownloadMirrorFile(string mirror_uri_str)
+bool MirrorMethod::DownloadMirrorFile(string /*mirror_uri_str*/)

 {
    // not that great to use pkgAcquire here, but we do not have
    // any other way right now
 {
    // not that great to use pkgAcquire here, but we do not have
    // any other way right now