merge patch from Daniel Hartwig to Show a error message if {,dist-}upgrade is used...

[apt.git] / apt-pkg / contrib / error.cc

diff --git a/apt-pkg/contrib/error.cc b/apt-pkg/contrib/error.cc
index 8cee21c9c8c916637c8135e502972afc2068417d..122e2c8098eb6b063b87bdbcc0ef576b3bbc2c8c 100644 (file)
--- a/apt-pkg/contrib/error.cc
+++ b/apt-pkg/contrib/error.cc
@@ -13,18 +13,20 @@
    ##################################################################### */
                                                                        /*}}}*/
 // Include Files                                                       /*{{{*/
    ##################################################################### */
                                                                        /*}}}*/
 // Include Files                                                       /*{{{*/

+#include <config.h>
+

 #include <apt-pkg/error.h>
 
 #include <iostream>
 #include <errno.h>
 #include <stdio.h>
 #include <apt-pkg/error.h>
 
 #include <iostream>
 #include <errno.h>
 #include <stdio.h>

+#include <stdlib.h>

 #include <unistd.h>
 
 #include <string>
 #include <cstring>
 
 #include <unistd.h>
 
 #include <string>
 #include <cstring>
 

-#include "config.h"
-                                                                       /*}}}*/
+                                                                       /*}}}*/

 
 // Global Error Object                                                 /*{{{*/
 /* If the implementation supports posix threads then the accessor function
 
 // Global Error Object                                                 /*{{{*/
 /* If the implementation supports posix threads then the accessor function


@@ -57,93 +59,112 @@
 // GlobalError::GlobalError - Constructor                              /*{{{*/
 GlobalError::GlobalError() : PendingFlag(false) {}
                                                                        /*}}}*/
 // GlobalError::GlobalError - Constructor                              /*{{{*/
 GlobalError::GlobalError() : PendingFlag(false) {}
                                                                        /*}}}*/

-// GlobalError::FatalE - Get part of the error string from errno       /*{{{*/
-bool GlobalError::FatalE(const char *Function,const char *Description,...) {
-       va_list args;
-       va_start(args,Description);
-       return InsertErrno(FATAL, Function, Description, args);
-}
-                                                                       /*}}}*/
-// GlobalError::Errno - Get part of the error string from errno                /*{{{*/
-bool GlobalError::Errno(const char *Function,const char *Description,...) {
-       va_list args;
-       va_start(args,Description);
-       return InsertErrno(ERROR, Function, Description, args);
-}
-                                                                       /*}}}*/
-// GlobalError::WarningE - Get part of the warning string from errno   /*{{{*/
-bool GlobalError::WarningE(const char *Function,const char *Description,...) {
-       va_list args;
-       va_start(args,Description);
-       return InsertErrno(WARNING, Function, Description, args);
+// GlobalError::FatalE, Errno, WarningE, NoticeE and DebugE - Add to the list/*{{{*/
+#define GEMessage(NAME, TYPE) \
+bool GlobalError::NAME (const char *Function, const char *Description,...) { \
+       va_list args; \
+       size_t msgSize = 400; \
+       int const errsv = errno; \
+       while (true) { \
+               va_start(args,Description); \
+               if (InsertErrno(TYPE, Function, Description, args, errsv, msgSize) == false) \
+                       break; \
+               va_end(args); \
+       } \
+       return false; \

 }
 }

+GEMessage(FatalE, FATAL)
+GEMessage(Errno, ERROR)
+GEMessage(WarningE, WARNING)
+GEMessage(NoticeE, NOTICE)
+GEMessage(DebugE, DEBUG)
+#undef GEMessage

                                                                        /*}}}*/
                                                                        /*}}}*/

-// GlobalError::NoticeE - Get part of the notice string from errno     /*{{{*/
-bool GlobalError::NoticeE(const char *Function,const char *Description,...) {
+// GlobalError::InsertErrno - Get part of the errortype string from errno/*{{{*/
+bool GlobalError::InsertErrno(MsgType const &type, const char *Function,
+                               const char *Description,...) {

        va_list args;
        va_list args;

-       va_start(args,Description);
-       return InsertErrno(NOTICE, Function, Description, args);
-}
-                                                                       /*}}}*/
-// GlobalError::DebugE - Get part of the debug string from errno       /*{{{*/
-bool GlobalError::DebugE(const char *Function,const char *Description,...) {
-       va_list args;
-       va_start(args,Description);
-       return InsertErrno(DEBUG, Function, Description, args);
+       size_t msgSize = 400;
+       int const errsv = errno;
+       while (true) {
+               va_start(args,Description);
+               if (InsertErrno(type, Function, Description, args, errsv, msgSize) == false)
+                       break;
+               va_end(args);
+       }
+       return false;

 }
                                                                        /*}}}*/
 // GlobalError::InsertErrno - formats an error message with the errno  /*{{{*/
 bool GlobalError::InsertErrno(MsgType type, const char* Function,
 }
                                                                        /*}}}*/
 // GlobalError::InsertErrno - formats an error message with the errno  /*{{{*/
 bool GlobalError::InsertErrno(MsgType type, const char* Function,

-                             const char* Description, va_list const &args) {
-       char S[400];
-       vsnprintf(S,sizeof(S),Description,args);
-       snprintf(S + strlen(S),sizeof(S) - strlen(S),
-                " - %s (%i: %s)", Function, errno, strerror(errno));
-       return Insert(type, S, args);
-}
-                                                                       /*}}}*/
-// GlobalError::Fatal - Add a fatal error to the list                  /*{{{*/
-bool GlobalError::Fatal(const char *Description,...) {
-       va_list args;
-       va_start(args,Description);
-       return Insert(FATAL, Description, args);
-}
-                                                                       /*}}}*/
-// GlobalError::Error - Add an error to the list                       /*{{{*/
-bool GlobalError::Error(const char *Description,...) {
-       va_list args;
-       va_start(args,Description);
-       return Insert(ERROR, Description, args);
-}
-                                                                       /*}}}*/
-// GlobalError::Warning - Add a warning to the list                    /*{{{*/
-bool GlobalError::Warning(const char *Description,...) {
-       va_list args;
-       va_start(args,Description);
-       return Insert(WARNING, Description, args);
+                             const char* Description, va_list &args,
+                             int const errsv, size_t &msgSize) {
+       char* S = (char*) malloc(msgSize);
+       int const n = snprintf(S, msgSize, "%s - %s (%i: %s)", Description,
+                              Function, errsv, strerror(errsv));
+       if (n > -1 && ((unsigned int) n) < msgSize);
+       else {
+               if (n > -1)
+                       msgSize = n + 1;
+               else
+                       msgSize *= 2;
+               free(S);
+               return true;
+       }
+
+       bool const geins = Insert(type, S, args, msgSize);
+       free(S);
+       return geins;

 }
                                                                        /*}}}*/
 }
                                                                        /*}}}*/

-// GlobalError::Notice - Add a notice to the list                      /*{{{*/
-bool GlobalError::Notice(const char *Description,...)
-{
-       va_list args;
-       va_start(args,Description);
-       return Insert(NOTICE, Description, args);
+// GlobalError::Fatal, Error, Warning, Notice and Debug - Add to the list/*{{{*/
+#define GEMessage(NAME, TYPE) \
+bool GlobalError::NAME (const char *Description,...) { \
+       va_list args; \
+       size_t msgSize = 400; \
+       while (true) { \
+               va_start(args,Description); \
+               if (Insert(TYPE, Description, args, msgSize) == false) \
+                       break; \
+               va_end(args); \
+       } \
+       return false; \

 }
 }

+GEMessage(Fatal, FATAL)
+GEMessage(Error, ERROR)
+GEMessage(Warning, WARNING)
+GEMessage(Notice, NOTICE)
+GEMessage(Debug, DEBUG)
+#undef GEMessage

                                                                        /*}}}*/
                                                                        /*}}}*/

-// GlobalError::Debug - Add a debug to the list                                /*{{{*/
-bool GlobalError::Debug(const char *Description,...)
+// GlobalError::Insert - Add a errotype message to the list            /*{{{*/
+bool GlobalError::Insert(MsgType const &type, const char *Description,...)

 {
        va_list args;
 {
        va_list args;

-       va_start(args,Description);
-       return Insert(DEBUG, Description, args);
+       size_t msgSize = 400;
+       while (true) {
+               va_start(args,Description);
+               if (Insert(type, Description, args, msgSize) == false)
+                       break;
+               va_end(args);
+       }
+       return false;

 }
                                                                        /*}}}*/
 // GlobalError::Insert - Insert a new item at the end                  /*{{{*/
 bool GlobalError::Insert(MsgType type, const char* Description,
 }
                                                                        /*}}}*/
 // GlobalError::Insert - Insert a new item at the end                  /*{{{*/
 bool GlobalError::Insert(MsgType type, const char* Description,

-                        va_list const &args) {
-       char S[400];
-       vsnprintf(S,sizeof(S),Description,args);
+                        va_list &args, size_t &msgSize) {
+       char* S = (char*) malloc(msgSize);
+       int const n = vsnprintf(S, msgSize, Description, args);
+       if (n > -1 && ((unsigned int) n) < msgSize);
+       else {
+               if (n > -1)
+                       msgSize = n + 1;
+               else
+                       msgSize *= 2;
+               free(S);
+               return true;
+       }

 
        Item const m(S, type);
        Messages.push_back(m);
 
        Item const m(S, type);
        Messages.push_back(m);


@@ -154,6 +175,7 @@ bool GlobalError::Insert(MsgType type, const char* Description,
        if (type == FATAL || type == DEBUG)
                std::clog << m << std::endl;
 
        if (type == FATAL || type == DEBUG)
                std::clog << m << std::endl;
 

+       free(S);

        return false;
 }
                                                                        /*}}}*/
        return false;
 }
                                                                        /*}}}*/


@@ -172,7 +194,7 @@ bool GlobalError::PopMessage(std::string &Text) {
 
        // check if another error message is pending
        for (std::list<Item>::const_iterator m = Messages.begin();
 
        // check if another error message is pending
        for (std::list<Item>::const_iterator m = Messages.begin();

-            m != Messages.end(); m++)
+            m != Messages.end(); ++m)

                if (m->Type == ERROR || m->Type == FATAL)
                        return Ret;
 
                if (m->Type == ERROR || m->Type == FATAL)
                        return Ret;
 


@@ -181,7 +203,7 @@ bool GlobalError::PopMessage(std::string &Text) {
 }
                                                                        /*}}}*/
 // GlobalError::DumpErrors - Dump all of the errors/warns to cerr      /*{{{*/
 }
                                                                        /*}}}*/
 // GlobalError::DumpErrors - Dump all of the errors/warns to cerr      /*{{{*/

-void GlobalError::DumpErrors(std::ostream &out, MsgType const &trashhold,
+void GlobalError::DumpErrors(std::ostream &out, MsgType const &threshold,

                             bool const &mergeStack) {
        if (mergeStack == true)
                for (std::list<MsgStack>::const_reverse_iterator s = Stacks.rbegin();
                             bool const &mergeStack) {
        if (mergeStack == true)
                for (std::list<MsgStack>::const_reverse_iterator s = Stacks.rbegin();


@@ -189,8 +211,8 @@ void GlobalError::DumpErrors(std::ostream &out, MsgType const &trashhold,
                        Messages.insert(Messages.begin(), s->Messages.begin(), s->Messages.end());
 
        for (std::list<Item>::const_iterator m = Messages.begin();
                        Messages.insert(Messages.begin(), s->Messages.begin(), s->Messages.end());
 
        for (std::list<Item>::const_iterator m = Messages.begin();

-            m != Messages.end(); m++)
-               if (m->Type >= trashhold)
+            m != Messages.end(); ++m)
+               if (m->Type >= threshold)

                        out << (*m) << std::endl;
        Discard();
 }
                        out << (*m) << std::endl;
        Discard();
 }


@@ -210,7 +232,7 @@ bool GlobalError::empty(MsgType const &trashhold) const {
                return true;
 
        for (std::list<Item>::const_iterator m = Messages.begin();
                return true;
 
        for (std::list<Item>::const_iterator m = Messages.begin();

-            m != Messages.end(); m++)
+            m != Messages.end(); ++m)

                if (m->Type >= trashhold)
                        return false;
 
                if (m->Type >= trashhold)
                        return false;