Corrections for object lifetime

[apt.git] / methods / connect.cc

diff --git a/methods/connect.cc b/methods/connect.cc
index e17645a96b124fe1311f0cc9998b67d5f0093d3f..e9109423bdabeb2a0f197255ab6b132890321518 100644 (file)
--- a/methods/connect.cc
+++ b/methods/connect.cc
@@ -1,6 +1,6 @@
 // -*- mode: cpp; mode: fold -*-
 // Description                                                         /*{{{*/
 // -*- mode: cpp; mode: fold -*-
 // Description                                                         /*{{{*/

-// $Id: connect.cc,v 1.2 1999/07/10 05:39:29 jgg Exp $
+// $Id: connect.cc,v 1.8 2002/02/28 03:51:55 jgg Exp $

 /* ######################################################################
 
    Connect - Replacement connect call
 /* ######################################################################
 
    Connect - Replacement connect call


@@ -30,6 +30,18 @@ static int LastPort = 0;
 static struct addrinfo *LastHostAddr = 0;
 static struct addrinfo *LastUsed = 0;
 
 static struct addrinfo *LastHostAddr = 0;
 static struct addrinfo *LastUsed = 0;
 

+// RotateDNS - Select a new server from a DNS rotation                 /*{{{*/
+// ---------------------------------------------------------------------
+/* This is called during certain errors in order to recover by selecting a 
+   new server */
+void RotateDNS()
+{
+   if (LastUsed != 0 && LastUsed->ai_next != 0)
+      LastUsed = LastUsed->ai_next;
+   else
+      LastUsed = LastHostAddr;
+}
+                                                                       /*}}}*/

 // DoConnect - Attempt a connect operation                             /*{{{*/
 // ---------------------------------------------------------------------
 /* This helper function attempts a connection to a single address. */
 // DoConnect - Attempt a connect operation                             /*{{{*/
 // ---------------------------------------------------------------------
 /* This helper function attempts a connection to a single address. */


@@ -38,28 +50,44 @@ static bool DoConnect(struct addrinfo *Addr,string Host,
 {
    // Show a status indicator
    char Name[NI_MAXHOST];
 {
    // Show a status indicator
    char Name[NI_MAXHOST];

-   Name[0] = 0;
+   char Service[NI_MAXSERV];
+   
+   Name[0] = 0;   
+   Service[0] = 0;

    getnameinfo(Addr->ai_addr,Addr->ai_addrlen,
    getnameinfo(Addr->ai_addr,Addr->ai_addrlen,

-              Name,sizeof(Name),0,0,NI_NUMERICHOST);
+              Name,sizeof(Name),Service,sizeof(Service),
+              NI_NUMERICHOST|NI_NUMERICSERV);

    Owner->Status("Connecting to %s (%s)",Host.c_str(),Name);
    Owner->Status("Connecting to %s (%s)",Host.c_str(),Name);

-   
+
+   /* If this is an IP rotation store the IP we are using.. If something goes
+      wrong this will get tacked onto the end of the error message */
+   if (LastHostAddr->ai_next != 0)
+   {
+      char Name2[NI_MAXHOST + NI_MAXSERV + 10];
+      snprintf(Name2,sizeof(Name2),"[IP: %s %s]",Name,Service);
+      Owner->SetFailExtraMsg(string(Name2));
+   }   
+   else
+      Owner->SetFailExtraMsg("");
+      

    // Get a socket
    if ((Fd = socket(Addr->ai_family,Addr->ai_socktype,
                    Addr->ai_protocol)) < 0)
    // Get a socket
    if ((Fd = socket(Addr->ai_family,Addr->ai_socktype,
                    Addr->ai_protocol)) < 0)

-      return _error->Errno("socket","Could not create a socket");
+      return _error->Errno("socket","Could not create a socket for %s (f=%u t=%u p=%u)",
+                          Name,Addr->ai_family,Addr->ai_socktype,Addr->ai_protocol);

    
    SetNonBlock(Fd,true);
    if (connect(Fd,Addr->ai_addr,Addr->ai_addrlen) < 0 &&
        errno != EINPROGRESS)
       return _error->Errno("connect","Cannot initiate the connection "
    
    SetNonBlock(Fd,true);
    if (connect(Fd,Addr->ai_addr,Addr->ai_addrlen) < 0 &&
        errno != EINPROGRESS)
       return _error->Errno("connect","Cannot initiate the connection "

-                          "to %s (%s).",Host.c_str(),Name);
+                          "to %s:%s (%s).",Host.c_str(),Service,Name);

    
    /* This implements a timeout for connect by opening the connection
       nonblocking */
    if (WaitFd(Fd,true,TimeOut) == false)
    
    /* This implements a timeout for connect by opening the connection
       nonblocking */
    if (WaitFd(Fd,true,TimeOut) == false)

-      return _error->Error("Could not connect to %s (%s), "
-                          "connection timed out",Host.c_str(),Name);
-   
+      return _error->Error("Could not connect to %s:%s (%s), "
+                          "connection timed out",Host.c_str(),Service,Name);
+

    // Check the socket for an error condition
    unsigned int Err;
    unsigned int Len = sizeof(Err);
    // Check the socket for an error condition
    unsigned int Err;
    unsigned int Len = sizeof(Err);


@@ -67,19 +95,30 @@ static bool DoConnect(struct addrinfo *Addr,string Host,
       return _error->Errno("getsockopt","Failed");
    
    if (Err != 0)
       return _error->Errno("getsockopt","Failed");
    
    if (Err != 0)

-      return _error->Error("Could not connect to %s (%s).",Host.c_str(),Name);
-
+   {
+      errno = Err;
+      return _error->Errno("connect","Could not connect to %s:%s (%s).",Host.c_str(),
+                          Service,Name);
+   }
+   

    return true;
 }
                                                                        /*}}}*/
 // Connect - Connect to a server                                       /*{{{*/
 // ---------------------------------------------------------------------
 /* Performs a connection to the server */
    return true;
 }
                                                                        /*}}}*/
 // Connect - Connect to a server                                       /*{{{*/
 // ---------------------------------------------------------------------
 /* Performs a connection to the server */

-bool Connect(string Host,int Port,const char *Service,int &Fd,
+bool Connect(string Host,int Port,const char *Service,int DefPort,int &Fd,

             unsigned long TimeOut,pkgAcqMethod *Owner)
 {
    if (_error->PendingError() == true)
       return false;
             unsigned long TimeOut,pkgAcqMethod *Owner)
 {
    if (_error->PendingError() == true)
       return false;

+
+   // Convert the port name/number
+   char ServStr[300];
+   if (Port != 0)
+      snprintf(ServStr,sizeof(ServStr),"%u",Port);
+   else
+      snprintf(ServStr,sizeof(ServStr),"%s",Service);

    
    /* We used a cached address record.. Yes this is against the spec but
       the way we have setup our rotating dns suggests that this is more
    
    /* We used a cached address record.. Yes this is against the spec but
       the way we have setup our rotating dns suggests that this is more


@@ -88,46 +127,52 @@ bool Connect(string Host,int Port,const char *Service,int &Fd,
    {
       Owner->Status("Connecting to %s",Host.c_str());
 
    {
       Owner->Status("Connecting to %s",Host.c_str());
 

-      // Lookup the host
-      char S[300];
-      if (Port != 0)
-        snprintf(S,sizeof(S),"%u",Port);
-      else
-        snprintf(S,sizeof(S),"%s",Service);
-

       // Free the old address structure
       if (LastHostAddr != 0)
       {
         freeaddrinfo(LastHostAddr);
         LastHostAddr = 0;
       // Free the old address structure
       if (LastHostAddr != 0)
       {
         freeaddrinfo(LastHostAddr);
         LastHostAddr = 0;

+        LastUsed = 0;

       }
       
       // We only understand SOCK_STREAM sockets.
       struct addrinfo Hints;
       memset(&Hints,0,sizeof(Hints));
       Hints.ai_socktype = SOCK_STREAM;
       }
       
       // We only understand SOCK_STREAM sockets.
       struct addrinfo Hints;
       memset(&Hints,0,sizeof(Hints));
       Hints.ai_socktype = SOCK_STREAM;

+      Hints.ai_protocol = 0;

       
       // Resolve both the host and service simultaneously
       
       // Resolve both the host and service simultaneously

-      int Res;
-      if ((Res = getaddrinfo(Host.c_str(),S,&Hints,&LastHostAddr)) != 0 ||
-         LastHostAddr == 0)
+      while (1)

       {
       {

-        if (Res == EAI_SERVICE)
-           return _error->Error("Could not resolve service '%s'",S);
-        
-        if (Res == EAI_NONAME)
-           return _error->Error("Could not resolve '%s'",Host.c_str());
-        
-        return _error->Error("Something wicked happend resolving '%s/%s'",
-                             Host.c_str(),S);
+        int Res;
+        if ((Res = getaddrinfo(Host.c_str(),ServStr,&Hints,&LastHostAddr)) != 0 ||
+            LastHostAddr == 0)
+        {
+           if (Res == EAI_NONAME || Res == EAI_SERVICE)
+           {
+              if (DefPort != 0)
+              {
+                 snprintf(ServStr,sizeof(ServStr),"%u",DefPort);
+                 DefPort = 0;
+                 continue;
+              }
+              return _error->Error("Could not resolve '%s'",Host.c_str());
+           }
+           
+           if (Res == EAI_AGAIN)
+              return _error->Error("Temporary failure resolving '%s'",
+                                   Host.c_str());
+           return _error->Error("Something wicked happened resolving '%s:%s' (%i)",
+                                Host.c_str(),ServStr,Res);
+        }
+        break;

       }
       
       LastHost = Host;
       LastPort = Port;
       }
       
       LastHost = Host;
       LastPort = Port;

-      LastUsed = 0;

    }
 
    }
 

-   // Get the printable IP address
+   // When we have an IP rotation stay with the last IP.

    struct addrinfo *CurHost = LastHostAddr;
    if (LastUsed != 0)
        CurHost = LastUsed;
    struct addrinfo *CurHost = LastHostAddr;
    if (LastUsed != 0)
        CurHost = LastUsed;


@@ -142,12 +187,28 @@ bool Connect(string Host,int Port,const char *Service,int &Fd,
       close(Fd);
       Fd = -1;
       
       close(Fd);
       Fd = -1;
       

-      CurHost = CurHost->ai_next;
-      LastUsed = 0;
+      // Ignore UNIX domain sockets
+      do
+      {
+        CurHost = CurHost->ai_next;
+      }
+      while (CurHost != 0 && CurHost->ai_family == AF_UNIX);
+
+      /* If we reached the end of the search list then wrap around to the
+         start */
+      if (CurHost == 0 && LastUsed != 0)
+        CurHost = LastHostAddr;
+      
+      // Reached the end of the search cycle
+      if (CurHost == LastUsed)
+        break;
+      

       if (CurHost != 0)
         _error->Discard();
       if (CurHost != 0)
         _error->Discard();

-   }
-   
-   return false;
+   }   
+
+   if (_error->PendingError() == true)
+      return false;   
+   return _error->Error("Unable to connect to %s %s:",Host.c_str(),ServStr);

 }
                                                                        /*}}}*/
 }
                                                                        /*}}}*/