drop confusing comma from no strong hash message

[apt.git] / test / integration / test-apt-helper

diff --git a/test/integration/test-apt-helper b/test/integration/test-apt-helper
index 00d859ad583a012491b43913c6bd348140f0dec2..b2347ddcf152ee5bd013fe91d59c9f3482d69e34 100755 (executable)
--- a/test/integration/test-apt-helper
+++ b/test/integration/test-apt-helper
@@ -1,45 +1,61 @@
 #!/bin/sh
 set -e
 
 #!/bin/sh
 set -e
 

-TESTDIR=$(readlink -f $(dirname $0))
-. $TESTDIR/framework
+TESTDIR="$(readlink -f "$(dirname "$0")")"
+. "$TESTDIR/framework"

 
 setupenvironment
 configarchitecture 'i386'
 
 changetohttpswebserver
 
 
 setupenvironment
 configarchitecture 'i386'
 
 changetohttpswebserver
 

+echo 'foo' > aptarchive/foo
+echo 'bar' > aptarchive/foo2
+

 test_apt_helper_download() {
 test_apt_helper_download() {

-    echo 'foo' > aptarchive/foo
-    echo 'bar' > aptarchive/foo2
+    msgmsg 'Test with' "$1"

 
 

-    msgtest 'apt-file download-file md5sum'
-    testsuccess --nomsg apthelper download-file http://localhost:8080/foo ./downloaded/foo2 MD5Sum:d3b07384d113edec49eaa6238ad5ff00
+    msgtest 'apt-file download-file' 'md5sum'
+    testsuccess --nomsg apthelper download-file "${1}/foo" './downloaded/foo2' 'MD5Sum:d3b07384d113edec49eaa6238ad5ff00'

     testfileequal ./downloaded/foo2 'foo'
 
     testfileequal ./downloaded/foo2 'foo'
 

-    msgtest 'apt-file download-file sha1'
-    testsuccess --nomsg apthelper download-file http://localhost:8080/foo ./downloaded/foo1 SHA1:f1d2d2f924e986ac86fdf7b36c94bcdf32beec15
+    msgtest 'apt-file download-file' 'sha1'
+    testsuccess --nomsg apthelper download-file "${1}/foo" './downloaded/foo1' 'SHA1:f1d2d2f924e986ac86fdf7b36c94bcdf32beec15'

     testfileequal ./downloaded/foo1 'foo'
 
     testfileequal ./downloaded/foo1 'foo'
 

-    msgtest 'apt-file download-file sha256'
-    testsuccess --nomsg apthelper download-file http://localhost:8080/foo ./downloaded/foo3 SHA256:b5bb9d8014a0f9b1d61e21e796d78dccdf1352f23cd32812f4850b878ae4944c
+    msgtest 'apt-file download-file' 'sha256'
+    testsuccess --nomsg apthelper download-file "${1}/foo" './downloaded/foo3' 'SHA256:b5bb9d8014a0f9b1d61e21e796d78dccdf1352f23cd32812f4850b878ae4944c'

     testfileequal ./downloaded/foo3 'foo'
 
     testfileequal ./downloaded/foo3 'foo'
 

-    msgtest 'apt-file download-file no-hash'
-    testsuccess --nomsg apthelper download-file http://localhost:8080/foo ./downloaded/foo4
+    msgtest 'apt-file download-file' 'no-hash'
+    testsuccess --nomsg apthelper download-file "${1}/foo" './downloaded/foo4'

     testfileequal ./downloaded/foo4 'foo'
     testfileequal ./downloaded/foo4 'foo'

-    
-    msgtest 'apt-file download-file wrong hash'
-    testfailure --nomsg apthelper -qq download-file http://localhost:8080/foo ./downloaded/foo5 MD5Sum:aabbcc
-    testfileequal rootdir/tmp/testfailure.output 'E: Failed to fetch http://localhost:8080/foo  Hash Sum mismatch

 
 

-E: Download Failed'
+    msgtest 'apt-file download-file' 'wrong md5sum'
+    testfailure --nomsg apthelper -qq download-file "${1}/foo" './downloaded/foo5' 'MD5Sum:aabbcc'
+    testfileequal rootdir/tmp/testfailure.output "E: Failed to fetch ${1}/foo  Hash Sum mismatch
+
+E: Download Failed"

     testfileequal ./downloaded/foo5.FAILED 'foo'
 
     testfileequal ./downloaded/foo5.FAILED 'foo'
 

-    msgtest 'apt-file download-file md5sum sha1'
-    testsuccess --nomsg apthelper download-file http://localhost:8080/foo ./downloaded/foo6 MD5Sum:d3b07384d113edec49eaa6238ad5ff00 http://localhost:8080/foo2 ./downloaded/foo7 SHA1:e242ed3bffccdf271b7fbaf34ed72d089537b42f
-    testfileequal ./downloaded/foo6 'foo'
-    testfileequal ./downloaded/foo7 'bar'
+    msgtest 'apt-file download-file' 'wrong sha256'
+    testfailure --nomsg apthelper -qq download-file "${1}/foo" './downloaded/foo6' 'SHA256:aabbcc'
+    testfileequal rootdir/tmp/testfailure.output "E: Failed to fetch ${1}/foo  Hash Sum mismatch
+
+E: Download Failed"
+    testfileequal './downloaded/foo6.FAILED' 'foo'
+
+    msgtest 'apt-file download-file' 'sha256 sha1'
+    testsuccess --nomsg apthelper download-file "${1}/foo" './downloaded/foo8' 'SHA256:b5bb9d8014a0f9b1d61e21e796d78dccdf1352f23cd32812f4850b878ae4944c' \
+           "${1}/foo2" './downloaded/foo7' 'SHA1:e242ed3bffccdf271b7fbaf34ed72d089537b42f'
+    testfileequal './downloaded/foo8' 'foo'
+    testfileequal './downloaded/foo7' 'bar'
+
+    msgtest 'apt-file download-file' 'md5sum sha1'
+    testsuccess --nomsg apthelper download-file "${1}/foo" './downloaded/foo9' 'MD5Sum:d3b07384d113edec49eaa6238ad5ff00' \
+           "${1}/foo2" './downloaded/foo10' 'SHA1:e242ed3bffccdf271b7fbaf34ed72d089537b42f'
+    testfileequal './downloaded/foo9' 'foo'
+    testfileequal './downloaded/foo10' 'bar'

 }
 
 test_apt_helper_detect_proxy() {
 }
 
 test_apt_helper_detect_proxy() {


@@ -69,11 +85,16 @@ EOF
     testsuccessequal "Using proxy 'https://https-proxy' for URL 'https://ssl.example.com/'" apthelper auto-detect-proxy https://ssl.example.com
 }
 
     testsuccessequal "Using proxy 'https://https-proxy' for URL 'https://ssl.example.com/'" apthelper auto-detect-proxy https://ssl.example.com
 }
 

-test_apt_helper_download
+test_apt_helper_download "http://localhost:${APTHTTPPORT}"
+test_apt_helper_download "https://localhost:${APTHTTPSPORT}"

 test_apt_helper_detect_proxy
 
 # test failure modes
 testfailureequal 'E: Invalid operation download' apthelper download
 testfailureequal 'E: Must specify at least one pair url/filename' apthelper download-file
 test_apt_helper_detect_proxy
 
 # test failure modes
 testfailureequal 'E: Invalid operation download' apthelper download
 testfailureequal 'E: Must specify at least one pair url/filename' apthelper download-file

-testfailureequal 'E: Must specify at least one pair url/filename' apthelper download-file http://example.org/
+testfailureequal 'E: Must specify at least one pair url/filename' apthelper download-file 'http://example.org/'

 testfailureequal 'E: Need one URL as argument' apthelper auto-detect-proxy
 testfailureequal 'E: Need one URL as argument' apthelper auto-detect-proxy

+testfailureequal 'E: Must specify at least one SRV record' apthelper srv-lookup
+testfailureequal 'E: GetSrvRec failed for localhost' apthelper -q=1 srv-lookup 'localhost'
+testfailureequal "E: GetSrvRec failed for localhost:${APTHTTPPORT}" apthelper -q=1 srv-lookup "localhost:${APTHTTPPORT}"
+testfailureequal "E: GetSrvRec failed for localhost:${APTHTTPSPORT}" apthelper -q=1 srv-lookup "localhost:${APTHTTPSPORT}"