cmdline/apt-key: refactor the master key checking into a function

[apt.git] / cmdline / apt-key

diff --git a/cmdline/apt-key b/cmdline/apt-key
index 90ecae2cf543440ae5e93e070254c0f4372b1356..048105320b4ca313ad817b72d4ef49f0e74d415c 100755 (executable)
--- a/cmdline/apt-key
+++ b/cmdline/apt-key
@@ -5,13 +5,43 @@ set -e
 # We don't use a secret keyring, of course, but gpg panics and
 # implodes if there isn't one available
 
 # We don't use a secret keyring, of course, but gpg panics and
 # implodes if there isn't one available
 

-GPG_CMD="gpg --no-options --no-default-keyring --secret-keyring /etc/apt/secring.gpg --trustdb-name /etc/apt/trustdb.gpg"
+GPG_CMD="gpg --ignore-time-conflict --no-options --no-default-keyring --secret-keyring /etc/apt/secring.gpg --trustdb-name /etc/apt/trustdb.gpg"

 GPG="$GPG_CMD --keyring /etc/apt/trusted.gpg"
 
 
 GPG="$GPG_CMD --keyring /etc/apt/trusted.gpg"
 
 

+MASTER_KEYRING=""
+#MASTER_KEYRING=/usr/share/keyrings/debian-master-keyring.gpg

 ARCHIVE_KEYRING=/usr/share/keyrings/debian-archive-keyring.gpg
 REMOVED_KEYS=/usr/share/keyrings/debian-archive-removed-keys.gpg
 
 ARCHIVE_KEYRING=/usr/share/keyrings/debian-archive-keyring.gpg
 REMOVED_KEYS=/usr/share/keyrings/debian-archive-removed-keys.gpg
 

+add_keys_with_verify_against_master_keyring() {
+    ADD_KEYRING=$1
+    MASTER=$2
+    
+    if [ ! -f "$ADD_KEYRING" ]; then
+       echo "ERROR: '$ADD_KEYRING' not found"
+       return
+    fi 
+    if [ ! -f "$MASTER" ]; then
+       echo "ERROR: '$MASTER' not found"
+       return
+    fi
+
+    # when adding new keys, make sure that the archive-master-keyring
+    # is honored. so:
+    #   all keys that are exported and have the name
+    #   "Ubuntu Archive Automatic Signing Key" must have a valid signature
+    #   from a key in the ubuntu-master-keyring
+    add_keys=`$GPG_CMD --keyring $ADD_KEYRING --with-colons --list-keys | grep ^pub | cut -d: -f5`
+    master_keys=`$GPG_CMD --keyring $MASTER --with-colons --list-keys | grep ^pub | cut -d: -f5`
+    for add_key in $add_keys; do
+       for master_key in $master_keys; do
+           if $GPG --list-sigs --with-colons $add_key | grep ^sig | cut -d: -f5 | grep -q $master_key; then
+               $GPG_CMD --quiet --batch --keyring $ARCHIVE_KEYRING --export $add_key | $GPG --import
+           fi
+       done
+    done
+}

 
 update() {
     if [ ! -f $ARCHIVE_KEYRING ]; then
 
 update() {
     if [ ! -f $ARCHIVE_KEYRING ]; then


@@ -20,10 +50,15 @@ update() {
        exit 1
     fi
 
        exit 1
     fi
 

-    # add new keys
-    $GPG_CMD --quiet --batch --keyring $ARCHIVE_KEYRING --export | $GPG --ignore-time-conflict --import
+    # add new keys, if no MASTER_KEYRING is used, use the traditional
+    # way
+    if [ -z "$MASTER_KEYRING" ]; then
+       $GPG_CMD --quiet --batch --keyring $ARCHIVE_KEYRING --export | $GPG --import
+    else
+       add_keys_with_verify_against_master_keyring $ARCHIVE_KEYRING $MASTER_KEYRING
+    fi

 
 

-    # remove no-longer used keys
+    # remove no-longer supported/used keys

     keys=`$GPG_CMD --keyring $REMOVED_KEYS --with-colons --list-keys | grep ^pub | cut -d: -f5`
     for key in $keys; do
        if $GPG --list-keys --with-colons | grep ^pub | cut -d: -f5 | grep -q $key; then
     keys=`$GPG_CMD --keyring $REMOVED_KEYS --with-colons --list-keys | grep ^pub | cut -d: -f5`
     for key in $keys; do
        if $GPG --list-keys --with-colons | grep ^pub | cut -d: -f5 | grep -q $key; then


@@ -32,6 +67,7 @@ update() {
     done
 }
 
     done
 }
 

+

 usage() {
     echo "Usage: apt-key [command] [arguments]"
     echo
 usage() {
     echo "Usage: apt-key [command] [arguments]"
     echo


@@ -39,6 +75,8 @@ usage() {
     echo
     echo "  apt-key add <file>          - add the key contained in <file> ('-' for stdin)"
     echo "  apt-key del <keyid>         - remove the key <keyid>"
     echo
     echo "  apt-key add <file>          - add the key contained in <file> ('-' for stdin)"
     echo "  apt-key del <keyid>         - remove the key <keyid>"

+    echo "  apt-key export <keyid>      - output the key <keyid>"
+    echo "  apt-key exportall           - output all trusted keys"

     echo "  apt-key update              - update keys using the keyring package"
     echo "  apt-key list                - list keys"
     echo
     echo "  apt-key update              - update keys using the keyring package"
     echo "  apt-key list                - list keys"
     echo


@@ -75,6 +113,12 @@ case "$command" in
     finger*)
         $GPG --batch --fingerprint
         ;;
     finger*)
         $GPG --batch --fingerprint
         ;;

+    export)
+        $GPG --armor --export "$1"
+        ;;
+    exportall)
+        $GPG --armor --export
+        ;;

     adv*)
         echo "Executing: $GPG $*"
         $GPG $*
     adv*)
         echo "Executing: $GPG $*"
         $GPG $*