don't ask server if we have entire file in partial/

[apt.git] / test / integration / test-apt-key

diff --git a/test/integration/test-apt-key b/test/integration/test-apt-key
index e1be08c65150f2026317d8237a938c253cd6335e..82b64963cd7ba5888c48e77eb1320ea90151a33f 100755 (executable)
--- a/test/integration/test-apt-key
+++ b/test/integration/test-apt-key
@@ -1,8 +1,15 @@
 #!/bin/sh
 set -e
 
 #!/bin/sh
 set -e
 

-TESTDIR=$(readlink -f $(dirname $0))
-. $TESTDIR/framework
+# apt-key is a shell script, so relatively prune to be effected by 'crazy' things:
+# confuses config parser as there exists no way of escaping " currently.
+#TMPDIR="$(mktemp -d)/This is \"fü\$\$ing cràzy\", \$(man man | head -n1 | cut -d' ' -f 1)\$!"
+# gpg doesn't like | in path names – documented e.g. in the man gpg2 --agent-program
+#TMPDIR="$(mktemp -d)/This is fü\$\$ing cràzy, \$(man man | head -n1 | cut -d' ' -f 1)\$!"
+TMPDIR_ADD="This is fü\$\$ing cràzy, \$(apt -v)\$!"
+
+TESTDIR="$(readlink -f "$(dirname "$0")")"
+. "$TESTDIR/framework"

 
 setupenvironment
 configarchitecture 'amd64'
 
 setupenvironment
 configarchitecture 'amd64'


@@ -13,35 +20,27 @@ cleanplate() {
        mkdir rootdir/etc/apt/trusted.gpg.d/
 }
 
        mkdir rootdir/etc/apt/trusted.gpg.d/
 }
 

-testaptkeys() {
-       if ! aptkey list | grep '^pub' > aptkey.list; then
-               echo -n > aptkey.list
-       fi
-       testfileequal './aptkey.list' "$1"
-}
-

 echo 'APT::Key::ArchiveKeyring "./keys/joesixpack.pub";
 APT::Key::RemovedKeys "./keys/rexexpired.pub";' > rootdir/etc/apt/apt.conf.d/aptkey.conf
 
 testrun() {
        cleanplate
 echo 'APT::Key::ArchiveKeyring "./keys/joesixpack.pub";
 APT::Key::RemovedKeys "./keys/rexexpired.pub";' > rootdir/etc/apt/apt.conf.d/aptkey.conf
 
 testrun() {
        cleanplate

-       ln -sf ${TMPWORKINGDIRECTORY}/keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
+       ln -sf "${TMPWORKINGDIRECTORY}/keys/joesixpack.pub" rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg

 
        msgtest 'Check that paths in list output are not' 'double-slashed'
        aptkey list 2>&1 | grep -q '//' && msgfail || msgpass
 
        msgtest 'Check that paths in finger output are not' 'double-slashed'
        aptkey finger 2>&1 | grep -q '//' && msgfail || msgpass
 
        msgtest 'Check that paths in list output are not' 'double-slashed'
        aptkey list 2>&1 | grep -q '//' && msgfail || msgpass
 
        msgtest 'Check that paths in finger output are not' 'double-slashed'
        aptkey finger 2>&1 | grep -q '//' && msgfail || msgpass

-
-       testaptkeys 'pub   2048R/DBAC8DAE 2010-08-18'
+       testaptkeys 'Joe Sixpack'

 
        testsuccessequal 'gpg: key DBAC8DAE: "Joe Sixpack (APT Testcases Dummy) <joe@example.org>" not changed
 gpg: Total number processed: 1
 gpg:              unchanged: 1' aptkey --fakeroot update
 
 
        testsuccessequal 'gpg: key DBAC8DAE: "Joe Sixpack (APT Testcases Dummy) <joe@example.org>" not changed
 gpg: Total number processed: 1
 gpg:              unchanged: 1' aptkey --fakeroot update
 

-       testaptkeys 'pub   2048R/DBAC8DAE 2010-08-18'
-
+       testaptkeys 'Joe Sixpack'

        testfailure test -e rootdir/etc/apt/trusted.gpg
        testfailure test -e rootdir/etc/apt/trusted.gpg

+

        testsuccess aptkey --fakeroot add ./keys/rexexpired.pub
        msgtest 'Check if trusted.gpg is created with permissions set to' '0644'
        if [ "$(stat -c '%a' rootdir/etc/apt/trusted.gpg )" = '644' ]; then
        testsuccess aptkey --fakeroot add ./keys/rexexpired.pub
        msgtest 'Check if trusted.gpg is created with permissions set to' '0644'
        if [ "$(stat -c '%a' rootdir/etc/apt/trusted.gpg )" = '644' ]; then


@@ -50,8 +49,7 @@ gpg:              unchanged: 1' aptkey --fakeroot update
                msgfail
        fi
 
                msgfail
        fi
 

-       testaptkeys 'pub   2048R/27CE74F9 2013-07-12 [expired: 2013-07-13]
-pub   2048R/DBAC8DAE 2010-08-18'
+       testaptkeys 'Rex Expired' 'Joe Sixpack'

 
        msgtest 'Check that Sixpack key can be' 'exported'
        aptkey export 'Sixpack' > aptkey.export
 
        msgtest 'Check that Sixpack key can be' 'exported'
        aptkey export 'Sixpack' > aptkey.export


@@ -63,12 +61,12 @@ pub   2048R/DBAC8DAE 2010-08-18'
        msgtest 'Execute update again to trigger removal of' 'Rex Expired key'
        testsuccess --nomsg aptkey --fakeroot update
 
        msgtest 'Execute update again to trigger removal of' 'Rex Expired key'
        testsuccess --nomsg aptkey --fakeroot update
 

-       testaptkeys 'pub   2048R/DBAC8DAE 2010-08-18'
+       testaptkeys 'Joe Sixpack'

 
        msgtest "Try to remove a key which exists, but isn't in the" 'forced keyring'
        testsuccess --nomsg aptkey --fakeroot --keyring rootdir/etc/apt/trusted.gpg del DBAC8DAE
 
 
        msgtest "Try to remove a key which exists, but isn't in the" 'forced keyring'
        testsuccess --nomsg aptkey --fakeroot --keyring rootdir/etc/apt/trusted.gpg del DBAC8DAE
 

-       testaptkeys 'pub   2048R/DBAC8DAE 2010-08-18'
+       testaptkeys 'Joe Sixpack'

 
        testsuccess aptkey --fakeroot del DBAC8DAE
        testempty aptkey list
 
        testsuccess aptkey --fakeroot del DBAC8DAE
        testempty aptkey list


@@ -87,6 +85,17 @@ pub   2048R/DBAC8DAE 2010-08-18'
        testfailure test -e rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
        testsuccess cmp keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg~
 
        testfailure test -e rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
        testsuccess cmp keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg~
 

+       msgtest 'Test key removal with' 'different key specs'
+       cleanplate
+       cp -a keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
+       cp -a keys/marvinparanoid.pub rootdir/etc/apt/trusted.gpg.d/marvinparanoid.gpg
+       testsuccess --nomsg aptkey --fakeroot del 0xDBAC8DAE 528144E2
+       testempty aptkey list
+       testfailure test -e rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
+       testsuccess cmp keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg~
+       testfailure test -e rootdir/etc/apt/trusted.gpg.d/marvinparanoid.gpg
+       testsuccess cmp keys/marvinparanoid.pub rootdir/etc/apt/trusted.gpg.d/marvinparanoid.gpg~
+

        msgtest 'Test key removal with' 'long key ID'
        cleanplate
        cp -a keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
        msgtest 'Test key removal with' 'long key ID'
        cleanplate
        cp -a keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg


@@ -105,7 +114,7 @@ pub   2048R/DBAC8DAE 2010-08-18'
 
        msgtest 'Test key removal with' 'single key in softlink'
        cleanplate
 
        msgtest 'Test key removal with' 'single key in softlink'
        cleanplate

-       ln -s $(readlink -f ./keys/joesixpack.pub) rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
+       ln -s "$(readlink -f ./keys/joesixpack.pub)" rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg

        testsuccess --nomsg aptkey --fakeroot del DBAC8DAE
        testempty aptkey list
        testfailure test -e rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
        testsuccess --nomsg aptkey --fakeroot del DBAC8DAE
        testempty aptkey list
        testfailure test -e rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg


@@ -113,23 +122,23 @@ pub   2048R/DBAC8DAE 2010-08-18'
 
        cleanplate
        testsuccess aptkey --fakeroot add ./keys/joesixpack.pub
 
        cleanplate
        testsuccess aptkey --fakeroot add ./keys/joesixpack.pub

-       testsuccess aptkey --fakeroot add ./keys/marvinparanoid.pub
-       testaptkeys 'pub   2048R/DBAC8DAE 2010-08-18
-pub   2048R/528144E2 2011-01-16'
+       ln -sf "$(readlink -f ./keys/marvinparanoid.pub)" "./keys/marvin paránöid.pub"
+       testsuccess aptkey --fakeroot add "./keys/marvin paránöid.pub"
+       testaptkeys 'Joe Sixpack' 'Marvin Paranoid'

        cp -a rootdir/etc/apt/trusted.gpg keys/testcase-multikey.pub # store for reuse
 
        msgtest 'Test key removal with' 'multi key in real file'
        cleanplate
        cp -a keys/testcase-multikey.pub rootdir/etc/apt/trusted.gpg.d/multikey.gpg
        testsuccess --nomsg aptkey --fakeroot del DBAC8DAE
        cp -a rootdir/etc/apt/trusted.gpg keys/testcase-multikey.pub # store for reuse
 
        msgtest 'Test key removal with' 'multi key in real file'
        cleanplate
        cp -a keys/testcase-multikey.pub rootdir/etc/apt/trusted.gpg.d/multikey.gpg
        testsuccess --nomsg aptkey --fakeroot del DBAC8DAE

-       testaptkeys 'pub   2048R/528144E2 2011-01-16'
+       testaptkeys 'Marvin Paranoid'

        testsuccess cmp keys/testcase-multikey.pub rootdir/etc/apt/trusted.gpg.d/multikey.gpg~
 
        msgtest 'Test key removal with' 'multi key in softlink'
        cleanplate
        testsuccess cmp keys/testcase-multikey.pub rootdir/etc/apt/trusted.gpg.d/multikey.gpg~
 
        msgtest 'Test key removal with' 'multi key in softlink'
        cleanplate

-       ln -s $(readlink -f ./keys/testcase-multikey.pub) rootdir/etc/apt/trusted.gpg.d/multikey.gpg
+       ln -s "$(readlink -f ./keys/testcase-multikey.pub)" rootdir/etc/apt/trusted.gpg.d/multikey.gpg

        testsuccess --nomsg aptkey --fakeroot del DBAC8DAE
        testsuccess --nomsg aptkey --fakeroot del DBAC8DAE

-       testaptkeys 'pub   2048R/528144E2 2011-01-16'
+       testaptkeys 'Marvin Paranoid'

        testsuccess cmp keys/testcase-multikey.pub rootdir/etc/apt/trusted.gpg.d/multikey.gpg~
        testfailure test -L rootdir/etc/apt/trusted.gpg.d/multikey.gpg
        testsuccess test -L rootdir/etc/apt/trusted.gpg.d/multikey.gpg~
        testsuccess cmp keys/testcase-multikey.pub rootdir/etc/apt/trusted.gpg.d/multikey.gpg~
        testfailure test -L rootdir/etc/apt/trusted.gpg.d/multikey.gpg
        testsuccess test -L rootdir/etc/apt/trusted.gpg.d/multikey.gpg~


@@ -139,7 +148,7 @@ pub   2048R/528144E2 2011-01-16'
        cp -a keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
        cp -a keys/testcase-multikey.pub rootdir/etc/apt/trusted.gpg.d/multikey.gpg
        testsuccess --nomsg aptkey --fakeroot del DBAC8DAE
        cp -a keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
        cp -a keys/testcase-multikey.pub rootdir/etc/apt/trusted.gpg.d/multikey.gpg
        testsuccess --nomsg aptkey --fakeroot del DBAC8DAE

-       testaptkeys 'pub   2048R/528144E2 2011-01-16'
+       testaptkeys 'Marvin Paranoid'

        testfailure test -e rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
        testsuccess cmp keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg~
        testsuccess cmp keys/testcase-multikey.pub rootdir/etc/apt/trusted.gpg.d/multikey.gpg~
        testfailure test -e rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
        testsuccess cmp keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg~
        testsuccess cmp keys/testcase-multikey.pub rootdir/etc/apt/trusted.gpg.d/multikey.gpg~


@@ -147,25 +156,18 @@ pub   2048R/528144E2 2011-01-16'
        cleanplate
        cp -a keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
        cp -a keys/testcase-multikey.pub rootdir/etc/apt/trusted.gpg.d/multikey.gpg
        cleanplate
        cp -a keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
        cp -a keys/testcase-multikey.pub rootdir/etc/apt/trusted.gpg.d/multikey.gpg

-       testaptkeys 'pub   2048R/DBAC8DAE 2010-08-18
-pub   2048R/DBAC8DAE 2010-08-18
-pub   2048R/528144E2 2011-01-16'
+       testaptkeys 'Joe Sixpack' 'Joe Sixpack' 'Marvin Paranoid'

        msgtest 'Test merge-back of' 'added keys'
        testsuccess --nomsg aptkey adv --batch --yes --import keys/rexexpired.pub
        msgtest 'Test merge-back of' 'added keys'
        testsuccess --nomsg aptkey adv --batch --yes --import keys/rexexpired.pub

-       testaptkeys 'pub   2048R/27CE74F9 2013-07-12 [expired: 2013-07-13]
-pub   2048R/DBAC8DAE 2010-08-18
-pub   2048R/DBAC8DAE 2010-08-18
-pub   2048R/528144E2 2011-01-16'
+       testaptkeys 'Rex Expired' 'Joe Sixpack' 'Joe Sixpack' 'Marvin Paranoid'

 
        msgtest 'Test merge-back of' 'removed keys'
        testsuccess --nomsg aptkey adv --batch --yes --delete-keys 27CE74F9
 
        msgtest 'Test merge-back of' 'removed keys'
        testsuccess --nomsg aptkey adv --batch --yes --delete-keys 27CE74F9

-       testaptkeys 'pub   2048R/DBAC8DAE 2010-08-18
-pub   2048R/DBAC8DAE 2010-08-18
-pub   2048R/528144E2 2011-01-16'
+       testaptkeys 'Joe Sixpack' 'Joe Sixpack' 'Marvin Paranoid'

 
        msgtest 'Test merge-back of' 'removed duplicate keys'
        testsuccess --nomsg aptkey adv --batch --yes --delete-keys DBAC8DAE
 
        msgtest 'Test merge-back of' 'removed duplicate keys'
        testsuccess --nomsg aptkey adv --batch --yes --delete-keys DBAC8DAE

-       testaptkeys 'pub   2048R/528144E2 2011-01-16'
+       testaptkeys 'Marvin Paranoid'

 
        cleanplate
        cp -a keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg
 
        cleanplate
        cp -a keys/joesixpack.pub rootdir/etc/apt/trusted.gpg.d/joesixpack.gpg


@@ -174,50 +176,53 @@ pub   2048R/528144E2 2011-01-16'
        echo 'Verify me. This is my signature.' > signature
        testsuccess --nomsg aptkey --quiet --keyring keys/marvinparanoid.pub --secret-keyring keys/marvinparanoid.sec --readonly \
                adv --batch --yes --default-key 'Marvin' --armor --detach-sign --sign --output signature.gpg signature
        echo 'Verify me. This is my signature.' > signature
        testsuccess --nomsg aptkey --quiet --keyring keys/marvinparanoid.pub --secret-keyring keys/marvinparanoid.sec --readonly \
                adv --batch --yes --default-key 'Marvin' --armor --detach-sign --sign --output signature.gpg signature

+       testsuccess test -s signature.gpg -a -s signature
+
+
+       for GPGV in '' 'gpgv' 'gpgv2'; do
+               echo "APT::Key::GPGVCommand \"$GPGV\";" > rootdir/etc/apt/apt.conf.d/00gpgvcmd

 
 

-       msgtest 'Test verify a file' 'with all keys'
-       testsuccess --nomsg aptkey --quiet --readonly verify signature.gpg signature
+               msgtest 'Test verify a file' 'with all keys'
+               testsuccess --nomsg aptkey --quiet --readonly verify signature.gpg signature

 
 

-       msgtest 'Test verify a file' 'with good keyring'
-       testsuccess --nomsg aptkey --quiet --readonly --keyring keys/testcase-multikey.pub verify signature.gpg signature
+               msgtest 'Test verify a file' 'with good keyring'
+               testsuccess --nomsg aptkey --quiet --readonly --keyring keys/testcase-multikey.pub verify signature.gpg signature

 
 

-       msgtest 'Test fail verify a file' 'with bad keyring'
-       testfailure --nomsg aptkey --quiet --readonly --keyring keys/joesixpack.pub verify signature.gpg signature
+               msgtest 'Test fail verify a file' 'with bad keyring'
+               testfailure --nomsg aptkey --quiet --readonly --keyring keys/joesixpack.pub verify signature.gpg signature

 
 

-       msgtest 'Test fail verify a file' 'with non-existing keyring'
-       testfailure --nomsg aptkey --quiet --readonly --keyring keys/does-not-exist.pub verify signature.gpg signature
-       testfailure test -e keys/does-not-exist.pub
+               msgtest 'Test fail verify a file' 'with non-existing keyring'
+               testfailure --nomsg aptkey --quiet --readonly --keyring keys/does-not-exist.pub verify signature.gpg signature
+               testfailure test -e keys/does-not-exist.pub

 
 

-       msgtest 'Test verify a file' 'with good keyid'
-       testsuccess --nomsg aptkey --quiet --readonly --keyid 'Paranoid' verify signature.gpg signature
+               # note: this isn't how apts gpgv method implements keyid for verify
+               msgtest 'Test verify a file' 'with good keyid'
+               testsuccess --nomsg aptkey --quiet --readonly --keyid 'Paranoid' verify signature.gpg signature

 
 

-       msgtest 'Test fail verify a file' 'with bad keyid'
-       testfailure --nomsg aptkey --quiet --readonly --keyid 'Sixpack' verify signature.gpg signature
+               msgtest 'Test fail verify a file' 'with bad keyid'
+               testfailure --nomsg aptkey --quiet --readonly --keyid 'Sixpack' verify signature.gpg signature

 
 

-       msgtest 'Test fail verify a file' 'with non-existing keyid'
-       testfailure --nomsg aptkey --quiet --readonly --keyid 'Kalnischkies' verify signature.gpg signature
+               msgtest 'Test fail verify a file' 'with non-existing keyid'
+               testfailure --nomsg aptkey --quiet --readonly --keyid 'Kalnischkies' verify signature.gpg signature

 
 

-       msgtest 'Test verify fails on' 'bad file'
-       echo 'lalalalala' > signature
-       testfailure --nomsg aptkey --quiet --readonly verify signature.gpg signature
+               msgtest 'Test verify fails on' 'bad file'
+               echo 'lalalalala' > signature2
+               testfailure --nomsg aptkey --quiet --readonly verify signature.gpg signature2
+       done

 }
 
 setupgpgcommand() {
        echo "APT::Key::GPGCommand \"$1\";" > rootdir/etc/apt/apt.conf.d/00gpgcmd
 }
 
 setupgpgcommand() {
        echo "APT::Key::GPGCommand \"$1\";" > rootdir/etc/apt/apt.conf.d/00gpgcmd

-       msgtest 'Test that apt-key uses for the following tests command' "$1"
-       aptkey adv --version >aptkey.version 2>&1
-       if grep -q "^Executing: $1 --" aptkey.version; then
-               msgpass
-       else
-               cat aptkey.version
-               msgfail
-       fi
+       msgmsg 'Force tests to be run with' "$1"
+       testsuccess aptkey --readonly adv --version
+       cp rootdir/tmp/testsuccess.output aptkey.version
+       testsuccess grep "^gpg (GnuPG) $2\." aptkey.version

 }
 
 # run with default (whatever this is)
 testrun
 # run with …
 }
 
 # run with default (whatever this is)
 testrun
 # run with …

-setupgpgcommand 'gpg'
+setupgpgcommand 'gpg' '1'

 testrun
 testrun

-setupgpgcommand 'gpg2'
+setupgpgcommand 'gpg2' '2'

 testrun
 testrun