correct some style/performance/warnings from cppcheck

[apt.git] / methods / https.h

diff --git a/methods/https.h b/methods/https.h
index 2c33d95ee10db3d6e0e1590b1e3cf7c1483639ad..89a89d19c361afcfbadbf838f801a965177e452b 100644 (file)
--- a/methods/https.h
+++ b/methods/https.h
@@ -8,41 +8,76 @@
    ##################################################################### */
                                                                        /*}}}*/
 
    ##################################################################### */
                                                                        /*}}}*/
 

-#ifndef APT_HTTP_H
-#define APT_HTTP_H
-
-#define MAXLEN 360
+#ifndef APT_HTTPS_H
+#define APT_HTTPS_H

 
 #include <iostream>
 #include <curl/curl.h>
 
 
 #include <iostream>
 #include <curl/curl.h>
 

+#include "server.h"
+

 using std::cout;
 using std::endl;
 
 class HttpsMethod;
 using std::cout;
 using std::endl;
 
 class HttpsMethod;

+class FileFd;
+
+class HttpsServerState : public ServerState
+{
+   protected:
+   virtual bool ReadHeaderLines(std::string &Data) { return false; }
+   virtual bool LoadNextResponse(bool const ToFile, FileFd * const File) { return false; }
+
+   public:
+   virtual bool WriteResponse(std::string const &Data) { return false; }

 
 

+   /** \brief Transfer the data from the socket */
+   virtual bool RunData(FileFd * const File) { return false; }
+
+   virtual bool Open() { return false; }
+   virtual bool IsOpen() { return false; }
+   virtual bool Close() { return false; }
+   virtual bool InitHashes(FileFd &File) { return false; }
+   virtual Hashes * GetHashes() { return NULL; }
+   virtual bool Die(FileFd &File) { return false; }
+   virtual bool Flush(FileFd * const File) { return false; }
+   virtual bool Go(bool ToFile, FileFd * const File) { return false; }
+
+   HttpsServerState(URI Srv, HttpsMethod *Owner);
+   virtual ~HttpsServerState() {Close();};
+};

 
 class HttpsMethod : public pkgAcqMethod
 {
 
 class HttpsMethod : public pkgAcqMethod
 {

+   // minimum speed in bytes/se that triggers download timeout handling
+   static const int DL_MIN_SPEED = 10;

 
    virtual bool Fetch(FetchItem *);
 
    virtual bool Fetch(FetchItem *);

+   static size_t parse_header(void *buffer, size_t size, size_t nmemb, void *userp);

    static size_t write_data(void *buffer, size_t size, size_t nmemb, void *userp);
    static int progress_callback(void *clientp, double dltotal, double dlnow, 
                                double ultotal, double ulnow);
    void SetupProxy();
    CURL *curl;
    FetchResult Res;
    static size_t write_data(void *buffer, size_t size, size_t nmemb, void *userp);
    static int progress_callback(void *clientp, double dltotal, double dlnow, 
                                double ultotal, double ulnow);
    void SetupProxy();
    CURL *curl;
    FetchResult Res;

+   HttpsServerState *Server;

 
    public:
    FileFd *File;
       
 
    public:
    FileFd *File;
       

-   HttpsMethod() : pkgAcqMethod("1.2",Pipeline | SendConfig) 
+   HttpsMethod() : pkgAcqMethod("1.2",Pipeline | SendConfig), File(NULL)

    {
       File = 0;
       curl = curl_easy_init();
    };
    {
       File = 0;
       curl = curl_easy_init();
    };

+
+   ~HttpsMethod()
+   {
+      curl_easy_cleanup(curl);
+   };

 };
 
 };
 

+#include <apt-pkg/strutl.h>

 URI Proxy;
 
 #endif
 URI Proxy;
 
 #endif