Do not buffer writes larger than the buffer if possible

[apt.git] / ftparchive / writer.h

diff --git a/ftparchive/writer.h b/ftparchive/writer.h
index 226996475242ece27fabd1b82d594f1223ded0a9..ea4c66da486e959bd58b972a01b2d10c6e0916c5 100644 (file)
--- a/ftparchive/writer.h
+++ b/ftparchive/writer.h
@@ -40,12 +40,13 @@ class FTWScanner
    protected:
    vector<string> Patterns;
    string Arch;
    protected:
    vector<string> Patterns;
    string Arch;

+   bool IncludeArchAll;

    const char *OriginalPath;
    bool ErrorPrinted;
    const char *OriginalPath;
    bool ErrorPrinted;

-   
+

    // Stuff for the delinker
    bool NoLinkAct;
    // Stuff for the delinker
    bool NoLinkAct;

-   
+

    static FTWScanner *Owner;
    static int ScannerFTW(const char *File,const struct stat *sb,int Flag);
    static int ScannerFile(const char *File, bool const &ReadLink);
    static FTWScanner *Owner;
    static int ScannerFTW(const char *File,const struct stat *sb,int Flag);
    static int ScannerFile(const char *File, bool const &ReadLink);


@@ -59,10 +60,12 @@ class FTWScanner
       {
         c1out << endl;
         ErrorPrinted = true;
       {
         c1out << endl;
         ErrorPrinted = true;

-      }         
+      }

    }
    }

-   
+

    public:
    public:

+   FileFd *Output;
+   bool OwnsOutput;

    unsigned int DoHashes;
 
    unsigned long DeLinkLimit;
    unsigned int DoHashes;
 
    unsigned long DeLinkLimit;


@@ -76,9 +79,9 @@ class FTWScanner
    void AddPattern(char const *Pattern) { Patterns.push_back(Pattern); };
    void AddPatterns(std::vector<std::string> const &patterns) { Patterns.insert(Patterns.end(), patterns.begin(), patterns.end()); };
    bool SetExts(string const &Vals);
    void AddPattern(char const *Pattern) { Patterns.push_back(Pattern); };
    void AddPatterns(std::vector<std::string> const &patterns) { Patterns.insert(Patterns.end(), patterns.begin(), patterns.end()); };
    bool SetExts(string const &Vals);

-      
-   FTWScanner(string const &Arch = string());
-   virtual ~FTWScanner() {};
+
+   FTWScanner(FileFd * const Output, string const &Arch = string(), bool const IncludeArchAll = true);
+   virtual ~FTWScanner();

 };
 
 class MultiCompress;
 };
 
 class MultiCompress;


@@ -86,18 +89,13 @@ class MultiCompress;
 class TranslationWriter
 {
    MultiCompress *Comp;
 class TranslationWriter
 {
    MultiCompress *Comp;

-   FILE *Output;

    std::set<string> Included;
    std::set<string> Included;

-   unsigned short RefCounter;
+   FileFd *Output;

 
    public:
 
    public:

-   void IncreaseRefCounter() { ++RefCounter; };
-   unsigned short DecreaseRefCounter() { return (RefCounter == 0) ? 0 : --RefCounter; };
-   unsigned short GetRefCounter() const { return RefCounter; };

    bool DoPackage(string const &Pkg, string const &Desc, string const &MD5);
 
    TranslationWriter(string const &File, string const &TransCompress, mode_t const &Permissions);
    bool DoPackage(string const &Pkg, string const &Desc, string const &MD5);
 
    TranslationWriter(string const &File, string const &TransCompress, mode_t const &Permissions);

-   TranslationWriter() : Comp(NULL), Output(NULL), RefCounter(0) {};

    ~TranslationWriter();
 };
 
    ~TranslationWriter();
 };
 


@@ -105,7 +103,7 @@ class PackagesWriter : public FTWScanner
 {
    Override Over;
    CacheDB Db;
 {
    Override Over;
    CacheDB Db;

-      
+

    public:
 
    // Some flags
    public:
 
    // Some flags


@@ -117,44 +115,44 @@ class PackagesWriter : public FTWScanner
    // General options
    string PathPrefix;
    string DirStrip;
    // General options
    string PathPrefix;
    string DirStrip;

-   FILE *Output;

    struct CacheDB::Stats &Stats;
    struct CacheDB::Stats &Stats;

-   TranslationWriter *TransWriter;
+   TranslationWriter * const TransWriter;

 
    inline bool ReadOverride(string const &File) {return Over.ReadOverride(File);};
    inline bool ReadExtraOverride(string const &File) 
       {return Over.ReadExtraOverride(File);};
 
    inline bool ReadOverride(string const &File) {return Over.ReadOverride(File);};
    inline bool ReadExtraOverride(string const &File) 
       {return Over.ReadExtraOverride(File);};

-   virtual bool DoPackage(string FileName);
+   virtual bool DoPackage(string FileName) APT_OVERRIDE;

 
 

-   PackagesWriter(string const &DB,
+   PackagesWriter(FileFd * const Output, TranslationWriter * const TransWriter, string const &DB,

                   string const &Overrides,
                   string const &ExtOverrides = "",
                   string const &Overrides,
                   string const &ExtOverrides = "",

-                 string const &Arch = "");
-   virtual ~PackagesWriter() {};
+                 string const &Arch = "",
+                 bool const IncludeArchAll = true);
+   virtual ~PackagesWriter();

 };
 
 class ContentsWriter : public FTWScanner
 {
    CacheDB Db;
 };
 
 class ContentsWriter : public FTWScanner
 {
    CacheDB Db;

-   
+

    GenContents Gen;
    GenContents Gen;

-   
+

    public:
 
    // General options
    public:
 
    // General options

-   FILE *Output;

    struct CacheDB::Stats &Stats;
    string Prefix;
    struct CacheDB::Stats &Stats;
    string Prefix;

-   
+

    bool DoPackage(string FileName,string Package);
    bool DoPackage(string FileName,string Package);

-   virtual bool DoPackage(string FileName) 
+   virtual bool DoPackage(string FileName) APT_OVERRIDE 

              {return DoPackage(FileName,string());};
    bool ReadFromPkgs(string const &PkgFile,string const &PkgCompress);
 
              {return DoPackage(FileName,string());};
    bool ReadFromPkgs(string const &PkgFile,string const &PkgCompress);
 

-   void Finish() {Gen.Print(Output);};
+   void Finish() {Gen.Print(*Output);};

    inline bool ReadyDB(string const &DB) {return Db.ReadyDB(DB);};
    inline bool ReadyDB(string const &DB) {return Db.ReadyDB(DB);};

-   
-   ContentsWriter(string const &DB, string const &Arch = string());
+
+   ContentsWriter(FileFd * const Output, string const &DB, string const &Arch = string(),
+        bool const IncludeArchAll = true);

    virtual ~ContentsWriter() {};
 };
 
    virtual ~ContentsWriter() {};
 };
 


@@ -165,21 +163,20 @@ class SourcesWriter : public FTWScanner
    Override SOver;
    char *Buffer;
    unsigned long long BufSize;
    Override SOver;
    char *Buffer;
    unsigned long long BufSize;

-   
+

    public:
 
    bool NoOverride;
    bool DoAlwaysStat;
    public:
 
    bool NoOverride;
    bool DoAlwaysStat;

-   
+

    // General options
    string PathPrefix;
    string DirStrip;
    // General options
    string PathPrefix;
    string DirStrip;

-   FILE *Output;

    struct CacheDB::Stats &Stats;
 
    struct CacheDB::Stats &Stats;
 

-   virtual bool DoPackage(string FileName);
+   virtual bool DoPackage(string FileName) APT_OVERRIDE;

 
 

-   SourcesWriter(string const &DB,string const &BOverrides,string const &SOverrides,
+   SourcesWriter(FileFd * const Output, string const &DB,string const &BOverrides,string const &SOverrides,

                 string const &ExtOverrides=string());
    virtual ~SourcesWriter() {free(Buffer);};
 };
                 string const &ExtOverrides=string());
    virtual ~SourcesWriter() {free(Buffer);};
 };


@@ -187,11 +184,10 @@ class SourcesWriter : public FTWScanner
 class ReleaseWriter : public FTWScanner
 {
 public:
 class ReleaseWriter : public FTWScanner
 {
 public:

-   ReleaseWriter(string const &DB);
-   virtual bool DoPackage(string FileName);
+   ReleaseWriter(FileFd * const Output, string const &DB);
+   virtual bool DoPackage(string FileName) APT_OVERRIDE;

    void Finish();
 
    void Finish();
 

-   FILE *Output;

    // General options
    string PathPrefix;
    string DirStrip;
    // General options
    string PathPrefix;
    string DirStrip;