make all d-pointer * const pointers

[apt.git] / apt-pkg / indexrecords.cc

diff --git a/apt-pkg/indexrecords.cc b/apt-pkg/indexrecords.cc
index e1e9ba657f3881a2236e41f24cd36e24e87e8ea3..5a93d826fe29de75447b678a9009ff9a6af1c878 100644 (file)
--- a/apt-pkg/indexrecords.cc
+++ b/apt-pkg/indexrecords.cc
@@ -42,7 +42,7 @@ APT_PURE bool indexRecords::GetSupportsAcquireByHash() const
    return this->SupportsAcquireByHash;
 }
 
    return this->SupportsAcquireByHash;
 }
 

-APT_PURE bool indexRecords::CheckDist(const string MaybeDist) const
+APT_PURE bool indexRecords::CheckDist(string const &MaybeDist) const

 {
    return (this->Dist == MaybeDist
           || this->Suite == MaybeDist);
 {
    return (this->Dist == MaybeDist
           || this->Suite == MaybeDist);


@@ -58,7 +58,12 @@ APT_PURE time_t indexRecords::GetValidUntil() const
    return this->ValidUntil;
 }
 
    return this->ValidUntil;
 }
 

-APT_PURE indexRecords::checkSum *indexRecords::Lookup(const string MetaKey)
+APT_PURE time_t indexRecords::GetDate() const
+{
+   return this->Date;
+}
+
+APT_PURE indexRecords::checkSum *indexRecords::Lookup(string const &MetaKey)

 {
    std::map<std::string, indexRecords::checkSum* >::const_iterator sum = Entries.find(MetaKey);
    if (sum == Entries.end())
 {
    std::map<std::string, indexRecords::checkSum* >::const_iterator sum = Entries.find(MetaKey);
    if (sum == Entries.end())


@@ -68,10 +73,10 @@ APT_PURE indexRecords::checkSum *indexRecords::Lookup(const string MetaKey)
 
 APT_PURE bool indexRecords::Exists(string const &MetaKey) const
 {
 
 APT_PURE bool indexRecords::Exists(string const &MetaKey) const
 {

-   return Entries.count(MetaKey) == 1;
+   return Entries.find(MetaKey) != Entries.end();

 }
 
 }
 

-bool indexRecords::Load(const string Filename)                         /*{{{*/
+bool indexRecords::Load(string const &Filename)                                /*{{{*/

 {
    FileFd Fd;
    if (OpenMaybeClearSignedFile(Filename, Fd) == false)
 {
    FileFd Fd;
    if (OpenMaybeClearSignedFile(Filename, Fd) == false)


@@ -116,17 +121,8 @@ bool indexRecords::Load(const string Filename)                             /*{{{*/
             indexRecords::checkSum *Sum = new indexRecords::checkSum;
             Sum->MetaKeyFilename = Name;
             Sum->Size = Size;
             indexRecords::checkSum *Sum = new indexRecords::checkSum;
             Sum->MetaKeyFilename = Name;
             Sum->Size = Size;

-           std::string SizeStr;
-           strprintf(SizeStr, "%llu", Size);
-           Sum->Hashes.push_back(HashString("Checksum-FileSize", SizeStr));
-#if __GNUC__ >= 4
-       #pragma GCC diagnostic push
-       #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
-#endif
-            Sum->Hash = HashString(HashString::SupportedHashes()[i],Hash);
-#if __GNUC__ >= 4
-       #pragma GCC diagnostic pop
-#endif
+           Sum->Hashes.FileSize(Size);
+            APT_IGNORE_DEPRECATED(Sum->Hash = HashString(HashString::SupportedHashes()[i],Hash);)

             Entries[Name] = Sum;
          }
          Entries[Name]->Hashes.push_back(HashString(HashString::SupportedHashes()[i],Hash));
             Entries[Name] = Sum;
          }
          Entries[Name]->Hashes.push_back(HashString(HashString::SupportedHashes()[i],Hash));


@@ -140,9 +136,15 @@ bool indexRecords::Load(const string Filename)                             /*{{{*/
       return false;
    }
 
       return false;
    }
 

-   string Label = Section.FindS("Label");
-   string StrDate = Section.FindS("Date");
-   string StrValidUntil = Section.FindS("Valid-Until");
+   string const StrDate = Section.FindS("Date");
+   if (RFC1123StrToTime(StrDate.c_str(), Date) == false)
+   {
+      strprintf(ErrorText, _("Invalid 'Date' entry in Release file %s"), Filename.c_str());
+      return false;
+   }
+
+   string const Label = Section.FindS("Label");
+   string const StrValidUntil = Section.FindS("Valid-Until");

 
    // if we have a Valid-Until header in the Release file, use it as default
    if (StrValidUntil.empty() == false)
 
    // if we have a Valid-Until header in the Release file, use it as default
    if (StrValidUntil.empty() == false)


@@ -165,20 +167,13 @@ bool indexRecords::Load(const string Filename)                            /*{{{*/
       (MinAge == 0 || ValidUntil == 0)) // No user settings, use the one from the Release file
       return true;
 
       (MinAge == 0 || ValidUntil == 0)) // No user settings, use the one from the Release file
       return true;
 

-   time_t date;
-   if (RFC1123StrToTime(StrDate.c_str(), date) == false)
-   {
-      strprintf(ErrorText, _("Invalid 'Date' entry in Release file %s"), Filename.c_str());
-      return false;
-   }
-

    if (MinAge != 0 && ValidUntil != 0) {
    if (MinAge != 0 && ValidUntil != 0) {

-      time_t const min_date = date + MinAge;
+      time_t const min_date = Date + MinAge;

       if (ValidUntil < min_date)
         ValidUntil = min_date;
    }
    if (MaxAge != 0) {
       if (ValidUntil < min_date)
         ValidUntil = min_date;
    }
    if (MaxAge != 0) {

-      time_t const max_date = date + MaxAge;
+      time_t const max_date = Date + MaxAge;

       if (ValidUntil == 0 || ValidUntil > max_date)
         ValidUntil = max_date;
    }
       if (ValidUntil == 0 || ValidUntil > max_date)
         ValidUntil = max_date;
    }