]> git.saurik.com Git - apt.git/blobdiff - test/integration/test-releasefile-verification
test-apt-update-reporting: Make more use of framework
[apt.git] / test / integration / test-releasefile-verification
index 06701c62307f1addcd1bf6d6b4707af68037d78e..ffb5073b6ad886388af8c1edc1f65cc4d5c9b2b2 100755 (executable)
@@ -1,8 +1,8 @@
 #!/bin/sh
 set -e
 
-TESTDIR=$(readlink -f $(dirname $0))
-. $TESTDIR/framework
+TESTDIR="$(readlink -f "$(dirname "$0")")"
+. "$TESTDIR/framework"
 
 setupenvironment
 configarchitecture "i386"
@@ -23,17 +23,17 @@ prepare() {
                fi
        fi
        for release in $(find rootdir/var/lib/apt/lists 2> /dev/null); do
-               touch -d 'now - 1 year' $release
+               touch -d 'now - 1 year' "$release"
        done
        aptget clean
-       cp $1 aptarchive/Packages
+       cp "$1" aptarchive/Packages
        find aptarchive -name 'Release' -delete
        compressfile 'aptarchive/Packages' "$DATE"
        generatereleasefiles "$DATE"
 }
 
 installaptold() {
-       testsuccessequal 'Reading package lists...
+       testsuccessequal "Reading package lists...
 Building dependency tree...
 Suggested packages:
   aptitude | synaptic | wajig dpkg-dev apt-doc bzip2 lzma python-apt
@@ -41,12 +41,12 @@ The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5370 kB of additional disk space will be used.
-Get:1 http://localhost:8080  apt 0.7.25.3
-Download complete and in download only mode' aptget install apt -dy
+Get:1 http://localhost:${APTHTTPPORT}  apt 0.7.25.3
+Download complete and in download only mode" aptget install apt -dy
 }
 
 installaptnew() {
-       testsuccessequal 'Reading package lists...
+       testsuccessequal "Reading package lists...
 Building dependency tree...
 Suggested packages:
   aptitude | synaptic | wajig dpkg-dev apt-doc bzip2 lzma python-apt
@@ -54,8 +54,8 @@ The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5808 kB of additional disk space will be used.
-Get:1 http://localhost:8080  apt 0.8.0~pre1
-Download complete and in download only mode' aptget install apt -dy
+Get:1 http://localhost:${APTHTTPPORT}  apt 0.8.0~pre1
+Download complete and in download only mode" aptget install apt -dy
 }
 
 failaptold() {
@@ -69,7 +69,7 @@ The following NEW packages will be installed:
 After this operation, 5370 kB of additional disk space will be used.
 WARNING: The following packages cannot be authenticated!
   apt
-E: There are problems and -y was used without --force-yes' aptget install apt -dy
+E: There were unauthenticated packages and -y was used without --allow-unauthenticated' aptget install apt -dy
 }
 
 failaptnew() {
@@ -83,13 +83,13 @@ The following NEW packages will be installed:
 After this operation, 5808 kB of additional disk space will be used.
 WARNING: The following packages cannot be authenticated!
   apt
-E: There are problems and -y was used without --force-yes' aptget install apt -dy
+E: There were unauthenticated packages and -y was used without --allow-unauthenticated' aptget install apt -dy
 }
 
 # fake our downloadable file
 touch aptarchive/apt.deb
 
-PKGFILE="${TESTDIR}/$(echo "$(basename $0)" | sed 's#^test-#Packages-#')"
+PKGFILE="${TESTDIR}/$(echo "$(basename "$0")" | sed 's#^test-#Packages-#')"
 
 updatewithwarnings() {
        testwarning aptget update -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
@@ -97,180 +97,227 @@ updatewithwarnings() {
 }
 
 runtest() {
-       prepare ${PKGFILE}
+       local DELETEFILE="$1"
+       msgmsg 'Cold archive signed by' 'Joe Sixpack'
+       prepare "${PKGFILE}"
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete
-       msgmsg 'Cold archive signed by' 'Joe Sixpack'
-       testsuccess aptget update
-       testsuccessequal "$(cat ${PKGFILE})
+       successfulaptgetupdate
+       testsuccessequal "$(cat "${PKGFILE}")
 " aptcache show apt
        installaptold
 
-       prepare ${PKGFILE}-new
+       msgmsg 'Good warm archive signed by' 'Joe Sixpack'
+       prepare "${PKGFILE}-new"
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete
-       msgmsg 'Good warm archive signed by' 'Joe Sixpack'
-       testsuccess aptget update
-       testsuccessequal "$(cat ${PKGFILE}-new)
+       successfulaptgetupdate
+       testsuccessequal "$(cat "${PKGFILE}-new")
 " aptcache show apt
        installaptnew
 
-       prepare ${PKGFILE}
+       msgmsg 'Cold archive signed by' 'Rex Expired'
+       prepare "${PKGFILE}"
        rm -rf rootdir/var/lib/apt/lists
        cp keys/rexexpired.pub rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg
        signreleasefiles 'Rex Expired'
        find aptarchive/ -name "$DELETEFILE" -delete
-       msgmsg 'Cold archive signed by' 'Rex Expired'
        updatewithwarnings '^W: .* KEYEXPIRED'
-       testsuccessequal "$(cat ${PKGFILE})
+       testsuccessequal "$(cat "${PKGFILE}")
 " aptcache show apt
        failaptold
        rm rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg
 
-       prepare ${PKGFILE}
+       msgmsg 'Cold archive signed by' 'Marvin Paranoid'
+       prepare "${PKGFILE}"
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Marvin Paranoid'
        find aptarchive/ -name "$DELETEFILE" -delete
-       msgmsg 'Cold archive signed by' 'Marvin Paranoid'
        updatewithwarnings '^W: .* NO_PUBKEY'
-       testsuccessequal "$(cat ${PKGFILE})
+       testsuccessequal "$(cat "${PKGFILE}")
 " aptcache show apt
        failaptold
 
-       prepare ${PKGFILE}-new
+       msgmsg 'Bad warm archive signed by' 'Joe Sixpack'
+       prepare "${PKGFILE}-new"
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete
-       msgmsg 'Bad warm archive signed by' 'Joe Sixpack'
-       testsuccess aptget update
-       testsuccessequal "$(cat ${PKGFILE}-new)
+       successfulaptgetupdate
+       testsuccessequal "$(cat "${PKGFILE}-new")
 " aptcache show apt
        installaptnew
 
-
-       prepare ${PKGFILE}
+       msgmsg 'Cold archive signed by' 'Joe Sixpack'
+       prepare "${PKGFILE}"
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete
-       msgmsg 'Cold archive signed by' 'Joe Sixpack'
-       testsuccess aptget update
-       testsuccessequal "$(cat ${PKGFILE})
+       successfulaptgetupdate
+       testsuccessequal "$(cat "${PKGFILE}")
 " aptcache show apt
        installaptold
 
-       prepare ${PKGFILE}-new
+       msgmsg 'Good warm archive signed by' 'Marvin Paranoid'
+       prepare "${PKGFILE}-new"
        signreleasefiles 'Marvin Paranoid'
        find aptarchive/ -name "$DELETEFILE" -delete
-       msgmsg 'Good warm archive signed by' 'Marvin Paranoid'
        updatewithwarnings '^W: .* NO_PUBKEY'
-       testsuccessequal "$(cat ${PKGFILE})
+       testsuccessequal "$(cat "${PKGFILE}")
 " aptcache show apt
        installaptold
 
-       prepare ${PKGFILE}-new
+       msgmsg 'Good warm archive signed by' 'Rex Expired'
+       prepare "${PKGFILE}-new"
        cp keys/rexexpired.pub rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg
        signreleasefiles 'Rex Expired'
        find aptarchive/ -name "$DELETEFILE" -delete
-       msgmsg 'Good warm archive signed by' 'Rex Expired'
        updatewithwarnings '^W: .* KEYEXPIRED'
-       testsuccessequal "$(cat ${PKGFILE})
+       testsuccessequal "$(cat "${PKGFILE}")
 " aptcache show apt
        installaptold
        rm rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg
 
-       prepare ${PKGFILE}-new
+       msgmsg 'Good warm archive signed by' 'Joe Sixpack'
+       prepare "${PKGFILE}-new"
        signreleasefiles
        find aptarchive/ -name "$DELETEFILE" -delete
-       msgmsg 'Good warm archive signed by' 'Joe Sixpack'
-       testsuccess aptget update
-       testsuccessequal "$(cat ${PKGFILE}-new)
+       successfulaptgetupdate
+       testsuccessequal "$(cat "${PKGFILE}-new")
 " aptcache show apt
        installaptnew
 
-       prepare ${PKGFILE}
+       msgmsg 'Cold archive signed by good keyring' 'Marvin Paranoid'
+       prepare "${PKGFILE}"
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Marvin Paranoid'
        find aptarchive/ -name "$DELETEFILE" -delete
-       msgmsg 'Cold archive signed by good keyring' 'Marvin Paranoid'
        local MARVIN="$(readlink -f keys/marvinparanoid.pub)"
        sed -i "s#^\(deb\(-src\)\?\) #\1 [signed-by=$MARVIN] #" rootdir/etc/apt/sources.list.d/*
-       testsuccess aptget update -o Debug::pkgAcquire::Worker=1
-       testsuccessequal "$(cat ${PKGFILE})
+       successfulaptgetupdate
+       testsuccessequal "$(cat "${PKGFILE}")
 " aptcache show apt
        installaptold
 
+       msgmsg 'Cold archive signed by bad keyring' 'Joe Sixpack'
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete
-       msgmsg 'Cold archive signed by bad keyring' 'Joe Sixpack'
        updatewithwarnings '^W: .* NO_PUBKEY'
 
        sed -i "s#^\(deb\(-src\)\?\) \[signed-by=$MARVIN\] #\1 #" rootdir/etc/apt/sources.list.d/*
        local MARVIN="$(aptkey --keyring $MARVIN finger | grep 'Key fingerprint' | cut -d'=' -f 2 | tr -d ' ')"
 
-       prepare ${PKGFILE}
+       msgmsg 'Cold archive signed by good keyid' 'Marvin Paranoid'
+       prepare "${PKGFILE}"
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Marvin Paranoid'
        find aptarchive/ -name "$DELETEFILE" -delete
-       msgmsg 'Cold archive signed by good keyid' 'Marvin Paranoid'
        sed -i "s#^\(deb\(-src\)\?\) #\1 [signed-by=$MARVIN] #" rootdir/etc/apt/sources.list.d/*
        cp keys/marvinparanoid.pub rootdir/etc/apt/trusted.gpg.d/marvinparanoid.gpg
-       testsuccess aptget update -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
-       testsuccessequal "$(cat ${PKGFILE})
+       successfulaptgetupdate
+       testsuccessequal "$(cat "${PKGFILE}")
 " aptcache show apt
        installaptold
        rm -f rootdir/etc/apt/trusted.gpg.d/marvinparanoid.gpg
 
+       msgmsg 'Cold archive signed by bad keyid' 'Joe Sixpack'
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete
-       msgmsg 'Cold archive signed by bad keyid' 'Joe Sixpack'
        updatewithwarnings '^W: .* be verified because the public key is not available: .*'
 
        sed -i "s#^\(deb\(-src\)\?\) \[signed-by=$MARVIN\] #\1 #" rootdir/etc/apt/sources.list.d/*
 }
 
 runtest2() {
-       prepare ${PKGFILE}
+       msgmsg 'Cold archive signed by' 'Joe Sixpack'
+       prepare "${PKGFILE}"
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
-       msgmsg 'Cold archive signed by' 'Joe Sixpack'
-       testsuccess aptget update
+       successfulaptgetupdate
 
        # New .deb but now an unsigned archive. For example MITM to circumvent
        # package verification.
-       prepare ${PKGFILE}-new
+       msgmsg 'Warm archive signed by' 'nobody'
+       prepare "${PKGFILE}-new"
        find aptarchive/ -name InRelease -delete
        find aptarchive/ -name Release.gpg -delete
-       msgmsg 'Warm archive signed by' 'nobody'
        updatewithwarnings 'W: .* no longer signed.'
-       testsuccessequal "$(cat ${PKGFILE}-new)
+       testsuccessequal "$(cat "${PKGFILE}-new")
 " aptcache show apt
        failaptnew
 
        # Unsigned archive from the beginning must also be detected.
-       rm -rf rootdir/var/lib/apt/lists
        msgmsg 'Cold archive signed by' 'nobody'
+       rm -rf rootdir/var/lib/apt/lists
        updatewithwarnings 'W: .* is not signed.'
-       testsuccessequal "$(cat ${PKGFILE}-new)
+       testsuccessequal "$(cat "${PKGFILE}-new")
 " aptcache show apt
        failaptnew
 }
 
+runtest3() {
+       echo "Debug::Acquire::gpgv::configdigest::truststate \"$1\";" > rootdir/etc/apt/apt.conf.d/truststate
+       msgmsg "Running base test with $1 digest"
+       runtest2
+
+       for DELETEFILE in 'InRelease' 'Release.gpg'; do
+               msgmsg "Running test with deletion of $DELETEFILE and $1 digest"
+               runtest "$DELETEFILE"
+       done
+}
+
 # diable some protection by default and ensure we still do the verification
 # correctly
 cat > rootdir/etc/apt/apt.conf.d/weaken-security <<EOF
 Acquire::AllowInsecureRepositories "1";
 Acquire::AllowDowngradeToInsecureRepositories "1";
 EOF
+# the hash marked as configureable in our gpgv method
+export APT_TESTS_DIGEST_ALGO='SHA224'
 
-msgmsg "Runing base test"
-runtest2
+successfulaptgetupdate() {
+       testsuccess aptget update -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
+}
+runtest3 'trusted'
 
-DELETEFILE="InRelease"
-msgmsg "Running test with deletion of $DELETEFILE"
-runtest
+successfulaptgetupdate() {
+       testwarning aptget update -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
+       testsuccess grep 'uses weak digest algorithm' rootdir/tmp/testwarning.output
+}
+runtest3 'weak'
+
+msgmsg "Running test with apt-untrusted digest"
+echo "Debug::Acquire::gpgv::configdigest::truststate \"untrusted\";" > rootdir/etc/apt/apt.conf.d/truststate
+runfailure() {
+       for DELETEFILE in 'InRelease' 'Release.gpg'; do
+               msgmsg 'Cold archive signed by' 'Joe Sixpack'
+               prepare "${PKGFILE}"
+               rm -rf rootdir/var/lib/apt/lists
+               signreleasefiles 'Joe Sixpack'
+               find aptarchive/ -name "$DELETEFILE" -delete
+               testfailure aptget update --no-allow-insecure-repositories -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
+               testsuccess grep 'The following signatures were invalid' rootdir/tmp/testfailure.output
+               testnopackage 'apt'
+               testwarning aptget update --allow-insecure-repositories -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
+               failaptold
+
+               msgmsg 'Cold archive signed by' 'Marvin Paranoid'
+               prepare "${PKGFILE}"
+               rm -rf rootdir/var/lib/apt/lists
+               signreleasefiles 'Marvin Paranoid'
+               find aptarchive/ -name "$DELETEFILE" -delete
+               testfailure aptget update --no-allow-insecure-repositories -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
+               testnopackage 'apt'
+               updatewithwarnings '^W: .* NO_PUBKEY'
+               testsuccessequal "$(cat "${PKGFILE}")
+" aptcache show apt
+               failaptold
+       done
+}
+runfailure
 
-DELETEFILE="Release.gpg"
-msgmsg "Running test with deletion of $DELETEFILE"
-runtest
+msgmsg "Running test with gpgv-untrusted digest"
+export APT_TESTS_DIGEST_ALGO='MD5'
+runfailure