correct some style/performance/warnings from cppcheck

[apt.git] / apt-inst / dirstream.cc

diff --git a/apt-inst/dirstream.cc b/apt-inst/dirstream.cc
index 586bbf739d71572f667ae73c867c8492416e9741..b62bdcae12457e0440ea3910093449218da5a7cc 100644 (file)
--- a/apt-inst/dirstream.cc
+++ b/apt-inst/dirstream.cc
@@ -11,6 +11,8 @@
    ##################################################################### */
                                                                        /*}}}*/
 // Include Files                                                       /*{{{*/
    ##################################################################### */
                                                                        /*}}}*/
 // Include Files                                                       /*{{{*/

+#include<config.h>
+

 #include <apt-pkg/dirstream.h>
 #include <apt-pkg/error.h>
 
 #include <apt-pkg/dirstream.h>
 #include <apt-pkg/error.h>
 


@@ -18,7 +20,6 @@
 #include <sys/stat.h>
 #include <sys/types.h>
 #include <errno.h>
 #include <sys/stat.h>
 #include <sys/types.h>
 #include <errno.h>

-#include <utime.h>

 #include <unistd.h>
 #include <apti18n.h>
                                                                        /*}}}*/
 #include <unistd.h>
 #include <apti18n.h>
                                                                        /*}}}*/


@@ -43,11 +44,15 @@ bool pkgDirStream::DoItem(Item &Itm,int &Fd)
         
         // fchmod deals with umask and fchown sets the ownership
         if (fchmod(iFd,Itm.Mode) != 0)
         
         // fchmod deals with umask and fchown sets the ownership
         if (fchmod(iFd,Itm.Mode) != 0)

-           return _error->Errno("fchmod",_("Failed to write file %s"),
-                                Itm.Name);
+        {
+           close(iFd);
+           return _error->Errno("fchmod",_("Failed to write file %s"), Itm.Name);
+        }

         if (fchown(iFd,Itm.UID,Itm.GID) != 0 && errno != EPERM)
         if (fchown(iFd,Itm.UID,Itm.GID) != 0 && errno != EPERM)

-           return _error->Errno("fchown",_("Failed to write file %s"),
-                                Itm.Name);
+        {
+           close(iFd);
+           return _error->Errno("fchown",_("Failed to write file %s"), Itm.Name);
+        }

         Fd = iFd;
         return true;
       }
         Fd = iFd;
         return true;
       }


@@ -87,19 +92,18 @@ bool pkgDirStream::FinishedFile(Item &Itm,int Fd)
 {
    if (Fd < 0)
       return true;
 {
    if (Fd < 0)
       return true;

-   
-   if (close(Fd) != 0)
-      return _error->Errno("close",_("Failed to close file %s"),Itm.Name);

 
    /* Set the modification times. The only way it can fail is if someone
       has futzed with our file, which is intolerable :> */
 
    /* Set the modification times. The only way it can fail is if someone
       has futzed with our file, which is intolerable :> */

-   struct utimbuf Time;
-   Time.actime = Itm.MTime;
-   Time.modtime = Itm.MTime;
-   if (utime(Itm.Name,&Time) != 0)
-      _error->Errno("utime",_("Failed to close file %s"),Itm.Name);
-   
-   return true;   
+   struct timespec times[2];
+   times[0].tv_sec = times[1].tv_sec = Itm.MTime;
+   times[0].tv_nsec = times[1].tv_nsec = 0;
+   if (futimens(Fd, times) != 0)
+      _error->Errno("futimens", "Failed to set modification time for %s",Itm.Name);
+
+   if (close(Fd) != 0)
+      return _error->Errno("close",_("Failed to close file %s"),Itm.Name);
+   return true;

 }
                                                                        /*}}}*/
 // DirStream::Fail - Failed processing a file                          /*{{{*/
 }
                                                                        /*}}}*/
 // DirStream::Fail - Failed processing a file                          /*{{{*/