You have to do the bounds check before the access.

[apt.git] / methods / copy.cc

diff --git a/methods/copy.cc b/methods/copy.cc
index b1c0fe3601cc8d4308502ad808c481802d72ba19..810fc2f38356612649fd8d58e14b275639773262 100644 (file)
--- a/methods/copy.cc
+++ b/methods/copy.cc
@@ -1,6 +1,6 @@
 // -*- mode: cpp; mode: fold -*-
 // Description                                                         /*{{{*/
-// $Id: copy.cc,v 1.3 1998/10/26 07:11:52 jgg Exp $
+// $Id: copy.cc,v 1.7.2.1 2004/01/16 18:58:50 mdz Exp $
 /* ######################################################################
 
    Copy URI - This method takes a uri like a file: uri and copies it
@@ -9,131 +9,85 @@
    ##################################################################### */
                                                                        /*}}}*/
 // Include Files                                                       /*{{{*/
+#include <config.h>
+
 #include <apt-pkg/fileutl.h>
-#include <strutl.h>
+#include <apt-pkg/strutl.h>
 #include <apt-pkg/error.h>
+#include <apt-pkg/hashes.h>
+#include <apt-pkg/configuration.h>
+#include "aptmethod.h"
 
+#include <string>
 #include <sys/stat.h>
-#include <utime.h>
-#include <unistd.h>
-#include <stdio.h>
+#include <sys/time.h>
+
+#include <apti18n.h>
                                                                        /*}}}*/
 
-// Fail - Generate a failure message                                   /*{{{*/
+class CopyMethod : public aptMethod
+{
+   virtual bool Fetch(FetchItem *Itm) APT_OVERRIDE;
+
+   public:
+
+   CopyMethod() : aptMethod("copy", "1.0",SingleInstance | SendConfig) {};
+};
+
+// CopyMethod::Fetch - Fetch a file                                    /*{{{*/
 // ---------------------------------------------------------------------
 /* */
-void Fail(string URI)
+bool CopyMethod::Fetch(FetchItem *Itm)
 {
-   string Err = "Undetermined Error";
-   if (_error->empty() == false)
-      _error->PopMessage(Err);
-   
-   printf("400 URI Failure\n"
-         "URI: %s\n"
-         "Message: %s\n\n",URI.c_str(),Err.c_str());
-   _error->Discard();
+   // this ensures that relative paths work in copy
+   std::string const File = Itm->Uri.substr(Itm->Uri.find(':')+1);
+
+   // Stat the file and send a start message
+   struct stat Buf;
+   if (stat(File.c_str(),&Buf) != 0)
+      return _error->Errno("stat",_("Failed to stat"));
+
+   // Forumulate a result and send a start message
+   FetchResult Res;
+   Res.Size = Buf.st_size;
+   Res.Filename = Itm->DestFile;
+   Res.LastModified = Buf.st_mtime;
+   Res.IMSHit = false;
+   URIStart(Res);
+
+   // just calc the hashes if the source and destination are identical
+   if (File == Itm->DestFile || Itm->DestFile == "/dev/null")
+   {
+      CalculateHashes(Itm, Res);
+      URIDone(Res);
+      return true;
+   }
+
+   // See if the file exists
+   FileFd From(File,FileFd::ReadOnly);
+   FileFd To(Itm->DestFile,FileFd::WriteAtomic);
+   To.EraseOnFailure();
+
+   // Copy the file
+   if (CopyFile(From,To) == false)
+   {
+      To.OpFail();
+      return false;
+   }
+
+   From.Close();
+   To.Close();
+
+   if (TransferModificationTimes(File.c_str(), Res.Filename.c_str(), Res.LastModified) == false)
+      return false;
+
+   CalculateHashes(Itm, Res);
+   URIDone(Res);
+   return true;
 }
                                                                        /*}}}*/
 
 int main()
 {
-   setlinebuf(stdout);
-   SetNonBlock(STDIN_FILENO,true);
-   
-   printf("100 Capabilities\n"
-         "Version: 1.0\n"
-         "Pipeline: true\n\n");
-      
-   vector<string> Messages;   
-   while (1)
-   {
-      if (WaitFd(STDIN_FILENO) == false ||
-         ReadMessages(STDIN_FILENO,Messages) == false)
-        return 0;
-
-      while (Messages.empty() == false)
-      {
-        string Message = Messages.front();
-        Messages.erase(Messages.begin());
-        
-        // Fetch the message number
-        char *End;
-        int Number = strtol(Message.c_str(),&End,10);
-        if (End == Message.c_str())
-        {
-           cerr << "Malformed message!" << endl;
-           return 100;
-        }
-        
-        // We only understand 600 URI Fetch messages
-        if (Number != 600)
-           continue;
-        
-        // Grab the URI bit 
-        string URI = LookupTag(Message,"URI");
-        string Target = LookupTag(Message,"Filename");
-        
-        // Grab the filename
-        string::size_type Pos = URI.find(':');
-        if (Pos == string::npos)
-        {
-           _error->Error("Invalid message");
-           Fail(URI);
-           continue;
-        }
-        string File = string(URI,Pos+1);
-        
-        // Start the reply message
-        string Result = "201 URI Done";
-        Result += "\nURI: " + URI;
-        Result += "\nFileName: " + Target;
-        
-        // See if the file exists
-        FileFd From(File,FileFd::ReadOnly);
-        FileFd To(Target,FileFd::WriteEmpty);
-        To.EraseOnFailure();
-        if (_error->PendingError() == true)
-        {
-           Fail(URI);
-           continue;
-        }       
-        
-        // Copy the file
-        if (CopyFile(From,To) == false)
-        {
-           Fail(URI);
-           continue;
-        }       
-       
-        From.Close();
-        To.Close();
-        
-        // Transfer the modification times
-        struct stat Buf;
-        if (stat(File.c_str(),&Buf) != 0)
-        {
-           _error->Errno("stat","Failed to stat");
-           Fail(URI);
-           continue;
-        }
-        struct utimbuf TimeBuf;
-        TimeBuf.actime = Buf.st_atime;
-        TimeBuf.modtime = Buf.st_mtime;
-        if (utime(Target.c_str(),&TimeBuf) != 0)
-        {
-           To.OpFail();
-           _error->Errno("utime","Failed to set modification time");
-           Fail(URI);
-           continue;
-        }
-              
-        // Send the message
-        Result += "\n\n";
-        if (write(STDOUT_FILENO,Result.begin(),Result.length()) != 
-            (signed)Result.length())
-           return 100;
-      }      
-   }
-   
-   return 0;
+   return CopyMethod().Run();
 }