disable updating insecure repositories in apt by default

[apt.git] / test / integration / test-apt-update-rollback

diff --git a/test/integration/test-apt-update-rollback b/test/integration/test-apt-update-rollback
index 5b9c200fe1a3285225fb47aab62612f5537cdefa..12d541055fc94f7eef8d59dddde8ab24c933684b 100755 (executable)
--- a/test/integration/test-apt-update-rollback
+++ b/test/integration/test-apt-update-rollback
@@ -23,21 +23,22 @@ create_fresh_archive()
 }
 
 add_new_package() {
 }
 
 add_new_package() {

-    insertpackage "unstable" "new" "all" "1.0"
-    insertsource "unstable" "new" "all" "1.0"
+    insertpackage 'unstable' 'new' 'all' '1.0'
+    insertsource 'unstable' 'new' 'all' '1.0'

 
     setupaptarchive --no-update "$@"
 }
 
 break_repository_sources_index() {
 
     setupaptarchive --no-update "$@"
 }
 
 break_repository_sources_index() {

-    printf 'xxx' > $APTARCHIVE/dists/unstable/main/source/Sources
+    printf 'xxx' > "$APTARCHIVE/dists/unstable/main/source/Sources"

     compressfile "$APTARCHIVE/dists/unstable/main/source/Sources" "$@"
 }
 
 start_with_good_inrelease() {
     create_fresh_archive
     testsuccess aptget update
     compressfile "$APTARCHIVE/dists/unstable/main/source/Sources" "$@"
 }
 
 start_with_good_inrelease() {
     create_fresh_archive
     testsuccess aptget update

-    testequal "old/unstable 1.0 all" apt list -q
+    listcurrentlistsdirectory > lists.before
+    testsuccessequal 'old/unstable 1.0 all' apt list -q

 }
 
 test_inrelease_to_new_inrelease() {
 }
 
 test_inrelease_to_new_inrelease() {


@@ -46,8 +47,8 @@ test_inrelease_to_new_inrelease() {
 
     add_new_package '+1hour'
     testsuccess aptget update -o Debug::Acquire::Transaction=1
 
     add_new_package '+1hour'
     testsuccess aptget update -o Debug::Acquire::Transaction=1

-    testequal "new/unstable 1.0 all
-old/unstable 1.0 all" apt list -q
+    testsuccessequal 'new/unstable 1.0 all
+old/unstable 1.0 all' apt list -q

 }
 
 test_inrelease_to_broken_hash_reverts_all() {
 }
 
 test_inrelease_to_broken_hash_reverts_all() {


@@ -59,11 +60,11 @@ test_inrelease_to_broken_hash_reverts_all() {
     break_repository_sources_index '+1hour'
 
     # test the error condition
     break_repository_sources_index '+1hour'
 
     # test the error condition

-    testequal "W: Failed to fetch file:${APTARCHIVE}/dists/unstable/main/source/Sources  Hash Sum mismatch
-
+    testfailureequal "W: Failed to fetch file:${APTARCHIVE}/dists/unstable/main/source/Sources.gz  Hash Sum mismatch

 E: Some index files failed to download. They have been ignored, or old ones used instead." aptget update -qq
     # ensure that the Packages file is also rolled back
 E: Some index files failed to download. They have been ignored, or old ones used instead." aptget update -qq
     # ensure that the Packages file is also rolled back

-    testequal "E: Unable to locate package new" aptget install new -s -qq
+    testfileequal lists.before "$(listcurrentlistsdirectory)"
+    testfailureequal "E: Unable to locate package new" aptget install new -s -qq

 }
 
 test_inrelease_to_valid_release() {
 }
 
 test_inrelease_to_valid_release() {


@@ -72,17 +73,18 @@ test_inrelease_to_valid_release() {
 
     add_new_package '+1hour'
     # switch to a unsigned repo now
 
     add_new_package '+1hour'
     # switch to a unsigned repo now

-    rm $APTARCHIVE/dists/unstable/InRelease
-    rm $APTARCHIVE/dists/unstable/Release.gpg
+    rm "$APTARCHIVE/dists/unstable/InRelease"
+    rm "$APTARCHIVE/dists/unstable/Release.gpg"

 
     # update fails
 
     # update fails

-    testequal "E: The repository 'file: unstable Release.gpg' is no longer signed." aptget update -qq
+    testfailureequal "E: The repository 'file:${APTARCHIVE} unstable Release' is no longer signed." aptget update -qq

 
 

-    # test that we can install the new packages but do no longer have a sig
+    # test that security downgrade was not successful
+    testfileequal lists.before "$(listcurrentlistsdirectory)"

     testsuccess aptget install old -s
     testfailure aptget install new -s
     testsuccess aptget install old -s
     testfailure aptget install new -s

-    testsuccess ls $ROOTDIR/var/lib/apt/lists/*_InRelease
-    testfailure ls $ROOTDIR/var/lib/apt/lists/*_Release
+    testnotempty find "${ROOTDIR}/var/lib/apt/lists" -name '*_InRelease'
+    testempty find "${ROOTDIR}/var/lib/apt/lists" -name '*_Release'

 }
 
 test_inrelease_to_release_reverts_all() {
 }
 
 test_inrelease_to_release_reverts_all() {


@@ -91,73 +93,80 @@ test_inrelease_to_release_reverts_all() {
 
     # switch to a unsigned repo now
     add_new_package '+1hour'
 
     # switch to a unsigned repo now
     add_new_package '+1hour'

-    rm $APTARCHIVE/dists/unstable/InRelease
-    rm $APTARCHIVE/dists/unstable/Release.gpg
+    rm "$APTARCHIVE/dists/unstable/InRelease"
+    rm "$APTARCHIVE/dists/unstable/Release.gpg"

 
     # break it
     break_repository_sources_index '+1hour'
 
     # ensure error
 
     # break it
     break_repository_sources_index '+1hour'
 
     # ensure error

-    testequal "E: The repository 'file: unstable Release.gpg' is no longer signed." aptget update -qq # -o Debug::acquire::transaction=1
+    testfailureequal "E: The repository 'file:${APTARCHIVE} unstable Release' is no longer signed." aptget update -qq # -o Debug::acquire::transaction=1

 
     # ensure that the Packages file is also rolled back
 
     # ensure that the Packages file is also rolled back

+    testfileequal lists.before "$(listcurrentlistsdirectory)"

     testsuccess aptget install old -s
     testfailure aptget install new -s
     testsuccess aptget install old -s
     testfailure aptget install new -s

-    testsuccess ls $ROOTDIR/var/lib/apt/lists/*_InRelease
-    testfailure ls $ROOTDIR/var/lib/apt/lists/*_Release
+    testnotempty find "${ROOTDIR}/var/lib/apt/lists" -name '*_InRelease'
+    testempty find "${ROOTDIR}/var/lib/apt/lists" -name '*_Release'

 }
 
 test_unauthenticated_to_invalid_inrelease() {
     msgmsg 'Test UnAuthenticated to invalid InRelease reverts everything'
     create_fresh_archive
 }
 
 test_unauthenticated_to_invalid_inrelease() {
     msgmsg 'Test UnAuthenticated to invalid InRelease reverts everything'
     create_fresh_archive

-    rm $APTARCHIVE/dists/unstable/InRelease
-    rm $APTARCHIVE/dists/unstable/Release.gpg
+    rm "$APTARCHIVE/dists/unstable/InRelease"
+    rm "$APTARCHIVE/dists/unstable/Release.gpg"

 
 

-    testsuccess aptget update --allow-insecure-repositories
-    testequal "WARNING: The following packages cannot be authenticated!
+    testwarning aptget update --allow-insecure-repositories
+    listcurrentlistsdirectory > lists.before
+    testfailureequal "WARNING: The following packages cannot be authenticated!

   old
   old

-E: There are problems and -y was used without --force-yes" aptget install -qq -y old
+E: There were unauthenticated packages and -y was used without --allow-unauthenticated" aptget install -qq -y old

 
     # go to authenticated but not correct
     add_new_package '+1hour'
     break_repository_sources_index '+1hour'
 
 
     # go to authenticated but not correct
     add_new_package '+1hour'
     break_repository_sources_index '+1hour'
 

-    testequal "W: Failed to fetch file:$APTARCHIVE/dists/unstable/main/source/Sources  Hash Sum mismatch
-
+    testfailureequal "W: Failed to fetch file:$APTARCHIVE/dists/unstable/main/source/Sources.gz  Hash Sum mismatch

 E: Some index files failed to download. They have been ignored, or old ones used instead." aptget update -qq
 
 E: Some index files failed to download. They have been ignored, or old ones used instead." aptget update -qq
 

-    testfailure ls rootdir/var/lib/apt/lists/*_InRelease
-    testequal "WARNING: The following packages cannot be authenticated!
+    testfileequal lists.before "$(listcurrentlistsdirectory)"
+    testempty find "${ROOTDIR}/var/lib/apt/lists" -maxdepth 1 -name '*_InRelease'
+    testfailureequal "WARNING: The following packages cannot be authenticated!

   old
   old

-E: There are problems and -y was used without --force-yes" aptget install -qq -y old
+E: There were unauthenticated packages and -y was used without --allow-unauthenticated" aptget install -qq -y old

 }
 
 test_inrelease_to_unauth_inrelease() {
     msgmsg 'Test InRelease to InRelease without good sig'
     start_with_good_inrelease
 
 }
 
 test_inrelease_to_unauth_inrelease() {
     msgmsg 'Test InRelease to InRelease without good sig'
     start_with_good_inrelease
 

-    signreleasefiles 'Marvin Paranoid' '+1hour'
-
-    testequal "W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: file: unstable InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY E8525D47528144E2
+    signreleasefiles 'Marvin Paranoid'

 
 

+    testwarningequal "W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: file:${APTARCHIVE} unstable InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY E8525D47528144E2

 W: Failed to fetch file:$APTARCHIVE/dists/unstable/InRelease  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY E8525D47528144E2
 W: Failed to fetch file:$APTARCHIVE/dists/unstable/InRelease  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY E8525D47528144E2

-

 W: Some index files failed to download. They have been ignored, or old ones used instead." aptget update -qq
 
 W: Some index files failed to download. They have been ignored, or old ones used instead." aptget update -qq
 

-    testsuccess ls rootdir/var/lib/apt/lists/*_InRelease
+    testfileequal lists.before "$(listcurrentlistsdirectory)"
+    testnotempty find "${ROOTDIR}/var/lib/apt/lists" -name '*_InRelease'

 }
 
 test_inrelease_to_broken_gzip() {
     msgmsg "Test InRelease to broken gzip"
     start_with_good_inrelease
 
 }
 
 test_inrelease_to_broken_gzip() {
     msgmsg "Test InRelease to broken gzip"
     start_with_good_inrelease
 

+    break_repository_sources_index '+1hour'
+    generatereleasefiles '+2hours'
+    signreleasefiles
+

     # append junk at the end of the compressed file
     # append junk at the end of the compressed file

-    echo "lala" >> $APTARCHIVE/dists/unstable/main/source/Sources.gz
-    touch -d '+2min' $APTARCHIVE/dists/unstable/main/source/Sources.gz
+    echo "lala" >> "$APTARCHIVE/dists/unstable/main/source/Sources.gz"
+    touch -d '+2min' "$APTARCHIVE/dists/unstable/main/source/Sources.gz"

     # remove uncompressed file to avoid fallback
     # remove uncompressed file to avoid fallback

-    rm $APTARCHIVE/dists/unstable/main/source/Sources
+    rm "$APTARCHIVE/dists/unstable/main/source/Sources"

 
     testfailure aptget update
 
     testfailure aptget update

+    testsuccess grep 'Hash Sum mismatch' rootdir/tmp/testfailure.output
+    testfileequal lists.before "$(listcurrentlistsdirectory)"

 }
 
 TESTDIR=$(readlink -f $(dirname $0))
 }
 
 TESTDIR=$(readlink -f $(dirname $0))


@@ -168,9 +177,9 @@ configarchitecture "i386"
 
 # setup the archive and ensure we have a single package that installs fine
 setupaptarchive
 
 # setup the archive and ensure we have a single package that installs fine
 setupaptarchive

-APTARCHIVE=$(readlink -f ./aptarchive)
-ROOTDIR=${TMPWORKINGDIRECTORY}/rootdir
-APTARCHIVE_LISTS="$(echo $APTARCHIVE | tr "/" "_" )"
+APTARCHIVE="$(readlink -f ./aptarchive)"
+ROOTDIR="${TMPWORKINGDIRECTORY}/rootdir"
+APTARCHIVE_LISTS="$(echo "$APTARCHIVE" | tr "/" "_" )"

 
 # test the following cases:
 # - InRelease -> broken InRelease revert to previous state
 
 # test the following cases:
 # - InRelease -> broken InRelease revert to previous state