* debian/rules

[apt.git] / methods / gpgv.cc

diff --git a/methods/gpgv.cc b/methods/gpgv.cc
index b34ea8d8561c459e490653ee89e187a1f44df766..2b1fa51691e26b9350f01f7b5ffcd9db22e22278 100644 (file)
--- a/methods/gpgv.cc
+++ b/methods/gpgv.cc
@@ -1,6 +1,7 @@
 #include <apt-pkg/error.h>
 #include <apt-pkg/acquire-method.h>
 #include <apt-pkg/strutl.h>
 #include <apt-pkg/error.h>
 #include <apt-pkg/acquire-method.h>
 #include <apt-pkg/strutl.h>

+#include <apti18n.h>

 
 #include <sys/stat.h>
 #include <unistd.h>
 
 #include <sys/stat.h>
 #include <unistd.h>


@@ -10,16 +11,18 @@
 #include <errno.h>
 #include <sys/wait.h>
 #include <iostream>
 #include <errno.h>
 #include <sys/wait.h>
 #include <iostream>

+#include <sstream>

 
 #define GNUPGPREFIX "[GNUPG:]"
 #define GNUPGBADSIG "[GNUPG:] BADSIG"
 #define GNUPGNOPUBKEY "[GNUPG:] NO_PUBKEY"
 #define GNUPGVALIDSIG "[GNUPG:] VALIDSIG"
 
 #define GNUPGPREFIX "[GNUPG:]"
 #define GNUPGBADSIG "[GNUPG:] BADSIG"
 #define GNUPGNOPUBKEY "[GNUPG:] NO_PUBKEY"
 #define GNUPGVALIDSIG "[GNUPG:] VALIDSIG"

+#define GNUPGNODATA "[GNUPG:] NODATA"

 
 class GPGVMethod : public pkgAcqMethod
 {
    private:
 
 class GPGVMethod : public pkgAcqMethod
 {
    private:

-   const char *VerifyGetSigners(const char *file, const char *outfile,
+   string VerifyGetSigners(const char *file, const char *outfile,

                                vector<string> &GoodSigners, vector<string> &BadSigners,
                                vector<string> &NoPubKeySigners);
    
                                vector<string> &GoodSigners, vector<string> &BadSigners,
                                vector<string> &NoPubKeySigners);
    


@@ -31,11 +34,15 @@ class GPGVMethod : public pkgAcqMethod
    GPGVMethod() : pkgAcqMethod("1.0",SingleInstance | SendConfig) {};
 };
 
    GPGVMethod() : pkgAcqMethod("1.0",SingleInstance | SendConfig) {};
 };
 

-const char *GPGVMethod::VerifyGetSigners(const char *file, const char *outfile,
+string GPGVMethod::VerifyGetSigners(const char *file, const char *outfile,

                                         vector<string> &GoodSigners,
                                         vector<string> &BadSigners,
                                         vector<string> &NoPubKeySigners)
 {
                                         vector<string> &GoodSigners,
                                         vector<string> &BadSigners,
                                         vector<string> &NoPubKeySigners)
 {

+   // setup a (empty) stringstream for formating the return value
+   std::stringstream ret;
+   ret.str("");
+

    if (_config->FindB("Debug::Acquire::gpgv", false))
    {
       std::cerr << "inside VerifyGetSigners" << std::endl;
    if (_config->FindB("Debug::Acquire::gpgv", false))
    {
       std::cerr << "inside VerifyGetSigners" << std::endl;


@@ -46,16 +53,18 @@ const char *GPGVMethod::VerifyGetSigners(const char *file, const char *outfile,
    int status;
    struct stat buff;
    string gpgvpath = _config->Find("Dir::Bin::gpg", "/usr/bin/gpgv");
    int status;
    struct stat buff;
    string gpgvpath = _config->Find("Dir::Bin::gpg", "/usr/bin/gpgv");

-   string pubringpath = _config->Find("Apt::GPGV::TrustedKeyring", "/etc/apt/trusted.gpg");
+   string pubringpath = _config->Find("APT::GPGV::TrustedKeyring", "/etc/apt/trusted.gpg");

    if (_config->FindB("Debug::Acquire::gpgv", false))
    {
       std::cerr << "gpgv path: " << gpgvpath << std::endl;
       std::cerr << "Keyring path: " << pubringpath << std::endl;
    }
 
    if (_config->FindB("Debug::Acquire::gpgv", false))
    {
       std::cerr << "gpgv path: " << gpgvpath << std::endl;
       std::cerr << "Keyring path: " << pubringpath << std::endl;
    }
 

-   if (stat(pubringpath.c_str(), &buff) != 0)
-      return (string("Couldn't access keyring: ") + strerror(errno)).c_str();
-
+   if (stat(pubringpath.c_str(), &buff) != 0) 
+   {
+      ioprintf(ret, _("Couldn't access keyring: '%s'"), strerror(errno)); 
+      return ret.str();
+   }

    if (pipe(fd) < 0)
    {
       return "Couldn't create pipe";
    if (pipe(fd) < 0)
    {
       return "Couldn't create pipe";


@@ -64,15 +73,45 @@ const char *GPGVMethod::VerifyGetSigners(const char *file, const char *outfile,
    pid = fork();
    if (pid < 0)
    {
    pid = fork();
    if (pid < 0)
    {

-      return (string("Couldn't spawn new process") + strerror(errno)).c_str();
+      return string("Couldn't spawn new process") + strerror(errno);

    }
    else if (pid == 0)
    {
    }
    else if (pid == 0)
    {

+      const char *Args[400];
+      unsigned int i = 0;
+
+      Args[i++] = gpgvpath.c_str();
+      Args[i++] = "--status-fd";
+      Args[i++] = "3";
+      Args[i++] = "--keyring";
+      Args[i++] = pubringpath.c_str();
+
+      Configuration::Item const *Opts;
+      Opts = _config->Tree("Acquire::gpgv::Options");
+      if (Opts != 0)
+      {
+         Opts = Opts->Child;
+        for (; Opts != 0; Opts = Opts->Next)
+         {
+            if (Opts->Value.empty() == true)
+               continue;
+            Args[i++] = Opts->Value.c_str();
+           if(i >= 395) { 
+              std::cerr << _("E: Argument list from Acquire::gpgv::Options too long. Exiting.") << std::endl;
+              exit(111);
+           }
+         }
+      }
+      Args[i++] = file;
+      Args[i++] = outfile;
+      Args[i++] = NULL;
+

       if (_config->FindB("Debug::Acquire::gpgv", false))
       {
       if (_config->FindB("Debug::Acquire::gpgv", false))
       {

-         std::cerr << "Preparing to exec: " << gpgvpath
-                  << " --status-fd 3 --keyring " << pubringpath
-                  << " " << file << " " << outfile << std::endl;
+         std::cerr << "Preparing to exec: " << gpgvpath;
+        for(unsigned int j=0;Args[j] != NULL; j++)
+           std::cerr << " " << Args[j];
+        std::cerr << std::endl;

       }
       int nullfd = open("/dev/null", O_RDONLY);
       close(fd[0]);
       }
       int nullfd = open("/dev/null", O_RDONLY);
       close(fd[0]);


@@ -82,11 +121,10 @@ const char *GPGVMethod::VerifyGetSigners(const char *file, const char *outfile,
       // Redirect the pipe to the status fd (3)
       dup2(fd[1], 3);
 
       // Redirect the pipe to the status fd (3)
       dup2(fd[1], 3);
 

-      putenv("LANG=");
-      putenv("LC_ALL=");
-      putenv("LC_MESSAGES=");
-      execlp(gpgvpath.c_str(), gpgvpath.c_str(), "--status-fd", "3", "--keyring", 
-            pubringpath.c_str(), file, outfile, NULL);
+      putenv((char *)"LANG=");
+      putenv((char *)"LC_ALL=");
+      putenv((char *)"LC_MESSAGES=");
+      execvp(gpgvpath.c_str(), (char **)Args);

              
       exit(111);
    }
              
       exit(111);
    }


@@ -134,7 +172,12 @@ const char *GPGVMethod::VerifyGetSigners(const char *file, const char *outfile,
             std::cerr << "Got NO_PUBKEY " << std::endl;
          NoPubKeySigners.push_back(string(buffer+sizeof(GNUPGPREFIX)));
       }
             std::cerr << "Got NO_PUBKEY " << std::endl;
          NoPubKeySigners.push_back(string(buffer+sizeof(GNUPGPREFIX)));
       }

-
+      if (strncmp(buffer, GNUPGNODATA, sizeof(GNUPGBADSIG)-1) == 0)
+      {
+         if (_config->FindB("Debug::Acquire::gpgv", false))
+            std::cerr << "Got NODATA! " << std::endl;
+         BadSigners.push_back(string(buffer+sizeof(GNUPGPREFIX)));
+      }

       if (strncmp(buffer, GNUPGVALIDSIG, sizeof(GNUPGVALIDSIG)-1) == 0)
       {
          char *sig = buffer + sizeof(GNUPGPREFIX);
       if (strncmp(buffer, GNUPGVALIDSIG, sizeof(GNUPGVALIDSIG)-1) == 0)
       {
          char *sig = buffer + sizeof(GNUPGPREFIX);


@@ -152,27 +195,27 @@ const char *GPGVMethod::VerifyGetSigners(const char *file, const char *outfile,
    waitpid(pid, &status, 0);
    if (_config->FindB("Debug::Acquire::gpgv", false))
    {
    waitpid(pid, &status, 0);
    if (_config->FindB("Debug::Acquire::gpgv", false))
    {

-      std::cerr <<"gpgv exited\n";
+      std::cerr << "gpgv exited\n";

    }
    
    if (WEXITSTATUS(status) == 0)
    {
       if (GoodSigners.empty())
    }
    
    if (WEXITSTATUS(status) == 0)
    {
       if (GoodSigners.empty())

-         return "Internal error: Good signature, but could not determine key fingerprint?!";
-      return NULL;
+         return _("Internal error: Good signature, but could not determine key fingerprint?!");
+      return "";

    }
    else if (WEXITSTATUS(status) == 1)
    {
    }
    else if (WEXITSTATUS(status) == 1)
    {

-      return "At least one invalid signature was encountered.";
+      return _("At least one invalid signature was encountered.");

    }
    else if (WEXITSTATUS(status) == 111)
    {
    }
    else if (WEXITSTATUS(status) == 111)
    {

-      return (string("Could not execute ") + gpgvpath +
-             string(" to verify signature (is gnupg installed?)")).c_str();
+      ioprintf(ret, _("Could not execute '%s' to verify signature (is gnupg installed?)"), gpgvpath.c_str());
+      return ret.str();

    }
    else
    {
    }
    else
    {

-      return "Unknown error executing gpgv";
+      return _("Unknown error executing gpgv");

    }
 }
 
    }
 }
 


@@ -190,8 +233,8 @@ bool GPGVMethod::Fetch(FetchItem *Itm)
    URIStart(Res);
 
    // Run gpgv on file, extract contents and get the key ID of the signer
    URIStart(Res);
 
    // Run gpgv on file, extract contents and get the key ID of the signer

-   const char *msg = VerifyGetSigners(Path.c_str(), Itm->DestFile.c_str(),
-                                     GoodSigners, BadSigners, NoPubKeySigners);
+   string msg = VerifyGetSigners(Path.c_str(), Itm->DestFile.c_str(),
+                             GoodSigners, BadSigners, NoPubKeySigners);

    if (GoodSigners.empty() || !BadSigners.empty() || !NoPubKeySigners.empty())
    {
       string errmsg;
    if (GoodSigners.empty() || !BadSigners.empty() || !NoPubKeySigners.empty())
    {
       string errmsg;


@@ -203,35 +246,39 @@ bool GPGVMethod::Fetch(FetchItem *Itm)
       {
          if (!BadSigners.empty())
          {
       {
          if (!BadSigners.empty())
          {

-            errmsg += "The following signatures were invalid:\n";
+            errmsg += _("The following signatures were invalid:\n");

             for (vector<string>::iterator I = BadSigners.begin();
                 I != BadSigners.end(); I++)
                errmsg += (*I + "\n");
          }
          if (!NoPubKeySigners.empty())
          {
             for (vector<string>::iterator I = BadSigners.begin();
                 I != BadSigners.end(); I++)
                errmsg += (*I + "\n");
          }
          if (!NoPubKeySigners.empty())
          {

-             errmsg += "The following signatures couldn't be verified because the public key is not available:\n";
+             errmsg += _("The following signatures couldn't be verified because the public key is not available:\n");

             for (vector<string>::iterator I = NoPubKeySigners.begin();
                 I != NoPubKeySigners.end(); I++)
                errmsg += (*I + "\n");
          }
       }
             for (vector<string>::iterator I = NoPubKeySigners.begin();
                 I != NoPubKeySigners.end(); I++)
                errmsg += (*I + "\n");
          }
       }

-      return _error->Error(errmsg.c_str());
+      // this is only fatal if we have no good sigs or if we have at
+      // least one bad signature. good signatures and NoPubKey signatures
+      // happen easily when a file is signed with multiple signatures
+      if(GoodSigners.empty() or !BadSigners.empty())
+        return _error->Error(errmsg.c_str());

    }
       
    // Transfer the modification times
    struct stat Buf;
    if (stat(Path.c_str(),&Buf) != 0)
    }
       
    // Transfer the modification times
    struct stat Buf;
    if (stat(Path.c_str(),&Buf) != 0)

-      return _error->Errno("stat","Failed to stat %s", Path.c_str());
+      return _error->Errno("stat",_("Failed to stat %s"), Path.c_str());

 
    struct utimbuf TimeBuf;
    TimeBuf.actime = Buf.st_atime;
    TimeBuf.modtime = Buf.st_mtime;
    if (utime(Itm->DestFile.c_str(),&TimeBuf) != 0)
 
    struct utimbuf TimeBuf;
    TimeBuf.actime = Buf.st_atime;
    TimeBuf.modtime = Buf.st_mtime;
    if (utime(Itm->DestFile.c_str(),&TimeBuf) != 0)

-      return _error->Errno("utime","Failed to set modification time");
+      return _error->Errno("utime",_("Failed to set modification time"));

 
    if (stat(Itm->DestFile.c_str(),&Buf) != 0)
 
    if (stat(Itm->DestFile.c_str(),&Buf) != 0)

-      return _error->Errno("stat","Failed to stat");
+      return _error->Errno("stat",_("Failed to stat"));

    
    // Return a Done response
    Res.LastModified = Buf.st_mtime;
    
    // Return a Done response
    Res.LastModified = Buf.st_mtime;


@@ -246,7 +293,7 @@ bool GPGVMethod::Fetch(FetchItem *Itm)
 
    if (_config->FindB("Debug::Acquire::gpgv", false))
    {
 
    if (_config->FindB("Debug::Acquire::gpgv", false))
    {

-      std::cerr <<"gpgv suceeded\n";
+      std::cerr << "gpgv succeeded\n";

    }
 
    return true;
    }
 
    return true;


@@ -255,6 +302,8 @@ bool GPGVMethod::Fetch(FetchItem *Itm)
 
 int main()
 {
 
 int main()
 {

+   setlocale(LC_ALL, "");
+   

    GPGVMethod Mth;
 
    return Mth.Run();
    GPGVMethod Mth;
 
    return Mth.Run();