Merge branch 'feature/extractar-filefd' into debian/experimental

[apt.git] / test / integration / test-apt-update-nofallback

diff --git a/test/integration/test-apt-update-nofallback b/test/integration/test-apt-update-nofallback
index 4e8ea99166e0dc31f569d22fc1fae7da63db8ca9..dae537c32c6d7ed782fe8f5c2891f2ca015cb6c0 100755 (executable)
--- a/test/integration/test-apt-update-nofallback
+++ b/test/integration/test-apt-update-nofallback
@@ -8,6 +8,7 @@ set -e
 
 simulate_mitm_and_inject_evil_package()
 {
 
 simulate_mitm_and_inject_evil_package()
 {

+    redatereleasefiles '+1 hour'

     rm -f $APTARCHIVE/dists/unstable/InRelease
     rm -f $APTARCHIVE/dists/unstable/Release.gpg
     inject_evil_package
     rm -f $APTARCHIVE/dists/unstable/InRelease
     rm -f $APTARCHIVE/dists/unstable/Release.gpg
     inject_evil_package


@@ -27,20 +28,22 @@ Description: an autogenerated evil package
 EOF
     # avoid ims hit
     touch -d '+1hour' aptarchive/dists/unstable/main/binary-i386/Packages
 EOF
     # avoid ims hit
     touch -d '+1hour' aptarchive/dists/unstable/main/binary-i386/Packages

+    compressfile aptarchive/dists/unstable/main/binary-i386/Packages

 }
 
 assert_update_is_refused_and_last_good_state_used()
 {
 }
 
 assert_update_is_refused_and_last_good_state_used()
 {

-    testequal "E: The repository 'file: unstable Release.gpg' is no longer signed." aptget update -qq
+    testfailuremsg "E: The repository 'file:${APTARCHIVE} unstable Release' is no longer signed." aptget update

 
     assert_repo_is_intact
 }
 
 assert_repo_is_intact()
 {
 
     assert_repo_is_intact
 }
 
 assert_repo_is_intact()
 {

-    testequal "foo/unstable 2.0 all" apt list -q
-    testsuccess "" aptget install -y -s foo
-    testfailure "" aptget install -y evil
+    testsuccessequal "foo/unstable 2.0 all" apt list -q
+    testsuccess aptget install -y -s foo
+    testfailure aptget install -y evil
+    testsuccess aptget source foo --print-uris

 
     LISTDIR=rootdir/var/lib/apt/lists
     if ! ( ls $LISTDIR/*InRelease >/dev/null 2>&1 || 
 
     LISTDIR=rootdir/var/lib/apt/lists
     if ! ( ls $LISTDIR/*InRelease >/dev/null 2>&1 || 


@@ -53,8 +56,7 @@ assert_repo_is_intact()
 setupaptarchive_with_lists_clean()
 {
     setupaptarchive --no-update
 setupaptarchive_with_lists_clean()
 {
     setupaptarchive --no-update

-    rm -f rootdir/var/lib/apt/lists/_*
-    #rm -rf rootdir/var/lib/apt/lists
+    rm -rf rootdir/var/lib/apt/lists

 }
 
 test_from_inrelease_to_unsigned()
 }
 
 test_from_inrelease_to_unsigned()


@@ -62,9 +64,11 @@ test_from_inrelease_to_unsigned()
     # setup archive with InRelease file
     setupaptarchive_with_lists_clean
     testsuccess aptget update
     # setup archive with InRelease file
     setupaptarchive_with_lists_clean
     testsuccess aptget update

+    listcurrentlistsdirectory > lists.before

 
     simulate_mitm_and_inject_evil_package
     assert_update_is_refused_and_last_good_state_used
 
     simulate_mitm_and_inject_evil_package
     assert_update_is_refused_and_last_good_state_used

+    testfileequal lists.before "$(listcurrentlistsdirectory)"

 }
 
 test_from_release_gpg_to_unsigned()
 }
 
 test_from_release_gpg_to_unsigned()


@@ -73,9 +77,31 @@ test_from_release_gpg_to_unsigned()
     setupaptarchive_with_lists_clean
     rm $APTARCHIVE/dists/unstable/InRelease
     testsuccess aptget update
     setupaptarchive_with_lists_clean
     rm $APTARCHIVE/dists/unstable/InRelease
     testsuccess aptget update

+    listcurrentlistsdirectory > lists.before

 
     simulate_mitm_and_inject_evil_package
     assert_update_is_refused_and_last_good_state_used
 
     simulate_mitm_and_inject_evil_package
     assert_update_is_refused_and_last_good_state_used

+    testfileequal lists.before "$(listcurrentlistsdirectory)"
+}
+
+test_from_inrelease_to_unsigned_with_override()
+{
+    # setup archive with InRelease file
+    setupaptarchive_with_lists_clean
+    testsuccess aptget update
+
+    # simulate moving to a unsigned but otherwise valid repo
+    simulate_mitm_and_inject_evil_package
+    generatereleasefiles '+2 hours'
+    find $APTARCHIVE -name '*Packages*' -exec touch -d '+2 hours' {} \;
+
+    # and ensure we can update to it (with enough force) 
+    testwarning aptget update --allow-insecure-repositories \
+        -o Acquire::AllowDowngradeToInsecureRepositories=1 -o Debug::pkgAcquire::Worker=1 -o Debug::pkgAcquire::Auth=1
+    # but that the individual packages are still considered untrusted
+    testfailureequal "WARNING: The following packages cannot be authenticated!
+  evil
+E: There were unauthenticated packages and -y was used without --allow-unauthenticated" aptget install -qq -y evil

 }
 
 test_cve_2012_0214()
 }
 
 test_cve_2012_0214()


@@ -89,7 +115,7 @@ test_cve_2012_0214()
     # the unauthenticated Release file too giving the false impression that
     # Release was authenticated
     #
     # the unauthenticated Release file too giving the false impression that
     # Release was authenticated
     #

-    # Note that this is pretty much impossible nowdays because:
+    # Note that this is pretty much impossible nowadays because:

     # a) InRelease is left as is, not split to InRelease/Release as it was 
     #    in the old days
     # b) we refuse to go from signed->unsigned
     # a) InRelease is left as is, not split to InRelease/Release as it was 
     #    in the old days
     # b) we refuse to go from signed->unsigned


@@ -99,6 +125,7 @@ test_cve_2012_0214()
     # setup archive with InRelease
     setupaptarchive_with_lists_clean
     testsuccess aptget update
     # setup archive with InRelease
     setupaptarchive_with_lists_clean
     testsuccess aptget update

+    listcurrentlistsdirectory > lists.before

 
     # do what CVE-2012-0214 did
     rm $APTARCHIVE/dists/unstable/InRelease
 
     # do what CVE-2012-0214 did
     rm $APTARCHIVE/dists/unstable/InRelease


@@ -108,6 +135,7 @@ test_cve_2012_0214()
     aptftparchive -qq release ./aptarchive > aptarchive/dists/unstable/Release 
 
     assert_update_is_refused_and_last_good_state_used
     aptftparchive -qq release ./aptarchive > aptarchive/dists/unstable/Release 
 
     assert_update_is_refused_and_last_good_state_used

+    testfileequal lists.before "$(listcurrentlistsdirectory)"

 
     # ensure there is no _Release file downloaded
     testfailure ls rootdir/var/lib/apt/lists/*_Release
 
     # ensure there is no _Release file downloaded
     testfailure ls rootdir/var/lib/apt/lists/*_Release


@@ -118,15 +146,16 @@ test_subvert_inrelease()
     # setup archive with InRelease
     setupaptarchive_with_lists_clean
     testsuccess aptget update
     # setup archive with InRelease
     setupaptarchive_with_lists_clean
     testsuccess aptget update

+    listcurrentlistsdirectory > lists.before

 
     # replace InRelease with something else
     mv $APTARCHIVE/dists/unstable/Release $APTARCHIVE/dists/unstable/InRelease
 
 
     # replace InRelease with something else
     mv $APTARCHIVE/dists/unstable/Release $APTARCHIVE/dists/unstable/InRelease
 

-    testequal "W: Failed to fetch file:${APTARCHIVE}/dists/unstable/InRelease  Does not start with a cleartext signature
-
-E: Some index files failed to download. They have been ignored, or old ones used instead." aptget update -qq
+    testfailuremsg "W: Failed to fetch file:${APTARCHIVE}/dists/unstable/InRelease  Clearsigned file isn't valid, got 'NOSPLIT' (does the network require authentication?)
+E: Some index files failed to download. They have been ignored, or old ones used instead." aptget update

 
     # ensure we keep the repo
 
     # ensure we keep the repo

+    testfileequal lists.before "$(listcurrentlistsdirectory)"

     assert_repo_is_intact
 }
 
     assert_repo_is_intact
 }
 


@@ -135,20 +164,20 @@ test_inrelease_to_invalid_inrelease()
     # setup archive with InRelease
     setupaptarchive_with_lists_clean
     testsuccess aptget update
     # setup archive with InRelease
     setupaptarchive_with_lists_clean
     testsuccess aptget update

+    listcurrentlistsdirectory > lists.before

 
     # now remove InRelease and subvert Release do no longer verify
 
     # now remove InRelease and subvert Release do no longer verify

-    sed -i 's/Codename.*/Codename: evil!'/ $APTARCHIVE/dists/unstable/InRelease
+    sed -i 's/^Codename:.*/Codename: evil!/' $APTARCHIVE/dists/unstable/InRelease

     inject_evil_package
 
     inject_evil_package
 

-    testequal "W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: file: unstable InRelease: The following signatures were invalid: BADSIG 5A90D141DBAC8DAE Joe Sixpack (APT Testcases Dummy) <joe@example.org>
-
-W: Failed to fetch file:${APTARCHIVE}/dists/unstable/InRelease  
-
+    testwarningequal "W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: file:${APTARCHIVE} unstable InRelease: The following signatures were invalid: BADSIG 5A90D141DBAC8DAE Joe Sixpack (APT Testcases Dummy) <joe@example.org>
+W: Failed to fetch file:${APTARCHIVE}/dists/unstable/InRelease  The following signatures were invalid: BADSIG 5A90D141DBAC8DAE Joe Sixpack (APT Testcases Dummy) <joe@example.org>

 W: Some index files failed to download. They have been ignored, or old ones used instead." aptget update -qq
 
     # ensure we keep the repo
 W: Some index files failed to download. They have been ignored, or old ones used instead." aptget update -qq
 
     # ensure we keep the repo

+    testfailure grep 'evil' rootdir/var/lib/apt/lists/*InRelease
+    testfileequal lists.before "$(listcurrentlistsdirectory)"

     assert_repo_is_intact
     assert_repo_is_intact

-    testfailure grep "evil" rootdir/var/lib/apt/lists/*InRelease

 }
 
 test_release_gpg_to_invalid_release_release_gpg()
 }
 
 test_release_gpg_to_invalid_release_release_gpg()


@@ -157,15 +186,19 @@ test_release_gpg_to_invalid_release_release_gpg()
     setupaptarchive_with_lists_clean
     rm $APTARCHIVE/dists/unstable/InRelease
     testsuccess aptget update
     setupaptarchive_with_lists_clean
     rm $APTARCHIVE/dists/unstable/InRelease
     testsuccess aptget update

+    listcurrentlistsdirectory > lists.before

 
     # now subvert Release do no longer verify
     echo "Some evil data" >>  $APTARCHIVE/dists/unstable/Release
     inject_evil_package
 
 
     # now subvert Release do no longer verify
     echo "Some evil data" >>  $APTARCHIVE/dists/unstable/Release
     inject_evil_package
 

-    testequal "E: The repository 'file: unstable Release.gpg' is no longer signed." aptget update -qq
+    testwarningequal "W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: file:${APTARCHIVE} unstable Release: The following signatures were invalid: BADSIG 5A90D141DBAC8DAE Joe Sixpack (APT Testcases Dummy) <joe@example.org>
+W: Failed to fetch file:${APTARCHIVE}/dists/unstable/Release.gpg  The following signatures were invalid: BADSIG 5A90D141DBAC8DAE Joe Sixpack (APT Testcases Dummy) <joe@example.org>
+W: Some index files failed to download. They have been ignored, or old ones used instead." aptget update -qq

 
 

+    testfailure grep 'evil' rootdir/var/lib/apt/lists/*Release
+    testfileequal lists.before "$(listcurrentlistsdirectory)"

     assert_repo_is_intact
     assert_repo_is_intact

-    testfailure grep "evil" rootdir/var/lib/apt/lists/*Release

 }
 
 
 }
 
 


@@ -205,3 +238,7 @@ test_inrelease_to_invalid_inrelease
 # ensure we revert to last good state if Release/Release.gpg does not verify
 msgmsg "test_release_gpg_to_invalid_release_release_gpg"
 test_release_gpg_to_invalid_release_release_gpg
 # ensure we revert to last good state if Release/Release.gpg does not verify
 msgmsg "test_release_gpg_to_invalid_release_release_gpg"
 test_release_gpg_to_invalid_release_release_gpg

+
+# ensure we can override the downgrade error
+msgmsg "test_from_inrelease_to_unsigned_with_override"
+test_from_inrelease_to_unsigned_with_override