test framework: Correctly generate new paths in noopchroot

[apt.git] / apt-pkg / contrib / cmndline.cc

diff --git a/apt-pkg/contrib/cmndline.cc b/apt-pkg/contrib/cmndline.cc
index bfd53695e38ab3b438807e6a9a65380441ab0389..c8a6e27873341cd3129394facc283e5953740451 100644 (file)
--- a/apt-pkg/contrib/cmndline.cc
+++ b/apt-pkg/contrib/cmndline.cc
@@ -11,11 +11,19 @@
    ##################################################################### */
                                                                        /*}}}*/
 // Include files                                                       /*{{{*/
    ##################################################################### */
                                                                        /*}}}*/
 // Include files                                                       /*{{{*/

+#include<config.h>
+
+#include <apt-pkg/configuration.h>

 #include <apt-pkg/cmndline.h>
 #include <apt-pkg/error.h>
 #include <apt-pkg/strutl.h>
 
 #include <apt-pkg/cmndline.h>
 #include <apt-pkg/error.h>
 #include <apt-pkg/strutl.h>
 

-#include <apti18n.h>    
+#include <stddef.h>
+#include <stdlib.h>
+#include <string.h>
+#include <string>
+
+#include <apti18n.h>

                                                                        /*}}}*/
 using namespace std;
 
                                                                        /*}}}*/
 using namespace std;
 


@@ -25,6 +33,9 @@ using namespace std;
 CommandLine::CommandLine(Args *AList,Configuration *Conf) : ArgList(AList), 
                                  Conf(Conf), FileList(0)
 {
 CommandLine::CommandLine(Args *AList,Configuration *Conf) : ArgList(AList), 
                                  Conf(Conf), FileList(0)
 {

+}
+CommandLine::CommandLine() : ArgList(NULL), Conf(NULL), FileList(0)
+{

 }
                                                                        /*}}}*/
 // CommandLine::~CommandLine - Destructor                              /*{{{*/
 }
                                                                        /*}}}*/
 // CommandLine::~CommandLine - Destructor                              /*{{{*/


@@ -35,6 +46,45 @@ CommandLine::~CommandLine()
    delete [] FileList;
 }
                                                                        /*}}}*/
    delete [] FileList;
 }
                                                                        /*}}}*/

+// CommandLine::GetCommand - return the first non-option word          /*{{{*/
+char const * CommandLine::GetCommand(Dispatch const * const Map,
+      unsigned int const argc, char const * const * const argv)
+{
+   // if there is a -- on the line there must be the word we search for either
+   // before it (as -- marks the end of the options) or right after it (as we can't
+   // decide if the command is actually an option, given that in theory, you could
+   // have parameters named like commands)
+   for (size_t i = 1; i < argc; ++i)
+   {
+      if (strcmp(argv[i], "--") != 0)
+        continue;
+      // check if command is before --
+      for (size_t k = 1; k < i; ++k)
+        for (size_t j = 0; Map[j].Match != NULL; ++j)
+           if (strcmp(argv[k], Map[j].Match) == 0)
+              return Map[j].Match;
+      // see if the next token after -- is the command
+      ++i;
+      if (i < argc)
+        for (size_t j = 0; Map[j].Match != NULL; ++j)
+           if (strcmp(argv[i], Map[j].Match) == 0)
+              return Map[j].Match;
+      // we found a --, but not a command
+      return NULL;
+   }
+   // no --, so search for the first word matching a command
+   // FIXME: How like is it that an option parameter will be also a valid Match ?
+   for (size_t i = 1; i < argc; ++i)
+   {
+      if (*(argv[i]) == '-')
+        continue;
+      for (size_t j = 0; Map[j].Match != NULL; ++j)
+        if (strcmp(argv[i], Map[j].Match) == 0)
+           return Map[j].Match;
+   }
+   return NULL;
+}
+                                                                       /*}}}*/

 // CommandLine::Parse - Main action member                             /*{{{*/
 // ---------------------------------------------------------------------
 /* */
 // CommandLine::Parse - Main action member                             /*{{{*/
 // ---------------------------------------------------------------------
 /* */


@@ -74,7 +124,7 @@ bool CommandLine::Parse(int argc,const char **argv)
            Args *A;
            for (A = ArgList; A->end() == false && A->ShortOpt != *Opt; A++);
            if (A->end() == true)
            Args *A;
            for (A = ArgList; A->end() == false && A->ShortOpt != *Opt; A++);
            if (A->end() == true)

-              return _error->Error(_("Command line option '%c' [from %s] is not known."),*Opt,argv[I]);
+              return _error->Error(_("Command line option '%c' [from %s] is not understood in combination with the other options."),*Opt,argv[I]);

 
            if (HandleOpt(I,argc,argv,Opt,A) == false)
               return false;
 
            if (HandleOpt(I,argc,argv,Opt,A) == false)
               return false;


@@ -87,28 +137,28 @@ bool CommandLine::Parse(int argc,const char **argv)
       Opt++;
 
       // Match up to a = against the list
       Opt++;
 
       // Match up to a = against the list

-      const char *OptEnd = Opt;

       Args *A;
       Args *A;

-      for (; *OptEnd != 0 && *OptEnd != '='; OptEnd++);
-      for (A = ArgList; A->end() == false && 
-          stringcasecmp(Opt,OptEnd,A->LongOpt) != 0; A++);
+      const char *OptEnd = strchrnul(Opt, '=');
+      for (A = ArgList; A->end() == false &&
+          (A->LongOpt == 0 || stringcasecmp(Opt,OptEnd,A->LongOpt) != 0);
+          ++A);

       
       // Failed, look for a word after the first - (no-foo)
       bool PreceedMatch = false;
       if (A->end() == true)
       {
       
       // Failed, look for a word after the first - (no-foo)
       bool PreceedMatch = false;
       if (A->end() == true)
       {

-        for (; Opt != OptEnd && *Opt != '-'; Opt++);
-
-        if (Opt == OptEnd)
-           return _error->Error(_("Command line option %s is not understood"),argv[I]);
+         Opt = (const char*) memchr(Opt, '-', OptEnd - Opt);
+        if (Opt == NULL)
+           return _error->Error(_("Command line option %s is not understood in combination with the other options"),argv[I]);

         Opt++;
         
         for (A = ArgList; A->end() == false &&
         Opt++;
         
         for (A = ArgList; A->end() == false &&

-             stringcasecmp(Opt,OptEnd,A->LongOpt) != 0; A++);
+             (A->LongOpt == 0 || stringcasecmp(Opt,OptEnd,A->LongOpt) != 0);
+             ++A);

 
         // Failed again..
         if (A->end() == true && OptEnd - Opt != 1)
 
         // Failed again..
         if (A->end() == true && OptEnd - Opt != 1)

-           return _error->Error(_("Command line option %s is not understood"),argv[I]);
+           return _error->Error(_("Command line option %s is not understood in combination with the other options"),argv[I]);

 
         // The option could be a single letter option prefixed by a no-..
         if (A->end() == true)
 
         // The option could be a single letter option prefixed by a no-..
         if (A->end() == true)


@@ -116,7 +166,7 @@ bool CommandLine::Parse(int argc,const char **argv)
            for (A = ArgList; A->end() == false && A->ShortOpt != *Opt; A++);
            
            if (A->end() == true)
            for (A = ArgList; A->end() == false && A->ShortOpt != *Opt; A++);
            
            if (A->end() == true)

-              return _error->Error(_("Command line option %s is not understood"),argv[I]);
+              return _error->Error(_("Command line option %s is not understood in combination with the other options"),argv[I]);

         }
         
         // The option is not boolean
         }
         
         // The option is not boolean


@@ -135,7 +185,9 @@ bool CommandLine::Parse(int argc,const char **argv)
    for (; I != argc; I++)
       *Files++ = argv[I];
    *Files = 0;
    for (; I != argc; I++)
       *Files++ = argv[I];
    *Files = 0;

-   
+
+   SaveInConfig(argc, argv);
+

    return true;
 }
                                                                        /*}}}*/
    return true;
 }
                                                                        /*}}}*/


@@ -153,17 +205,11 @@ bool CommandLine::HandleOpt(int &I,int argc,const char *argv[],
 
    /* Determine the possible location of an option or 0 if their is
       no option */
 
    /* Determine the possible location of an option or 0 if their is
       no option */

-   if (Opt[1] == 0 || (Opt[1] == '=' && Opt[2] == 0))
+   if (Opt[1] == 0)

    {
       if (I + 1 < argc && argv[I+1][0] != '-')
         Argument = argv[I+1];
    {
       if (I + 1 < argc && argv[I+1][0] != '-')
         Argument = argv[I+1];

-      
-      // Equals was specified but we fell off the end!
-      if (Opt[1] == '=' && Argument == 0)
-        return _error->Error(_("Option %s requires an argument."),argv[I]);
-      if (Opt[1] == '=')
-        CertainArg = true;
-        
+

       IncI = 1;
    }
    else
       IncI = 1;
    }
    else


@@ -192,26 +238,15 @@ bool CommandLine::HandleOpt(int &I,int argc,const char *argv[],
       // Arbitrary item specification
       if ((A->Flags & ArbItem) == ArbItem)
       {
       // Arbitrary item specification
       if ((A->Flags & ArbItem) == ArbItem)
       {

-        const char *J;
-        for (J = Argument; *J != 0 && *J != '='; J++);
-        if (*J == 0)
+        const char * const J = strchr(Argument, '=');
+        if (J == nullptr)

            return _error->Error(_("Option %s: Configuration item specification must have an =<val>."),argv[I]);
 
            return _error->Error(_("Option %s: Configuration item specification must have an =<val>."),argv[I]);
 

-        // = is trailing
-        if (J[1] == 0)
-        {
-           if (I+1 >= argc)
-              return _error->Error(_("Option %s: Configuration item specification must have an =<val>."),argv[I]);
-           Conf->Set(string(Argument,J-Argument),string(argv[I++ +1]));
-        }
-        else
-           Conf->Set(string(Argument,J-Argument),string(J+1));
-        
+        Conf->Set(string(Argument,J-Argument), J+1);

         return true;
       }
       
         return true;
       }
       

-      const char *I = A->ConfName;
-      for (; *I != 0 && *I != ' '; I++);
+      const char *I = strchrnul(A->ConfName, ' ');

       if (*I == ' ')
         Conf->Set(string(A->ConfName,0,I-A->ConfName),string(I+1) + Argument);
       else
       if (*I == ' ')
         Conf->Set(string(A->ConfName,0,I-A->ConfName),string(I+1) + Argument);
       else


@@ -254,7 +289,7 @@ bool CommandLine::HandleOpt(int &I,int argc,const char *argv[],
    // Look for an argument.
    while (1)
    {
    // Look for an argument.
    while (1)
    {

-      // Look at preceeding text
+      // Look at preceding text

       char Buffer[300];
       if (Argument == 0)
       {
       char Buffer[300];
       if (Argument == 0)
       {


@@ -267,10 +302,9 @@ bool CommandLine::HandleOpt(int &I,int argc,const char *argv[],
         // Skip the leading dash
         const char *J = argv[I];
         for (; *J != 0 && *J == '-'; J++);
         // Skip the leading dash
         const char *J = argv[I];
         for (; *J != 0 && *J == '-'; J++);

-        
-        const char *JEnd = J;
-        for (; *JEnd != 0 && *JEnd != '-'; JEnd++);
-        if (*JEnd != 0)
+
+        const char *JEnd = strchr(J, '-');
+        if (JEnd != NULL)

         {
            strncpy(Buffer,J,JEnd - J);
            Buffer[JEnd - J] = 0;
         {
            strncpy(Buffer,J,JEnd - J);
            Buffer[JEnd - J] = 0;


@@ -325,9 +359,7 @@ unsigned int CommandLine::FileSize() const
 }
                                                                        /*}}}*/
 // CommandLine::DispatchArg - Do something with the first arg          /*{{{*/
 }
                                                                        /*}}}*/
 // CommandLine::DispatchArg - Do something with the first arg          /*{{{*/

-// ---------------------------------------------------------------------
-/* */
-bool CommandLine::DispatchArg(Dispatch *Map,bool NoMatch)
+bool CommandLine::DispatchArg(Dispatch const * const Map,bool NoMatch)

 {
    int I;
    for (I = 0; Map[I].Match != 0; I++)
 {
    int I;
    for (I = 0; Map[I].Match != 0; I++)


@@ -349,5 +381,60 @@ bool CommandLine::DispatchArg(Dispatch *Map,bool NoMatch)
    }
    
    return false;
    }
    
    return false;

+}
+bool CommandLine::DispatchArg(Dispatch *Map,bool NoMatch)
+{
+   Dispatch const * const Map2 = Map;
+   return DispatchArg(Map2, NoMatch);
+}
+                                                                       /*}}}*/
+// CommandLine::SaveInConfig - for output later in a logfile or so     /*{{{*/
+// ---------------------------------------------------------------------
+/* We save the commandline here to have it around later for e.g. logging.
+   It feels a bit like a hack here and isn't bulletproof, but it is better
+   than nothing after all. */
+void CommandLine::SaveInConfig(unsigned int const &argc, char const * const * const argv)
+{
+   char cmdline[100 + argc * 50];
+   memset(cmdline, 0, sizeof(cmdline));
+   unsigned int length = 0;
+   bool lastWasOption = false;
+   bool closeQuote = false;
+   for (unsigned int i = 0; i < argc && length < sizeof(cmdline); ++i, ++length)
+   {
+      for (unsigned int j = 0; argv[i][j] != '\0' && length < sizeof(cmdline)-1; ++j, ++length)
+      {
+        cmdline[length] = argv[i][j];
+        if (lastWasOption == true && argv[i][j] == '=')
+        {
+           // That is possibly an option: Quote it if it includes spaces,
+           // the benefit is that this will eliminate also most false positives
+           const char* c = strchr(&argv[i][j+1], ' ');
+           if (c == NULL) continue;
+           cmdline[++length] = '"';
+           closeQuote = true;
+        }
+      }
+      if (closeQuote == true)
+        cmdline[length++] = '"';
+      // Problem: detects also --hello
+      if (cmdline[length-1] == 'o')
+        lastWasOption = true;
+      cmdline[length] = ' ';
+   }
+   cmdline[--length] = '\0';
+   _config->Set("CommandLine::AsString", cmdline);
+}
+                                                                       /*}}}*/
+CommandLine::Args CommandLine::MakeArgs(char ShortOpt, char const *LongOpt, char const *ConfName, unsigned long Flags)/*{{{*/
+{
+   /* In theory, this should be a constructor for CommandLine::Args instead,
+      but this breaks compatibility as gcc thinks this is a c++11 initializer_list */
+   CommandLine::Args arg;
+   arg.ShortOpt = ShortOpt;
+   arg.LongOpt = LongOpt;
+   arg.ConfName = ConfName;
+   arg.Flags = Flags;
+   return arg;

 }
                                                                        /*}}}*/
 }
                                                                        /*}}}*/