Minor cleanups, fix for checksum lowercase bug

[apt.git] / apt-pkg / deb / dpkgpm.cc

diff --git a/apt-pkg/deb/dpkgpm.cc b/apt-pkg/deb/dpkgpm.cc
index 9322a868d9d434e0d27197ba30818c392b3cfee9..7645929dbd1383d0c27099116e0886f390127c84 100644 (file)
--- a/apt-pkg/deb/dpkgpm.cc
+++ b/apt-pkg/deb/dpkgpm.cc
@@ -1,6 +1,6 @@
 // -*- mode: cpp; mode: fold -*-
 // Description                                                         /*{{{*/
-// $Id: dpkgpm.cc,v 1.6 1999/01/31 08:49:39 jgg Exp $
+// $Id: dpkgpm.cc,v 1.12 1999/07/26 17:46:08 jgg Exp $
 /* ######################################################################
 
    DPKG Package Manager - Provide an interface to dpkg
@@ -65,12 +65,15 @@ bool pkgDPkgPM::Configure(PkgIterator Pkg)
 // DPkgPM::Remove - Remove a package                                   /*{{{*/
 // ---------------------------------------------------------------------
 /* Add a remove operation to the sequence list */
-bool pkgDPkgPM::Remove(PkgIterator Pkg)
+bool pkgDPkgPM::Remove(PkgIterator Pkg,bool Purge)
 {
    if (Pkg.end() == true)
       return false;
    
-   List.push_back(Item(Item::Remove,Pkg));
+   if (Purge == true)
+      List.push_back(Item(Item::Purge,Pkg));
+   else
+      List.push_back(Item(Item::Remove,Pkg));
    return true;
 }
                                                                        /*}}}*/
@@ -86,27 +89,14 @@ bool pkgDPkgPM::RunScripts(const char *Cnf)
    Opts = Opts->Child;
 
    // Fork for running the system calls
-   pid_t Child = fork();
-   if (Child < 0)
-      return _error->Errno("fork","Could't fork");
+   pid_t Child = ExecFork();
    
    // This is the child
    if (Child == 0)
    {
-      signal(SIGPIPE,SIG_DFL);
-      signal(SIGQUIT,SIG_DFL);
-      signal(SIGINT,SIG_DFL);
-      signal(SIGWINCH,SIG_DFL);
-      signal(SIGCONT,SIG_DFL);
-      signal(SIGTSTP,SIG_DFL);
-      
       if (chdir("/tmp/") != 0)
         _exit(100);
         
-      // Close all of our FDs - just in case
-      for (int K = 3; K != 40; K++)
-        fcntl(K,F_SETFD,FD_CLOEXEC);
-
       unsigned int Count = 1;
       for (; Opts != 0; Opts = Opts->Next, Count++)
       {
@@ -131,7 +121,7 @@ bool pkgDPkgPM::RunScripts(const char *Cnf)
    // Restore sig int/quit
    signal(SIGQUIT,SIG_DFL);
    signal(SIGINT,SIG_DFL);   
-       
+
    // Check for an error code.
    if (WIFEXITED(Status) == 0 || WEXITSTATUS(Status) != 0)
    {
@@ -140,7 +130,7 @@ bool pkgDPkgPM::RunScripts(const char *Cnf)
       {
         Count -= 100;
         for (; Opts != 0 && Count != 1; Opts = Opts->Next, Count--);
-        _error->Error("Probablem executing scripts %s '%s'",Cnf,Opts->Value.c_str());
+        _error->Error("Problem executing scripts %s '%s'",Cnf,Opts->Value.c_str());
       }
       
       return _error->Error("Sub-process returned an error code");
@@ -197,6 +187,15 @@ bool pkgDPkgPM::Go()
         Size += strlen(Args[n-1]);
         break;
         
+        case Item::Purge:
+        Args[n++] = "--force-depends";
+        Size += strlen(Args[n-1]);
+        Args[n++] = "--force-remove-essential";
+        Size += strlen(Args[n-1]);
+        Args[n++] = "--purge";
+        Size += strlen(Args[n-1]);
+        break;
+        
         case Item::Configure:
         Args[n++] = "--configure";
         Size += strlen(Args[n-1]);
@@ -213,6 +212,8 @@ bool pkgDPkgPM::Go()
       {
         for (;I != J && Size < 1024; I++)
         {
+           if (I->File[0] != '/')
+              return _error->Error("Internal Error, Pathname to install is not absolute '%s'",I->File.c_str());
            Args[n++] = I->File.c_str();
            Size += strlen(Args[n-1]);
         }
@@ -248,27 +249,14 @@ bool pkgDPkgPM::Go()
       signal(SIGINT,SIG_IGN);
                     
       // Fork dpkg
-      pid_t Child = fork();
-      if (Child < 0)
-        return _error->Errno("fork","Could't fork");
+      pid_t Child = ExecFork();
             
       // This is the child
       if (Child == 0)
       {
-        signal(SIGPIPE,SIG_DFL);
-        signal(SIGQUIT,SIG_DFL);
-        signal(SIGINT,SIG_DFL);
-        signal(SIGWINCH,SIG_DFL);
-        signal(SIGCONT,SIG_DFL);
-        signal(SIGTSTP,SIG_DFL);
-        
-        if (chdir(_config->FindDir("Dir::Cache::Archives").c_str()) != 0)
+        if (chdir(_config->FindDir("DPkg::Run-Directory","/").c_str()) != 0)
            _exit(100);
         
-        // Close all of our FDs - just in case
-        for (int K = 3; K != 40; K++)
-           fcntl(K,F_SETFD,FD_CLOEXEC);
-
         int Flags,dummy;
         if ((Flags = fcntl(STDIN_FILENO,F_GETFL,dummy)) < 0)
            _exit(100);
@@ -308,7 +296,13 @@ bool pkgDPkgPM::Go()
       if (WIFEXITED(Status) == 0 || WEXITSTATUS(Status) != 0)
       {
         RunScripts("DPkg::Post-Invoke");
-        return _error->Error("Sub-process returned an error code");
+        if (WIFSIGNALED(Status) != 0 && WTERMSIG(Status) == SIGSEGV)
+           return _error->Error("Sub-process recieved a segmentation fault.");
+           
+        if (WIFEXITED(Status) != 0)
+           return _error->Error("Sub-process returned an error code (%u)",WEXITSTATUS(Status));
+        
+        return _error->Error("Sub-process exited unexpectedly");
       }      
    }
 
@@ -317,3 +311,11 @@ bool pkgDPkgPM::Go()
    return true;
 }
                                                                        /*}}}*/
+// pkgDpkgPM::Reset - Dump the contents of the command list            /*{{{*/
+// ---------------------------------------------------------------------
+/* */
+void pkgDPkgPM::Reset() 
+{
+   List.erase(List.begin(),List.end());
+}
+                                                                       /*}}}*/