allow http protocol to switch to https

[apt.git] / methods / rsh.cc

diff --git a/methods/rsh.cc b/methods/rsh.cc
index f0ccfc42d2890513c0b5048943915da75afcc184..4e1aaea26d4b2965fde61d2dd35ffe265396775e 100644 (file)
--- a/methods/rsh.cc
+++ b/methods/rsh.cc
@@ -11,17 +11,22 @@
    ##################################################################### */
                                                                        /*}}}*/
 // Include Files                                                       /*{{{*/
    ##################################################################### */
                                                                        /*}}}*/
 // Include Files                                                       /*{{{*/

-#include "rsh.h"
+#include <config.h>
+

 #include <apt-pkg/error.h>
 #include <apt-pkg/error.h>

+#include <apt-pkg/fileutl.h>
+#include <apt-pkg/hashes.h>
+#include <apt-pkg/configuration.h>

 
 #include <sys/stat.h>
 #include <sys/time.h>
 
 #include <sys/stat.h>
 #include <sys/time.h>

-#include <utime.h>

 #include <unistd.h>
 #include <signal.h>
 #include <stdio.h>
 #include <errno.h>
 #include <stdarg.h>
 #include <unistd.h>
 #include <signal.h>
 #include <stdio.h>
 #include <errno.h>
 #include <stdarg.h>

+#include "rsh.h"
+

 #include <apti18n.h>
                                                                        /*}}}*/
 
 #include <apti18n.h>
                                                                        /*}}}*/
 


@@ -29,14 +34,16 @@ const char *Prog;
 unsigned long TimeOut = 120;
 Configuration::Item const *RshOptions = 0;
 time_t RSHMethod::FailTime = 0;
 unsigned long TimeOut = 120;
 Configuration::Item const *RshOptions = 0;
 time_t RSHMethod::FailTime = 0;

-string RSHMethod::FailFile;
+std::string RSHMethod::FailFile;

 int RSHMethod::FailFd = -1;
 
 // RSHConn::RSHConn - Constructor                                      /*{{{*/
 // ---------------------------------------------------------------------
 /* */
 RSHConn::RSHConn(URI Srv) : Len(0), WriteFd(-1), ReadFd(-1),
 int RSHMethod::FailFd = -1;
 
 // RSHConn::RSHConn - Constructor                                      /*{{{*/
 // ---------------------------------------------------------------------
 /* */
 RSHConn::RSHConn(URI Srv) : Len(0), WriteFd(-1), ReadFd(-1),

-                            ServerName(Srv), Process(-1) {}
+                            ServerName(Srv), Process(-1) {
+   Buffer[0] = '\0';
+}

                                                                        /*}}}*/
 // RSHConn::RSHConn - Destructor                                       /*{{{*/
 // ---------------------------------------------------------------------
                                                                        /*}}}*/
 // RSHConn::RSHConn - Destructor                                       /*{{{*/
 // ---------------------------------------------------------------------


@@ -82,7 +89,7 @@ bool RSHConn::Open()
 // RSHConn::Connect - Fire up rsh and connect                          /*{{{*/
 // ---------------------------------------------------------------------
 /* */
 // RSHConn::Connect - Fire up rsh and connect                          /*{{{*/
 // ---------------------------------------------------------------------
 /* */

-bool RSHConn::Connect(string Host, string User)
+bool RSHConn::Connect(std::string Host, std::string User)

 {
    // Create the pipes
    int Pipes[4] = {-1,-1,-1,-1};
 {
    // Create the pipes
    int Pipes[4] = {-1,-1,-1,-1};


@@ -110,6 +117,8 @@ bool RSHConn::Connect(string Host, string User)
       // Probably should do
       // dup2(open("/dev/null",O_RDONLY),STDERR_FILENO);
 
       // Probably should do
       // dup2(open("/dev/null",O_RDONLY),STDERR_FILENO);
 

+      Args[i++] = Prog;
+

       // Insert user-supplied command line options
       Configuration::Item const *Opts = RshOptions;
       if (Opts != 0)
       // Insert user-supplied command line options
       Configuration::Item const *Opts = RshOptions;
       if (Opts != 0)


@@ -123,7 +132,6 @@ bool RSHConn::Connect(string Host, string User)
          }
       }
 
          }
       }
 

-      Args[i++] = Prog;

       if (User.empty() == false) {
          Args[i++] = "-l";
         Args[i++] = User.c_str();
       if (User.empty() == false) {
          Args[i++] = "-l";
         Args[i++] = User.c_str();


@@ -150,7 +158,7 @@ bool RSHConn::Connect(string Host, string User)
 // RSHConn::ReadLine - Very simple buffered read with timeout          /*{{{*/
 // ---------------------------------------------------------------------
 /* */
 // RSHConn::ReadLine - Very simple buffered read with timeout          /*{{{*/
 // ---------------------------------------------------------------------
 /* */

-bool RSHConn::ReadLine(string &Text)
+bool RSHConn::ReadLine(std::string &Text)

 {
    if (Process == -1 || ReadFd == -1)
       return false;
 {
    if (Process == -1 || ReadFd == -1)
       return false;


@@ -170,7 +178,7 @@ bool RSHConn::ReadLine(string &Text)
             continue;
 
          I++;
             continue;
 
          I++;

-         Text = string(Buffer,I);
+         Text = std::string(Buffer,I);

          memmove(Buffer,Buffer+I,Len - I);
          Len -= I;
          return true;
          memmove(Buffer,Buffer+I,Len - I);
          Len -= I;
          return true;


@@ -201,7 +209,7 @@ bool RSHConn::ReadLine(string &Text)
 // ---------------------------------------------------------------------
 /* The remote sync flag appends a || echo which will insert blank line
    once the command completes. */
 // ---------------------------------------------------------------------
 /* The remote sync flag appends a || echo which will insert blank line
    once the command completes. */

-bool RSHConn::WriteMsg(string &Text,bool Sync,const char *Fmt,...)
+bool RSHConn::WriteMsg(std::string &Text,bool Sync,const char *Fmt,...)

 {
    va_list args;
    va_start(args,Fmt);
 {
    va_list args;
    va_start(args,Fmt);


@@ -209,6 +217,8 @@ bool RSHConn::WriteMsg(string &Text,bool Sync,const char *Fmt,...)
    // sprintf the description
    char S[512];
    vsnprintf(S,sizeof(S) - 4,Fmt,args);
    // sprintf the description
    char S[512];
    vsnprintf(S,sizeof(S) - 4,Fmt,args);

+   va_end(args);
+

    if (Sync == true)
       strcat(S," 2> /dev/null || echo\n");
    else
    if (Sync == true)
       strcat(S," 2> /dev/null || echo\n");
    else


@@ -247,10 +257,10 @@ bool RSHConn::WriteMsg(string &Text,bool Sync,const char *Fmt,...)
 // ---------------------------------------------------------------------
 /* Right now for successfull transfer the file size must be known in 
    advance. */
 // ---------------------------------------------------------------------
 /* Right now for successfull transfer the file size must be known in 
    advance. */

-bool RSHConn::Size(const char *Path,unsigned long &Size)
+bool RSHConn::Size(const char *Path,unsigned long long &Size)

 {
    // Query the size
 {
    // Query the size

-   string Msg;
+       std::string Msg;

    Size = 0;
 
    if (WriteMsg(Msg,true,"find %s -follow -printf '%%s\\n'",Path) == false)
    Size = 0;
 
    if (WriteMsg(Msg,true,"find %s -follow -printf '%%s\\n'",Path) == false)


@@ -259,7 +269,7 @@ bool RSHConn::Size(const char *Path,unsigned long &Size)
    // FIXME: Sense if the bad reply is due to a File Not Found. 
    
    char *End;
    // FIXME: Sense if the bad reply is due to a File Not Found. 
    
    char *End;

-   Size = strtoul(Msg.c_str(),&End,10);
+   Size = strtoull(Msg.c_str(),&End,10);

    if (End == Msg.c_str())
       return _error->Error(_("File not found"));
    return true;
    if (End == Msg.c_str())
       return _error->Error(_("File not found"));
    return true;


@@ -272,21 +282,20 @@ bool RSHConn::ModTime(const char *Path, time_t &Time)
 {
    Time = time(&Time);
    // Query the mod time
 {
    Time = time(&Time);
    // Query the mod time

-   string Msg;
+   std::string Msg;

 
    if (WriteMsg(Msg,true,"TZ=UTC find %s -follow -printf '%%TY%%Tm%%Td%%TH%%TM%%TS\\n'",Path) == false)
       return false;
 
    // Parse it
 
    if (WriteMsg(Msg,true,"TZ=UTC find %s -follow -printf '%%TY%%Tm%%Td%%TH%%TM%%TS\\n'",Path) == false)
       return false;
 
    // Parse it

-   StrToTime(Msg,Time);
-   return true;
+   return FTPMDTMStrToTime(Msg.c_str(), Time);

 }
                                                                        /*}}}*/
 // RSHConn::Get - Get a file                                           /*{{{*/
 // ---------------------------------------------------------------------
 /* */
 }
                                                                        /*}}}*/
 // RSHConn::Get - Get a file                                           /*{{{*/
 // ---------------------------------------------------------------------
 /* */

-bool RSHConn::Get(const char *Path,FileFd &To,unsigned long Resume,
-                  Hashes &Hash,bool &Missing, unsigned long Size)
+bool RSHConn::Get(const char *Path,FileFd &To,unsigned long long Resume,
+                  Hashes &Hash,bool &Missing, unsigned long long Size)

 {
    Missing = false;
 
 {
    Missing = false;
 


@@ -299,19 +308,19 @@ bool RSHConn::Get(const char *Path,FileFd &To,unsigned long Resume,
       return false;
 
    if (Resume != 0) {
       return false;
 
    if (Resume != 0) {

-      if (Hash.AddFD(To.Fd(),Resume) == false) {
+      if (Hash.AddFD(To,Resume) == false) {

         _error->Errno("read",_("Problem hashing file"));
         return false;
       }
    }
    
    // FIXME: Detect file-not openable type errors.
         _error->Errno("read",_("Problem hashing file"));
         return false;
       }
    }
    
    // FIXME: Detect file-not openable type errors.

-   string Jnk;
+   std::string Jnk;

    if (WriteMsg(Jnk,false,"dd if=%s bs=2048 skip=%u", Path, Resume / 2048) == false)
       return false;
 
    // Copy loop
    if (WriteMsg(Jnk,false,"dd if=%s bs=2048 skip=%u", Path, Resume / 2048) == false)
       return false;
 
    // Copy loop

-   unsigned int MyLen = Resume;
+   unsigned long long MyLen = Resume;

    unsigned char Buffer[4096];
    while (MyLen < Size)
    {
    unsigned char Buffer[4096];
    while (MyLen < Size)
    {


@@ -363,7 +372,7 @@ RSHMethod::RSHMethod() : pkgAcqMethod("1.0",SendConfig)
                                                                        /*}}}*/
 // RSHMethod::Configuration - Handle a configuration message           /*{{{*/
 // ---------------------------------------------------------------------
                                                                        /*}}}*/
 // RSHMethod::Configuration - Handle a configuration message           /*{{{*/
 // ---------------------------------------------------------------------

-bool RSHMethod::Configuration(string Message)
+bool RSHMethod::Configuration(std::string Message)

 {
    char ProgStr[100];
   
 {
    char ProgStr[100];
   


@@ -385,13 +394,14 @@ void RSHMethod::SigTerm(int sig)
 {
    if (FailFd == -1)
       _exit(100);
 {
    if (FailFd == -1)
       _exit(100);

-   close(FailFd);

 
 

-   // Timestamp
-   struct utimbuf UBuf;
-   UBuf.actime = FailTime;
-   UBuf.modtime = FailTime;
-   utime(FailFile.c_str(),&UBuf);
+   // Transfer the modification times
+   struct timeval times[2];
+   times[0].tv_sec = FailTime;
+   times[1].tv_sec = FailTime;
+   times[0].tv_usec = times[1].tv_usec = 0;
+   utimes(FailFile.c_str(), times);
+   close(FailFd);

 
    _exit(100);
 }
 
    _exit(100);
 }


@@ -425,7 +435,7 @@ bool RSHMethod::Fetch(FetchItem *Itm)
    Status(_("Connecting to %s"), Get.Host.c_str());
 
    // Get the files information
    Status(_("Connecting to %s"), Get.Host.c_str());
 
    // Get the files information

-   unsigned long Size;
+   unsigned long long Size;

    if (Server->Size(File,Size) == false ||
        Server->ModTime(File,FailTime) == false)
    {
    if (Server->Size(File,Size) == false ||
        Server->ModTime(File,FailTime) == false)
    {


@@ -446,7 +456,7 @@ bool RSHMethod::Fetch(FetchItem *Itm)
    // See if the file exists
    struct stat Buf;
    if (stat(Itm->DestFile.c_str(),&Buf) == 0) {
    // See if the file exists
    struct stat Buf;
    if (stat(Itm->DestFile.c_str(),&Buf) == 0) {

-      if (Size == (unsigned)Buf.st_size && FailTime == Buf.st_mtime) {
+      if (Size == (unsigned long long)Buf.st_size && FailTime == Buf.st_mtime) {

         Res.Size = Buf.st_size;
         Res.LastModified = Buf.st_mtime;
         Res.ResumePoint = Buf.st_size;
         Res.Size = Buf.st_size;
         Res.LastModified = Buf.st_mtime;
         Res.ResumePoint = Buf.st_size;


@@ -455,7 +465,7 @@ bool RSHMethod::Fetch(FetchItem *Itm)
       }
 
       // Resume?
       }
 
       // Resume?

-      if (FailTime == Buf.st_mtime && Size > (unsigned)Buf.st_size)
+      if (FailTime == Buf.st_mtime && Size > (unsigned long long)Buf.st_size)

         Res.ResumePoint = Buf.st_size;
    }
 
         Res.ResumePoint = Buf.st_size;
    }
 


@@ -478,10 +488,11 @@ bool RSHMethod::Fetch(FetchItem *Itm)
         Fd.Close();
 
         // Timestamp
         Fd.Close();
 
         // Timestamp

-        struct utimbuf UBuf;
-        UBuf.actime = FailTime;
-        UBuf.modtime = FailTime;
-        utime(FailFile.c_str(),&UBuf);
+        struct timeval times[2];
+        times[0].tv_sec = FailTime;
+        times[1].tv_sec = FailTime;
+        times[0].tv_usec = times[1].tv_usec = 0;
+        utimes(FailFile.c_str(), times);

 
         // If the file is missing we hard fail otherwise transient fail
         if (Missing == true)
 
         // If the file is missing we hard fail otherwise transient fail
         if (Missing == true)


@@ -491,18 +502,17 @@ bool RSHMethod::Fetch(FetchItem *Itm)
       }
 
       Res.Size = Fd.Size();
       }
 
       Res.Size = Fd.Size();

+      struct timeval times[2];
+      times[0].tv_sec = FailTime;
+      times[1].tv_sec = FailTime;
+      times[0].tv_usec = times[1].tv_usec = 0;
+      utimes(Fd.Name().c_str(), times);
+      FailFd = -1;

    }
 
    Res.LastModified = FailTime;
    Res.TakeHashes(Hash);
 
    }
 
    Res.LastModified = FailTime;
    Res.TakeHashes(Hash);
 

-   // Timestamp
-   struct utimbuf UBuf;
-   UBuf.actime = FailTime;
-   UBuf.modtime = FailTime;
-   utime(Queue->DestFile.c_str(),&UBuf);
-   FailFd = -1;
-

    URIDone(Res);
 
    return true;
    URIDone(Res);
 
    return true;