* cmdline/apt-get.cc

[apt.git] / apt-pkg / contrib / hashes.cc

diff --git a/apt-pkg/contrib/hashes.cc b/apt-pkg/contrib/hashes.cc
index da714f9970e22ebc45d171f0b3aa949158a84dd0..985d89d903ea502c448d28aa2bb819c121d8eb64 100644 (file)
--- a/apt-pkg/contrib/hashes.cc
+++ b/apt-pkg/contrib/hashes.cc
@@ -14,9 +14,9 @@
 #include <apt-pkg/hashes.h>
 #include <apt-pkg/fileutl.h>
 #include <apt-pkg/configuration.h>
 #include <apt-pkg/hashes.h>
 #include <apt-pkg/fileutl.h>
 #include <apt-pkg/configuration.h>

-    
+#include <apt-pkg/macros.h>
+

 #include <unistd.h>    
 #include <unistd.h>    

-#include <system.h>    

 #include <string>
 #include <iostream>
                                                                        /*}}}*/
 #include <string>
 #include <iostream>
                                                                        /*}}}*/


@@ -34,7 +34,7 @@ HashString::HashString(string Type, string Hash) : Type(Type), Hash(Hash)
 {
 }
 
 {
 }
 

-HashString::HashString(string StringedHash)
+HashString::HashString(string StringedHash)                            /*{{{*/

 {
    // legacy: md5sum without "MD5Sum:" prefix
    if (StringedHash.find(":") == string::npos && StringedHash.size() == 32)
 {
    // legacy: md5sum without "MD5Sum:" prefix
    if (StringedHash.find(":") == string::npos && StringedHash.size() == 32)


@@ -44,15 +44,14 @@ HashString::HashString(string StringedHash)
       return;
    }
    string::size_type pos = StringedHash.find(":");
       return;
    }
    string::size_type pos = StringedHash.find(":");

-   Type = StringedHash.substr(0,pos-1);
+   Type = StringedHash.substr(0,pos);

    Hash = StringedHash.substr(pos+1, StringedHash.size() - pos);
 
    if(_config->FindB("Debug::Hashes",false) == true)
       std::clog << "HashString(string): " << Type << " : " << Hash << std::endl;
 }
    Hash = StringedHash.substr(pos+1, StringedHash.size() - pos);
 
    if(_config->FindB("Debug::Hashes",false) == true)
       std::clog << "HashString(string): " << Type << " : " << Hash << std::endl;
 }

-
-
-bool HashString::VerifyFile(string filename) const
+                                                                       /*}}}*/
+bool HashString::VerifyFile(string filename) const                     /*{{{*/

 {
    FileFd fd;
    MD5Summation MD5;
 {
    FileFd fd;
    MD5Summation MD5;


@@ -83,7 +82,7 @@ bool HashString::VerifyFile(string filename) const
 
    return (fileHash == Hash);
 }
 
    return (fileHash == Hash);
 }

-
+                                                                       /*}}}*/

 const char** HashString::SupportedHashes()
 {
    return _SupportedHashes;
 const char** HashString::SupportedHashes()
 {
    return _SupportedHashes;


@@ -94,13 +93,11 @@ bool HashString::empty() const
    return (Type.empty() || Hash.empty());
 }
 
    return (Type.empty() || Hash.empty());
 }
 

-

 string HashString::toStr() const
 {
    return Type+string(":")+Hash;
 }
 
 string HashString::toStr() const
 {
    return Type+string(":")+Hash;
 }
 

-

 // Hashes::AddFD - Add the contents of the FD                          /*{{{*/
 // ---------------------------------------------------------------------
 /* */
 // Hashes::AddFD - Add the contents of the FD                          /*{{{*/
 // ---------------------------------------------------------------------
 /* */


@@ -108,11 +105,16 @@ bool Hashes::AddFD(int Fd,unsigned long Size)
 {
    unsigned char Buf[64*64];
    int Res = 0;
 {
    unsigned char Buf[64*64];
    int Res = 0;

-   while (Size != 0)
+   int ToEOF = (Size == 0);
+   while (Size != 0 || ToEOF)

    {
    {

-      Res = read(Fd,Buf,min(Size,(unsigned long)sizeof(Buf)));
-      if (Res < 0 || (unsigned)Res != min(Size,(unsigned long)sizeof(Buf)))
-        return false;
+      unsigned n = sizeof(Buf);
+      if (!ToEOF) n = min(Size,(unsigned long)n);
+      Res = read(Fd,Buf,n);
+      if (Res < 0 || (!ToEOF && (unsigned) Res != n)) // error, or short read
+         return false;
+      if (ToEOF && Res == 0) // EOF
+         break;

       Size -= Res;
       MD5.Add(Buf,Res);
       SHA1.Add(Buf,Res);
       Size -= Res;
       MD5.Add(Buf,Res);
       SHA1.Add(Buf,Res);