improve CheckDropPrivsMustBeDisabled further

[apt.git] / test / integration / test-releasefile-verification

diff --git a/test/integration/test-releasefile-verification b/test/integration/test-releasefile-verification
index 01fb2e529c194baab3638721ad4acf95be36da3e..60aa4421a1da28e937348fd16af5e29becee82a7 100755 (executable)
--- a/test/integration/test-releasefile-verification
+++ b/test/integration/test-releasefile-verification
@@ -11,75 +11,79 @@ buildaptarchive
 setupflataptarchive
 changetowebserver
 
 setupflataptarchive
 changetowebserver
 

+webserverconfig 'aptwebserver::support::range' 'false'
+

 prepare() {
        local DATE="${2:-now}"
 prepare() {
        local DATE="${2:-now}"

-       if [ "$DATE" = 'now' -a "$1" = "${PKGFILE}-new" ]; then
-               DATE='now + 6 days'
+       if [ "$DATE" = 'now' ]; then
+               if [ "$1" = "${PKGFILE}-new" ]; then
+                       DATE='now - 1 day'
+               else
+                       DATE='now - 7 day'
+               fi

        fi
        for release in $(find rootdir/var/lib/apt/lists 2> /dev/null); do
        fi
        for release in $(find rootdir/var/lib/apt/lists 2> /dev/null); do

-               touch -d 'now - 6 hours' $release
+               touch -d 'now - 1 year' $release

        done
        aptget clean
        cp $1 aptarchive/Packages
        find aptarchive -name 'Release' -delete
        done
        aptget clean
        cp $1 aptarchive/Packages
        find aptarchive -name 'Release' -delete

-       cat aptarchive/Packages | gzip > aptarchive/Packages.gz
-       cat aptarchive/Packages | bzip2 > aptarchive/Packages.bz2
-       cat aptarchive/Packages | xz --format=lzma > aptarchive/Packages.lzma
+       compressfile 'aptarchive/Packages' "$DATE"

        generatereleasefiles "$DATE"
 }
 
 installaptold() {
        generatereleasefiles "$DATE"
 }
 
 installaptold() {

-       testequal 'Reading package lists...
+       testsuccessequal 'Reading package lists...

 Building dependency tree...
 Suggested packages:
 Building dependency tree...
 Suggested packages:

-  aptitude synaptic wajig dpkg-dev apt-doc bzip2 lzma python-apt
+  aptitude | synaptic | wajig dpkg-dev apt-doc bzip2 lzma python-apt

 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5370 kB of additional disk space will be used.
 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5370 kB of additional disk space will be used.

-Get:1 http://localhost/  apt 0.7.25.3
+Get:1 http://localhost:8080  apt 0.7.25.3

 Download complete and in download only mode' aptget install apt -dy
 }
 
 installaptnew() {
 Download complete and in download only mode' aptget install apt -dy
 }
 
 installaptnew() {

-       testequal 'Reading package lists...
+       testsuccessequal 'Reading package lists...

 Building dependency tree...
 Suggested packages:
 Building dependency tree...
 Suggested packages:

-  aptitude synaptic wajig dpkg-dev apt-doc bzip2 lzma python-apt
+  aptitude | synaptic | wajig dpkg-dev apt-doc bzip2 lzma python-apt

 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5808 kB of additional disk space will be used.
 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5808 kB of additional disk space will be used.

-Get:1 http://localhost/  apt 0.8.0~pre1
+Get:1 http://localhost:8080  apt 0.8.0~pre1

 Download complete and in download only mode' aptget install apt -dy
 }
 
 failaptold() {
 Download complete and in download only mode' aptget install apt -dy
 }
 
 failaptold() {

-       testequal 'Reading package lists...
+       testfailureequal 'Reading package lists...

 Building dependency tree...
 Suggested packages:
 Building dependency tree...
 Suggested packages:

-  aptitude synaptic wajig dpkg-dev apt-doc bzip2 lzma python-apt
+  aptitude | synaptic | wajig dpkg-dev apt-doc bzip2 lzma python-apt

 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5370 kB of additional disk space will be used.
 WARNING: The following packages cannot be authenticated!
   apt
 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5370 kB of additional disk space will be used.
 WARNING: The following packages cannot be authenticated!
   apt

-E: There are problems and -y was used without --force-yes' aptget install apt -dy
+E: There were unauthenticated packages and -y was used without --allow-unauthenticated' aptget install apt -dy

 }
 
 failaptnew() {
 }
 
 failaptnew() {

-       testequal 'Reading package lists...
+       testfailureequal 'Reading package lists...

 Building dependency tree...
 Suggested packages:
 Building dependency tree...
 Suggested packages:

-  aptitude synaptic wajig dpkg-dev apt-doc bzip2 lzma python-apt
+  aptitude | synaptic | wajig dpkg-dev apt-doc bzip2 lzma python-apt

 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5808 kB of additional disk space will be used.
 WARNING: The following packages cannot be authenticated!
   apt
 The following NEW packages will be installed:
   apt
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 After this operation, 5808 kB of additional disk space will be used.
 WARNING: The following packages cannot be authenticated!
   apt

-E: There are problems and -y was used without --force-yes' aptget install apt -dy
+E: There were unauthenticated packages and -y was used without --allow-unauthenticated' aptget install apt -dy

 }
 
 # fake our downloadable file
 }
 
 # fake our downloadable file


@@ -87,48 +91,59 @@ touch aptarchive/apt.deb
 
 PKGFILE="${TESTDIR}/$(echo "$(basename $0)" | sed 's#^test-#Packages-#')"
 
 
 PKGFILE="${TESTDIR}/$(echo "$(basename $0)" | sed 's#^test-#Packages-#')"
 

+updatewithwarnings() {
+       testwarning aptget update -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
+       testsuccess grep -E "$1" rootdir/tmp/testwarning.output
+}
+

 runtest() {
        prepare ${PKGFILE}
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete
 runtest() {
        prepare ${PKGFILE}
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Cold archive signed by' 'Joe Sixpack'
-       aptget update 2>&1 | grep -E '^(W|E): ' > /dev/null && msgfail || msgpass
-       testequal "$(cat ${PKGFILE})
+       msgmsg 'Cold archive signed by' 'Joe Sixpack'
+       testsuccess aptget update
+       testsuccessequal "$(cat ${PKGFILE})

 " aptcache show apt
        installaptold
 
        prepare ${PKGFILE}-new
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete
 " aptcache show apt
        installaptold
 
        prepare ${PKGFILE}-new
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Good warm archive signed by' 'Joe Sixpack'
-       aptget update 2>&1 | grep -E '^(W|E): ' > /dev/null && msgfail || msgpass
-       testequal "$(cat ${PKGFILE}-new)
+       msgmsg 'Good warm archive signed by' 'Joe Sixpack'
+       testsuccess aptget update
+       testsuccessequal "$(cat ${PKGFILE}-new)

 " aptcache show apt
        installaptnew
 
 " aptcache show apt
        installaptnew
 

+       prepare ${PKGFILE}
+       rm -rf rootdir/var/lib/apt/lists
+       cp keys/rexexpired.pub rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg
+       signreleasefiles 'Rex Expired'
+       find aptarchive/ -name "$DELETEFILE" -delete
+       msgmsg 'Cold archive signed by' 'Rex Expired'
+       updatewithwarnings '^W: .* KEYEXPIRED'
+       testsuccessequal "$(cat ${PKGFILE})
+" aptcache show apt
+       failaptold
+       rm rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg

 
        prepare ${PKGFILE}
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Marvin Paranoid'
        find aptarchive/ -name "$DELETEFILE" -delete
 
        prepare ${PKGFILE}
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Marvin Paranoid'
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Cold archive signed by' 'Marvin Paranoid'
-       aptget update 2>&1 | grep -E '^(W|E): ' > /dev/null && msgpass || msgfail
-       testequal "$(cat ${PKGFILE})
+       msgmsg 'Cold archive signed by' 'Marvin Paranoid'
+       updatewithwarnings '^W: .* NO_PUBKEY'
+       testsuccessequal "$(cat ${PKGFILE})

 " aptcache show apt
        failaptold
 
        prepare ${PKGFILE}-new
 " aptcache show apt
        failaptold
 
        prepare ${PKGFILE}-new

-       # weborf doesn't support If-Range
-       for release in $(find rootdir/var/lib/apt/lists/partial/ -name '*Release'); do
-               rm $release
-               touch $release
-       done

        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Bad warm archive signed by' 'Joe Sixpack'
-       aptget update 2>&1 | grep -E '^(W|E): ' > /dev/null && msgfail || msgpass
-       testequal "$(cat ${PKGFILE}-new)
+       msgmsg 'Bad warm archive signed by' 'Joe Sixpack'
+       testsuccess aptget update
+       testsuccessequal "$(cat ${PKGFILE}-new)

 " aptcache show apt
        installaptnew
 
 " aptcache show apt
        installaptnew
 


@@ -137,52 +152,125 @@ runtest() {
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Cold archive signed by' 'Joe Sixpack'
-       aptget update 2>&1 | grep -E '^(W|E): ' > /dev/null && msgfail || msgpass
-       testequal "$(cat ${PKGFILE})
+       msgmsg 'Cold archive signed by' 'Joe Sixpack'
+       testsuccess aptget update
+       testsuccessequal "$(cat ${PKGFILE})
+" aptcache show apt
+       installaptold
+
+       prepare ${PKGFILE}-new
+       signreleasefiles 'Marvin Paranoid'
+       find aptarchive/ -name "$DELETEFILE" -delete
+       msgmsg 'Good warm archive signed by' 'Marvin Paranoid'
+       updatewithwarnings '^W: .* NO_PUBKEY'
+       testsuccessequal "$(cat ${PKGFILE})
+" aptcache show apt
+       installaptold
+
+       prepare ${PKGFILE}-new
+       cp keys/rexexpired.pub rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg
+       signreleasefiles 'Rex Expired'
+       find aptarchive/ -name "$DELETEFILE" -delete
+       msgmsg 'Good warm archive signed by' 'Rex Expired'
+       updatewithwarnings '^W: .* KEYEXPIRED'
+       testsuccessequal "$(cat ${PKGFILE})

 " aptcache show apt
        installaptold
 " aptcache show apt
        installaptold

+       rm rootdir/etc/apt/trusted.gpg.d/rexexpired.gpg

 
        prepare ${PKGFILE}-new
 
        prepare ${PKGFILE}-new

+       signreleasefiles
+       find aptarchive/ -name "$DELETEFILE" -delete
+       msgmsg 'Good warm archive signed by' 'Joe Sixpack'
+       testsuccess aptget update
+       testsuccessequal "$(cat ${PKGFILE}-new)
+" aptcache show apt
+       installaptnew
+
+       prepare ${PKGFILE}
+       rm -rf rootdir/var/lib/apt/lists
+       signreleasefiles 'Marvin Paranoid'
+       find aptarchive/ -name "$DELETEFILE" -delete
+       msgmsg 'Cold archive signed by good keyring' 'Marvin Paranoid'
+       local MARVIN="$(readlink -f keys/marvinparanoid.pub)"
+       sed -i "s#^\(deb\(-src\)\?\) #\1 [signed-by=$MARVIN] #" rootdir/etc/apt/sources.list.d/*
+       testsuccess aptget update -o Debug::pkgAcquire::Worker=1
+       testsuccessequal "$(cat ${PKGFILE})
+" aptcache show apt
+       installaptold
+
+       rm -rf rootdir/var/lib/apt/lists
+       signreleasefiles 'Joe Sixpack'
+       find aptarchive/ -name "$DELETEFILE" -delete
+       msgmsg 'Cold archive signed by bad keyring' 'Joe Sixpack'
+       updatewithwarnings '^W: .* NO_PUBKEY'
+
+       sed -i "s#^\(deb\(-src\)\?\) \[signed-by=$MARVIN\] #\1 #" rootdir/etc/apt/sources.list.d/*
+       local MARVIN="$(aptkey --keyring $MARVIN finger | grep 'Key fingerprint' | cut -d'=' -f 2 | tr -d ' ')"
+
+       prepare ${PKGFILE}
+       rm -rf rootdir/var/lib/apt/lists

        signreleasefiles 'Marvin Paranoid'
        find aptarchive/ -name "$DELETEFILE" -delete
        signreleasefiles 'Marvin Paranoid'
        find aptarchive/ -name "$DELETEFILE" -delete

-       msgtest 'Good warm archive signed by' 'Marvin Paranoid'
-       aptget update 2>&1 | grep -E '^(W|E): ' > /dev/null && msgpass || msgfail
-       testequal "$(cat ${PKGFILE})
+       msgmsg 'Cold archive signed by good keyid' 'Marvin Paranoid'
+       sed -i "s#^\(deb\(-src\)\?\) #\1 [signed-by=$MARVIN] #" rootdir/etc/apt/sources.list.d/*
+       cp keys/marvinparanoid.pub rootdir/etc/apt/trusted.gpg.d/marvinparanoid.gpg
+       testsuccess aptget update -o Debug::pkgAcquire::Worker=1 -o Debug::Acquire::gpgv=1
+       testsuccessequal "$(cat ${PKGFILE})

 " aptcache show apt
        installaptold
 " aptcache show apt
        installaptold

+       rm -f rootdir/etc/apt/trusted.gpg.d/marvinparanoid.gpg
+
+       rm -rf rootdir/var/lib/apt/lists
+       signreleasefiles 'Joe Sixpack'
+       find aptarchive/ -name "$DELETEFILE" -delete
+       msgmsg 'Cold archive signed by bad keyid' 'Joe Sixpack'
+       updatewithwarnings '^W: .* be verified because the public key is not available: .*'
+
+       sed -i "s#^\(deb\(-src\)\?\) \[signed-by=$MARVIN\] #\1 #" rootdir/etc/apt/sources.list.d/*

 }
 
 runtest2() {
        prepare ${PKGFILE}
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'
 }
 
 runtest2() {
        prepare ${PKGFILE}
        rm -rf rootdir/var/lib/apt/lists
        signreleasefiles 'Joe Sixpack'

-       msgtest 'Cold archive signed by' 'Joe Sixpack'
-       aptget update 2>&1 | grep -E '^(W|E): ' > /dev/null && msgfail || msgpass
+       msgmsg 'Cold archive signed by' 'Joe Sixpack'
+       testsuccess aptget update

 
        # New .deb but now an unsigned archive. For example MITM to circumvent
        # package verification.
        prepare ${PKGFILE}-new
        find aptarchive/ -name InRelease -delete
        find aptarchive/ -name Release.gpg -delete
 
        # New .deb but now an unsigned archive. For example MITM to circumvent
        # package verification.
        prepare ${PKGFILE}-new
        find aptarchive/ -name InRelease -delete
        find aptarchive/ -name Release.gpg -delete

-       msgtest 'Warm archive signed by' 'nobody'
-       aptget update 2>&1 | grep -E '^(W|E): ' > /dev/null && msgfail || msgpass
-       testequal "$(cat ${PKGFILE}-new)
+       msgmsg 'Warm archive signed by' 'nobody'
+       updatewithwarnings 'W: .* no longer signed.'
+       testsuccessequal "$(cat ${PKGFILE}-new)

 " aptcache show apt
        failaptnew
 
        # Unsigned archive from the beginning must also be detected.
        rm -rf rootdir/var/lib/apt/lists
 " aptcache show apt
        failaptnew
 
        # Unsigned archive from the beginning must also be detected.
        rm -rf rootdir/var/lib/apt/lists

-       msgtest 'Cold archive signed by' 'nobody'
-       aptget update 2>&1 | grep -E '^(W|E): ' > /dev/null && msgfail || msgpass
-       testequal "$(cat ${PKGFILE}-new)
+       msgmsg 'Cold archive signed by' 'nobody'
+       updatewithwarnings 'W: .* is not signed.'
+       testsuccessequal "$(cat ${PKGFILE}-new)

 " aptcache show apt
        failaptnew
 }
 " aptcache show apt
        failaptnew
 }

-runtest2

 
 

+# diable some protection by default and ensure we still do the verification
+# correctly
+cat > rootdir/etc/apt/apt.conf.d/weaken-security <<EOF
+Acquire::AllowInsecureRepositories "1";
+Acquire::AllowDowngradeToInsecureRepositories "1";
+EOF
+
+msgmsg "Running base test"
+runtest2

 
 DELETEFILE="InRelease"
 
 DELETEFILE="InRelease"

+msgmsg "Running test with deletion of $DELETEFILE"
+runtest
+
+DELETEFILE="Release.gpg"
+msgmsg "Running test with deletion of $DELETEFILE"

 runtest
 runtest

-#DELETEFILE="Release.gpg"
-#runtest