Fixed dumpavail bug with dup packageS

[apt.git] / methods / http.cc

diff --git a/methods/http.cc b/methods/http.cc
index e947bcc959377eea0b5e23b04d8dd7c19a4104dd..b5d26d127754867fefbc5f5926127cb778b5990e 100644 (file)
--- a/methods/http.cc
+++ b/methods/http.cc
@@ -1,6 +1,6 @@
 // -*- mode: cpp; mode: fold -*-
 // Description                                                         /*{{{*/
-// $Id: http.cc,v 1.16 1998/12/11 07:23:17 jgg Exp $
+// $Id: http.cc,v 1.26 1999/02/15 00:26:55 jgg Exp $
 /* ######################################################################
 
    HTTP Aquire Method - This is the HTTP aquire method for APT.
@@ -38,6 +38,7 @@
 #include <unistd.h>
 #include <signal.h>
 #include <stdio.h>
+#include <errno.h>
 
 // Internet stuff
 #include <netinet/in.h>
@@ -346,7 +347,7 @@ bool ServerState::Open()
       return _error->Errno("select","Select failed");
    if (Res == 0)
       return _error->Error("Could not connect, connection timed out");
-   unsigned int Err,Len;
+   unsigned int Err,Len=sizeof(Err);
    if (getsockopt(ServerFd,SOL_SOCKET,SO_ERROR,&Err,&Len) != 0)
       return _error->Errno("getsockopt","Failed");
    if (Err != 0)
@@ -447,7 +448,7 @@ bool ServerState::RunData()
            while ((Last = Owner->Go(false,this)) == true);
            if (Last == false)
               return false;
-           return true;
+           return !_error->PendingError();
         }
         
         // Transfer the block
@@ -489,12 +490,12 @@ bool ServerState::RunData()
            continue;
         
         In.Limit(-1);
-        return true;
+        return !_error->PendingError();
       }
       while (Owner->Go(true,this) == true);
    }
 
-   return Owner->Flush(this);
+   return Owner->Flush(this) && !_error->PendingError();
 }
                                                                        /*}}}*/
 // ServerState::HeaderLine - Process a header line                     /*{{{*/
@@ -616,7 +617,7 @@ void HttpMethod::SendReq(FetchItem *Itm,CircleBuf &Out)
       and we expect the proxy to do this */
    if (Proxy.empty() == true)
       sprintf(Buf,"GET %s HTTP/1.1\r\nHost: %s\r\nConnection: keep-alive\r\n",
-             Uri.Path.c_str(),ProperHost.c_str());
+             QuoteString(Uri.Path,"~").c_str(),ProperHost.c_str());
    else
    {
       /* Generate a cache control header if necessary. We place a max
@@ -625,7 +626,7 @@ void HttpMethod::SendReq(FetchItem *Itm,CircleBuf &Out)
       sprintf(Buf,"GET %s HTTP/1.1\r\nHost: %s\r\n",
              Itm->Uri.c_str(),ProperHost.c_str());
       if (_config->FindB("Acquire::http::No-Cache",false) == true)
-        strcat(Buf,"Cache-Control: no-cache\r\n");
+        strcat(Buf,"Cache-Control: no-cache\r\nPragma: no-cache\r\n");
       else
       {
         if (Itm->IndexFile == true)
@@ -659,8 +660,9 @@ void HttpMethod::SendReq(FetchItem *Itm,CircleBuf &Out)
       }
    }
 
-/*   if (ProxyAuth.empty() == false)
-      Req += string("Proxy-Authorization: Basic ") + Base64Encode(ProxyAuth) + "\r\n";*/
+   if (Proxy.User.empty() == false || Proxy.Password.empty() == false)
+      Req += string("Proxy-Authorization: Basic ") + 
+          Base64Encode(Proxy.User + ":" + Proxy.Password) + "\r\n";
 
    Req += "User-Agent: Debian APT-HTTP/1.2\r\n\r\n";
 //   cerr << Req << endl;
@@ -874,6 +876,7 @@ int HttpMethod::DealWithHeaders(FetchResult &Res,ServerState *Srv)
       return 5;
 
    FailFile = Queue->DestFile;
+   FailFile.c_str();   // Make sure we don't do a malloc in the signal handler
    FailFd = File->Fd();
    FailTime = Srv->Date;
       
@@ -986,7 +989,7 @@ int HttpMethod::Loop()
    {
       if (FailCounter >= 2)
       {
-        Fail("Massive Server Brain Damage");
+        Fail("Massive Server Brain Damage",true);
         FailCounter = 0;
       }
       
@@ -1018,7 +1021,9 @@ int HttpMethod::Loop()
       // Connnect to the host
       if (Server->Open() == false)
       {
-        Fail();
+        Fail(true);
+        delete Server;
+        Server = 0;
         continue;
       }
 
@@ -1035,7 +1040,7 @@ int HttpMethod::Loop()
         case 2:
         {
            _error->Error("Bad header Data");
-           Fail();
+           Fail(true);
            continue;
         }