* support multiple signatures

[apt.git] / methods / gpgv.cc

diff --git a/methods/gpgv.cc b/methods/gpgv.cc
index 24e945b2c3c772d4dfc62d7a024b930302de4a94..a114ad797dd0967c19e87d83829d9e11e017d02e 100644 (file)
--- a/methods/gpgv.cc
+++ b/methods/gpgv.cc
@@ -1,6 +1,7 @@
 #include <apt-pkg/error.h>
 #include <apt-pkg/acquire-method.h>
 #include <apt-pkg/strutl.h>
+#include <apti18n.h>
 
 #include <sys/stat.h>
 #include <unistd.h>
@@ -88,7 +89,7 @@ const char *GPGVMethod::VerifyGetSigners(const char *file, const char *outfile,
                continue;
             Args[i++] = Opts->Value.c_str();
            if(i >= 395) { 
-              std::cerr << "E: Argument list from Acquire::gpgv::Options too long. Exiting." << std::endl;
+              std::cerr << _("E: Argument list from Acquire::gpgv::Options too long. Exiting.") << std::endl;
               exit(111);
            }
          }
@@ -181,27 +182,28 @@ const char *GPGVMethod::VerifyGetSigners(const char *file, const char *outfile,
    waitpid(pid, &status, 0);
    if (_config->FindB("Debug::Acquire::gpgv", false))
    {
-      std::cerr <<"gpgv exited\n";
+      std::cerr << "gpgv exited\n";
    }
    
    if (WEXITSTATUS(status) == 0)
    {
       if (GoodSigners.empty())
-         return "Internal error: Good signature, but could not determine key fingerprint?!";
+         return _("Internal error: Good signature, but could not determine key fingerprint?!");
       return NULL;
    }
    else if (WEXITSTATUS(status) == 1)
    {
-      return "At least one invalid signature was encountered.";
+      return _("At least one invalid signature was encountered.");
    }
    else if (WEXITSTATUS(status) == 111)
    {
-      return (string("Could not execute ") + gpgvpath +
-             string(" to verify signature (is gnupg installed?)")).c_str();
+      // FIXME String concatenation considered harmful.
+      return (string(_("Could not execute ")) + gpgvpath +
+             string(_(" to verify signature (is gnupg installed?)"))).c_str();
    }
    else
    {
-      return "Unknown error executing gpgv";
+      return _("Unknown error executing gpgv");
    }
 }
 
@@ -232,35 +234,39 @@ bool GPGVMethod::Fetch(FetchItem *Itm)
       {
          if (!BadSigners.empty())
          {
-            errmsg += "The following signatures were invalid:\n";
+            errmsg += _("The following signatures were invalid:\n");
             for (vector<string>::iterator I = BadSigners.begin();
                 I != BadSigners.end(); I++)
                errmsg += (*I + "\n");
          }
          if (!NoPubKeySigners.empty())
          {
-             errmsg += "The following signatures couldn't be verified because the public key is not available:\n";
+             errmsg += _("The following signatures couldn't be verified because the public key is not available:\n");
             for (vector<string>::iterator I = NoPubKeySigners.begin();
                 I != NoPubKeySigners.end(); I++)
                errmsg += (*I + "\n");
          }
       }
-      return _error->Error(errmsg.c_str());
+      // this is only fatal if we have no good sigs or if we have at
+      // least one bad signature. good signatures and NoPubKey signatures
+      // happen easily when a file is signed with multiple signatures
+      if(GoodSigners.empty() or !BadSigners.empty())
+        return _error->Error(errmsg.c_str());
    }
       
    // Transfer the modification times
    struct stat Buf;
    if (stat(Path.c_str(),&Buf) != 0)
-      return _error->Errno("stat","Failed to stat %s", Path.c_str());
+      return _error->Errno("stat",_("Failed to stat %s"), Path.c_str());
 
    struct utimbuf TimeBuf;
    TimeBuf.actime = Buf.st_atime;
    TimeBuf.modtime = Buf.st_mtime;
    if (utime(Itm->DestFile.c_str(),&TimeBuf) != 0)
-      return _error->Errno("utime","Failed to set modification time");
+      return _error->Errno("utime",_("Failed to set modification time"));
 
    if (stat(Itm->DestFile.c_str(),&Buf) != 0)
-      return _error->Errno("stat","Failed to stat");
+      return _error->Errno("stat",_("Failed to stat"));
    
    // Return a Done response
    Res.LastModified = Buf.st_mtime;
@@ -275,7 +281,7 @@ bool GPGVMethod::Fetch(FetchItem *Itm)
 
    if (_config->FindB("Debug::Acquire::gpgv", false))
    {
-      std::cerr <<"gpgv suceeded\n";
+      std::cerr << "gpgv succeeded\n";
    }
 
    return true;
@@ -284,6 +290,8 @@ bool GPGVMethod::Fetch(FetchItem *Itm)
 
 int main()
 {
+   setlocale(LC_ALL, "");
+   
    GPGVMethod Mth;
 
    return Mth.Run();