The entire concept of PendingError() is flawed :/.

[apt.git] / methods / http.h

diff --git a/methods/http.h b/methods/http.h
index e73871931d3ee7fcf8fb08522ea24dcd3f6c8b69..b7341f5f8671c0f817a4a9db05b12ce949bc4be9 100644 (file)
--- a/methods/http.h
+++ b/methods/http.h
@@ -12,7 +12,6 @@
 #define APT_HTTP_H
 
 #include <apt-pkg/strutl.h>
 #define APT_HTTP_H
 
 #include <apt-pkg/strutl.h>

-#include <apt-pkg/acquire-method.h>

 
 #include <string>
 #include <sys/time.h>
 
 #include <string>
 #include <sys/time.h>


@@ -68,7 +67,7 @@ class CircleBuf
 
    // Read data in
    bool Read(int Fd);
 
    // Read data in
    bool Read(int Fd);

-   bool Read(std::string Data);
+   bool Read(std::string const &Data);

 
    // Write data out
    bool Write(int Fd);
 
    // Write data out
    bool Write(int Fd);


@@ -87,7 +86,7 @@ class CircleBuf
    // Dump everything
    void Stats();
 
    // Dump everything
    void Stats();
 

-   CircleBuf(unsigned long long Size);
+   CircleBuf(HttpMethod const * const Owner, unsigned long long Size);

    ~CircleBuf();
 };
 
    ~CircleBuf();
 };
 


@@ -99,23 +98,24 @@ struct HttpServerState: public ServerState
    int ServerFd;
 
    protected:
    int ServerFd;
 
    protected:

-   virtual bool ReadHeaderLines(std::string &Data);
-   virtual bool LoadNextResponse(bool const ToFile, FileFd * const File);
-   virtual bool WriteResponse(std::string const &Data);
+   virtual bool ReadHeaderLines(std::string &Data) APT_OVERRIDE;
+   virtual bool LoadNextResponse(bool const ToFile, FileFd * const File) APT_OVERRIDE;
+   virtual bool WriteResponse(std::string const &Data) APT_OVERRIDE;

 
    public:
 
    public:

-   virtual void Reset() { ServerState::Reset(); ServerFd = -1; };
+   virtual void Reset(bool const Everything = true) APT_OVERRIDE;

 
 

-   virtual bool RunData(FileFd * const File);
+   virtual bool RunData(FileFd * const File) APT_OVERRIDE;
+   virtual bool RunDataToDevNull() APT_OVERRIDE;

 
 

-   virtual bool Open();
-   virtual bool IsOpen();
-   virtual bool Close();
-   virtual bool InitHashes(HashStringList const &ExpectedHashes);
-   virtual Hashes * GetHashes();
-   virtual bool Die(FileFd &File);
-   virtual bool Flush(FileFd * const File);
-   virtual bool Go(bool ToFile, FileFd * const File);
+   virtual bool Open() APT_OVERRIDE;
+   virtual bool IsOpen() APT_OVERRIDE;
+   virtual bool Close() APT_OVERRIDE;
+   virtual bool InitHashes(HashStringList const &ExpectedHashes) APT_OVERRIDE;
+   virtual Hashes * GetHashes() APT_OVERRIDE;
+   virtual bool Die(FileFd * const File) APT_OVERRIDE;
+   virtual bool Flush(FileFd * const File) APT_OVERRIDE;
+   virtual bool Go(bool ToFile, FileFd * const File) APT_OVERRIDE;

 
    HttpServerState(URI Srv, HttpMethod *Owner);
    virtual ~HttpServerState() {Close();};
 
    HttpServerState(URI Srv, HttpMethod *Owner);
    virtual ~HttpServerState() {Close();};


@@ -124,12 +124,11 @@ struct HttpServerState: public ServerState
 class HttpMethod : public ServerMethod
 {
    public:
 class HttpMethod : public ServerMethod
 {
    public:

-   virtual void SendReq(FetchItem *Itm);
+   virtual void SendReq(FetchItem *Itm) APT_OVERRIDE;

 
 

-   virtual bool Configuration(std::string Message);
-
-   virtual ServerState * CreateServerState(URI uri);
-   virtual void RotateDNS();
+   virtual std::unique_ptr<ServerState> CreateServerState(URI const &uri) APT_OVERRIDE;
+   virtual void RotateDNS() APT_OVERRIDE;
+   virtual DealWithHeadersResult DealWithHeaders(FetchResult &Res) APT_OVERRIDE;

 
    protected:
    std::string AutoDetectProxyCmd;
 
    protected:
    std::string AutoDetectProxyCmd;


@@ -137,11 +136,7 @@ class HttpMethod : public ServerMethod
    public:
    friend struct HttpServerState;
 
    public:
    friend struct HttpServerState;
 

-   HttpMethod() : ServerMethod("1.2",Pipeline | SendConfig)
-   {
-      File = 0;
-      Server = 0;
-   };
+   explicit HttpMethod(std::string &&pProg);

 };
 
 #endif
 };
 
 #endif