report all instead of first error up the acquire chain

[apt.git] / methods / connect.cc

diff --git a/methods/connect.cc b/methods/connect.cc
index 8de4ad74799d29715bee12d8e97ad670d20b7e2b..07a730b887bdfa17f61b91537cd8a4774fb98590 100644 (file)
--- a/methods/connect.cc
+++ b/methods/connect.cc
@@ -45,7 +45,6 @@ static struct addrinfo *LastHostAddr = 0;
 static struct addrinfo *LastUsed = 0;
 
 static std::vector<SrvRec> SrvRecords;
 static struct addrinfo *LastUsed = 0;
 
 static std::vector<SrvRec> SrvRecords;

-static int LastSrvRecord = 0;

 
 // Set of IP/hostnames that we timed out before or couldn't resolve
 static std::set<std::string> bad_addr;
 
 // Set of IP/hostnames that we timed out before or couldn't resolve
 static std::set<std::string> bad_addr;


@@ -134,11 +133,10 @@ static bool DoConnect(struct addrinfo *Addr,std::string Host,
    return true;
 }
                                                                        /*}}}*/
    return true;
 }
                                                                        /*}}}*/

-
-// Connect to a given Hostname 
-bool ConnectAfterSrvRecords(std::string Host,int Port,const char *Service,
-                            int DefPort,int &Fd,
-                            unsigned long TimeOut,pkgAcqMethod *Owner)
+// Connect to a given Hostname                                         /*{{{*/
+static bool ConnectToHostname(std::string const &Host, int const Port,
+      const char * const Service, int DefPort, int &Fd,
+      unsigned long const TimeOut, pkgAcqMethod * const Owner)

 {
    // Convert the port name/number
    char ServStr[300];
 {
    // Convert the port name/number
    char ServStr[300];


@@ -166,7 +164,14 @@ bool ConnectAfterSrvRecords(std::string Host,int Port,const char *Service,
       struct addrinfo Hints;
       memset(&Hints,0,sizeof(Hints));
       Hints.ai_socktype = SOCK_STREAM;
       struct addrinfo Hints;
       memset(&Hints,0,sizeof(Hints));
       Hints.ai_socktype = SOCK_STREAM;

-      Hints.ai_flags = AI_ADDRCONFIG;
+      Hints.ai_flags = 0;
+      if (_config->FindB("Acquire::Connect::IDN", true) == true)
+        Hints.ai_flags |= AI_IDN;
+      // see getaddrinfo(3): only return address if system has such a address configured
+      // useful if system is ipv4 only, to not get ipv6, but that fails if the system has
+      // no address configured: e.g. offline and trying to connect to localhost.
+      if (_config->FindB("Acquire::Connect::AddrConfig", true) == true)
+        Hints.ai_flags |= AI_ADDRCONFIG;

       Hints.ai_protocol = 0;
       
       if(_config->FindB("Acquire::ForceIPv4", false) == true)
       Hints.ai_protocol = 0;
       
       if(_config->FindB("Acquire::ForceIPv4", false) == true)


@@ -261,36 +266,33 @@ bool ConnectAfterSrvRecords(std::string Host,int Port,const char *Service,
                                                                        /*}}}*/
 // Connect - Connect to a server                                       /*{{{*/
 // ---------------------------------------------------------------------
                                                                        /*}}}*/
 // Connect - Connect to a server                                       /*{{{*/
 // ---------------------------------------------------------------------

-/* Performs a connection to the server */
+/* Performs a connection to the server (including SRV record lookup) */

 bool Connect(std::string Host,int Port,const char *Service,
                             int DefPort,int &Fd,
                             unsigned long TimeOut,pkgAcqMethod *Owner)
 {
 bool Connect(std::string Host,int Port,const char *Service,
                             int DefPort,int &Fd,
                             unsigned long TimeOut,pkgAcqMethod *Owner)
 {

-#if 0

    if (_error->PendingError() == true)
       return false;
    if (_error->PendingError() == true)
       return false;

-#endif

 
    if(LastHost != Host || LastPort != Port)
    {
       SrvRecords.clear();
 
    if(LastHost != Host || LastPort != Port)
    {
       SrvRecords.clear();

-      bool res = GetSrvRecords(Host, DefPort, SrvRecords);
+      if (_config->FindB("Acquire::EnableSrvRecords", true) == true)
+         GetSrvRecords(Host, DefPort, SrvRecords);

    }
    }

+   // we have no SrvRecords for this host, connect right away

    if(SrvRecords.size() == 0)
    if(SrvRecords.size() == 0)

-      return ConnectAfterSrvRecords(Host, Port, Service, DefPort, Fd, 
+      return ConnectToHostname(Host, Port, Service, DefPort, Fd, 

                                     TimeOut, Owner);
 
                                     TimeOut, Owner);
 

-   bool connected = false;
+   // try to connect in the priority order of the srv records

    while(SrvRecords.size() > 0)
    {
    while(SrvRecords.size() > 0)
    {

-      Host = SrvRecords[0].target;
-      connected = ConnectAfterSrvRecords(Host, Port, Service, DefPort, Fd, 
-                                         TimeOut, Owner);
-      if(connected == true)
+      // PopFromSrvRecs will also remove the server
+      Host = PopFromSrvRecs(SrvRecords).target;
+      if(ConnectToHostname(Host, Port, Service, DefPort, Fd, TimeOut, Owner))

          return true;
          return true;

+   }

 
 

-      // we couldn't connect to this one, use the next
-      SrvRecords.erase(SrvRecords.begin());
-   } 

    return false;
 }
    return false;
 }