merged lp:~mvo/apt/conflicts-on-virtuals to better deal with

[apt.git] / apt-pkg / indexrecords.cc

diff --git a/apt-pkg/indexrecords.cc b/apt-pkg/indexrecords.cc
index 1312e6818faeaddc982cefd1bdd34bef0c9ba185..eb9a368662e9f8b192a8513ce9db6fdc6ef1c2fd 100644 (file)
--- a/apt-pkg/indexrecords.cc
+++ b/apt-pkg/indexrecords.cc
@@ -39,6 +39,11 @@ const indexRecords::checkSum *indexRecords::Lookup(const string MetaKey)
    return Entries[MetaKey];
 }
 
    return Entries[MetaKey];
 }
 

+bool indexRecords::Exists(string const &MetaKey) const
+{
+   return Entries.count(MetaKey) == 1;
+}
+

 bool indexRecords::Load(const string Filename)                         /*{{{*/
 {
    FileFd Fd(Filename, FileFd::ReadOnly);
 bool indexRecords::Load(const string Filename)                         /*{{{*/
 {
    FileFd Fd(Filename, FileFd::ReadOnly);


@@ -88,34 +93,39 @@ bool indexRecords::Load(const string Filename)                              /*{{{*/
    {
       strprintf(ErrorText, _("No Hash entry in Release file %s"), Filename.c_str());
       return false;
    {
       strprintf(ErrorText, _("No Hash entry in Release file %s"), Filename.c_str());
       return false;

-   }  
+   }

 
    string Label = Section.FindS("Label");
    string StrDate = Section.FindS("Date");
    string StrValidUntil = Section.FindS("Valid-Until");
 
 
    string Label = Section.FindS("Label");
    string StrDate = Section.FindS("Date");
    string StrValidUntil = Section.FindS("Valid-Until");
 

-   // if we have a Valid-Until header, use it
+   // if we have a Valid-Until header in the Release file, use it as default

    if (StrValidUntil.empty() == false)
    {
    if (StrValidUntil.empty() == false)
    {

-      // set ValidUntil based on the information in the Release file

       if(RFC1123StrToTime(StrValidUntil.c_str(), ValidUntil) == false)
       {
         strprintf(ErrorText, _("Invalid 'Valid-Until' entry in Release file %s"), Filename.c_str());
         return false;
       }
       if(RFC1123StrToTime(StrValidUntil.c_str(), ValidUntil) == false)
       {
         strprintf(ErrorText, _("Invalid 'Valid-Until' entry in Release file %s"), Filename.c_str());
         return false;
       }

-   } else {
-      // if we don't have a valid-until string, check if we have a default
-      int MaxAge = _config->FindI("APT::Acquire::Max-Default-Age", 0);
-      if (Label.empty() == true)
-        MaxAge = _config->FindI(string("APT::Acquire::Max-Default-Age::"+Label).c_str(), MaxAge);
+   }
+   // get the user settings for this archive and use what expires earlier
+   int MaxAge = _config->FindI("Acquire::Max-ValidTime", 0);
+   if (Label.empty() == true)
+      MaxAge = _config->FindI(string("Acquire::Max-ValidTime::" + Label).c_str(), MaxAge);

 
 

-      if(MaxAge > 0 && RFC1123StrToTime(StrDate.c_str(), ValidUntil) == false)
-      {
-        strprintf(ErrorText, _("Invalid 'Date' entry in Release file %s"), Filename.c_str());
-        return false;
-      }
-      ValidUntil += 24*60*60*MaxAge;
+   if(MaxAge == 0) // No user settings, use the one from the Release file
+      return true;
+
+   time_t date;
+   if (RFC1123StrToTime(StrDate.c_str(), date) == false)
+   {
+      strprintf(ErrorText, _("Invalid 'Date' entry in Release file %s"), Filename.c_str());
+      return false;

    }
    }

+   date += 24*60*60*MaxAge;
+
+   if (ValidUntil == 0 || ValidUntil > date)
+      ValidUntil = date;

 
    return true;
 }
 
    return true;
 }