Fix incorrect upgradable listing in "apt list" (thanks to Michael Musenbrock)

[apt.git] / apt-private / private-cacheset.cc

#include <config.h>

#include <apt-pkg/cachefile.h>
#include <apt-pkg/pkgcache.h>
#include <apt-pkg/depcache.h>
#include <apt-pkg/cacheiterators.h>
#include <apt-pkg/configuration.h>
#include <apt-pkg/progress.h>
#include <apt-pkg/policy.h>

#include <apt-private/private-cacheset.h>

#include <stddef.h>

#include <apti18n.h>

bool GetLocalitySortedVersionSet(pkgCacheFile &CacheFile, 
                                 LocalitySortedVersionSet &output_set,
                                 OpProgress &progress)
{
    Matcher null_matcher = Matcher();
    return GetLocalitySortedVersionSet(CacheFile, output_set, 
                                       null_matcher, progress);
}

bool GetLocalitySortedVersionSet(pkgCacheFile &CacheFile, 
                                 LocalitySortedVersionSet &output_set,
                                 Matcher &matcher,
                                 OpProgress &progress)
{
   pkgCache *Cache = CacheFile.GetPkgCache();
   pkgDepCache *DepCache = CacheFile.GetDepCache();

   int Done=0;
   progress.SubProgress(Cache->Head().PackageCount, _("Sorting"));
   for (pkgCache::PkgIterator P = Cache->PkgBegin(); P.end() == false; ++P)
   {
      if (Done%500 == 0)
         progress.Progress(Done);
      Done++;

      if ((matcher)(P) == false)
         continue;

      // exclude virtual pkgs
      if (P.VersionList() == 0)
         continue;
      pkgDepCache::StateCache &state = (*DepCache)[P];
      if (_config->FindB("APT::Cmd::Installed") == true)
      {
         if (P.CurrentVer() != NULL)
         {
            output_set.insert(P.CurrentVer());
         }
      }
      else if (_config->FindB("APT::Cmd::Upgradable") == true)
      {
         pkgPolicy *policy = CacheFile.GetPolicy();
         if(P.CurrentVer() && 
            state.Upgradable() && 
            policy->GetCandidateVer(P) != P.CurrentVer())
         {
             pkgPolicy *policy = CacheFile.GetPolicy();
             output_set.insert(policy->GetCandidateVer(P));
         }
      }
      else if (_config->FindB("APT::Cmd::Manual-Installed") == true)
      {
         if (P.CurrentVer() && 
             ((*DepCache)[P].Flags & pkgCache::Flag::Auto) == false)
         {
             pkgPolicy *policy = CacheFile.GetPolicy();
             output_set.insert(policy->GetCandidateVer(P));
         }
      }
      else 
      {
         pkgPolicy *policy = CacheFile.GetPolicy();
         if (policy->GetCandidateVer(P).IsGood())
            output_set.insert(policy->GetCandidateVer(P));
         else 
            // no candidate, this may happen for packages in 
            // dpkg "deinstall ok config-file" state - we pick the first ver
            // (which should be the only one)
            output_set.insert(P.VersionList());
      }
   }
   progress.Done();
   return true;
}