]>
Commit | Line | Data |
---|---|---|
6c139d6e AL |
1 | // -*- mode: cpp; mode: fold -*- |
2 | // Description /*{{{*/ | |
b8c0f9b7 | 3 | // $Id: algorithms.cc,v 1.44 2002/11/28 18:49:16 jgg Exp $ |
6c139d6e AL |
4 | /* ###################################################################### |
5 | ||
6 | Algorithms - A set of misc algorithms | |
7 | ||
0a8e3465 AL |
8 | The pkgProblemResolver class has become insanely complex and |
9 | very sophisticated, it handles every test case I have thrown at it | |
10 | to my satisfaction. Understanding exactly why all the steps the class | |
11 | does are required is difficult and changing though not very risky | |
12 | may result in other cases not working. | |
13 | ||
6c139d6e AL |
14 | ##################################################################### */ |
15 | /*}}}*/ | |
16 | // Include Files /*{{{*/ | |
ea542140 DK |
17 | #include <config.h> |
18 | ||
094a497d AL |
19 | #include <apt-pkg/algorithms.h> |
20 | #include <apt-pkg/error.h> | |
0a8e3465 | 21 | #include <apt-pkg/configuration.h> |
b2e465d6 | 22 | #include <apt-pkg/sptr.h> |
c3b85126 | 23 | #include <apt-pkg/edsp.h> |
472ff00e | 24 | #include <apt-pkg/progress.h> |
453b82a3 DK |
25 | #include <apt-pkg/depcache.h> |
26 | #include <apt-pkg/packagemanager.h> | |
27 | #include <apt-pkg/pkgcache.h> | |
28 | #include <apt-pkg/cacheiterators.h> | |
6d38011b | 29 | |
453b82a3 DK |
30 | #include <string.h> |
31 | #include <string> | |
152ab79e | 32 | #include <cstdlib> |
90f057fd | 33 | #include <iostream> |
ea542140 DK |
34 | |
35 | #include <apti18n.h> | |
6c139d6e | 36 | /*}}}*/ |
584e4558 | 37 | using namespace std; |
6c139d6e AL |
38 | |
39 | pkgProblemResolver *pkgProblemResolver::This = 0; | |
40 | ||
41 | // Simulate::Simulate - Constructor /*{{{*/ | |
42 | // --------------------------------------------------------------------- | |
b2e465d6 AL |
43 | /* The legacy translations here of input Pkg iterators is obsolete, |
44 | this is not necessary since the pkgCaches are fully shared now. */ | |
45 | pkgSimulate::pkgSimulate(pkgDepCache *Cache) : pkgPackageManager(Cache), | |
46 | iPolicy(Cache), | |
496d5c70 MV |
47 | Sim(&Cache->GetCache(),&iPolicy), |
48 | group(Sim) | |
6c139d6e | 49 | { |
b2e465d6 AL |
50 | Sim.Init(0); |
51 | Flags = new unsigned char[Cache->Head().PackageCount]; | |
52 | memset(Flags,0,sizeof(*Flags)*Cache->Head().PackageCount); | |
281daf46 AL |
53 | |
54 | // Fake a filename so as not to activate the media swapping | |
55 | string Jnk = "SIMULATE"; | |
b2e465d6 | 56 | for (unsigned int I = 0; I != Cache->Head().PackageCount; I++) |
281daf46 | 57 | FileNames[I] = Jnk; |
6c139d6e AL |
58 | } |
59 | /*}}}*/ | |
b270388b MV |
60 | // Simulate::~Simulate - Destructor /*{{{*/ |
61 | pkgSimulate::~pkgSimulate() | |
62 | { | |
63 | delete[] Flags; | |
64 | } | |
65 | /*}}}*/ | |
b2e465d6 AL |
66 | // Simulate::Describe - Describe a package /*{{{*/ |
67 | // --------------------------------------------------------------------- | |
3826564e MZ |
68 | /* Parameter Current == true displays the current package version, |
69 | Parameter Candidate == true displays the candidate package version */ | |
70 | void pkgSimulate::Describe(PkgIterator Pkg,ostream &out,bool Current,bool Candidate) | |
b2e465d6 AL |
71 | { |
72 | VerIterator Ver(Sim); | |
e59458f7 | 73 | |
47f6d1b7 | 74 | out << Pkg.FullName(true); |
e59458f7 | 75 | |
3826564e | 76 | if (Current == true) |
e59458f7 | 77 | { |
b2e465d6 | 78 | Ver = Pkg.CurrentVer(); |
e59458f7 AL |
79 | if (Ver.end() == false) |
80 | out << " [" << Ver.VerStr() << ']'; | |
81 | } | |
b2e465d6 | 82 | |
3826564e MZ |
83 | if (Candidate == true) |
84 | { | |
85 | Ver = Sim[Pkg].CandidateVerIter(Sim); | |
86 | if (Ver.end() == true) | |
87 | return; | |
b2e465d6 | 88 | |
3826564e MZ |
89 | out << " (" << Ver.VerStr() << ' ' << Ver.RelStr() << ')'; |
90 | } | |
b2e465d6 AL |
91 | } |
92 | /*}}}*/ | |
6c139d6e AL |
93 | // Simulate::Install - Simulate unpacking of a package /*{{{*/ |
94 | // --------------------------------------------------------------------- | |
95 | /* */ | |
96 | bool pkgSimulate::Install(PkgIterator iPkg,string /*File*/) | |
97 | { | |
98 | // Adapt the iterator | |
803ea2a8 | 99 | PkgIterator Pkg = Sim.FindPkg(iPkg.Name(), iPkg.Arch()); |
6c139d6e AL |
100 | Flags[Pkg->ID] = 1; |
101 | ||
b2e465d6 | 102 | cout << "Inst "; |
3826564e | 103 | Describe(Pkg,cout,true,true); |
6c139d6e | 104 | Sim.MarkInstall(Pkg,false); |
803ea2a8 | 105 | |
6c139d6e | 106 | // Look for broken conflicts+predepends. |
f7f0d6c7 | 107 | for (PkgIterator I = Sim.PkgBegin(); I.end() == false; ++I) |
6c139d6e AL |
108 | { |
109 | if (Sim[I].InstallVer == 0) | |
110 | continue; | |
111 | ||
b2e465d6 AL |
112 | for (DepIterator D = Sim[I].InstVerIter(Sim).DependsList(); D.end() == false;) |
113 | { | |
114 | DepIterator Start; | |
115 | DepIterator End; | |
116 | D.GlobOr(Start,End); | |
359e46db | 117 | if (Start.IsNegative() == true || |
b2e465d6 | 118 | End->Type == pkgCache::Dep::PreDepends) |
6c139d6e | 119 | { |
b2e465d6 | 120 | if ((Sim[End] & pkgDepCache::DepGInstall) == 0) |
6c139d6e | 121 | { |
47f6d1b7 | 122 | cout << " [" << I.FullName(false) << " on " << Start.TargetPkg().FullName(false) << ']'; |
b2e465d6 | 123 | if (Start->Type == pkgCache::Dep::Conflicts) |
47f6d1b7 | 124 | _error->Error("Fatal, conflicts violated %s",I.FullName(false).c_str()); |
6c139d6e | 125 | } |
b2e465d6 AL |
126 | } |
127 | } | |
6c139d6e AL |
128 | } |
129 | ||
130 | if (Sim.BrokenCount() != 0) | |
131 | ShortBreaks(); | |
132 | else | |
04aa15a8 | 133 | cout << endl; |
6c139d6e AL |
134 | return true; |
135 | } | |
136 | /*}}}*/ | |
137 | // Simulate::Configure - Simulate configuration of a Package /*{{{*/ | |
138 | // --------------------------------------------------------------------- | |
139 | /* This is not an acurate simulation of relatity, we should really not | |
140 | install the package.. For some investigations it may be necessary | |
141 | however. */ | |
142 | bool pkgSimulate::Configure(PkgIterator iPkg) | |
143 | { | |
144 | // Adapt the iterator | |
803ea2a8 | 145 | PkgIterator Pkg = Sim.FindPkg(iPkg.Name(), iPkg.Arch()); |
6c139d6e AL |
146 | |
147 | Flags[Pkg->ID] = 2; | |
803ea2a8 | 148 | |
6c139d6e AL |
149 | if (Sim[Pkg].InstBroken() == true) |
150 | { | |
47f6d1b7 | 151 | cout << "Conf " << Pkg.FullName(false) << " broken" << endl; |
6c139d6e AL |
152 | |
153 | Sim.Update(); | |
154 | ||
155 | // Print out each package and the failed dependencies | |
f7f0d6c7 | 156 | for (pkgCache::DepIterator D = Sim[Pkg].InstVerIter(Sim).DependsList(); D.end() == false; ++D) |
6c139d6e AL |
157 | { |
158 | if (Sim.IsImportantDep(D) == false || | |
159 | (Sim[D] & pkgDepCache::DepInstall) != 0) | |
160 | continue; | |
161 | ||
b2e465d6 | 162 | if (D->Type == pkgCache::Dep::Obsoletes) |
47f6d1b7 | 163 | cout << " Obsoletes:" << D.TargetPkg().FullName(false); |
b2e465d6 | 164 | else if (D->Type == pkgCache::Dep::Conflicts) |
47f6d1b7 | 165 | cout << " Conflicts:" << D.TargetPkg().FullName(false); |
308c7d30 | 166 | else if (D->Type == pkgCache::Dep::DpkgBreaks) |
47f6d1b7 | 167 | cout << " Breaks:" << D.TargetPkg().FullName(false); |
6c139d6e | 168 | else |
47f6d1b7 | 169 | cout << " Depends:" << D.TargetPkg().FullName(false); |
6c139d6e | 170 | } |
04aa15a8 | 171 | cout << endl; |
6c139d6e | 172 | |
09a10f9c | 173 | _error->Error("Conf Broken %s",Pkg.FullName(false).c_str()); |
6c139d6e AL |
174 | } |
175 | else | |
b2e465d6 AL |
176 | { |
177 | cout << "Conf "; | |
3826564e | 178 | Describe(Pkg,cout,false,true); |
b2e465d6 | 179 | } |
6c139d6e AL |
180 | |
181 | if (Sim.BrokenCount() != 0) | |
182 | ShortBreaks(); | |
183 | else | |
04aa15a8 | 184 | cout << endl; |
6c139d6e AL |
185 | |
186 | return true; | |
187 | } | |
188 | /*}}}*/ | |
189 | // Simulate::Remove - Simulate the removal of a package /*{{{*/ | |
190 | // --------------------------------------------------------------------- | |
191 | /* */ | |
fc4b5c9f | 192 | bool pkgSimulate::Remove(PkgIterator iPkg,bool Purge) |
6c139d6e AL |
193 | { |
194 | // Adapt the iterator | |
803ea2a8 | 195 | PkgIterator Pkg = Sim.FindPkg(iPkg.Name(), iPkg.Arch()); |
c919ad6e DK |
196 | if (Pkg.end() == true) |
197 | { | |
198 | std::cerr << (Purge ? "Purg" : "Remv") << " invalid package " << iPkg.FullName() << std::endl; | |
199 | return false; | |
200 | } | |
6c139d6e AL |
201 | |
202 | Flags[Pkg->ID] = 3; | |
203 | Sim.MarkDelete(Pkg); | |
803ea2a8 | 204 | |
fc4b5c9f | 205 | if (Purge == true) |
b2e465d6 | 206 | cout << "Purg "; |
fc4b5c9f | 207 | else |
b2e465d6 | 208 | cout << "Remv "; |
3826564e | 209 | Describe(Pkg,cout,true,false); |
6c139d6e AL |
210 | |
211 | if (Sim.BrokenCount() != 0) | |
212 | ShortBreaks(); | |
213 | else | |
04aa15a8 | 214 | cout << endl; |
6c139d6e AL |
215 | |
216 | return true; | |
217 | } | |
218 | /*}}}*/ | |
219 | // Simulate::ShortBreaks - Print out a short line describing all breaks /*{{{*/ | |
220 | // --------------------------------------------------------------------- | |
221 | /* */ | |
222 | void pkgSimulate::ShortBreaks() | |
223 | { | |
04aa15a8 | 224 | cout << " ["; |
f7f0d6c7 | 225 | for (PkgIterator I = Sim.PkgBegin(); I.end() == false; ++I) |
6c139d6e AL |
226 | { |
227 | if (Sim[I].InstBroken() == true) | |
228 | { | |
229 | if (Flags[I->ID] == 0) | |
47f6d1b7 | 230 | cout << I.FullName(false) << ' '; |
6c139d6e | 231 | /* else |
04aa15a8 | 232 | cout << I.Name() << "! ";*/ |
6c139d6e AL |
233 | } |
234 | } | |
04aa15a8 | 235 | cout << ']' << endl; |
6c139d6e AL |
236 | } |
237 | /*}}}*/ | |
238 | // ApplyStatus - Adjust for non-ok packages /*{{{*/ | |
239 | // --------------------------------------------------------------------- | |
240 | /* We attempt to change the state of the all packages that have failed | |
241 | installation toward their real state. The ordering code will perform | |
242 | the necessary calculations to deal with the problems. */ | |
243 | bool pkgApplyStatus(pkgDepCache &Cache) | |
244 | { | |
74a05226 MV |
245 | pkgDepCache::ActionGroup group(Cache); |
246 | ||
f7f0d6c7 | 247 | for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I) |
6c139d6e | 248 | { |
e481d5b0 AL |
249 | if (I->VersionList == 0) |
250 | continue; | |
251 | ||
d38b7b3d AL |
252 | // Only choice for a ReInstReq package is to reinstall |
253 | if (I->InstState == pkgCache::State::ReInstReq || | |
254 | I->InstState == pkgCache::State::HoldReInstReq) | |
255 | { | |
5871718b | 256 | if (I->CurrentVer != 0 && I.CurrentVer().Downloadable() == true) |
74a05226 | 257 | Cache.MarkKeep(I, false, false); |
813c8eea AL |
258 | else |
259 | { | |
260 | // Is this right? Will dpkg choke on an upgrade? | |
2a3f3893 AL |
261 | if (Cache[I].CandidateVer != 0 && |
262 | Cache[I].CandidateVerIter(Cache).Downloadable() == true) | |
74a05226 | 263 | Cache.MarkInstall(I, false, 0, false); |
813c8eea | 264 | else |
b2e465d6 | 265 | return _error->Error(_("The package %s needs to be reinstalled, " |
09a10f9c | 266 | "but I can't find an archive for it."),I.FullName(true).c_str()); |
813c8eea AL |
267 | } |
268 | ||
d38b7b3d AL |
269 | continue; |
270 | } | |
271 | ||
6c139d6e AL |
272 | switch (I->CurrentState) |
273 | { | |
813c8eea AL |
274 | /* This means installation failed somehow - it does not need to be |
275 | re-unpacked (probably) */ | |
b518cca6 AL |
276 | case pkgCache::State::UnPacked: |
277 | case pkgCache::State::HalfConfigured: | |
9d06bc80 MV |
278 | case pkgCache::State::TriggersAwaited: |
279 | case pkgCache::State::TriggersPending: | |
5871718b | 280 | if ((I->CurrentVer != 0 && I.CurrentVer().Downloadable() == true) || |
813c8eea | 281 | I.State() != pkgCache::PkgIterator::NeedsUnpack) |
74a05226 | 282 | Cache.MarkKeep(I, false, false); |
813c8eea AL |
283 | else |
284 | { | |
2a3f3893 AL |
285 | if (Cache[I].CandidateVer != 0 && |
286 | Cache[I].CandidateVerIter(Cache).Downloadable() == true) | |
74a05226 | 287 | Cache.MarkInstall(I, true, 0, false); |
813c8eea | 288 | else |
b83cad32 | 289 | Cache.MarkDelete(I, false, 0, false); |
813c8eea | 290 | } |
6c139d6e AL |
291 | break; |
292 | ||
293 | // This means removal failed | |
b518cca6 | 294 | case pkgCache::State::HalfInstalled: |
b83cad32 | 295 | Cache.MarkDelete(I, false, 0, false); |
6c139d6e AL |
296 | break; |
297 | ||
298 | default: | |
b518cca6 | 299 | if (I->InstState != pkgCache::State::Ok) |
6c139d6e | 300 | return _error->Error("The package %s is not ok and I " |
09a10f9c | 301 | "don't know how to fix it!",I.FullName(false).c_str()); |
6c139d6e AL |
302 | } |
303 | } | |
304 | return true; | |
305 | } | |
306 | /*}}}*/ | |
307 | // FixBroken - Fix broken packages /*{{{*/ | |
308 | // --------------------------------------------------------------------- | |
0a8e3465 AL |
309 | /* This autoinstalls every broken package and then runs the problem resolver |
310 | on the result. */ | |
6c139d6e AL |
311 | bool pkgFixBroken(pkgDepCache &Cache) |
312 | { | |
74a05226 MV |
313 | pkgDepCache::ActionGroup group(Cache); |
314 | ||
6c139d6e | 315 | // Auto upgrade all broken packages |
f7f0d6c7 | 316 | for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I) |
6c139d6e | 317 | if (Cache[I].NowBroken() == true) |
74a05226 | 318 | Cache.MarkInstall(I, true, 0, false); |
7e798dd7 | 319 | |
6c139d6e AL |
320 | /* Fix packages that are in a NeedArchive state but don't have a |
321 | downloadable install version */ | |
f7f0d6c7 | 322 | for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I) |
6c139d6e AL |
323 | { |
324 | if (I.State() != pkgCache::PkgIterator::NeedsUnpack || | |
325 | Cache[I].Delete() == true) | |
326 | continue; | |
327 | ||
b518cca6 | 328 | if (Cache[I].InstVerIter(Cache).Downloadable() == false) |
6c139d6e AL |
329 | continue; |
330 | ||
74a05226 | 331 | Cache.MarkInstall(I, true, 0, false); |
6c139d6e AL |
332 | } |
333 | ||
b2e465d6 | 334 | pkgProblemResolver Fix(&Cache); |
6c139d6e AL |
335 | return Fix.Resolve(true); |
336 | } | |
337 | /*}}}*/ | |
6c139d6e AL |
338 | // ProblemResolver::pkgProblemResolver - Constructor /*{{{*/ |
339 | // --------------------------------------------------------------------- | |
340 | /* */ | |
dcaa1185 | 341 | pkgProblemResolver::pkgProblemResolver(pkgDepCache *pCache) : d(NULL), Cache(*pCache) |
6c139d6e AL |
342 | { |
343 | // Allocate memory | |
b2e465d6 | 344 | unsigned long Size = Cache.Head().PackageCount; |
d0f2c87c | 345 | Scores = new int[Size]; |
6c139d6e AL |
346 | Flags = new unsigned char[Size]; |
347 | memset(Flags,0,sizeof(*Flags)*Size); | |
348 | ||
349 | // Set debug to true to see its decision logic | |
0a8e3465 | 350 | Debug = _config->FindB("Debug::pkgProblemResolver",false); |
6c139d6e AL |
351 | } |
352 | /*}}}*/ | |
b2e465d6 AL |
353 | // ProblemResolver::~pkgProblemResolver - Destructor /*{{{*/ |
354 | // --------------------------------------------------------------------- | |
355 | /* */ | |
356 | pkgProblemResolver::~pkgProblemResolver() | |
357 | { | |
358 | delete [] Scores; | |
359 | delete [] Flags; | |
360 | } | |
361 | /*}}}*/ | |
6c139d6e AL |
362 | // ProblemResolver::ScoreSort - Sort the list by score /*{{{*/ |
363 | // --------------------------------------------------------------------- | |
364 | /* */ | |
365 | int pkgProblemResolver::ScoreSort(const void *a,const void *b) | |
366 | { | |
367 | Package const **A = (Package const **)a; | |
368 | Package const **B = (Package const **)b; | |
369 | if (This->Scores[(*A)->ID] > This->Scores[(*B)->ID]) | |
370 | return -1; | |
371 | if (This->Scores[(*A)->ID] < This->Scores[(*B)->ID]) | |
372 | return 1; | |
373 | return 0; | |
374 | } | |
375 | /*}}}*/ | |
376 | // ProblemResolver::MakeScores - Make the score table /*{{{*/ | |
377 | // --------------------------------------------------------------------- | |
378 | /* */ | |
379 | void pkgProblemResolver::MakeScores() | |
380 | { | |
b2e465d6 | 381 | unsigned long Size = Cache.Head().PackageCount; |
6c139d6e AL |
382 | memset(Scores,0,sizeof(*Scores)*Size); |
383 | ||
b9179170 MV |
384 | // maps to pkgCache::State::VerPriority: |
385 | // Required Important Standard Optional Extra | |
d0f2c87c | 386 | int PrioMap[] = { |
8b4894fe | 387 | 0, |
84de0cea | 388 | _config->FindI("pkgProblemResolver::Scores::Required",3), |
b9179170 | 389 | _config->FindI("pkgProblemResolver::Scores::Important",2), |
d0f2c87c CW |
390 | _config->FindI("pkgProblemResolver::Scores::Standard",1), |
391 | _config->FindI("pkgProblemResolver::Scores::Optional",-1), | |
392 | _config->FindI("pkgProblemResolver::Scores::Extra",-2) | |
8b4894fe | 393 | }; |
d0f2c87c CW |
394 | int PrioEssentials = _config->FindI("pkgProblemResolver::Scores::Essentials",100); |
395 | int PrioInstalledAndNotObsolete = _config->FindI("pkgProblemResolver::Scores::NotObsolete",1); | |
8daf68e3 DK |
396 | int DepMap[] = { |
397 | 0, | |
398 | _config->FindI("pkgProblemResolver::Scores::Depends",1), | |
399 | _config->FindI("pkgProblemResolver::Scores::PreDepends",1), | |
400 | _config->FindI("pkgProblemResolver::Scores::Suggests",0), | |
401 | _config->FindI("pkgProblemResolver::Scores::Recommends",1), | |
402 | _config->FindI("pkgProblemResolver::Scores::Conflicts",-1), | |
403 | _config->FindI("pkgProblemResolver::Scores::Replaces",0), | |
404 | _config->FindI("pkgProblemResolver::Scores::Obsoletes",0), | |
405 | _config->FindI("pkgProblemResolver::Scores::Breaks",-1), | |
406 | _config->FindI("pkgProblemResolver::Scores::Enhances",0) | |
407 | }; | |
d0f2c87c CW |
408 | int AddProtected = _config->FindI("pkgProblemResolver::Scores::AddProtected",10000); |
409 | int AddEssential = _config->FindI("pkgProblemResolver::Scores::AddEssential",5000); | |
8b4894fe MV |
410 | |
411 | if (_config->FindB("Debug::pkgProblemResolver::ShowScores",false) == true) | |
412 | clog << "Settings used to calculate pkgProblemResolver::Scores::" << endl | |
84de0cea MV |
413 | << " Required => " << PrioMap[pkgCache::State::Required] << endl |
414 | << " Important => " << PrioMap[pkgCache::State::Important] << endl | |
415 | << " Standard => " << PrioMap[pkgCache::State::Standard] << endl | |
416 | << " Optional => " << PrioMap[pkgCache::State::Optional] << endl | |
417 | << " Extra => " << PrioMap[pkgCache::State::Extra] << endl | |
8b4894fe MV |
418 | << " Essentials => " << PrioEssentials << endl |
419 | << " InstalledAndNotObsolete => " << PrioInstalledAndNotObsolete << endl | |
8daf68e3 DK |
420 | << " Pre-Depends => " << DepMap[pkgCache::Dep::PreDepends] << endl |
421 | << " Depends => " << DepMap[pkgCache::Dep::Depends] << endl | |
422 | << " Recommends => " << DepMap[pkgCache::Dep::Recommends] << endl | |
423 | << " Suggests => " << DepMap[pkgCache::Dep::Suggests] << endl | |
424 | << " Conflicts => " << DepMap[pkgCache::Dep::Conflicts] << endl | |
425 | << " Breaks => " << DepMap[pkgCache::Dep::DpkgBreaks] << endl | |
426 | << " Replaces => " << DepMap[pkgCache::Dep::Replaces] << endl | |
427 | << " Obsoletes => " << DepMap[pkgCache::Dep::Obsoletes] << endl | |
428 | << " Enhances => " << DepMap[pkgCache::Dep::Enhances] << endl | |
8b4894fe MV |
429 | << " AddProtected => " << AddProtected << endl |
430 | << " AddEssential => " << AddEssential << endl; | |
431 | ||
6c139d6e | 432 | // Generate the base scores for a package based on its properties |
f7f0d6c7 | 433 | for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I) |
6c139d6e AL |
434 | { |
435 | if (Cache[I].InstallVer == 0) | |
436 | continue; | |
437 | ||
d0f2c87c | 438 | int &Score = Scores[I->ID]; |
6c139d6e | 439 | |
7365ff46 | 440 | /* This is arbitrary, it should be high enough to elevate an |
6c139d6e AL |
441 | essantial package above most other packages but low enough |
442 | to allow an obsolete essential packages to be removed by | |
1e3f4083 | 443 | a conflicts on a powerful normal package (ie libc6) */ |
c5200869 JAK |
444 | if ((I->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential |
445 | || (I->Flags & pkgCache::Flag::Important) == pkgCache::Flag::Important) | |
8b4894fe | 446 | Score += PrioEssentials; |
6c139d6e | 447 | |
4cd4a2e7 DK |
448 | pkgCache::VerIterator const InstVer = Cache[I].InstVerIter(Cache); |
449 | // We apply priorities only to downloadable packages, all others are prio:extra | |
450 | // as an obsolete prio:standard package can't be that standard anymore… | |
451 | if (InstVer->Priority <= pkgCache::State::Extra && InstVer.Downloadable() == true) | |
452 | Score += PrioMap[InstVer->Priority]; | |
453 | else | |
454 | Score += PrioMap[pkgCache::State::Extra]; | |
455 | ||
6c139d6e | 456 | /* This helps to fix oddball problems with conflicting packages |
4cd4a2e7 DK |
457 | on the same level. We enhance the score of installed packages |
458 | if those are not obsolete */ | |
020daa7b | 459 | if (I->CurrentVer != 0 && Cache[I].CandidateVer != 0 && Cache[I].CandidateVerIter(Cache).Downloadable()) |
8b4894fe | 460 | Score += PrioInstalledAndNotObsolete; |
8daf68e3 | 461 | |
cb4b85b0 | 462 | // propagate score points along dependencies |
4cd4a2e7 | 463 | for (pkgCache::DepIterator D = InstVer.DependsList(); D.end() == false; ++D) |
9ec748ff DK |
464 | { |
465 | if (DepMap[D->Type] == 0) | |
466 | continue; | |
467 | pkgCache::PkgIterator const T = D.TargetPkg(); | |
468 | if (D->Version != 0) | |
469 | { | |
470 | pkgCache::VerIterator const IV = Cache[T].InstVerIter(Cache); | |
471 | if (IV.end() == true || D.IsSatisfied(IV) != D.IsNegative()) | |
472 | continue; | |
473 | } | |
474 | Scores[T->ID] += DepMap[D->Type]; | |
475 | } | |
8daf68e3 DK |
476 | } |
477 | ||
6c139d6e | 478 | // Copy the scores to advoid additive looping |
d0f2c87c | 479 | SPtrArray<int> OldScores = new int[Size]; |
6c139d6e AL |
480 | memcpy(OldScores,Scores,sizeof(*Scores)*Size); |
481 | ||
482 | /* Now we cause 1 level of dependency inheritance, that is we add the | |
483 | score of the packages that depend on the target Package. This | |
484 | fortifies high scoring packages */ | |
f7f0d6c7 | 485 | for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I) |
6c139d6e AL |
486 | { |
487 | if (Cache[I].InstallVer == 0) | |
488 | continue; | |
489 | ||
f7f0d6c7 | 490 | for (pkgCache::DepIterator D = I.RevDependsList(); D.end() == false; ++D) |
6c139d6e AL |
491 | { |
492 | // Only do it for the install version | |
493 | if ((pkgCache::Version *)D.ParentVer() != Cache[D.ParentPkg()].InstallVer || | |
3a998f6a MV |
494 | (D->Type != pkgCache::Dep::Depends && |
495 | D->Type != pkgCache::Dep::PreDepends && | |
496 | D->Type != pkgCache::Dep::Recommends)) | |
6c139d6e AL |
497 | continue; |
498 | ||
dec5b117 MV |
499 | // Do not propagate negative scores otherwise |
500 | // an extra (-2) package might score better than an optional (-1) | |
501 | if (OldScores[D.ParentPkg()->ID] > 0) | |
502 | Scores[I->ID] += OldScores[D.ParentPkg()->ID]; | |
6c139d6e AL |
503 | } |
504 | } | |
505 | ||
1e3f4083 | 506 | /* Now we propagate along provides. This makes the packages that |
6c139d6e | 507 | provide important packages extremely important */ |
f7f0d6c7 | 508 | for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I) |
6c139d6e | 509 | { |
f7f0d6c7 | 510 | for (pkgCache::PrvIterator P = I.ProvidesList(); P.end() == false; ++P) |
6c139d6e AL |
511 | { |
512 | // Only do it once per package | |
513 | if ((pkgCache::Version *)P.OwnerVer() != Cache[P.OwnerPkg()].InstallVer) | |
514 | continue; | |
515 | Scores[P.OwnerPkg()->ID] += abs(Scores[I->ID] - OldScores[I->ID]); | |
516 | } | |
517 | } | |
518 | ||
519 | /* Protected things are pushed really high up. This number should put them | |
520 | ahead of everything */ | |
f7f0d6c7 | 521 | for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I) |
d2685fd6 | 522 | { |
6c139d6e | 523 | if ((Flags[I->ID] & Protected) != 0) |
8b4894fe | 524 | Scores[I->ID] += AddProtected; |
c5200869 JAK |
525 | if ((I->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential || |
526 | (I->Flags & pkgCache::Flag::Important) == pkgCache::Flag::Important) | |
8b4894fe MV |
527 | Scores[I->ID] += AddEssential; |
528 | } | |
6c139d6e AL |
529 | } |
530 | /*}}}*/ | |
531 | // ProblemResolver::DoUpgrade - Attempt to upgrade this package /*{{{*/ | |
532 | // --------------------------------------------------------------------- | |
533 | /* This goes through and tries to reinstall packages to make this package | |
534 | installable */ | |
535 | bool pkgProblemResolver::DoUpgrade(pkgCache::PkgIterator Pkg) | |
536 | { | |
74a05226 MV |
537 | pkgDepCache::ActionGroup group(Cache); |
538 | ||
6c139d6e AL |
539 | if ((Flags[Pkg->ID] & Upgradable) == 0 || Cache[Pkg].Upgradable() == false) |
540 | return false; | |
3a486305 AL |
541 | if ((Flags[Pkg->ID] & Protected) == Protected) |
542 | return false; | |
0a8e3465 | 543 | |
6c139d6e AL |
544 | Flags[Pkg->ID] &= ~Upgradable; |
545 | ||
546 | bool WasKept = Cache[Pkg].Keep(); | |
74a05226 | 547 | Cache.MarkInstall(Pkg, false, 0, false); |
6c139d6e | 548 | |
0a8e3465 AL |
549 | // This must be a virtual package or something like that. |
550 | if (Cache[Pkg].InstVerIter(Cache).end() == true) | |
551 | return false; | |
552 | ||
6c139d6e AL |
553 | // Isolate the problem dependency |
554 | bool Fail = false; | |
555 | for (pkgCache::DepIterator D = Cache[Pkg].InstVerIter(Cache).DependsList(); D.end() == false;) | |
556 | { | |
557 | // Compute a single dependency element (glob or) | |
558 | pkgCache::DepIterator Start = D; | |
559 | pkgCache::DepIterator End = D; | |
4b1b89c5 | 560 | for (bool LastOR = true; D.end() == false && LastOR == true;) |
6c139d6e | 561 | { |
b518cca6 | 562 | LastOR = (D->CompareOp & pkgCache::Dep::Or) == pkgCache::Dep::Or; |
0284eee4 | 563 | ++D; |
6c139d6e AL |
564 | if (LastOR == true) |
565 | End = D; | |
566 | } | |
567 | ||
568 | // We only worry about critical deps. | |
569 | if (End.IsCritical() != true) | |
570 | continue; | |
4b1b89c5 AL |
571 | |
572 | // Iterate over all the members in the or group | |
573 | while (1) | |
0a8e3465 | 574 | { |
4b1b89c5 AL |
575 | // Dep is ok now |
576 | if ((Cache[End] & pkgDepCache::DepGInstall) == pkgDepCache::DepGInstall) | |
577 | break; | |
578 | ||
579 | // Do not change protected packages | |
580 | PkgIterator P = Start.SmartTargetPkg(); | |
581 | if ((Flags[P->ID] & Protected) == Protected) | |
582 | { | |
583 | if (Debug == true) | |
47f6d1b7 | 584 | clog << " Reinst Failed because of protected " << P.FullName(false) << endl; |
4b1b89c5 | 585 | Fail = true; |
4b1b89c5 | 586 | } |
648e3cb4 | 587 | else |
6c139d6e | 588 | { |
648e3cb4 AL |
589 | // Upgrade the package if the candidate version will fix the problem. |
590 | if ((Cache[Start] & pkgDepCache::DepCVer) == pkgDepCache::DepCVer) | |
591 | { | |
592 | if (DoUpgrade(P) == false) | |
593 | { | |
594 | if (Debug == true) | |
47f6d1b7 | 595 | clog << " Reinst Failed because of " << P.FullName(false) << endl; |
648e3cb4 AL |
596 | Fail = true; |
597 | } | |
598 | else | |
599 | { | |
600 | Fail = false; | |
601 | break; | |
602 | } | |
603 | } | |
604 | else | |
4b1b89c5 | 605 | { |
648e3cb4 AL |
606 | /* We let the algorithm deal with conflicts on its next iteration, |
607 | it is much smarter than us */ | |
359e46db | 608 | if (Start.IsNegative() == true) |
b2e465d6 | 609 | break; |
648e3cb4 | 610 | |
4b1b89c5 | 611 | if (Debug == true) |
47f6d1b7 | 612 | clog << " Reinst Failed early because of " << Start.TargetPkg().FullName(false) << endl; |
4b1b89c5 | 613 | Fail = true; |
648e3cb4 | 614 | } |
4b1b89c5 | 615 | } |
6c139d6e | 616 | |
4b1b89c5 AL |
617 | if (Start == End) |
618 | break; | |
f7f0d6c7 | 619 | ++Start; |
4b1b89c5 AL |
620 | } |
621 | if (Fail == true) | |
6c139d6e | 622 | break; |
6c139d6e AL |
623 | } |
624 | ||
625 | // Undo our operations - it might be smart to undo everything this did.. | |
626 | if (Fail == true) | |
627 | { | |
628 | if (WasKept == true) | |
74a05226 | 629 | Cache.MarkKeep(Pkg, false, false); |
6c139d6e | 630 | else |
b83cad32 | 631 | Cache.MarkDelete(Pkg, false, 0, false); |
6c139d6e AL |
632 | return false; |
633 | } | |
634 | ||
635 | if (Debug == true) | |
47f6d1b7 | 636 | clog << " Re-Instated " << Pkg.FullName(false) << endl; |
6c139d6e AL |
637 | return true; |
638 | } | |
639 | /*}}}*/ | |
6d38011b DK |
640 | // ProblemResolver::Resolve - calls a resolver to fix the situation /*{{{*/ |
641 | // --------------------------------------------------------------------- | |
642 | /* */ | |
fa5404ab DK |
643 | #if APT_PKG_ABI < 413 |
644 | bool pkgProblemResolver::Resolve(bool BrokenFix) | |
645 | { | |
646 | return Resolve(BrokenFix, NULL); | |
647 | } | |
648 | #endif | |
2a884c61 | 649 | bool pkgProblemResolver::Resolve(bool BrokenFix, OpProgress * const Progress) |
6d38011b | 650 | { |
98278a81 | 651 | std::string const solver = _config->Find("APT::Solver", "internal"); |
2a884c61 DK |
652 | if (solver != "internal") |
653 | return EDSP::ResolveExternal(solver.c_str(), Cache, false, false, false, Progress); | |
6d38011b DK |
654 | return ResolveInternal(BrokenFix); |
655 | } | |
656 | /*}}}*/ | |
657 | // ProblemResolver::ResolveInternal - Run the resolution pass /*{{{*/ | |
6c139d6e AL |
658 | // --------------------------------------------------------------------- |
659 | /* This routines works by calculating a score for each package. The score | |
660 | is derived by considering the package's priority and all reverse | |
661 | dependents giving an integer that reflects the amount of breakage that | |
662 | adjusting the package will inflict. | |
663 | ||
664 | It goes from highest score to lowest and corrects all of the breaks by | |
1e3f4083 | 665 | keeping or removing the dependent packages. If that fails then it removes |
6c139d6e AL |
666 | the package itself and goes on. The routine should be able to intelligently |
667 | go from any broken state to a fixed state. | |
668 | ||
669 | The BrokenFix flag enables a mode where the algorithm tries to | |
670 | upgrade packages to advoid problems. */ | |
6d38011b | 671 | bool pkgProblemResolver::ResolveInternal(bool const BrokenFix) |
6c139d6e | 672 | { |
74a05226 MV |
673 | pkgDepCache::ActionGroup group(Cache); |
674 | ||
6c139d6e AL |
675 | // Record which packages are marked for install |
676 | bool Again = false; | |
677 | do | |
678 | { | |
679 | Again = false; | |
f7f0d6c7 | 680 | for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I) |
6c139d6e AL |
681 | { |
682 | if (Cache[I].Install() == true) | |
683 | Flags[I->ID] |= PreInstalled; | |
684 | else | |
685 | { | |
686 | if (Cache[I].InstBroken() == true && BrokenFix == true) | |
687 | { | |
74a05226 | 688 | Cache.MarkInstall(I, false, 0, false); |
6c139d6e AL |
689 | if (Cache[I].Install() == true) |
690 | Again = true; | |
691 | } | |
692 | ||
693 | Flags[I->ID] &= ~PreInstalled; | |
694 | } | |
695 | Flags[I->ID] |= Upgradable; | |
696 | } | |
697 | } | |
698 | while (Again == true); | |
699 | ||
32b5dd08 | 700 | if (Debug == true) { |
49b49018 MV |
701 | clog << "Starting pkgProblemResolver with broken count: " |
702 | << Cache.BrokenCount() << endl; | |
32b5dd08 | 703 | } |
6c139d6e AL |
704 | |
705 | MakeScores(); | |
6d38011b DK |
706 | |
707 | unsigned long const Size = Cache.Head().PackageCount; | |
708 | ||
6c139d6e AL |
709 | /* We have to order the packages so that the broken fixing pass |
710 | operates from highest score to lowest. This prevents problems when | |
711 | high score packages cause the removal of lower score packages that | |
712 | would cause the removal of even lower score packages. */ | |
b2e465d6 | 713 | SPtrArray<pkgCache::Package *> PList = new pkgCache::Package *[Size]; |
6c139d6e | 714 | pkgCache::Package **PEnd = PList; |
f7f0d6c7 | 715 | for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I) |
6c139d6e AL |
716 | *PEnd++ = I; |
717 | This = this; | |
718 | qsort(PList,PEnd - PList,sizeof(*PList),&ScoreSort); | |
8b4894fe MV |
719 | |
720 | if (_config->FindB("Debug::pkgProblemResolver::ShowScores",false) == true) | |
721 | { | |
722 | clog << "Show Scores" << endl; | |
723 | for (pkgCache::Package **K = PList; K != PEnd; K++) | |
724 | if (Scores[(*K)->ID] != 0) | |
725 | { | |
726 | pkgCache::PkgIterator Pkg(Cache,*K); | |
727 | clog << Scores[(*K)->ID] << ' ' << Pkg << std::endl; | |
728 | } | |
729 | } | |
6c139d6e | 730 | |
32b5dd08 | 731 | if (Debug == true) { |
49b49018 MV |
732 | clog << "Starting 2 pkgProblemResolver with broken count: " |
733 | << Cache.BrokenCount() << endl; | |
32b5dd08 | 734 | } |
8b4894fe | 735 | |
6c139d6e AL |
736 | /* Now consider all broken packages. For each broken package we either |
737 | remove the package or fix it's problem. We do this once, it should | |
738 | not be possible for a loop to form (that is a < b < c and fixing b by | |
739 | changing a breaks c) */ | |
740 | bool Change = true; | |
09a10f9c | 741 | bool const TryFixByInstall = _config->FindB("pkgProblemResolver::FixByInstall", true); |
6c139d6e AL |
742 | for (int Counter = 0; Counter != 10 && Change == true; Counter++) |
743 | { | |
744 | Change = false; | |
745 | for (pkgCache::Package **K = PList; K != PEnd; K++) | |
746 | { | |
747 | pkgCache::PkgIterator I(Cache,*K); | |
748 | ||
749 | /* We attempt to install this and see if any breaks result, | |
750 | this takes care of some strange cases */ | |
751 | if (Cache[I].CandidateVer != Cache[I].InstallVer && | |
752 | I->CurrentVer != 0 && Cache[I].InstallVer != 0 && | |
753 | (Flags[I->ID] & PreInstalled) != 0 && | |
0a8e3465 AL |
754 | (Flags[I->ID] & Protected) == 0 && |
755 | (Flags[I->ID] & ReInstateTried) == 0) | |
6c139d6e AL |
756 | { |
757 | if (Debug == true) | |
09a10f9c | 758 | clog << " Try to Re-Instate (" << Counter << ") " << I.FullName(false) << endl; |
a6568219 | 759 | unsigned long OldBreaks = Cache.BrokenCount(); |
6c139d6e | 760 | pkgCache::Version *OldVer = Cache[I].InstallVer; |
0a8e3465 AL |
761 | Flags[I->ID] &= ReInstateTried; |
762 | ||
74a05226 | 763 | Cache.MarkInstall(I, false, 0, false); |
6c139d6e AL |
764 | if (Cache[I].InstBroken() == true || |
765 | OldBreaks < Cache.BrokenCount()) | |
766 | { | |
767 | if (OldVer == 0) | |
b83cad32 | 768 | Cache.MarkDelete(I, false, 0, false); |
6c139d6e | 769 | else |
74a05226 | 770 | Cache.MarkKeep(I, false, false); |
6c139d6e AL |
771 | } |
772 | else | |
773 | if (Debug == true) | |
47f6d1b7 | 774 | clog << "Re-Instated " << I.FullName(false) << " (" << OldBreaks << " vs " << Cache.BrokenCount() << ')' << endl; |
6c139d6e AL |
775 | } |
776 | ||
777 | if (Cache[I].InstallVer == 0 || Cache[I].InstBroken() == false) | |
778 | continue; | |
779 | ||
00b47c98 | 780 | if (Debug == true) |
09a10f9c | 781 | clog << "Investigating (" << Counter << ") " << I << endl; |
00b47c98 | 782 | |
6c139d6e AL |
783 | // Isolate the problem dependency |
784 | PackageKill KillList[100]; | |
785 | PackageKill *LEnd = KillList; | |
421c8d10 AL |
786 | bool InOr = false; |
787 | pkgCache::DepIterator Start; | |
788 | pkgCache::DepIterator End; | |
b2e465d6 | 789 | PackageKill *OldEnd = LEnd; |
648e3cb4 AL |
790 | |
791 | enum {OrRemove,OrKeep} OrOp = OrRemove; | |
421c8d10 AL |
792 | for (pkgCache::DepIterator D = Cache[I].InstVerIter(Cache).DependsList(); |
793 | D.end() == false || InOr == true;) | |
6c139d6e AL |
794 | { |
795 | // Compute a single dependency element (glob or) | |
648e3cb4 AL |
796 | if (Start == End) |
797 | { | |
798 | // Decide what to do | |
09a10f9c | 799 | if (InOr == true && OldEnd == LEnd) |
648e3cb4 | 800 | { |
09a10f9c | 801 | if (OrOp == OrRemove) |
70777d4b AL |
802 | { |
803 | if ((Flags[I->ID] & Protected) != Protected) | |
00b47c98 AL |
804 | { |
805 | if (Debug == true) | |
47f6d1b7 | 806 | clog << " Or group remove for " << I.FullName(false) << endl; |
b83cad32 | 807 | Cache.MarkDelete(I, false, 0, false); |
cd14eaf2 | 808 | Change = true; |
09a10f9c DK |
809 | } |
810 | } | |
811 | else if (OrOp == OrKeep) | |
00b47c98 AL |
812 | { |
813 | if (Debug == true) | |
47f6d1b7 | 814 | clog << " Or group keep for " << I.FullName(false) << endl; |
74a05226 | 815 | Cache.MarkKeep(I, false, false); |
cd14eaf2 | 816 | Change = true; |
b2e465d6 | 817 | } |
648e3cb4 AL |
818 | } |
819 | ||
b2e465d6 AL |
820 | /* We do an extra loop (as above) to finalize the or group |
821 | processing */ | |
822 | InOr = false; | |
648e3cb4 | 823 | OrOp = OrRemove; |
421c8d10 | 824 | D.GlobOr(Start,End); |
b2e465d6 AL |
825 | if (Start.end() == true) |
826 | break; | |
cd14eaf2 | 827 | |
b2e465d6 AL |
828 | // We only worry about critical deps. |
829 | if (End.IsCritical() != true) | |
830 | continue; | |
cd14eaf2 | 831 | |
648e3cb4 AL |
832 | InOr = Start != End; |
833 | OldEnd = LEnd; | |
cd14eaf2 | 834 | } |
421c8d10 | 835 | else |
4cc152f9 | 836 | { |
f7f0d6c7 | 837 | ++Start; |
4cc152f9 MV |
838 | // We only worry about critical deps. |
839 | if (Start.IsCritical() != true) | |
840 | continue; | |
841 | } | |
cd14eaf2 | 842 | |
6c139d6e AL |
843 | // Dep is ok |
844 | if ((Cache[End] & pkgDepCache::DepGInstall) == pkgDepCache::DepGInstall) | |
cd14eaf2 AL |
845 | { |
846 | InOr = false; | |
6c139d6e | 847 | continue; |
cd14eaf2 AL |
848 | } |
849 | ||
6c139d6e | 850 | if (Debug == true) |
47f6d1b7 | 851 | clog << "Broken " << Start << endl; |
fcf85120 AL |
852 | |
853 | /* Look across the version list. If there are no possible | |
854 | targets then we keep the package and bail. This is necessary | |
1e3f4083 | 855 | if a package has a dep on another package that can't be found */ |
b2e465d6 | 856 | SPtrArray<pkgCache::Version *> VList = Start.AllTargets(); |
fcf85120 | 857 | if (*VList == 0 && (Flags[I->ID] & Protected) != Protected && |
359e46db | 858 | Start.IsNegative() == false && |
fcf85120 | 859 | Cache[I].NowBroken() == false) |
648e3cb4 AL |
860 | { |
861 | if (InOr == true) | |
862 | { | |
863 | /* No keep choice because the keep being OK could be the | |
864 | result of another element in the OR group! */ | |
865 | continue; | |
866 | } | |
867 | ||
fcf85120 | 868 | Change = true; |
74a05226 | 869 | Cache.MarkKeep(I, false, false); |
fcf85120 AL |
870 | break; |
871 | } | |
872 | ||
6c139d6e AL |
873 | bool Done = false; |
874 | for (pkgCache::Version **V = VList; *V != 0; V++) | |
875 | { | |
876 | pkgCache::VerIterator Ver(Cache,*V); | |
877 | pkgCache::PkgIterator Pkg = Ver.ParentPkg(); | |
a6bfe583 | 878 | |
2ba99db8 MV |
879 | /* This is a conflicts, and the version we are looking |
880 | at is not the currently selected version of the | |
881 | package, which means it is not necessary to | |
882 | remove/keep */ | |
359e46db | 883 | if (Cache[Pkg].InstallVer != Ver && Start.IsNegative() == true) |
4429616b | 884 | { |
2ba99db8 MV |
885 | if (Debug) |
886 | clog << " Conflicts//Breaks against version " | |
887 | << Ver.VerStr() << " for " << Pkg.Name() | |
888 | << " but that is not InstVer, ignoring" | |
24e93662 | 889 | << endl; |
2ba99db8 | 890 | continue; |
4429616b MV |
891 | } |
892 | ||
6c139d6e | 893 | if (Debug == true) |
e788a834 DK |
894 | clog << " Considering " << Pkg.FullName(false) << ' ' << Scores[Pkg->ID] << |
895 | " as a solution to " << I.FullName(false) << ' ' << Scores[I->ID] << endl; | |
a6bfe583 AL |
896 | |
897 | /* Try to fix the package under consideration rather than | |
898 | fiddle with the VList package */ | |
6c139d6e | 899 | if (Scores[I->ID] <= Scores[Pkg->ID] || |
421c8d10 | 900 | ((Cache[Start] & pkgDepCache::DepNow) == 0 && |
359e46db | 901 | End.IsNegative() == false)) |
6c139d6e | 902 | { |
200f8c52 | 903 | // Try a little harder to fix protected packages.. |
3b5421b4 | 904 | if ((Flags[I->ID] & Protected) == Protected) |
200f8c52 AL |
905 | { |
906 | if (DoUpgrade(Pkg) == true) | |
0296c633 | 907 | { |
b2e465d6 AL |
908 | if (Scores[Pkg->ID] > Scores[I->ID]) |
909 | Scores[Pkg->ID] = Scores[I->ID]; | |
0296c633 AL |
910 | break; |
911 | } | |
912 | ||
6c139d6e | 913 | continue; |
200f8c52 AL |
914 | } |
915 | ||
916 | /* See if a keep will do, unless the package is protected, | |
648e3cb4 AL |
917 | then installing it will be necessary */ |
918 | bool Installed = Cache[I].Install(); | |
74a05226 | 919 | Cache.MarkKeep(I, false, false); |
6c139d6e AL |
920 | if (Cache[I].InstBroken() == false) |
921 | { | |
648e3cb4 AL |
922 | // Unwind operation will be keep now |
923 | if (OrOp == OrRemove) | |
924 | OrOp = OrKeep; | |
925 | ||
926 | // Restore | |
927 | if (InOr == true && Installed == true) | |
74a05226 | 928 | Cache.MarkInstall(I, false, 0, false); |
648e3cb4 | 929 | |
6c139d6e | 930 | if (Debug == true) |
47f6d1b7 | 931 | clog << " Holding Back " << I.FullName(false) << " rather than change " << Start.TargetPkg().FullName(false) << endl; |
6c139d6e AL |
932 | } |
933 | else | |
421c8d10 | 934 | { |
6c139d6e AL |
935 | if (BrokenFix == false || DoUpgrade(I) == false) |
936 | { | |
421c8d10 | 937 | // Consider other options |
87da7451 | 938 | if (InOr == false || Cache[I].Garbage == true) |
421c8d10 | 939 | { |
6910a2ac | 940 | if (Debug == true) |
47f6d1b7 | 941 | clog << " Removing " << I.FullName(false) << " rather than change " << Start.TargetPkg().FullName(false) << endl; |
b83cad32 | 942 | Cache.MarkDelete(I, false, 0, false); |
6910a2ac DK |
943 | if (Counter > 1 && Scores[Pkg->ID] > Scores[I->ID]) |
944 | Scores[I->ID] = Scores[Pkg->ID]; | |
d6ebeb21 | 945 | } |
09a10f9c DK |
946 | else if (TryFixByInstall == true && |
947 | Start.TargetPkg()->CurrentVer == 0 && | |
948 | Cache[Start.TargetPkg()].Delete() == false && | |
a3f1a6cc | 949 | (Flags[Start.TargetPkg()->ID] & ToRemove) != ToRemove && |
09a10f9c DK |
950 | Cache.GetCandidateVer(Start.TargetPkg()).end() == false) |
951 | { | |
952 | /* Before removing or keeping the package with the broken dependency | |
953 | try instead to install the first not previously installed package | |
954 | solving this dependency. This helps every time a previous solver | |
955 | is removed by the resolver because of a conflict or alike but it is | |
956 | dangerous as it could trigger new breaks/conflicts… */ | |
443266ef DK |
957 | if (Debug == true) |
958 | clog << " Try Installing " << Start.TargetPkg() << " before changing " << I.FullName(false) << std::endl; | |
09a10f9c DK |
959 | unsigned long const OldBroken = Cache.BrokenCount(); |
960 | Cache.MarkInstall(Start.TargetPkg(), true, 1, false); | |
961 | // FIXME: we should undo the complete MarkInstall process here | |
962 | if (Cache[Start.TargetPkg()].InstBroken() == true || Cache.BrokenCount() > OldBroken) | |
963 | Cache.MarkDelete(Start.TargetPkg(), false, 1, false); | |
964 | } | |
0a8e3465 | 965 | } |
6c139d6e | 966 | } |
b5dc9785 | 967 | |
6c139d6e AL |
968 | Change = true; |
969 | Done = true; | |
970 | break; | |
971 | } | |
972 | else | |
973 | { | |
308c7d30 IJ |
974 | if (Start->Type == pkgCache::Dep::DpkgBreaks) |
975 | { | |
76264cb7 MV |
976 | // first, try upgradring the package, if that |
977 | // does not help, the breaks goes onto the | |
978 | // kill list | |
2ba99db8 | 979 | // |
76264cb7 | 980 | // FIXME: use DoUpgrade(Pkg) instead? |
2ba99db8 | 981 | if (Cache[End] & pkgDepCache::DepGCVer) |
76264cb7 | 982 | { |
308c7d30 | 983 | if (Debug) |
47f6d1b7 | 984 | clog << " Upgrading " << Pkg.FullName(false) << " due to Breaks field in " << I.FullName(false) << endl; |
308c7d30 IJ |
985 | Cache.MarkInstall(Pkg, false, 0, false); |
986 | continue; | |
987 | } | |
308c7d30 IJ |
988 | } |
989 | ||
648e3cb4 | 990 | // Skip adding to the kill list if it is protected |
6c139d6e AL |
991 | if ((Flags[Pkg->ID] & Protected) != 0) |
992 | continue; | |
a6bfe583 AL |
993 | |
994 | if (Debug == true) | |
47f6d1b7 | 995 | clog << " Added " << Pkg.FullName(false) << " to the remove list" << endl; |
6c139d6e AL |
996 | |
997 | LEnd->Pkg = Pkg; | |
998 | LEnd->Dep = End; | |
999 | LEnd++; | |
0a8e3465 | 1000 | |
b47053bd | 1001 | if (Start.IsNegative() == false) |
6c139d6e AL |
1002 | break; |
1003 | } | |
1004 | } | |
1005 | ||
1006 | // Hm, nothing can possibly satisify this dep. Nuke it. | |
359e46db DK |
1007 | if (VList[0] == 0 && |
1008 | Start.IsNegative() == false && | |
648e3cb4 | 1009 | (Flags[I->ID] & Protected) != Protected) |
6c139d6e | 1010 | { |
648e3cb4 | 1011 | bool Installed = Cache[I].Install(); |
6c139d6e AL |
1012 | Cache.MarkKeep(I); |
1013 | if (Cache[I].InstBroken() == false) | |
1014 | { | |
648e3cb4 AL |
1015 | // Unwind operation will be keep now |
1016 | if (OrOp == OrRemove) | |
1017 | OrOp = OrKeep; | |
1018 | ||
1019 | // Restore | |
1020 | if (InOr == true && Installed == true) | |
74a05226 | 1021 | Cache.MarkInstall(I, false, 0, false); |
648e3cb4 | 1022 | |
6c139d6e | 1023 | if (Debug == true) |
47f6d1b7 | 1024 | clog << " Holding Back " << I.FullName(false) << " because I can't find " << Start.TargetPkg().FullName(false) << endl; |
6c139d6e AL |
1025 | } |
1026 | else | |
1027 | { | |
1028 | if (Debug == true) | |
47f6d1b7 | 1029 | clog << " Removing " << I.FullName(false) << " because I can't find " << Start.TargetPkg().FullName(false) << endl; |
648e3cb4 | 1030 | if (InOr == false) |
b83cad32 | 1031 | Cache.MarkDelete(I, false, 0, false); |
6c139d6e AL |
1032 | } |
1033 | ||
1034 | Change = true; | |
1035 | Done = true; | |
1036 | } | |
1037 | ||
421c8d10 AL |
1038 | // Try some more |
1039 | if (InOr == true) | |
1040 | continue; | |
1041 | ||
6c139d6e AL |
1042 | if (Done == true) |
1043 | break; | |
1044 | } | |
1045 | ||
1046 | // Apply the kill list now | |
1047 | if (Cache[I].InstallVer != 0) | |
648e3cb4 | 1048 | { |
6c139d6e | 1049 | for (PackageKill *J = KillList; J != LEnd; J++) |
6c139d6e | 1050 | { |
648e3cb4 AL |
1051 | Change = true; |
1052 | if ((Cache[J->Dep] & pkgDepCache::DepGNow) == 0) | |
1053 | { | |
359e46db | 1054 | if (J->Dep.IsNegative() == true) |
648e3cb4 AL |
1055 | { |
1056 | if (Debug == true) | |
47f6d1b7 | 1057 | clog << " Fixing " << I.FullName(false) << " via remove of " << J->Pkg.FullName(false) << endl; |
b83cad32 | 1058 | Cache.MarkDelete(J->Pkg, false, 0, false); |
648e3cb4 AL |
1059 | } |
1060 | } | |
1061 | else | |
6c139d6e AL |
1062 | { |
1063 | if (Debug == true) | |
47f6d1b7 | 1064 | clog << " Fixing " << I.FullName(false) << " via keep of " << J->Pkg.FullName(false) << endl; |
74a05226 | 1065 | Cache.MarkKeep(J->Pkg, false, false); |
6c139d6e | 1066 | } |
b2e465d6 | 1067 | |
648e3cb4 | 1068 | if (Counter > 1) |
b2e465d6 AL |
1069 | { |
1070 | if (Scores[I->ID] > Scores[J->Pkg->ID]) | |
1071 | Scores[J->Pkg->ID] = Scores[I->ID]; | |
1072 | } | |
648e3cb4 AL |
1073 | } |
1074 | } | |
1075 | } | |
6c139d6e AL |
1076 | } |
1077 | ||
1078 | if (Debug == true) | |
0a8e3465 | 1079 | clog << "Done" << endl; |
b2e465d6 | 1080 | |
6c139d6e | 1081 | if (Cache.BrokenCount() != 0) |
b5dc9785 AL |
1082 | { |
1083 | // See if this is the result of a hold | |
1084 | pkgCache::PkgIterator I = Cache.PkgBegin(); | |
f7f0d6c7 | 1085 | for (;I.end() != true; ++I) |
b5dc9785 AL |
1086 | { |
1087 | if (Cache[I].InstBroken() == false) | |
1088 | continue; | |
1089 | if ((Flags[I->ID] & Protected) != Protected) | |
b2e465d6 | 1090 | return _error->Error(_("Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages.")); |
b5dc9785 | 1091 | } |
b2e465d6 | 1092 | return _error->Error(_("Unable to correct problems, you have held broken packages.")); |
b5dc9785 AL |
1093 | } |
1094 | ||
fce72602 | 1095 | // set the auto-flags (mvo: I'm not sure if we _really_ need this) |
80fa0d8a | 1096 | pkgCache::PkgIterator I = Cache.PkgBegin(); |
f7f0d6c7 | 1097 | for (;I.end() != true; ++I) { |
80fa0d8a | 1098 | if (Cache[I].NewInstall() && !(Flags[I->ID] & PreInstalled)) { |
120365ce | 1099 | if(_config->FindI("Debug::pkgAutoRemove",false)) { |
47f6d1b7 | 1100 | std::clog << "Resolve installed new pkg: " << I.FullName(false) |
120365ce MV |
1101 | << " (now marking it as auto)" << std::endl; |
1102 | } | |
80fa0d8a MV |
1103 | Cache[I].Flags |= pkgCache::Flag::Auto; |
1104 | } | |
1105 | } | |
1106 | ||
1107 | ||
0a8e3465 AL |
1108 | return true; |
1109 | } | |
1110 | /*}}}*/ | |
953b348c MV |
1111 | // ProblemResolver::BreaksInstOrPolicy - Check if the given pkg is broken/*{{{*/ |
1112 | // --------------------------------------------------------------------- | |
1113 | /* This checks if the given package is broken either by a hard dependency | |
1114 | (InstBroken()) or by introducing a new policy breakage e.g. new | |
1115 | unsatisfied recommends for a package that was in "policy-good" state | |
1116 | ||
1117 | Note that this is not perfect as it will ignore further breakage | |
1118 | for already broken policy (recommends) | |
1119 | */ | |
1120 | bool pkgProblemResolver::InstOrNewPolicyBroken(pkgCache::PkgIterator I) | |
1121 | { | |
953b348c MV |
1122 | // a broken install is always a problem |
1123 | if (Cache[I].InstBroken() == true) | |
deec6474 DK |
1124 | { |
1125 | if (Debug == true) | |
1126 | std::clog << " Dependencies are not satisfied for " << I << std::endl; | |
953b348c | 1127 | return true; |
deec6474 | 1128 | } |
953b348c MV |
1129 | |
1130 | // a newly broken policy (recommends/suggests) is a problem | |
1131 | if (Cache[I].NowPolicyBroken() == false && | |
1132 | Cache[I].InstPolicyBroken() == true) | |
deec6474 DK |
1133 | { |
1134 | if (Debug == true) | |
1135 | std::clog << " Policy breaks with upgrade of " << I << std::endl; | |
953b348c | 1136 | return true; |
deec6474 DK |
1137 | } |
1138 | ||
953b348c MV |
1139 | return false; |
1140 | } | |
36a171e1 | 1141 | /*}}}*/ |
0a8e3465 AL |
1142 | // ProblemResolver::ResolveByKeep - Resolve problems using keep /*{{{*/ |
1143 | // --------------------------------------------------------------------- | |
1144 | /* This is the work horse of the soft upgrade routine. It is very gental | |
1145 | in that it does not install or remove any packages. It is assumed that the | |
1146 | system was non-broken previously. */ | |
fa5404ab DK |
1147 | #if APT_PKG_ABI < 413 |
1148 | bool pkgProblemResolver::ResolveByKeep() | |
1149 | { | |
1150 | return ResolveByKeep(NULL); | |
1151 | } | |
1152 | #endif | |
2a884c61 | 1153 | bool pkgProblemResolver::ResolveByKeep(OpProgress * const Progress) |
741b7da9 | 1154 | { |
98278a81 | 1155 | std::string const solver = _config->Find("APT::Solver", "internal"); |
2a884c61 DK |
1156 | if (solver != "internal") |
1157 | return EDSP::ResolveExternal(solver.c_str(), Cache, true, false, false, Progress); | |
741b7da9 DK |
1158 | return ResolveByKeepInternal(); |
1159 | } | |
1160 | /*}}}*/ | |
1161 | // ProblemResolver::ResolveByKeepInternal - Resolve problems using keep /*{{{*/ | |
1162 | // --------------------------------------------------------------------- | |
1163 | /* This is the work horse of the soft upgrade routine. It is very gental | |
1164 | in that it does not install or remove any packages. It is assumed that the | |
1165 | system was non-broken previously. */ | |
1166 | bool pkgProblemResolver::ResolveByKeepInternal() | |
0a8e3465 | 1167 | { |
74a05226 MV |
1168 | pkgDepCache::ActionGroup group(Cache); |
1169 | ||
b2e465d6 | 1170 | unsigned long Size = Cache.Head().PackageCount; |
0a8e3465 | 1171 | |
0a8e3465 AL |
1172 | MakeScores(); |
1173 | ||
1174 | /* We have to order the packages so that the broken fixing pass | |
1175 | operates from highest score to lowest. This prevents problems when | |
1176 | high score packages cause the removal of lower score packages that | |
1177 | would cause the removal of even lower score packages. */ | |
1178 | pkgCache::Package **PList = new pkgCache::Package *[Size]; | |
1179 | pkgCache::Package **PEnd = PList; | |
f7f0d6c7 | 1180 | for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I) |
0a8e3465 AL |
1181 | *PEnd++ = I; |
1182 | This = this; | |
1183 | qsort(PList,PEnd - PList,sizeof(*PList),&ScoreSort); | |
8b4894fe MV |
1184 | |
1185 | if (_config->FindB("Debug::pkgProblemResolver::ShowScores",false) == true) | |
1186 | { | |
1187 | clog << "Show Scores" << endl; | |
1188 | for (pkgCache::Package **K = PList; K != PEnd; K++) | |
1189 | if (Scores[(*K)->ID] != 0) | |
1190 | { | |
1191 | pkgCache::PkgIterator Pkg(Cache,*K); | |
1192 | clog << Scores[(*K)->ID] << ' ' << Pkg << std::endl; | |
1193 | } | |
1194 | } | |
1195 | ||
1196 | if (Debug == true) | |
1197 | clog << "Entering ResolveByKeep" << endl; | |
1198 | ||
0a8e3465 AL |
1199 | // Consider each broken package |
1200 | pkgCache::Package **LastStop = 0; | |
1201 | for (pkgCache::Package **K = PList; K != PEnd; K++) | |
1202 | { | |
1203 | pkgCache::PkgIterator I(Cache,*K); | |
1204 | ||
953b348c | 1205 | if (Cache[I].InstallVer == 0) |
0a8e3465 AL |
1206 | continue; |
1207 | ||
953b348c MV |
1208 | if (InstOrNewPolicyBroken(I) == false) |
1209 | continue; | |
1210 | ||
0a8e3465 | 1211 | /* Keep the package. If this works then great, otherwise we have |
1e3f4083 | 1212 | to be significantly more aggressive and manipulate its dependencies */ |
0a8e3465 AL |
1213 | if ((Flags[I->ID] & Protected) == 0) |
1214 | { | |
1215 | if (Debug == true) | |
47f6d1b7 | 1216 | clog << "Keeping package " << I.FullName(false) << endl; |
74a05226 | 1217 | Cache.MarkKeep(I, false, false); |
953b348c | 1218 | if (InstOrNewPolicyBroken(I) == false) |
0a8e3465 | 1219 | { |
b2e465d6 | 1220 | K = PList - 1; |
0a8e3465 AL |
1221 | continue; |
1222 | } | |
1223 | } | |
1224 | ||
1225 | // Isolate the problem dependencies | |
1226 | for (pkgCache::DepIterator D = Cache[I].InstVerIter(Cache).DependsList(); D.end() == false;) | |
1227 | { | |
c5532863 AL |
1228 | DepIterator Start; |
1229 | DepIterator End; | |
1230 | D.GlobOr(Start,End); | |
1231 | ||
0a8e3465 AL |
1232 | // We only worry about critical deps. |
1233 | if (End.IsCritical() != true) | |
1234 | continue; | |
1235 | ||
1236 | // Dep is ok | |
1237 | if ((Cache[End] & pkgDepCache::DepGInstall) == pkgDepCache::DepGInstall) | |
1238 | continue; | |
c5532863 AL |
1239 | |
1240 | /* Hm, the group is broken.. I suppose the best thing to do is to | |
1241 | is to try every combination of keep/not-keep for the set, but thats | |
1242 | slow, and this never happens, just be conservative and assume the | |
1243 | list of ors is in preference and keep till it starts to work. */ | |
1244 | while (true) | |
0a8e3465 | 1245 | { |
c5532863 | 1246 | if (Debug == true) |
47f6d1b7 | 1247 | clog << "Package " << I.FullName(false) << " " << Start << endl; |
8b4894fe | 1248 | |
c5532863 AL |
1249 | // Look at all the possible provides on this package |
1250 | SPtrArray<pkgCache::Version *> VList = Start.AllTargets(); | |
1251 | for (pkgCache::Version **V = VList; *V != 0; V++) | |
0a8e3465 | 1252 | { |
c5532863 AL |
1253 | pkgCache::VerIterator Ver(Cache,*V); |
1254 | pkgCache::PkgIterator Pkg = Ver.ParentPkg(); | |
1255 | ||
1256 | // It is not keepable | |
1257 | if (Cache[Pkg].InstallVer == 0 || | |
1258 | Pkg->CurrentVer == 0) | |
1259 | continue; | |
1260 | ||
1261 | if ((Flags[I->ID] & Protected) == 0) | |
1262 | { | |
1263 | if (Debug == true) | |
47f6d1b7 | 1264 | clog << " Keeping Package " << Pkg.FullName(false) << " due to " << Start.DepType() << endl; |
74a05226 | 1265 | Cache.MarkKeep(Pkg, false, false); |
c5532863 AL |
1266 | } |
1267 | ||
953b348c | 1268 | if (InstOrNewPolicyBroken(I) == false) |
c5532863 | 1269 | break; |
0a8e3465 AL |
1270 | } |
1271 | ||
953b348c | 1272 | if (InstOrNewPolicyBroken(I) == false) |
0a8e3465 | 1273 | break; |
0a8e3465 | 1274 | |
c5532863 AL |
1275 | if (Start == End) |
1276 | break; | |
f7f0d6c7 | 1277 | ++Start; |
c5532863 AL |
1278 | } |
1279 | ||
953b348c | 1280 | if (InstOrNewPolicyBroken(I) == false) |
0a8e3465 AL |
1281 | break; |
1282 | } | |
1283 | ||
953b348c | 1284 | if (InstOrNewPolicyBroken(I) == true) |
0a8e3465 AL |
1285 | continue; |
1286 | ||
1287 | // Restart again. | |
0291f645 JT |
1288 | if (K == LastStop) { |
1289 | // I is an iterator based off our temporary package list, | |
1290 | // so copy the name we need before deleting the temporary list | |
1291 | std::string const LoopingPackage = I.FullName(false); | |
1292 | delete[] PList; | |
1293 | return _error->Error("Internal Error, pkgProblemResolver::ResolveByKeep is looping on package %s.", LoopingPackage.c_str()); | |
1294 | } | |
0a8e3465 | 1295 | LastStop = K; |
b2e465d6 | 1296 | K = PList - 1; |
0291f645 | 1297 | } |
6c139d6e | 1298 | |
0291f645 | 1299 | delete[] PList; |
6c139d6e AL |
1300 | return true; |
1301 | } | |
1302 | /*}}}*/ | |
f3c736f9 | 1303 | // ProblemResolver::InstallProtect - deprecated cpu-eating no-op /*{{{*/ |
3b5421b4 | 1304 | // --------------------------------------------------------------------- |
f3c736f9 DK |
1305 | /* Actions issued with FromUser bit set are protected from further |
1306 | modification (expect by other calls with FromUser set) nowadays , so we | |
1307 | don't need to reissue actions here, they are already set in stone. */ | |
3b5421b4 AL |
1308 | void pkgProblemResolver::InstallProtect() |
1309 | { | |
74a05226 MV |
1310 | pkgDepCache::ActionGroup group(Cache); |
1311 | ||
f7f0d6c7 | 1312 | for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I) |
3b5421b4 AL |
1313 | { |
1314 | if ((Flags[I->ID] & Protected) == Protected) | |
1315 | { | |
1316 | if ((Flags[I->ID] & ToRemove) == ToRemove) | |
1317 | Cache.MarkDelete(I); | |
c15f5690 MV |
1318 | else |
1319 | { | |
da543ed8 OS |
1320 | // preserve the information whether the package was auto |
1321 | // or manually installed | |
c15f5690 MV |
1322 | bool autoInst = (Cache[I].Flags & pkgCache::Flag::Auto); |
1323 | Cache.MarkInstall(I, false, 0, !autoInst); | |
1324 | } | |
3b5421b4 AL |
1325 | } |
1326 | } | |
1327 | } | |
1328 | /*}}}*/ | |
b2e465d6 AL |
1329 | // PrioSortList - Sort a list of versions by priority /*{{{*/ |
1330 | // --------------------------------------------------------------------- | |
1331 | /* This is ment to be used in conjunction with AllTargets to get a list | |
1332 | of versions ordered by preference. */ | |
1333 | static pkgCache *PrioCache; | |
1334 | static int PrioComp(const void *A,const void *B) | |
1335 | { | |
1336 | pkgCache::VerIterator L(*PrioCache,*(pkgCache::Version **)A); | |
1337 | pkgCache::VerIterator R(*PrioCache,*(pkgCache::Version **)B); | |
1338 | ||
1339 | if ((L.ParentPkg()->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential && | |
b8c0f9b7 AL |
1340 | (R.ParentPkg()->Flags & pkgCache::Flag::Essential) != pkgCache::Flag::Essential) |
1341 | return 1; | |
b2e465d6 | 1342 | if ((L.ParentPkg()->Flags & pkgCache::Flag::Essential) != pkgCache::Flag::Essential && |
b8c0f9b7 AL |
1343 | (R.ParentPkg()->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential) |
1344 | return -1; | |
c5200869 JAK |
1345 | |
1346 | if ((L.ParentPkg()->Flags & pkgCache::Flag::Important) == pkgCache::Flag::Important && | |
1347 | (R.ParentPkg()->Flags & pkgCache::Flag::Important) != pkgCache::Flag::Important) | |
1348 | return 1; | |
1349 | if ((L.ParentPkg()->Flags & pkgCache::Flag::Important) != pkgCache::Flag::Important && | |
1350 | (R.ParentPkg()->Flags & pkgCache::Flag::Important) == pkgCache::Flag::Important) | |
1351 | return -1; | |
b2e465d6 AL |
1352 | |
1353 | if (L->Priority != R->Priority) | |
b8c0f9b7 | 1354 | return R->Priority - L->Priority; |
b2e465d6 AL |
1355 | return strcmp(L.ParentPkg().Name(),R.ParentPkg().Name()); |
1356 | } | |
1357 | void pkgPrioSortList(pkgCache &Cache,pkgCache::Version **List) | |
1358 | { | |
1359 | unsigned long Count = 0; | |
1360 | PrioCache = &Cache; | |
1361 | for (pkgCache::Version **I = List; *I != 0; I++) | |
1362 | Count++; | |
1363 | qsort(List,Count,sizeof(*List),PrioComp); | |
1364 | } | |
1365 | /*}}}*/ |