]>
Commit | Line | Data |
---|---|---|
631a7dc7 MV |
1 | #!/bin/sh |
2 | # | |
3 | # ensure we never fallback from a signed to a unsigned repo | |
4 | # | |
5 | # hash checks are done in | |
6 | # | |
7 | set -e | |
8 | ||
9 | simulate_mitm_and_inject_evil_package() | |
10 | { | |
6bf93605 | 11 | redatereleasefiles '+1 hour' |
761a5ad2 | 12 | rm -f "$APTARCHIVE/dists/unstable/InRelease" "$APTARCHIVE/dists/unstable/Release.gpg" |
631a7dc7 MV |
13 | inject_evil_package |
14 | } | |
15 | ||
16 | inject_evil_package() | |
17 | { | |
63c71412 | 18 | cat > "$APTARCHIVE/dists/unstable/main/binary-i386/Packages" <<EOF |
631a7dc7 MV |
19 | Package: evil |
20 | Installed-Size: 29 | |
21 | Maintainer: Joe Sixpack <joe@example.org> | |
22 | Architecture: all | |
23 | Version: 1.0 | |
24 | Filename: pool/evil_1.0_all.deb | |
25 | Size: 1270 | |
26 | Description: an autogenerated evil package | |
27 | EOF | |
28 | # avoid ims hit | |
29 | touch -d '+1hour' aptarchive/dists/unstable/main/binary-i386/Packages | |
448c38bd | 30 | compressfile aptarchive/dists/unstable/main/binary-i386/Packages |
631a7dc7 MV |
31 | } |
32 | ||
33 | assert_update_is_refused_and_last_good_state_used() | |
34 | { | |
002b1bc4 | 35 | testfailuremsg "E: The repository 'file:${APTARCHIVE} unstable Release' is no longer signed. |
83960341 | 36 | N: Updating from such a repository can't be done securely, and is therefore disabled by default. |
87d6947d | 37 | N: See apt-secure(8) manpage for repository creation and user configuration details." aptget update |
631a7dc7 MV |
38 | |
39 | assert_repo_is_intact | |
40 | } | |
41 | ||
42 | assert_repo_is_intact() | |
43 | { | |
2b0660b5 | 44 | testsuccessequal "foo/unstable 2.0 all" apt list -qq |
846bc058 DK |
45 | testsuccess aptget install -y -s foo |
46 | testfailure aptget install -y evil | |
47 | testsuccess aptget source foo --print-uris | |
631a7dc7 MV |
48 | |
49 | LISTDIR=rootdir/var/lib/apt/lists | |
63c71412 | 50 | testempty find "$LISTDIR" -name 'InRelease' -o -name 'Release.gpg' |
631a7dc7 MV |
51 | } |
52 | ||
53 | setupaptarchive_with_lists_clean() | |
54 | { | |
55 | setupaptarchive --no-update | |
4fa34122 | 56 | rm -rf rootdir/var/lib/apt/lists |
631a7dc7 MV |
57 | } |
58 | ||
59 | test_from_inrelease_to_unsigned() | |
60 | { | |
61 | # setup archive with InRelease file | |
62 | setupaptarchive_with_lists_clean | |
63 | testsuccess aptget update | |
846bc058 | 64 | listcurrentlistsdirectory > lists.before |
631a7dc7 MV |
65 | |
66 | simulate_mitm_and_inject_evil_package | |
67 | assert_update_is_refused_and_last_good_state_used | |
846bc058 | 68 | testfileequal lists.before "$(listcurrentlistsdirectory)" |
631a7dc7 MV |
69 | } |
70 | ||
71 | test_from_release_gpg_to_unsigned() | |
72 | { | |
73 | # setup archive with Release/Release.gpg (but no InRelease) | |
74 | setupaptarchive_with_lists_clean | |
63c71412 | 75 | rm "$APTARCHIVE/dists/unstable/InRelease" |
631a7dc7 | 76 | testsuccess aptget update |
846bc058 | 77 | listcurrentlistsdirectory > lists.before |
631a7dc7 MV |
78 | |
79 | simulate_mitm_and_inject_evil_package | |
80 | assert_update_is_refused_and_last_good_state_used | |
846bc058 | 81 | testfileequal lists.before "$(listcurrentlistsdirectory)" |
631a7dc7 MV |
82 | } |
83 | ||
c99fe2e1 MV |
84 | test_from_inrelease_to_unsigned_with_override() |
85 | { | |
86 | # setup archive with InRelease file | |
87 | setupaptarchive_with_lists_clean | |
448c38bd | 88 | testsuccess aptget update |
c99fe2e1 MV |
89 | |
90 | # simulate moving to a unsigned but otherwise valid repo | |
91 | simulate_mitm_and_inject_evil_package | |
448c38bd | 92 | generatereleasefiles '+2 hours' |
63c71412 | 93 | find "$APTARCHIVE" -name '*Packages*' -exec touch -d '+2 hours' {} \; |
c99fe2e1 MV |
94 | |
95 | # and ensure we can update to it (with enough force) | |
4fa34122 | 96 | testwarning aptget update --allow-insecure-repositories \ |
448c38bd | 97 | -o Acquire::AllowDowngradeToInsecureRepositories=1 -o Debug::pkgAcquire::Worker=1 -o Debug::pkgAcquire::Auth=1 |
c99fe2e1 | 98 | # but that the individual packages are still considered untrusted |
25b86db1 | 99 | testfailureequal "WARNING: The following packages cannot be authenticated! |
c99fe2e1 | 100 | evil |
b381a482 | 101 | E: There were unauthenticated packages and -y was used without --allow-unauthenticated" aptget install -qq -y evil |
c99fe2e1 MV |
102 | } |
103 | ||
631a7dc7 MV |
104 | test_cve_2012_0214() |
105 | { | |
106 | # see https://bugs.launchpad.net/ubuntu/+source/apt/+bug/947108 | |
107 | # | |
108 | # it was possible to MITM the download so that InRelease/Release.gpg | |
109 | # are not delivered (404) and a altered Release file was send | |
110 | # | |
111 | # apt left the old InRelease file in /var/lib/apt/lists and downloaded | |
112 | # the unauthenticated Release file too giving the false impression that | |
113 | # Release was authenticated | |
114 | # | |
3a8776a3 | 115 | # Note that this is pretty much impossible nowadays because: |
631a7dc7 MV |
116 | # a) InRelease is left as is, not split to InRelease/Release as it was |
117 | # in the old days | |
118 | # b) we refuse to go from signed->unsigned | |
119 | # | |
120 | # Still worth having a regression test the simulates the condition | |
121 | ||
122 | # setup archive with InRelease | |
123 | setupaptarchive_with_lists_clean | |
124 | testsuccess aptget update | |
846bc058 | 125 | listcurrentlistsdirectory > lists.before |
631a7dc7 MV |
126 | |
127 | # do what CVE-2012-0214 did | |
761a5ad2 | 128 | rm "$APTARCHIVE/dists/unstable/InRelease" "$APTARCHIVE/dists/unstable/Release.gpg" |
631a7dc7 MV |
129 | inject_evil_package |
130 | # build valid Release file | |
761a5ad2 | 131 | aptftparchive -qq release ./aptarchive > aptarchive/dists/unstable/Release |
631a7dc7 MV |
132 | |
133 | assert_update_is_refused_and_last_good_state_used | |
846bc058 | 134 | testfileequal lists.before "$(listcurrentlistsdirectory)" |
631a7dc7 MV |
135 | |
136 | # ensure there is no _Release file downloaded | |
137 | testfailure ls rootdir/var/lib/apt/lists/*_Release | |
138 | } | |
139 | ||
140 | test_subvert_inrelease() | |
141 | { | |
142 | # setup archive with InRelease | |
143 | setupaptarchive_with_lists_clean | |
144 | testsuccess aptget update | |
846bc058 | 145 | listcurrentlistsdirectory > lists.before |
631a7dc7 MV |
146 | |
147 | # replace InRelease with something else | |
63c71412 | 148 | mv "$APTARCHIVE/dists/unstable/Release" "$APTARCHIVE/dists/unstable/InRelease" |
631a7dc7 | 149 | |
f695e761 | 150 | testfailuremsg "E: Failed to fetch file:${APTARCHIVE}/dists/unstable/InRelease Clearsigned file isn't valid, got 'NOSPLIT' (does the network require authentication?) |
dd676dc7 | 151 | E: Some index files failed to download. They have been ignored, or old ones used instead." aptget update |
631a7dc7 MV |
152 | |
153 | # ensure we keep the repo | |
846bc058 | 154 | testfileequal lists.before "$(listcurrentlistsdirectory)" |
631a7dc7 MV |
155 | assert_repo_is_intact |
156 | } | |
157 | ||
158 | test_inrelease_to_invalid_inrelease() | |
159 | { | |
160 | # setup archive with InRelease | |
161 | setupaptarchive_with_lists_clean | |
162 | testsuccess aptget update | |
846bc058 | 163 | listcurrentlistsdirectory > lists.before |
631a7dc7 MV |
164 | |
165 | # now remove InRelease and subvert Release do no longer verify | |
63c71412 | 166 | sed -i 's/^Codename:.*/Codename: evil!/' "$APTARCHIVE/dists/unstable/InRelease" |
631a7dc7 MV |
167 | inject_evil_package |
168 | ||
1da3b7b8 | 169 | testwarningequal "W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: file:${APTARCHIVE} unstable InRelease: The following signatures were invalid: BADSIG 5A90D141DBAC8DAE Joe Sixpack (APT Testcases Dummy) <joe@example.org> |
4dbfe436 | 170 | W: Failed to fetch file:${APTARCHIVE}/dists/unstable/InRelease The following signatures were invalid: BADSIG 5A90D141DBAC8DAE Joe Sixpack (APT Testcases Dummy) <joe@example.org> |
631a7dc7 MV |
171 | W: Some index files failed to download. They have been ignored, or old ones used instead." aptget update -qq |
172 | ||
173 | # ensure we keep the repo | |
846bc058 DK |
174 | testfailure grep 'evil' rootdir/var/lib/apt/lists/*InRelease |
175 | testfileequal lists.before "$(listcurrentlistsdirectory)" | |
631a7dc7 | 176 | assert_repo_is_intact |
631a7dc7 MV |
177 | } |
178 | ||
179 | test_release_gpg_to_invalid_release_release_gpg() | |
180 | { | |
181 | # setup archive with InRelease | |
182 | setupaptarchive_with_lists_clean | |
63c71412 | 183 | rm "$APTARCHIVE/dists/unstable/InRelease" |
631a7dc7 | 184 | testsuccess aptget update |
846bc058 | 185 | listcurrentlistsdirectory > lists.before |
631a7dc7 MV |
186 | |
187 | # now subvert Release do no longer verify | |
63c71412 | 188 | echo "Some evil data" >> "$APTARCHIVE/dists/unstable/Release" |
631a7dc7 MV |
189 | inject_evil_package |
190 | ||
1da3b7b8 | 191 | testwarningequal "W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: file:${APTARCHIVE} unstable Release: The following signatures were invalid: BADSIG 5A90D141DBAC8DAE Joe Sixpack (APT Testcases Dummy) <joe@example.org> |
03aa0847 | 192 | W: Failed to fetch file:${APTARCHIVE}/dists/unstable/Release.gpg The following signatures were invalid: BADSIG 5A90D141DBAC8DAE Joe Sixpack (APT Testcases Dummy) <joe@example.org> |
8beef749 | 193 | W: Some index files failed to download. They have been ignored, or old ones used instead." aptget update -qq |
631a7dc7 | 194 | |
846bc058 DK |
195 | testfailure grep 'evil' rootdir/var/lib/apt/lists/*Release |
196 | testfileequal lists.before "$(listcurrentlistsdirectory)" | |
631a7dc7 | 197 | assert_repo_is_intact |
631a7dc7 MV |
198 | } |
199 | ||
200 | ||
3abb6a6a DK |
201 | TESTDIR="$(readlink -f "$(dirname "$0")")" |
202 | . "$TESTDIR/framework" | |
631a7dc7 MV |
203 | |
204 | setupenvironment | |
205 | configarchitecture "i386" | |
206 | ||
207 | # a "normal" package with source and binary | |
208 | buildsimplenativepackage 'foo' 'all' '2.0' | |
209 | ||
210 | # setup the archive and ensure we have a single package that installs fine | |
211 | setupaptarchive | |
63c71412 | 212 | APTARCHIVE="$(readlink -f ./aptarchive)" |
631a7dc7 MV |
213 | assert_repo_is_intact |
214 | ||
215 | # test the various cases where a repo may go from signed->unsigned | |
216 | msgmsg "test_from_inrelease_to_unsigned" | |
217 | test_from_inrelease_to_unsigned | |
218 | ||
219 | msgmsg "test_from_release_gpg_to_unsigned" | |
220 | test_from_release_gpg_to_unsigned | |
221 | ||
222 | # ensure we do not regress on CVE-2012-0214 | |
223 | msgmsg "test_cve_2012_0214" | |
224 | test_cve_2012_0214 | |
225 | ||
8d89cda7 | 226 | # ensure InRelease can not be subverted |
631a7dc7 MV |
227 | msgmsg "test_subvert_inrelease" |
228 | test_subvert_inrelease | |
229 | ||
230 | # ensure we revert to last good state if InRelease does not verify | |
231 | msgmsg "test_inrelease_to_invalid_inrelease" | |
232 | test_inrelease_to_invalid_inrelease | |
233 | ||
234 | # ensure we revert to last good state if Release/Release.gpg does not verify | |
235 | msgmsg "test_release_gpg_to_invalid_release_release_gpg" | |
236 | test_release_gpg_to_invalid_release_release_gpg | |
c99fe2e1 | 237 | |
846bc058 DK |
238 | # ensure we can override the downgrade error |
239 | msgmsg "test_from_inrelease_to_unsigned_with_override" | |
c99fe2e1 | 240 | test_from_inrelease_to_unsigned_with_override |