]> git.saurik.com Git - apt.git/blame - apt-pkg/algorithms.cc
promote filesize to a hashstring
[apt.git] / apt-pkg / algorithms.cc
CommitLineData
6c139d6e
AL
1// -*- mode: cpp; mode: fold -*-
2// Description /*{{{*/
b8c0f9b7 3// $Id: algorithms.cc,v 1.44 2002/11/28 18:49:16 jgg Exp $
6c139d6e
AL
4/* ######################################################################
5
6 Algorithms - A set of misc algorithms
7
0a8e3465
AL
8 The pkgProblemResolver class has become insanely complex and
9 very sophisticated, it handles every test case I have thrown at it
10 to my satisfaction. Understanding exactly why all the steps the class
11 does are required is difficult and changing though not very risky
12 may result in other cases not working.
13
6c139d6e
AL
14 ##################################################################### */
15 /*}}}*/
16// Include Files /*{{{*/
ea542140
DK
17#include <config.h>
18
094a497d
AL
19#include <apt-pkg/algorithms.h>
20#include <apt-pkg/error.h>
0a8e3465 21#include <apt-pkg/configuration.h>
b2e465d6 22#include <apt-pkg/sptr.h>
c3b85126 23#include <apt-pkg/edsp.h>
472ff00e 24#include <apt-pkg/progress.h>
453b82a3
DK
25#include <apt-pkg/depcache.h>
26#include <apt-pkg/packagemanager.h>
27#include <apt-pkg/pkgcache.h>
28#include <apt-pkg/cacheiterators.h>
6d38011b 29
453b82a3
DK
30#include <string.h>
31#include <string>
152ab79e 32#include <cstdlib>
90f057fd 33#include <iostream>
ea542140
DK
34
35#include <apti18n.h>
6c139d6e 36 /*}}}*/
584e4558 37using namespace std;
6c139d6e
AL
38
39pkgProblemResolver *pkgProblemResolver::This = 0;
40
41// Simulate::Simulate - Constructor /*{{{*/
42// ---------------------------------------------------------------------
b2e465d6
AL
43/* The legacy translations here of input Pkg iterators is obsolete,
44 this is not necessary since the pkgCaches are fully shared now. */
45pkgSimulate::pkgSimulate(pkgDepCache *Cache) : pkgPackageManager(Cache),
46 iPolicy(Cache),
496d5c70
MV
47 Sim(&Cache->GetCache(),&iPolicy),
48 group(Sim)
6c139d6e 49{
b2e465d6
AL
50 Sim.Init(0);
51 Flags = new unsigned char[Cache->Head().PackageCount];
52 memset(Flags,0,sizeof(*Flags)*Cache->Head().PackageCount);
281daf46
AL
53
54 // Fake a filename so as not to activate the media swapping
55 string Jnk = "SIMULATE";
b2e465d6 56 for (unsigned int I = 0; I != Cache->Head().PackageCount; I++)
281daf46 57 FileNames[I] = Jnk;
6c139d6e
AL
58}
59 /*}}}*/
b270388b
MV
60// Simulate::~Simulate - Destructor /*{{{*/
61pkgSimulate::~pkgSimulate()
62{
63 delete[] Flags;
64}
65 /*}}}*/
b2e465d6
AL
66// Simulate::Describe - Describe a package /*{{{*/
67// ---------------------------------------------------------------------
3826564e
MZ
68/* Parameter Current == true displays the current package version,
69 Parameter Candidate == true displays the candidate package version */
70void pkgSimulate::Describe(PkgIterator Pkg,ostream &out,bool Current,bool Candidate)
b2e465d6
AL
71{
72 VerIterator Ver(Sim);
e59458f7 73
47f6d1b7 74 out << Pkg.FullName(true);
e59458f7 75
3826564e 76 if (Current == true)
e59458f7 77 {
b2e465d6 78 Ver = Pkg.CurrentVer();
e59458f7
AL
79 if (Ver.end() == false)
80 out << " [" << Ver.VerStr() << ']';
81 }
b2e465d6 82
3826564e
MZ
83 if (Candidate == true)
84 {
85 Ver = Sim[Pkg].CandidateVerIter(Sim);
86 if (Ver.end() == true)
87 return;
b2e465d6 88
3826564e
MZ
89 out << " (" << Ver.VerStr() << ' ' << Ver.RelStr() << ')';
90 }
b2e465d6
AL
91}
92 /*}}}*/
6c139d6e
AL
93// Simulate::Install - Simulate unpacking of a package /*{{{*/
94// ---------------------------------------------------------------------
95/* */
96bool pkgSimulate::Install(PkgIterator iPkg,string /*File*/)
97{
98 // Adapt the iterator
803ea2a8 99 PkgIterator Pkg = Sim.FindPkg(iPkg.Name(), iPkg.Arch());
6c139d6e
AL
100 Flags[Pkg->ID] = 1;
101
b2e465d6 102 cout << "Inst ";
3826564e 103 Describe(Pkg,cout,true,true);
6c139d6e 104 Sim.MarkInstall(Pkg,false);
803ea2a8 105
6c139d6e 106 // Look for broken conflicts+predepends.
f7f0d6c7 107 for (PkgIterator I = Sim.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
108 {
109 if (Sim[I].InstallVer == 0)
110 continue;
111
b2e465d6
AL
112 for (DepIterator D = Sim[I].InstVerIter(Sim).DependsList(); D.end() == false;)
113 {
114 DepIterator Start;
115 DepIterator End;
116 D.GlobOr(Start,End);
359e46db 117 if (Start.IsNegative() == true ||
b2e465d6 118 End->Type == pkgCache::Dep::PreDepends)
6c139d6e 119 {
b2e465d6 120 if ((Sim[End] & pkgDepCache::DepGInstall) == 0)
6c139d6e 121 {
47f6d1b7 122 cout << " [" << I.FullName(false) << " on " << Start.TargetPkg().FullName(false) << ']';
b2e465d6 123 if (Start->Type == pkgCache::Dep::Conflicts)
47f6d1b7 124 _error->Error("Fatal, conflicts violated %s",I.FullName(false).c_str());
6c139d6e 125 }
b2e465d6
AL
126 }
127 }
6c139d6e
AL
128 }
129
130 if (Sim.BrokenCount() != 0)
131 ShortBreaks();
132 else
04aa15a8 133 cout << endl;
6c139d6e
AL
134 return true;
135}
136 /*}}}*/
137// Simulate::Configure - Simulate configuration of a Package /*{{{*/
138// ---------------------------------------------------------------------
139/* This is not an acurate simulation of relatity, we should really not
140 install the package.. For some investigations it may be necessary
141 however. */
142bool pkgSimulate::Configure(PkgIterator iPkg)
143{
144 // Adapt the iterator
803ea2a8 145 PkgIterator Pkg = Sim.FindPkg(iPkg.Name(), iPkg.Arch());
6c139d6e
AL
146
147 Flags[Pkg->ID] = 2;
803ea2a8 148
6c139d6e
AL
149 if (Sim[Pkg].InstBroken() == true)
150 {
47f6d1b7 151 cout << "Conf " << Pkg.FullName(false) << " broken" << endl;
6c139d6e
AL
152
153 Sim.Update();
154
155 // Print out each package and the failed dependencies
f7f0d6c7 156 for (pkgCache::DepIterator D = Sim[Pkg].InstVerIter(Sim).DependsList(); D.end() == false; ++D)
6c139d6e
AL
157 {
158 if (Sim.IsImportantDep(D) == false ||
159 (Sim[D] & pkgDepCache::DepInstall) != 0)
160 continue;
161
b2e465d6 162 if (D->Type == pkgCache::Dep::Obsoletes)
47f6d1b7 163 cout << " Obsoletes:" << D.TargetPkg().FullName(false);
b2e465d6 164 else if (D->Type == pkgCache::Dep::Conflicts)
47f6d1b7 165 cout << " Conflicts:" << D.TargetPkg().FullName(false);
308c7d30 166 else if (D->Type == pkgCache::Dep::DpkgBreaks)
47f6d1b7 167 cout << " Breaks:" << D.TargetPkg().FullName(false);
6c139d6e 168 else
47f6d1b7 169 cout << " Depends:" << D.TargetPkg().FullName(false);
6c139d6e 170 }
04aa15a8 171 cout << endl;
6c139d6e 172
09a10f9c 173 _error->Error("Conf Broken %s",Pkg.FullName(false).c_str());
6c139d6e
AL
174 }
175 else
b2e465d6
AL
176 {
177 cout << "Conf ";
3826564e 178 Describe(Pkg,cout,false,true);
b2e465d6 179 }
6c139d6e
AL
180
181 if (Sim.BrokenCount() != 0)
182 ShortBreaks();
183 else
04aa15a8 184 cout << endl;
6c139d6e
AL
185
186 return true;
187}
188 /*}}}*/
189// Simulate::Remove - Simulate the removal of a package /*{{{*/
190// ---------------------------------------------------------------------
191/* */
fc4b5c9f 192bool pkgSimulate::Remove(PkgIterator iPkg,bool Purge)
6c139d6e
AL
193{
194 // Adapt the iterator
803ea2a8 195 PkgIterator Pkg = Sim.FindPkg(iPkg.Name(), iPkg.Arch());
c919ad6e
DK
196 if (Pkg.end() == true)
197 {
198 std::cerr << (Purge ? "Purg" : "Remv") << " invalid package " << iPkg.FullName() << std::endl;
199 return false;
200 }
6c139d6e
AL
201
202 Flags[Pkg->ID] = 3;
203 Sim.MarkDelete(Pkg);
803ea2a8 204
fc4b5c9f 205 if (Purge == true)
b2e465d6 206 cout << "Purg ";
fc4b5c9f 207 else
b2e465d6 208 cout << "Remv ";
3826564e 209 Describe(Pkg,cout,true,false);
6c139d6e
AL
210
211 if (Sim.BrokenCount() != 0)
212 ShortBreaks();
213 else
04aa15a8 214 cout << endl;
6c139d6e
AL
215
216 return true;
217}
218 /*}}}*/
219// Simulate::ShortBreaks - Print out a short line describing all breaks /*{{{*/
220// ---------------------------------------------------------------------
221/* */
222void pkgSimulate::ShortBreaks()
223{
04aa15a8 224 cout << " [";
f7f0d6c7 225 for (PkgIterator I = Sim.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
226 {
227 if (Sim[I].InstBroken() == true)
228 {
229 if (Flags[I->ID] == 0)
47f6d1b7 230 cout << I.FullName(false) << ' ';
6c139d6e 231/* else
04aa15a8 232 cout << I.Name() << "! ";*/
6c139d6e
AL
233 }
234 }
04aa15a8 235 cout << ']' << endl;
6c139d6e
AL
236}
237 /*}}}*/
238// ApplyStatus - Adjust for non-ok packages /*{{{*/
239// ---------------------------------------------------------------------
240/* We attempt to change the state of the all packages that have failed
241 installation toward their real state. The ordering code will perform
242 the necessary calculations to deal with the problems. */
243bool pkgApplyStatus(pkgDepCache &Cache)
244{
74a05226
MV
245 pkgDepCache::ActionGroup group(Cache);
246
f7f0d6c7 247 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e 248 {
e481d5b0
AL
249 if (I->VersionList == 0)
250 continue;
251
d38b7b3d
AL
252 // Only choice for a ReInstReq package is to reinstall
253 if (I->InstState == pkgCache::State::ReInstReq ||
254 I->InstState == pkgCache::State::HoldReInstReq)
255 {
5871718b 256 if (I->CurrentVer != 0 && I.CurrentVer().Downloadable() == true)
74a05226 257 Cache.MarkKeep(I, false, false);
813c8eea
AL
258 else
259 {
260 // Is this right? Will dpkg choke on an upgrade?
2a3f3893
AL
261 if (Cache[I].CandidateVer != 0 &&
262 Cache[I].CandidateVerIter(Cache).Downloadable() == true)
74a05226 263 Cache.MarkInstall(I, false, 0, false);
813c8eea 264 else
b2e465d6 265 return _error->Error(_("The package %s needs to be reinstalled, "
09a10f9c 266 "but I can't find an archive for it."),I.FullName(true).c_str());
813c8eea
AL
267 }
268
d38b7b3d
AL
269 continue;
270 }
271
6c139d6e
AL
272 switch (I->CurrentState)
273 {
813c8eea
AL
274 /* This means installation failed somehow - it does not need to be
275 re-unpacked (probably) */
b518cca6
AL
276 case pkgCache::State::UnPacked:
277 case pkgCache::State::HalfConfigured:
9d06bc80
MV
278 case pkgCache::State::TriggersAwaited:
279 case pkgCache::State::TriggersPending:
5871718b 280 if ((I->CurrentVer != 0 && I.CurrentVer().Downloadable() == true) ||
813c8eea 281 I.State() != pkgCache::PkgIterator::NeedsUnpack)
74a05226 282 Cache.MarkKeep(I, false, false);
813c8eea
AL
283 else
284 {
2a3f3893
AL
285 if (Cache[I].CandidateVer != 0 &&
286 Cache[I].CandidateVerIter(Cache).Downloadable() == true)
74a05226 287 Cache.MarkInstall(I, true, 0, false);
813c8eea 288 else
b83cad32 289 Cache.MarkDelete(I, false, 0, false);
813c8eea 290 }
6c139d6e
AL
291 break;
292
293 // This means removal failed
b518cca6 294 case pkgCache::State::HalfInstalled:
b83cad32 295 Cache.MarkDelete(I, false, 0, false);
6c139d6e
AL
296 break;
297
298 default:
b518cca6 299 if (I->InstState != pkgCache::State::Ok)
6c139d6e 300 return _error->Error("The package %s is not ok and I "
09a10f9c 301 "don't know how to fix it!",I.FullName(false).c_str());
6c139d6e
AL
302 }
303 }
304 return true;
305}
306 /*}}}*/
307// FixBroken - Fix broken packages /*{{{*/
308// ---------------------------------------------------------------------
0a8e3465
AL
309/* This autoinstalls every broken package and then runs the problem resolver
310 on the result. */
6c139d6e
AL
311bool pkgFixBroken(pkgDepCache &Cache)
312{
74a05226
MV
313 pkgDepCache::ActionGroup group(Cache);
314
6c139d6e 315 // Auto upgrade all broken packages
f7f0d6c7 316 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e 317 if (Cache[I].NowBroken() == true)
74a05226 318 Cache.MarkInstall(I, true, 0, false);
7e798dd7 319
6c139d6e
AL
320 /* Fix packages that are in a NeedArchive state but don't have a
321 downloadable install version */
f7f0d6c7 322 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
323 {
324 if (I.State() != pkgCache::PkgIterator::NeedsUnpack ||
325 Cache[I].Delete() == true)
326 continue;
327
b518cca6 328 if (Cache[I].InstVerIter(Cache).Downloadable() == false)
6c139d6e
AL
329 continue;
330
74a05226 331 Cache.MarkInstall(I, true, 0, false);
6c139d6e
AL
332 }
333
b2e465d6 334 pkgProblemResolver Fix(&Cache);
6c139d6e
AL
335 return Fix.Resolve(true);
336}
337 /*}}}*/
6c139d6e
AL
338// ProblemResolver::pkgProblemResolver - Constructor /*{{{*/
339// ---------------------------------------------------------------------
340/* */
dcaa1185 341pkgProblemResolver::pkgProblemResolver(pkgDepCache *pCache) : d(NULL), Cache(*pCache)
6c139d6e
AL
342{
343 // Allocate memory
b2e465d6 344 unsigned long Size = Cache.Head().PackageCount;
d0f2c87c 345 Scores = new int[Size];
6c139d6e
AL
346 Flags = new unsigned char[Size];
347 memset(Flags,0,sizeof(*Flags)*Size);
348
349 // Set debug to true to see its decision logic
0a8e3465 350 Debug = _config->FindB("Debug::pkgProblemResolver",false);
6c139d6e
AL
351}
352 /*}}}*/
b2e465d6
AL
353// ProblemResolver::~pkgProblemResolver - Destructor /*{{{*/
354// ---------------------------------------------------------------------
355/* */
356pkgProblemResolver::~pkgProblemResolver()
357{
358 delete [] Scores;
359 delete [] Flags;
360}
361 /*}}}*/
6c139d6e
AL
362// ProblemResolver::ScoreSort - Sort the list by score /*{{{*/
363// ---------------------------------------------------------------------
364/* */
365int pkgProblemResolver::ScoreSort(const void *a,const void *b)
366{
367 Package const **A = (Package const **)a;
368 Package const **B = (Package const **)b;
369 if (This->Scores[(*A)->ID] > This->Scores[(*B)->ID])
370 return -1;
371 if (This->Scores[(*A)->ID] < This->Scores[(*B)->ID])
372 return 1;
373 return 0;
374}
375 /*}}}*/
376// ProblemResolver::MakeScores - Make the score table /*{{{*/
377// ---------------------------------------------------------------------
378/* */
379void pkgProblemResolver::MakeScores()
380{
b2e465d6 381 unsigned long Size = Cache.Head().PackageCount;
6c139d6e
AL
382 memset(Scores,0,sizeof(*Scores)*Size);
383
b9179170
MV
384 // maps to pkgCache::State::VerPriority:
385 // Required Important Standard Optional Extra
d0f2c87c 386 int PrioMap[] = {
8b4894fe 387 0,
84de0cea 388 _config->FindI("pkgProblemResolver::Scores::Required",3),
b9179170 389 _config->FindI("pkgProblemResolver::Scores::Important",2),
d0f2c87c
CW
390 _config->FindI("pkgProblemResolver::Scores::Standard",1),
391 _config->FindI("pkgProblemResolver::Scores::Optional",-1),
392 _config->FindI("pkgProblemResolver::Scores::Extra",-2)
8b4894fe 393 };
d0f2c87c
CW
394 int PrioEssentials = _config->FindI("pkgProblemResolver::Scores::Essentials",100);
395 int PrioInstalledAndNotObsolete = _config->FindI("pkgProblemResolver::Scores::NotObsolete",1);
8daf68e3
DK
396 int DepMap[] = {
397 0,
398 _config->FindI("pkgProblemResolver::Scores::Depends",1),
399 _config->FindI("pkgProblemResolver::Scores::PreDepends",1),
400 _config->FindI("pkgProblemResolver::Scores::Suggests",0),
401 _config->FindI("pkgProblemResolver::Scores::Recommends",1),
402 _config->FindI("pkgProblemResolver::Scores::Conflicts",-1),
403 _config->FindI("pkgProblemResolver::Scores::Replaces",0),
404 _config->FindI("pkgProblemResolver::Scores::Obsoletes",0),
405 _config->FindI("pkgProblemResolver::Scores::Breaks",-1),
406 _config->FindI("pkgProblemResolver::Scores::Enhances",0)
407 };
d0f2c87c
CW
408 int AddProtected = _config->FindI("pkgProblemResolver::Scores::AddProtected",10000);
409 int AddEssential = _config->FindI("pkgProblemResolver::Scores::AddEssential",5000);
8b4894fe
MV
410
411 if (_config->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
412 clog << "Settings used to calculate pkgProblemResolver::Scores::" << endl
84de0cea
MV
413 << " Required => " << PrioMap[pkgCache::State::Required] << endl
414 << " Important => " << PrioMap[pkgCache::State::Important] << endl
415 << " Standard => " << PrioMap[pkgCache::State::Standard] << endl
416 << " Optional => " << PrioMap[pkgCache::State::Optional] << endl
417 << " Extra => " << PrioMap[pkgCache::State::Extra] << endl
8b4894fe
MV
418 << " Essentials => " << PrioEssentials << endl
419 << " InstalledAndNotObsolete => " << PrioInstalledAndNotObsolete << endl
8daf68e3
DK
420 << " Pre-Depends => " << DepMap[pkgCache::Dep::PreDepends] << endl
421 << " Depends => " << DepMap[pkgCache::Dep::Depends] << endl
422 << " Recommends => " << DepMap[pkgCache::Dep::Recommends] << endl
423 << " Suggests => " << DepMap[pkgCache::Dep::Suggests] << endl
424 << " Conflicts => " << DepMap[pkgCache::Dep::Conflicts] << endl
425 << " Breaks => " << DepMap[pkgCache::Dep::DpkgBreaks] << endl
426 << " Replaces => " << DepMap[pkgCache::Dep::Replaces] << endl
427 << " Obsoletes => " << DepMap[pkgCache::Dep::Obsoletes] << endl
428 << " Enhances => " << DepMap[pkgCache::Dep::Enhances] << endl
8b4894fe
MV
429 << " AddProtected => " << AddProtected << endl
430 << " AddEssential => " << AddEssential << endl;
431
6c139d6e 432 // Generate the base scores for a package based on its properties
f7f0d6c7 433 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
434 {
435 if (Cache[I].InstallVer == 0)
436 continue;
437
d0f2c87c 438 int &Score = Scores[I->ID];
6c139d6e 439
7365ff46 440 /* This is arbitrary, it should be high enough to elevate an
6c139d6e
AL
441 essantial package above most other packages but low enough
442 to allow an obsolete essential packages to be removed by
1e3f4083 443 a conflicts on a powerful normal package (ie libc6) */
c5200869
JAK
444 if ((I->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential
445 || (I->Flags & pkgCache::Flag::Important) == pkgCache::Flag::Important)
8b4894fe 446 Score += PrioEssentials;
6c139d6e 447
4cd4a2e7
DK
448 pkgCache::VerIterator const InstVer = Cache[I].InstVerIter(Cache);
449 // We apply priorities only to downloadable packages, all others are prio:extra
450 // as an obsolete prio:standard package can't be that standard anymore…
451 if (InstVer->Priority <= pkgCache::State::Extra && InstVer.Downloadable() == true)
452 Score += PrioMap[InstVer->Priority];
453 else
454 Score += PrioMap[pkgCache::State::Extra];
455
6c139d6e 456 /* This helps to fix oddball problems with conflicting packages
4cd4a2e7
DK
457 on the same level. We enhance the score of installed packages
458 if those are not obsolete */
020daa7b 459 if (I->CurrentVer != 0 && Cache[I].CandidateVer != 0 && Cache[I].CandidateVerIter(Cache).Downloadable())
8b4894fe 460 Score += PrioInstalledAndNotObsolete;
8daf68e3 461
cb4b85b0 462 // propagate score points along dependencies
4cd4a2e7 463 for (pkgCache::DepIterator D = InstVer.DependsList(); D.end() == false; ++D)
9ec748ff
DK
464 {
465 if (DepMap[D->Type] == 0)
466 continue;
467 pkgCache::PkgIterator const T = D.TargetPkg();
468 if (D->Version != 0)
469 {
470 pkgCache::VerIterator const IV = Cache[T].InstVerIter(Cache);
471 if (IV.end() == true || D.IsSatisfied(IV) != D.IsNegative())
472 continue;
473 }
474 Scores[T->ID] += DepMap[D->Type];
475 }
8daf68e3
DK
476 }
477
6c139d6e 478 // Copy the scores to advoid additive looping
d0f2c87c 479 SPtrArray<int> OldScores = new int[Size];
6c139d6e
AL
480 memcpy(OldScores,Scores,sizeof(*Scores)*Size);
481
482 /* Now we cause 1 level of dependency inheritance, that is we add the
483 score of the packages that depend on the target Package. This
484 fortifies high scoring packages */
f7f0d6c7 485 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
486 {
487 if (Cache[I].InstallVer == 0)
488 continue;
489
f7f0d6c7 490 for (pkgCache::DepIterator D = I.RevDependsList(); D.end() == false; ++D)
6c139d6e
AL
491 {
492 // Only do it for the install version
493 if ((pkgCache::Version *)D.ParentVer() != Cache[D.ParentPkg()].InstallVer ||
3a998f6a
MV
494 (D->Type != pkgCache::Dep::Depends &&
495 D->Type != pkgCache::Dep::PreDepends &&
496 D->Type != pkgCache::Dep::Recommends))
6c139d6e
AL
497 continue;
498
dec5b117
MV
499 // Do not propagate negative scores otherwise
500 // an extra (-2) package might score better than an optional (-1)
501 if (OldScores[D.ParentPkg()->ID] > 0)
502 Scores[I->ID] += OldScores[D.ParentPkg()->ID];
6c139d6e
AL
503 }
504 }
505
1e3f4083 506 /* Now we propagate along provides. This makes the packages that
6c139d6e 507 provide important packages extremely important */
f7f0d6c7 508 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e 509 {
f7f0d6c7 510 for (pkgCache::PrvIterator P = I.ProvidesList(); P.end() == false; ++P)
6c139d6e
AL
511 {
512 // Only do it once per package
513 if ((pkgCache::Version *)P.OwnerVer() != Cache[P.OwnerPkg()].InstallVer)
514 continue;
515 Scores[P.OwnerPkg()->ID] += abs(Scores[I->ID] - OldScores[I->ID]);
516 }
517 }
518
519 /* Protected things are pushed really high up. This number should put them
520 ahead of everything */
f7f0d6c7 521 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
d2685fd6 522 {
6c139d6e 523 if ((Flags[I->ID] & Protected) != 0)
8b4894fe 524 Scores[I->ID] += AddProtected;
c5200869
JAK
525 if ((I->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential ||
526 (I->Flags & pkgCache::Flag::Important) == pkgCache::Flag::Important)
8b4894fe
MV
527 Scores[I->ID] += AddEssential;
528 }
6c139d6e
AL
529}
530 /*}}}*/
531// ProblemResolver::DoUpgrade - Attempt to upgrade this package /*{{{*/
532// ---------------------------------------------------------------------
533/* This goes through and tries to reinstall packages to make this package
534 installable */
535bool pkgProblemResolver::DoUpgrade(pkgCache::PkgIterator Pkg)
536{
74a05226
MV
537 pkgDepCache::ActionGroup group(Cache);
538
6c139d6e
AL
539 if ((Flags[Pkg->ID] & Upgradable) == 0 || Cache[Pkg].Upgradable() == false)
540 return false;
3a486305
AL
541 if ((Flags[Pkg->ID] & Protected) == Protected)
542 return false;
0a8e3465 543
6c139d6e
AL
544 Flags[Pkg->ID] &= ~Upgradable;
545
546 bool WasKept = Cache[Pkg].Keep();
74a05226 547 Cache.MarkInstall(Pkg, false, 0, false);
6c139d6e 548
0a8e3465
AL
549 // This must be a virtual package or something like that.
550 if (Cache[Pkg].InstVerIter(Cache).end() == true)
551 return false;
552
6c139d6e
AL
553 // Isolate the problem dependency
554 bool Fail = false;
555 for (pkgCache::DepIterator D = Cache[Pkg].InstVerIter(Cache).DependsList(); D.end() == false;)
556 {
557 // Compute a single dependency element (glob or)
558 pkgCache::DepIterator Start = D;
559 pkgCache::DepIterator End = D;
4b1b89c5 560 for (bool LastOR = true; D.end() == false && LastOR == true;)
6c139d6e 561 {
b518cca6 562 LastOR = (D->CompareOp & pkgCache::Dep::Or) == pkgCache::Dep::Or;
0284eee4 563 ++D;
6c139d6e
AL
564 if (LastOR == true)
565 End = D;
566 }
567
568 // We only worry about critical deps.
569 if (End.IsCritical() != true)
570 continue;
4b1b89c5
AL
571
572 // Iterate over all the members in the or group
573 while (1)
0a8e3465 574 {
4b1b89c5
AL
575 // Dep is ok now
576 if ((Cache[End] & pkgDepCache::DepGInstall) == pkgDepCache::DepGInstall)
577 break;
578
579 // Do not change protected packages
580 PkgIterator P = Start.SmartTargetPkg();
581 if ((Flags[P->ID] & Protected) == Protected)
582 {
583 if (Debug == true)
47f6d1b7 584 clog << " Reinst Failed because of protected " << P.FullName(false) << endl;
4b1b89c5 585 Fail = true;
4b1b89c5 586 }
648e3cb4 587 else
6c139d6e 588 {
648e3cb4
AL
589 // Upgrade the package if the candidate version will fix the problem.
590 if ((Cache[Start] & pkgDepCache::DepCVer) == pkgDepCache::DepCVer)
591 {
592 if (DoUpgrade(P) == false)
593 {
594 if (Debug == true)
47f6d1b7 595 clog << " Reinst Failed because of " << P.FullName(false) << endl;
648e3cb4
AL
596 Fail = true;
597 }
598 else
599 {
600 Fail = false;
601 break;
602 }
603 }
604 else
4b1b89c5 605 {
648e3cb4
AL
606 /* We let the algorithm deal with conflicts on its next iteration,
607 it is much smarter than us */
359e46db 608 if (Start.IsNegative() == true)
b2e465d6 609 break;
648e3cb4 610
4b1b89c5 611 if (Debug == true)
47f6d1b7 612 clog << " Reinst Failed early because of " << Start.TargetPkg().FullName(false) << endl;
4b1b89c5 613 Fail = true;
648e3cb4 614 }
4b1b89c5 615 }
6c139d6e 616
4b1b89c5
AL
617 if (Start == End)
618 break;
f7f0d6c7 619 ++Start;
4b1b89c5
AL
620 }
621 if (Fail == true)
6c139d6e 622 break;
6c139d6e
AL
623 }
624
625 // Undo our operations - it might be smart to undo everything this did..
626 if (Fail == true)
627 {
628 if (WasKept == true)
74a05226 629 Cache.MarkKeep(Pkg, false, false);
6c139d6e 630 else
b83cad32 631 Cache.MarkDelete(Pkg, false, 0, false);
6c139d6e
AL
632 return false;
633 }
634
635 if (Debug == true)
47f6d1b7 636 clog << " Re-Instated " << Pkg.FullName(false) << endl;
6c139d6e
AL
637 return true;
638}
639 /*}}}*/
6d38011b
DK
640// ProblemResolver::Resolve - calls a resolver to fix the situation /*{{{*/
641// ---------------------------------------------------------------------
642/* */
2a884c61 643bool pkgProblemResolver::Resolve(bool BrokenFix, OpProgress * const Progress)
6d38011b 644{
98278a81 645 std::string const solver = _config->Find("APT::Solver", "internal");
2a884c61
DK
646 if (solver != "internal")
647 return EDSP::ResolveExternal(solver.c_str(), Cache, false, false, false, Progress);
6d38011b
DK
648 return ResolveInternal(BrokenFix);
649}
650 /*}}}*/
651// ProblemResolver::ResolveInternal - Run the resolution pass /*{{{*/
6c139d6e
AL
652// ---------------------------------------------------------------------
653/* This routines works by calculating a score for each package. The score
654 is derived by considering the package's priority and all reverse
655 dependents giving an integer that reflects the amount of breakage that
656 adjusting the package will inflict.
657
658 It goes from highest score to lowest and corrects all of the breaks by
1e3f4083 659 keeping or removing the dependent packages. If that fails then it removes
6c139d6e
AL
660 the package itself and goes on. The routine should be able to intelligently
661 go from any broken state to a fixed state.
662
663 The BrokenFix flag enables a mode where the algorithm tries to
664 upgrade packages to advoid problems. */
6d38011b 665bool pkgProblemResolver::ResolveInternal(bool const BrokenFix)
6c139d6e 666{
74a05226
MV
667 pkgDepCache::ActionGroup group(Cache);
668
6c139d6e
AL
669 // Record which packages are marked for install
670 bool Again = false;
671 do
672 {
673 Again = false;
f7f0d6c7 674 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
675 {
676 if (Cache[I].Install() == true)
677 Flags[I->ID] |= PreInstalled;
678 else
679 {
680 if (Cache[I].InstBroken() == true && BrokenFix == true)
681 {
74a05226 682 Cache.MarkInstall(I, false, 0, false);
6c139d6e
AL
683 if (Cache[I].Install() == true)
684 Again = true;
685 }
686
687 Flags[I->ID] &= ~PreInstalled;
688 }
689 Flags[I->ID] |= Upgradable;
690 }
691 }
692 while (Again == true);
693
32b5dd08 694 if (Debug == true) {
49b49018
MV
695 clog << "Starting pkgProblemResolver with broken count: "
696 << Cache.BrokenCount() << endl;
32b5dd08 697 }
6c139d6e
AL
698
699 MakeScores();
6d38011b
DK
700
701 unsigned long const Size = Cache.Head().PackageCount;
702
6c139d6e
AL
703 /* We have to order the packages so that the broken fixing pass
704 operates from highest score to lowest. This prevents problems when
705 high score packages cause the removal of lower score packages that
706 would cause the removal of even lower score packages. */
b2e465d6 707 SPtrArray<pkgCache::Package *> PList = new pkgCache::Package *[Size];
6c139d6e 708 pkgCache::Package **PEnd = PList;
f7f0d6c7 709 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
710 *PEnd++ = I;
711 This = this;
712 qsort(PList,PEnd - PList,sizeof(*PList),&ScoreSort);
8b4894fe
MV
713
714 if (_config->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
715 {
716 clog << "Show Scores" << endl;
717 for (pkgCache::Package **K = PList; K != PEnd; K++)
718 if (Scores[(*K)->ID] != 0)
719 {
720 pkgCache::PkgIterator Pkg(Cache,*K);
721 clog << Scores[(*K)->ID] << ' ' << Pkg << std::endl;
722 }
723 }
6c139d6e 724
32b5dd08 725 if (Debug == true) {
49b49018
MV
726 clog << "Starting 2 pkgProblemResolver with broken count: "
727 << Cache.BrokenCount() << endl;
32b5dd08 728 }
8b4894fe 729
6c139d6e
AL
730 /* Now consider all broken packages. For each broken package we either
731 remove the package or fix it's problem. We do this once, it should
732 not be possible for a loop to form (that is a < b < c and fixing b by
733 changing a breaks c) */
734 bool Change = true;
09a10f9c 735 bool const TryFixByInstall = _config->FindB("pkgProblemResolver::FixByInstall", true);
6c139d6e
AL
736 for (int Counter = 0; Counter != 10 && Change == true; Counter++)
737 {
738 Change = false;
739 for (pkgCache::Package **K = PList; K != PEnd; K++)
740 {
741 pkgCache::PkgIterator I(Cache,*K);
742
743 /* We attempt to install this and see if any breaks result,
744 this takes care of some strange cases */
745 if (Cache[I].CandidateVer != Cache[I].InstallVer &&
746 I->CurrentVer != 0 && Cache[I].InstallVer != 0 &&
747 (Flags[I->ID] & PreInstalled) != 0 &&
0a8e3465
AL
748 (Flags[I->ID] & Protected) == 0 &&
749 (Flags[I->ID] & ReInstateTried) == 0)
6c139d6e
AL
750 {
751 if (Debug == true)
09a10f9c 752 clog << " Try to Re-Instate (" << Counter << ") " << I.FullName(false) << endl;
a6568219 753 unsigned long OldBreaks = Cache.BrokenCount();
6c139d6e 754 pkgCache::Version *OldVer = Cache[I].InstallVer;
0a8e3465
AL
755 Flags[I->ID] &= ReInstateTried;
756
74a05226 757 Cache.MarkInstall(I, false, 0, false);
6c139d6e
AL
758 if (Cache[I].InstBroken() == true ||
759 OldBreaks < Cache.BrokenCount())
760 {
761 if (OldVer == 0)
b83cad32 762 Cache.MarkDelete(I, false, 0, false);
6c139d6e 763 else
74a05226 764 Cache.MarkKeep(I, false, false);
6c139d6e
AL
765 }
766 else
767 if (Debug == true)
47f6d1b7 768 clog << "Re-Instated " << I.FullName(false) << " (" << OldBreaks << " vs " << Cache.BrokenCount() << ')' << endl;
6c139d6e
AL
769 }
770
771 if (Cache[I].InstallVer == 0 || Cache[I].InstBroken() == false)
772 continue;
773
00b47c98 774 if (Debug == true)
09a10f9c 775 clog << "Investigating (" << Counter << ") " << I << endl;
00b47c98 776
6c139d6e
AL
777 // Isolate the problem dependency
778 PackageKill KillList[100];
779 PackageKill *LEnd = KillList;
421c8d10
AL
780 bool InOr = false;
781 pkgCache::DepIterator Start;
782 pkgCache::DepIterator End;
b2e465d6 783 PackageKill *OldEnd = LEnd;
648e3cb4
AL
784
785 enum {OrRemove,OrKeep} OrOp = OrRemove;
421c8d10
AL
786 for (pkgCache::DepIterator D = Cache[I].InstVerIter(Cache).DependsList();
787 D.end() == false || InOr == true;)
6c139d6e
AL
788 {
789 // Compute a single dependency element (glob or)
648e3cb4
AL
790 if (Start == End)
791 {
792 // Decide what to do
09a10f9c 793 if (InOr == true && OldEnd == LEnd)
648e3cb4 794 {
09a10f9c 795 if (OrOp == OrRemove)
70777d4b
AL
796 {
797 if ((Flags[I->ID] & Protected) != Protected)
00b47c98
AL
798 {
799 if (Debug == true)
47f6d1b7 800 clog << " Or group remove for " << I.FullName(false) << endl;
b83cad32 801 Cache.MarkDelete(I, false, 0, false);
cd14eaf2 802 Change = true;
09a10f9c
DK
803 }
804 }
805 else if (OrOp == OrKeep)
00b47c98
AL
806 {
807 if (Debug == true)
47f6d1b7 808 clog << " Or group keep for " << I.FullName(false) << endl;
74a05226 809 Cache.MarkKeep(I, false, false);
cd14eaf2 810 Change = true;
b2e465d6 811 }
648e3cb4
AL
812 }
813
b2e465d6
AL
814 /* We do an extra loop (as above) to finalize the or group
815 processing */
816 InOr = false;
648e3cb4 817 OrOp = OrRemove;
421c8d10 818 D.GlobOr(Start,End);
b2e465d6
AL
819 if (Start.end() == true)
820 break;
cd14eaf2 821
b2e465d6
AL
822 // We only worry about critical deps.
823 if (End.IsCritical() != true)
824 continue;
cd14eaf2 825
648e3cb4
AL
826 InOr = Start != End;
827 OldEnd = LEnd;
cd14eaf2 828 }
421c8d10 829 else
4cc152f9 830 {
f7f0d6c7 831 ++Start;
4cc152f9
MV
832 // We only worry about critical deps.
833 if (Start.IsCritical() != true)
834 continue;
835 }
cd14eaf2 836
6c139d6e
AL
837 // Dep is ok
838 if ((Cache[End] & pkgDepCache::DepGInstall) == pkgDepCache::DepGInstall)
cd14eaf2
AL
839 {
840 InOr = false;
6c139d6e 841 continue;
cd14eaf2
AL
842 }
843
6c139d6e 844 if (Debug == true)
47f6d1b7 845 clog << "Broken " << Start << endl;
fcf85120
AL
846
847 /* Look across the version list. If there are no possible
848 targets then we keep the package and bail. This is necessary
1e3f4083 849 if a package has a dep on another package that can't be found */
b2e465d6 850 SPtrArray<pkgCache::Version *> VList = Start.AllTargets();
fcf85120 851 if (*VList == 0 && (Flags[I->ID] & Protected) != Protected &&
359e46db 852 Start.IsNegative() == false &&
fcf85120 853 Cache[I].NowBroken() == false)
648e3cb4
AL
854 {
855 if (InOr == true)
856 {
857 /* No keep choice because the keep being OK could be the
858 result of another element in the OR group! */
859 continue;
860 }
861
fcf85120 862 Change = true;
74a05226 863 Cache.MarkKeep(I, false, false);
fcf85120
AL
864 break;
865 }
866
6c139d6e
AL
867 bool Done = false;
868 for (pkgCache::Version **V = VList; *V != 0; V++)
869 {
870 pkgCache::VerIterator Ver(Cache,*V);
871 pkgCache::PkgIterator Pkg = Ver.ParentPkg();
a6bfe583 872
2ba99db8
MV
873 /* This is a conflicts, and the version we are looking
874 at is not the currently selected version of the
875 package, which means it is not necessary to
876 remove/keep */
359e46db 877 if (Cache[Pkg].InstallVer != Ver && Start.IsNegative() == true)
4429616b 878 {
2ba99db8
MV
879 if (Debug)
880 clog << " Conflicts//Breaks against version "
881 << Ver.VerStr() << " for " << Pkg.Name()
882 << " but that is not InstVer, ignoring"
24e93662 883 << endl;
2ba99db8 884 continue;
4429616b
MV
885 }
886
6c139d6e 887 if (Debug == true)
e788a834
DK
888 clog << " Considering " << Pkg.FullName(false) << ' ' << Scores[Pkg->ID] <<
889 " as a solution to " << I.FullName(false) << ' ' << Scores[I->ID] << endl;
a6bfe583
AL
890
891 /* Try to fix the package under consideration rather than
892 fiddle with the VList package */
6c139d6e 893 if (Scores[I->ID] <= Scores[Pkg->ID] ||
421c8d10 894 ((Cache[Start] & pkgDepCache::DepNow) == 0 &&
359e46db 895 End.IsNegative() == false))
6c139d6e 896 {
200f8c52 897 // Try a little harder to fix protected packages..
3b5421b4 898 if ((Flags[I->ID] & Protected) == Protected)
200f8c52
AL
899 {
900 if (DoUpgrade(Pkg) == true)
0296c633 901 {
b2e465d6
AL
902 if (Scores[Pkg->ID] > Scores[I->ID])
903 Scores[Pkg->ID] = Scores[I->ID];
0296c633
AL
904 break;
905 }
906
6c139d6e 907 continue;
200f8c52
AL
908 }
909
910 /* See if a keep will do, unless the package is protected,
648e3cb4
AL
911 then installing it will be necessary */
912 bool Installed = Cache[I].Install();
74a05226 913 Cache.MarkKeep(I, false, false);
6c139d6e
AL
914 if (Cache[I].InstBroken() == false)
915 {
648e3cb4
AL
916 // Unwind operation will be keep now
917 if (OrOp == OrRemove)
918 OrOp = OrKeep;
919
920 // Restore
921 if (InOr == true && Installed == true)
74a05226 922 Cache.MarkInstall(I, false, 0, false);
648e3cb4 923
6c139d6e 924 if (Debug == true)
47f6d1b7 925 clog << " Holding Back " << I.FullName(false) << " rather than change " << Start.TargetPkg().FullName(false) << endl;
6c139d6e
AL
926 }
927 else
421c8d10 928 {
6c139d6e
AL
929 if (BrokenFix == false || DoUpgrade(I) == false)
930 {
421c8d10 931 // Consider other options
87da7451 932 if (InOr == false || Cache[I].Garbage == true)
421c8d10 933 {
6910a2ac 934 if (Debug == true)
47f6d1b7 935 clog << " Removing " << I.FullName(false) << " rather than change " << Start.TargetPkg().FullName(false) << endl;
b83cad32 936 Cache.MarkDelete(I, false, 0, false);
6910a2ac
DK
937 if (Counter > 1 && Scores[Pkg->ID] > Scores[I->ID])
938 Scores[I->ID] = Scores[Pkg->ID];
d6ebeb21 939 }
09a10f9c
DK
940 else if (TryFixByInstall == true &&
941 Start.TargetPkg()->CurrentVer == 0 &&
942 Cache[Start.TargetPkg()].Delete() == false &&
a3f1a6cc 943 (Flags[Start.TargetPkg()->ID] & ToRemove) != ToRemove &&
09a10f9c
DK
944 Cache.GetCandidateVer(Start.TargetPkg()).end() == false)
945 {
946 /* Before removing or keeping the package with the broken dependency
947 try instead to install the first not previously installed package
948 solving this dependency. This helps every time a previous solver
949 is removed by the resolver because of a conflict or alike but it is
950 dangerous as it could trigger new breaks/conflicts… */
443266ef
DK
951 if (Debug == true)
952 clog << " Try Installing " << Start.TargetPkg() << " before changing " << I.FullName(false) << std::endl;
09a10f9c
DK
953 unsigned long const OldBroken = Cache.BrokenCount();
954 Cache.MarkInstall(Start.TargetPkg(), true, 1, false);
955 // FIXME: we should undo the complete MarkInstall process here
956 if (Cache[Start.TargetPkg()].InstBroken() == true || Cache.BrokenCount() > OldBroken)
957 Cache.MarkDelete(Start.TargetPkg(), false, 1, false);
958 }
0a8e3465 959 }
6c139d6e 960 }
b5dc9785 961
6c139d6e
AL
962 Change = true;
963 Done = true;
964 break;
965 }
966 else
967 {
308c7d30
IJ
968 if (Start->Type == pkgCache::Dep::DpkgBreaks)
969 {
76264cb7
MV
970 // first, try upgradring the package, if that
971 // does not help, the breaks goes onto the
972 // kill list
2ba99db8 973 //
76264cb7 974 // FIXME: use DoUpgrade(Pkg) instead?
2ba99db8 975 if (Cache[End] & pkgDepCache::DepGCVer)
76264cb7 976 {
308c7d30 977 if (Debug)
47f6d1b7 978 clog << " Upgrading " << Pkg.FullName(false) << " due to Breaks field in " << I.FullName(false) << endl;
308c7d30
IJ
979 Cache.MarkInstall(Pkg, false, 0, false);
980 continue;
981 }
308c7d30
IJ
982 }
983
648e3cb4 984 // Skip adding to the kill list if it is protected
6c139d6e
AL
985 if ((Flags[Pkg->ID] & Protected) != 0)
986 continue;
a6bfe583
AL
987
988 if (Debug == true)
47f6d1b7 989 clog << " Added " << Pkg.FullName(false) << " to the remove list" << endl;
6c139d6e
AL
990
991 LEnd->Pkg = Pkg;
992 LEnd->Dep = End;
993 LEnd++;
0a8e3465 994
b47053bd 995 if (Start.IsNegative() == false)
6c139d6e
AL
996 break;
997 }
998 }
999
1000 // Hm, nothing can possibly satisify this dep. Nuke it.
359e46db
DK
1001 if (VList[0] == 0 &&
1002 Start.IsNegative() == false &&
648e3cb4 1003 (Flags[I->ID] & Protected) != Protected)
6c139d6e 1004 {
648e3cb4 1005 bool Installed = Cache[I].Install();
6c139d6e
AL
1006 Cache.MarkKeep(I);
1007 if (Cache[I].InstBroken() == false)
1008 {
648e3cb4
AL
1009 // Unwind operation will be keep now
1010 if (OrOp == OrRemove)
1011 OrOp = OrKeep;
1012
1013 // Restore
1014 if (InOr == true && Installed == true)
74a05226 1015 Cache.MarkInstall(I, false, 0, false);
648e3cb4 1016
6c139d6e 1017 if (Debug == true)
47f6d1b7 1018 clog << " Holding Back " << I.FullName(false) << " because I can't find " << Start.TargetPkg().FullName(false) << endl;
6c139d6e
AL
1019 }
1020 else
1021 {
1022 if (Debug == true)
47f6d1b7 1023 clog << " Removing " << I.FullName(false) << " because I can't find " << Start.TargetPkg().FullName(false) << endl;
648e3cb4 1024 if (InOr == false)
b83cad32 1025 Cache.MarkDelete(I, false, 0, false);
6c139d6e
AL
1026 }
1027
1028 Change = true;
1029 Done = true;
1030 }
1031
421c8d10
AL
1032 // Try some more
1033 if (InOr == true)
1034 continue;
1035
6c139d6e
AL
1036 if (Done == true)
1037 break;
1038 }
1039
1040 // Apply the kill list now
1041 if (Cache[I].InstallVer != 0)
648e3cb4 1042 {
6c139d6e 1043 for (PackageKill *J = KillList; J != LEnd; J++)
6c139d6e 1044 {
648e3cb4
AL
1045 Change = true;
1046 if ((Cache[J->Dep] & pkgDepCache::DepGNow) == 0)
1047 {
359e46db 1048 if (J->Dep.IsNegative() == true)
648e3cb4
AL
1049 {
1050 if (Debug == true)
47f6d1b7 1051 clog << " Fixing " << I.FullName(false) << " via remove of " << J->Pkg.FullName(false) << endl;
b83cad32 1052 Cache.MarkDelete(J->Pkg, false, 0, false);
648e3cb4
AL
1053 }
1054 }
1055 else
6c139d6e
AL
1056 {
1057 if (Debug == true)
47f6d1b7 1058 clog << " Fixing " << I.FullName(false) << " via keep of " << J->Pkg.FullName(false) << endl;
74a05226 1059 Cache.MarkKeep(J->Pkg, false, false);
6c139d6e 1060 }
b2e465d6 1061
648e3cb4 1062 if (Counter > 1)
b2e465d6
AL
1063 {
1064 if (Scores[I->ID] > Scores[J->Pkg->ID])
1065 Scores[J->Pkg->ID] = Scores[I->ID];
1066 }
648e3cb4
AL
1067 }
1068 }
1069 }
6c139d6e
AL
1070 }
1071
1072 if (Debug == true)
0a8e3465 1073 clog << "Done" << endl;
b2e465d6 1074
6c139d6e 1075 if (Cache.BrokenCount() != 0)
b5dc9785
AL
1076 {
1077 // See if this is the result of a hold
1078 pkgCache::PkgIterator I = Cache.PkgBegin();
f7f0d6c7 1079 for (;I.end() != true; ++I)
b5dc9785
AL
1080 {
1081 if (Cache[I].InstBroken() == false)
1082 continue;
1083 if ((Flags[I->ID] & Protected) != Protected)
b2e465d6 1084 return _error->Error(_("Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages."));
b5dc9785 1085 }
b2e465d6 1086 return _error->Error(_("Unable to correct problems, you have held broken packages."));
b5dc9785
AL
1087 }
1088
fce72602 1089 // set the auto-flags (mvo: I'm not sure if we _really_ need this)
80fa0d8a 1090 pkgCache::PkgIterator I = Cache.PkgBegin();
f7f0d6c7 1091 for (;I.end() != true; ++I) {
80fa0d8a 1092 if (Cache[I].NewInstall() && !(Flags[I->ID] & PreInstalled)) {
120365ce 1093 if(_config->FindI("Debug::pkgAutoRemove",false)) {
47f6d1b7 1094 std::clog << "Resolve installed new pkg: " << I.FullName(false)
120365ce
MV
1095 << " (now marking it as auto)" << std::endl;
1096 }
80fa0d8a
MV
1097 Cache[I].Flags |= pkgCache::Flag::Auto;
1098 }
1099 }
1100
1101
0a8e3465
AL
1102 return true;
1103}
1104 /*}}}*/
953b348c
MV
1105// ProblemResolver::BreaksInstOrPolicy - Check if the given pkg is broken/*{{{*/
1106// ---------------------------------------------------------------------
1107/* This checks if the given package is broken either by a hard dependency
1108 (InstBroken()) or by introducing a new policy breakage e.g. new
1109 unsatisfied recommends for a package that was in "policy-good" state
1110
1111 Note that this is not perfect as it will ignore further breakage
1112 for already broken policy (recommends)
1113*/
1114bool pkgProblemResolver::InstOrNewPolicyBroken(pkgCache::PkgIterator I)
1115{
953b348c
MV
1116 // a broken install is always a problem
1117 if (Cache[I].InstBroken() == true)
deec6474
DK
1118 {
1119 if (Debug == true)
1120 std::clog << " Dependencies are not satisfied for " << I << std::endl;
953b348c 1121 return true;
deec6474 1122 }
953b348c
MV
1123
1124 // a newly broken policy (recommends/suggests) is a problem
1125 if (Cache[I].NowPolicyBroken() == false &&
1126 Cache[I].InstPolicyBroken() == true)
deec6474
DK
1127 {
1128 if (Debug == true)
1129 std::clog << " Policy breaks with upgrade of " << I << std::endl;
953b348c 1130 return true;
deec6474
DK
1131 }
1132
953b348c
MV
1133 return false;
1134}
36a171e1 1135 /*}}}*/
0a8e3465
AL
1136// ProblemResolver::ResolveByKeep - Resolve problems using keep /*{{{*/
1137// ---------------------------------------------------------------------
1138/* This is the work horse of the soft upgrade routine. It is very gental
1139 in that it does not install or remove any packages. It is assumed that the
1140 system was non-broken previously. */
2a884c61 1141bool pkgProblemResolver::ResolveByKeep(OpProgress * const Progress)
741b7da9 1142{
98278a81 1143 std::string const solver = _config->Find("APT::Solver", "internal");
2a884c61
DK
1144 if (solver != "internal")
1145 return EDSP::ResolveExternal(solver.c_str(), Cache, true, false, false, Progress);
741b7da9
DK
1146 return ResolveByKeepInternal();
1147}
1148 /*}}}*/
1149// ProblemResolver::ResolveByKeepInternal - Resolve problems using keep /*{{{*/
1150// ---------------------------------------------------------------------
1151/* This is the work horse of the soft upgrade routine. It is very gental
1152 in that it does not install or remove any packages. It is assumed that the
1153 system was non-broken previously. */
1154bool pkgProblemResolver::ResolveByKeepInternal()
0a8e3465 1155{
74a05226
MV
1156 pkgDepCache::ActionGroup group(Cache);
1157
b2e465d6 1158 unsigned long Size = Cache.Head().PackageCount;
0a8e3465 1159
0a8e3465
AL
1160 MakeScores();
1161
1162 /* We have to order the packages so that the broken fixing pass
1163 operates from highest score to lowest. This prevents problems when
1164 high score packages cause the removal of lower score packages that
1165 would cause the removal of even lower score packages. */
1166 pkgCache::Package **PList = new pkgCache::Package *[Size];
1167 pkgCache::Package **PEnd = PList;
f7f0d6c7 1168 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
0a8e3465
AL
1169 *PEnd++ = I;
1170 This = this;
1171 qsort(PList,PEnd - PList,sizeof(*PList),&ScoreSort);
8b4894fe
MV
1172
1173 if (_config->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
1174 {
1175 clog << "Show Scores" << endl;
1176 for (pkgCache::Package **K = PList; K != PEnd; K++)
1177 if (Scores[(*K)->ID] != 0)
1178 {
1179 pkgCache::PkgIterator Pkg(Cache,*K);
1180 clog << Scores[(*K)->ID] << ' ' << Pkg << std::endl;
1181 }
1182 }
1183
1184 if (Debug == true)
1185 clog << "Entering ResolveByKeep" << endl;
1186
0a8e3465
AL
1187 // Consider each broken package
1188 pkgCache::Package **LastStop = 0;
1189 for (pkgCache::Package **K = PList; K != PEnd; K++)
1190 {
1191 pkgCache::PkgIterator I(Cache,*K);
1192
953b348c 1193 if (Cache[I].InstallVer == 0)
0a8e3465
AL
1194 continue;
1195
953b348c
MV
1196 if (InstOrNewPolicyBroken(I) == false)
1197 continue;
1198
0a8e3465 1199 /* Keep the package. If this works then great, otherwise we have
1e3f4083 1200 to be significantly more aggressive and manipulate its dependencies */
0a8e3465
AL
1201 if ((Flags[I->ID] & Protected) == 0)
1202 {
1203 if (Debug == true)
47f6d1b7 1204 clog << "Keeping package " << I.FullName(false) << endl;
74a05226 1205 Cache.MarkKeep(I, false, false);
953b348c 1206 if (InstOrNewPolicyBroken(I) == false)
0a8e3465 1207 {
b2e465d6 1208 K = PList - 1;
0a8e3465
AL
1209 continue;
1210 }
1211 }
1212
1213 // Isolate the problem dependencies
1214 for (pkgCache::DepIterator D = Cache[I].InstVerIter(Cache).DependsList(); D.end() == false;)
1215 {
c5532863
AL
1216 DepIterator Start;
1217 DepIterator End;
1218 D.GlobOr(Start,End);
1219
0a8e3465
AL
1220 // We only worry about critical deps.
1221 if (End.IsCritical() != true)
1222 continue;
1223
1224 // Dep is ok
1225 if ((Cache[End] & pkgDepCache::DepGInstall) == pkgDepCache::DepGInstall)
1226 continue;
c5532863
AL
1227
1228 /* Hm, the group is broken.. I suppose the best thing to do is to
1229 is to try every combination of keep/not-keep for the set, but thats
1230 slow, and this never happens, just be conservative and assume the
1231 list of ors is in preference and keep till it starts to work. */
1232 while (true)
0a8e3465 1233 {
c5532863 1234 if (Debug == true)
47f6d1b7 1235 clog << "Package " << I.FullName(false) << " " << Start << endl;
8b4894fe 1236
c5532863
AL
1237 // Look at all the possible provides on this package
1238 SPtrArray<pkgCache::Version *> VList = Start.AllTargets();
1239 for (pkgCache::Version **V = VList; *V != 0; V++)
0a8e3465 1240 {
c5532863
AL
1241 pkgCache::VerIterator Ver(Cache,*V);
1242 pkgCache::PkgIterator Pkg = Ver.ParentPkg();
1243
1244 // It is not keepable
1245 if (Cache[Pkg].InstallVer == 0 ||
1246 Pkg->CurrentVer == 0)
1247 continue;
1248
1249 if ((Flags[I->ID] & Protected) == 0)
1250 {
1251 if (Debug == true)
47f6d1b7 1252 clog << " Keeping Package " << Pkg.FullName(false) << " due to " << Start.DepType() << endl;
74a05226 1253 Cache.MarkKeep(Pkg, false, false);
c5532863
AL
1254 }
1255
953b348c 1256 if (InstOrNewPolicyBroken(I) == false)
c5532863 1257 break;
0a8e3465
AL
1258 }
1259
953b348c 1260 if (InstOrNewPolicyBroken(I) == false)
0a8e3465 1261 break;
0a8e3465 1262
c5532863
AL
1263 if (Start == End)
1264 break;
f7f0d6c7 1265 ++Start;
c5532863
AL
1266 }
1267
953b348c 1268 if (InstOrNewPolicyBroken(I) == false)
0a8e3465
AL
1269 break;
1270 }
1271
953b348c 1272 if (InstOrNewPolicyBroken(I) == true)
0a8e3465
AL
1273 continue;
1274
1275 // Restart again.
0291f645
JT
1276 if (K == LastStop) {
1277 // I is an iterator based off our temporary package list,
1278 // so copy the name we need before deleting the temporary list
1279 std::string const LoopingPackage = I.FullName(false);
1280 delete[] PList;
1281 return _error->Error("Internal Error, pkgProblemResolver::ResolveByKeep is looping on package %s.", LoopingPackage.c_str());
1282 }
0a8e3465 1283 LastStop = K;
b2e465d6 1284 K = PList - 1;
0291f645 1285 }
6c139d6e 1286
0291f645 1287 delete[] PList;
6c139d6e
AL
1288 return true;
1289}
1290 /*}}}*/
f3c736f9 1291// ProblemResolver::InstallProtect - deprecated cpu-eating no-op /*{{{*/
3b5421b4 1292// ---------------------------------------------------------------------
f3c736f9
DK
1293/* Actions issued with FromUser bit set are protected from further
1294 modification (expect by other calls with FromUser set) nowadays , so we
1295 don't need to reissue actions here, they are already set in stone. */
3b5421b4
AL
1296void pkgProblemResolver::InstallProtect()
1297{
74a05226
MV
1298 pkgDepCache::ActionGroup group(Cache);
1299
f7f0d6c7 1300 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
3b5421b4
AL
1301 {
1302 if ((Flags[I->ID] & Protected) == Protected)
1303 {
1304 if ((Flags[I->ID] & ToRemove) == ToRemove)
1305 Cache.MarkDelete(I);
c15f5690
MV
1306 else
1307 {
da543ed8
OS
1308 // preserve the information whether the package was auto
1309 // or manually installed
c15f5690
MV
1310 bool autoInst = (Cache[I].Flags & pkgCache::Flag::Auto);
1311 Cache.MarkInstall(I, false, 0, !autoInst);
1312 }
3b5421b4
AL
1313 }
1314 }
1315}
1316 /*}}}*/
b2e465d6
AL
1317// PrioSortList - Sort a list of versions by priority /*{{{*/
1318// ---------------------------------------------------------------------
1319/* This is ment to be used in conjunction with AllTargets to get a list
1320 of versions ordered by preference. */
1321static pkgCache *PrioCache;
1322static int PrioComp(const void *A,const void *B)
1323{
1324 pkgCache::VerIterator L(*PrioCache,*(pkgCache::Version **)A);
1325 pkgCache::VerIterator R(*PrioCache,*(pkgCache::Version **)B);
1326
1327 if ((L.ParentPkg()->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential &&
b8c0f9b7
AL
1328 (R.ParentPkg()->Flags & pkgCache::Flag::Essential) != pkgCache::Flag::Essential)
1329 return 1;
b2e465d6 1330 if ((L.ParentPkg()->Flags & pkgCache::Flag::Essential) != pkgCache::Flag::Essential &&
b8c0f9b7
AL
1331 (R.ParentPkg()->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential)
1332 return -1;
c5200869
JAK
1333
1334 if ((L.ParentPkg()->Flags & pkgCache::Flag::Important) == pkgCache::Flag::Important &&
1335 (R.ParentPkg()->Flags & pkgCache::Flag::Important) != pkgCache::Flag::Important)
1336 return 1;
1337 if ((L.ParentPkg()->Flags & pkgCache::Flag::Important) != pkgCache::Flag::Important &&
1338 (R.ParentPkg()->Flags & pkgCache::Flag::Important) == pkgCache::Flag::Important)
1339 return -1;
b2e465d6
AL
1340
1341 if (L->Priority != R->Priority)
b8c0f9b7 1342 return R->Priority - L->Priority;
b2e465d6
AL
1343 return strcmp(L.ParentPkg().Name(),R.ParentPkg().Name());
1344}
1345void pkgPrioSortList(pkgCache &Cache,pkgCache::Version **List)
1346{
1347 unsigned long Count = 0;
1348 PrioCache = &Cache;
1349 for (pkgCache::Version **I = List; *I != 0; I++)
1350 Count++;
1351 qsort(List,Count,sizeof(*List),PrioComp);
1352}
1353 /*}}}*/