]>
Commit | Line | Data |
---|---|---|
6c139d6e AL |
1 | // -*- mode: cpp; mode: fold -*- |
2 | // Description /*{{{*/ | |
5819a761 | 3 | // $Id: orderlist.cc,v 1.14 2001/05/07 05:49:43 jgg Exp $ |
6c139d6e AL |
4 | /* ###################################################################### |
5 | ||
6 | Order List - Represents and Manipulates an ordered list of packages. | |
7 | ||
8 | A list of packages can be ordered by a number of conflicting criteria | |
9 | each given a specific priority. Each package also has a set of flags | |
b2e465d6 | 10 | indicating some useful things about it that are derived in the |
6c139d6e AL |
11 | course of sorting. The pkgPackageManager class uses this class for |
12 | all of it's installation ordering needs. | |
13 | ||
14 | This is a modified version of Manoj's Routine B. It consists of four | |
15 | independent ordering algorithms that can be applied at for different | |
16 | points in the ordering. By appling progressivly fewer ordering | |
17 | operations it is possible to give each consideration it's own | |
18 | priority and create an order that satisfies the lowest applicable | |
19 | consideration. | |
20 | ||
21 | The rules for unpacking ordering are: | |
22 | 1) Unpacking ignores Depends: on all packages | |
23 | 2) Unpacking requires Conflicts: on -ALL- packages to be satisfied | |
24 | 3) Unpacking requires PreDepends: on this package only to be satisfied | |
25 | 4) Removing requires that no packages depend on the package to be | |
26 | removed. | |
27 | ||
28 | And the rule for configuration ordering is: | |
29 | 1) Configuring requires that the Depends: of the package be satisfied | |
30 | Conflicts+PreDepends are ignored because unpacking says they are | |
31 | already correct [exageration, it does check but we need not be | |
32 | concerned] | |
33 | ||
34 | And some features that are valuable for unpacking ordering. | |
35 | f1) Unpacking a new package should advoid breaking dependencies of | |
36 | configured packages | |
37 | f2) Removal should not require a force, corrolory of f1 | |
38 | f3) Unpacking should order by depends rather than fall back to random | |
39 | ordering. | |
40 | ||
41 | Each of the features can be enabled in the sorting routine at an | |
7365ff46 | 42 | arbitrary priority to give quite abit of control over the final unpacking |
6c139d6e AL |
43 | order. |
44 | ||
281daf46 | 45 | The rules listed above may never be violated and are called Critical. |
6c139d6e AL |
46 | When a critical rule is violated then a loop condition is recorded |
47 | and will have to be delt with in the caller. | |
63d3141a AL |
48 | |
49 | The ordering keeps two lists, the main list and the 'After List'. The | |
50 | purpose of the after list is to allow packages to be delayed. This is done | |
51 | by setting the after flag on the package. Any package which requires this | |
52 | package to be ordered before will inherit the after flag and so on. This | |
53 | is used for CD swap ordering where all packages on a second CD have the | |
54 | after flag set. This forces them and all their dependents to be ordered | |
55 | toward the end. | |
6c139d6e | 56 | |
b2e465d6 AL |
57 | There are complications in this algorithm when presented with cycles. |
58 | For all known practical cases it works, all cases where it doesn't work | |
59 | is fixable by tweaking the package descriptions. However, it should be | |
60 | possible to impove this further to make some better choices when | |
61 | presented with cycles. | |
62 | ||
6c139d6e AL |
63 | ##################################################################### */ |
64 | /*}}}*/ | |
65 | // Include Files /*{{{*/ | |
094a497d AL |
66 | #include <apt-pkg/orderlist.h> |
67 | #include <apt-pkg/depcache.h> | |
68 | #include <apt-pkg/error.h> | |
69 | #include <apt-pkg/version.h> | |
b2e465d6 AL |
70 | #include <apt-pkg/sptr.h> |
71 | #include <apt-pkg/configuration.h> | |
5819a761 AL |
72 | |
73 | #include <iostream> | |
6c139d6e AL |
74 | /*}}}*/ |
75 | ||
5819a761 AL |
76 | using namespace std; |
77 | ||
6c139d6e AL |
78 | pkgOrderList *pkgOrderList::Me = 0; |
79 | ||
80 | // OrderList::pkgOrderList - Constructor /*{{{*/ | |
81 | // --------------------------------------------------------------------- | |
82 | /* */ | |
b2e465d6 | 83 | pkgOrderList::pkgOrderList(pkgDepCache *pCache) : Cache(*pCache) |
6c139d6e | 84 | { |
281daf46 | 85 | FileList = 0; |
6c139d6e AL |
86 | Primary = 0; |
87 | Secondary = 0; | |
88 | RevDepends = 0; | |
89 | Remove = 0; | |
90 | LoopCount = -1; | |
b2e465d6 AL |
91 | Debug = _config->FindB("Debug::pkgOrderList",false); |
92 | ||
6c139d6e AL |
93 | /* Construct the arrays, egcs 1.0.1 bug requires the package count |
94 | hack */ | |
b2e465d6 | 95 | unsigned long Size = Cache.Head().PackageCount; |
63d3141a | 96 | Flags = new unsigned short[Size]; |
6c139d6e AL |
97 | End = List = new Package *[Size]; |
98 | memset(Flags,0,sizeof(*Flags)*Size); | |
99 | } | |
100 | /*}}}*/ | |
101 | // OrderList::~pkgOrderList - Destructor /*{{{*/ | |
102 | // --------------------------------------------------------------------- | |
103 | /* */ | |
104 | pkgOrderList::~pkgOrderList() | |
105 | { | |
106 | delete [] List; | |
107 | delete [] Flags; | |
108 | } | |
109 | /*}}}*/ | |
2fd65468 AL |
110 | // OrderList::IsMissing - Check if a file is missing /*{{{*/ |
111 | // --------------------------------------------------------------------- | |
112 | /* */ | |
113 | bool pkgOrderList::IsMissing(PkgIterator Pkg) | |
114 | { | |
115 | // Skip packages to erase | |
116 | if (Cache[Pkg].Delete() == true) | |
117 | return false; | |
118 | ||
119 | // Skip Packages that need configure only. | |
c0ba35fc DK |
120 | if ((Pkg.State() == pkgCache::PkgIterator::NeedsConfigure || |
121 | Pkg.State() == pkgCache::PkgIterator::NeedsNothing) && | |
2fd65468 AL |
122 | Cache[Pkg].Keep() == true) |
123 | return false; | |
7cd4153b AL |
124 | |
125 | if (FileList == 0) | |
126 | return false; | |
2fd65468 | 127 | |
7cd4153b | 128 | if (FileList[Pkg->ID].empty() == false) |
2fd65468 | 129 | return false; |
803ea2a8 | 130 | |
70ae2409 | 131 | // Missing Pseudo packages are missing if the real package is missing |
803ea2a8 | 132 | if (pkgCache::VerIterator(Cache, Cache[Pkg].CandidateVer).Pseudo() == true) |
70ae2409 | 133 | return IsMissing(Pkg.Group().FindPkg("all")); |
803ea2a8 | 134 | |
2fd65468 AL |
135 | return true; |
136 | } | |
137 | /*}}}*/ | |
6c139d6e AL |
138 | // OrderList::DoRun - Does an order run /*{{{*/ |
139 | // --------------------------------------------------------------------- | |
140 | /* The caller is expeted to have setup the desired probe state */ | |
141 | bool pkgOrderList::DoRun() | |
281daf46 | 142 | { |
6c139d6e | 143 | // Temp list |
b2e465d6 AL |
144 | unsigned long Size = Cache.Head().PackageCount; |
145 | SPtrArray<Package *> NList = new Package *[Size]; | |
146 | SPtrArray<Package *> AfterList = new Package *[Size]; | |
63d3141a AL |
147 | AfterEnd = AfterList; |
148 | ||
6c139d6e AL |
149 | Depth = 0; |
150 | WipeFlags(Added | AddPending | Loop | InList); | |
151 | ||
152 | for (iterator I = List; I != End; I++) | |
153 | Flag(*I,InList); | |
63d3141a | 154 | |
6c139d6e AL |
155 | // Rebuild the main list into the temp list. |
156 | iterator OldEnd = End; | |
157 | End = NList; | |
158 | for (iterator I = List; I != OldEnd; I++) | |
159 | if (VisitNode(PkgIterator(Cache,*I)) == false) | |
160 | { | |
161 | End = OldEnd; | |
6c139d6e AL |
162 | return false; |
163 | } | |
164 | ||
63d3141a AL |
165 | // Copy the after list to the end of the main list |
166 | for (Package **I = AfterList; I != AfterEnd; I++) | |
167 | *End++ = *I; | |
168 | ||
6c139d6e AL |
169 | // Swap the main list to the new list |
170 | delete [] List; | |
b2e465d6 | 171 | List = NList.UnGuard(); |
6c139d6e AL |
172 | return true; |
173 | } | |
174 | /*}}}*/ | |
175 | // OrderList::OrderCritical - Perform critical unpacking ordering /*{{{*/ | |
176 | // --------------------------------------------------------------------- | |
177 | /* This performs predepends and immediate configuration ordering only. | |
178 | This is termed critical unpacking ordering. Any loops that form are | |
179 | fatal and indicate that the packages cannot be installed. */ | |
180 | bool pkgOrderList::OrderCritical() | |
181 | { | |
281daf46 | 182 | FileList = 0; |
5e312de7 | 183 | |
d5081aee | 184 | Primary = &pkgOrderList::DepUnPackPreD; |
6c139d6e AL |
185 | Secondary = 0; |
186 | RevDepends = 0; | |
187 | Remove = 0; | |
188 | LoopCount = 0; | |
5e312de7 | 189 | |
6c139d6e AL |
190 | // Sort |
191 | Me = this; | |
5e312de7 DK |
192 | qsort(List,End - List,sizeof(*List),&OrderCompareB); |
193 | ||
6c139d6e AL |
194 | if (DoRun() == false) |
195 | return false; | |
5e312de7 | 196 | |
6c139d6e AL |
197 | if (LoopCount != 0) |
198 | return _error->Error("Fatal, predepends looping detected"); | |
5e312de7 DK |
199 | |
200 | if (Debug == true) | |
201 | { | |
202 | clog << "** Critical Unpack ordering done" << endl; | |
203 | ||
204 | for (iterator I = List; I != End; I++) | |
205 | { | |
206 | PkgIterator P(Cache,*I); | |
207 | if (IsNow(P) == true) | |
70ae2409 | 208 | clog << " " << P.FullName() << ' ' << IsMissing(P) << ',' << IsFlag(P,After) << endl; |
5e312de7 DK |
209 | } |
210 | } | |
211 | ||
6c139d6e AL |
212 | return true; |
213 | } | |
214 | /*}}}*/ | |
215 | // OrderList::OrderUnpack - Perform complete unpacking ordering /*{{{*/ | |
216 | // --------------------------------------------------------------------- | |
217 | /* This performs complete unpacking ordering and creates an order that is | |
218 | suitable for unpacking */ | |
281daf46 | 219 | bool pkgOrderList::OrderUnpack(string *FileList) |
6c139d6e | 220 | { |
281daf46 AL |
221 | this->FileList = FileList; |
222 | ||
63d3141a AL |
223 | // Setup the after flags |
224 | if (FileList != 0) | |
225 | { | |
226 | WipeFlags(After); | |
5e312de7 | 227 | |
63d3141a AL |
228 | // Set the inlist flag |
229 | for (iterator I = List; I != End; I++) | |
230 | { | |
231 | PkgIterator P(Cache,*I); | |
232 | if (IsMissing(P) == true && IsNow(P) == true) | |
233 | Flag(*I,After); | |
234 | } | |
235 | } | |
5e312de7 | 236 | |
727f18af AL |
237 | Primary = &pkgOrderList::DepUnPackCrit; |
238 | Secondary = &pkgOrderList::DepConfigure; | |
239 | RevDepends = &pkgOrderList::DepUnPackDep; | |
240 | Remove = &pkgOrderList::DepRemove; | |
6c139d6e AL |
241 | LoopCount = -1; |
242 | ||
243 | // Sort | |
244 | Me = this; | |
245 | qsort(List,End - List,sizeof(*List),&OrderCompareA); | |
281daf46 | 246 | |
d5081aee DK |
247 | if (Debug == true) |
248 | clog << "** Pass A" << endl; | |
249 | if (DoRun() == false) | |
250 | return false; | |
5e312de7 | 251 | |
b2e465d6 AL |
252 | if (Debug == true) |
253 | clog << "** Pass B" << endl; | |
6c139d6e AL |
254 | Secondary = 0; |
255 | if (DoRun() == false) | |
256 | return false; | |
257 | ||
b2e465d6 AL |
258 | if (Debug == true) |
259 | clog << "** Pass C" << endl; | |
6c139d6e AL |
260 | LoopCount = 0; |
261 | RevDepends = 0; | |
262 | Remove = 0; // Otherwise the libreadline remove problem occures | |
263 | if (DoRun() == false) | |
264 | return false; | |
5e312de7 | 265 | |
b2e465d6 AL |
266 | if (Debug == true) |
267 | clog << "** Pass D" << endl; | |
6c139d6e | 268 | LoopCount = 0; |
727f18af | 269 | Primary = &pkgOrderList::DepUnPackPre; |
6c139d6e AL |
270 | if (DoRun() == false) |
271 | return false; | |
272 | ||
b2e465d6 | 273 | if (Debug == true) |
6c139d6e | 274 | { |
b2e465d6 AL |
275 | clog << "** Unpack ordering done" << endl; |
276 | ||
277 | for (iterator I = List; I != End; I++) | |
278 | { | |
279 | PkgIterator P(Cache,*I); | |
280 | if (IsNow(P) == true) | |
70ae2409 | 281 | clog << " " << P.FullName() << ' ' << IsMissing(P) << ',' << IsFlag(P,After) << endl; |
b2e465d6 | 282 | } |
5e312de7 | 283 | } |
6c139d6e AL |
284 | |
285 | return true; | |
286 | } | |
287 | /*}}}*/ | |
288 | // OrderList::OrderConfigure - Perform configuration ordering /*{{{*/ | |
289 | // --------------------------------------------------------------------- | |
290 | /* This orders by depends only and produces an order which is suitable | |
291 | for configuration */ | |
292 | bool pkgOrderList::OrderConfigure() | |
293 | { | |
281daf46 | 294 | FileList = 0; |
727f18af | 295 | Primary = &pkgOrderList::DepConfigure; |
6c139d6e AL |
296 | Secondary = 0; |
297 | RevDepends = 0; | |
298 | Remove = 0; | |
299 | LoopCount = -1; | |
300 | return DoRun(); | |
301 | } | |
302 | /*}}}*/ | |
6c139d6e AL |
303 | // OrderList::Score - Score the package for sorting /*{{{*/ |
304 | // --------------------------------------------------------------------- | |
305 | /* Higher scores order earlier */ | |
306 | int pkgOrderList::Score(PkgIterator Pkg) | |
307 | { | |
5e312de7 DK |
308 | static int const ScoreDelete = _config->FindI("OrderList::Score::Delete", 500); |
309 | ||
6c139d6e AL |
310 | // Removal is always done first |
311 | if (Cache[Pkg].Delete() == true) | |
5e312de7 DK |
312 | return ScoreDelete; |
313 | ||
281daf46 AL |
314 | // This should never happen.. |
315 | if (Cache[Pkg].InstVerIter(Cache).end() == true) | |
316 | return -1; | |
5e312de7 DK |
317 | |
318 | static int const ScoreEssential = _config->FindI("OrderList::Score::Essential", 200); | |
319 | static int const ScoreImmediate = _config->FindI("OrderList::Score::Immediate", 10); | |
320 | static int const ScorePreDepends = _config->FindI("OrderList::Score::PreDepends", 50); | |
321 | ||
6c139d6e AL |
322 | int Score = 0; |
323 | if ((Pkg->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential) | |
5e312de7 | 324 | Score += ScoreEssential; |
6c139d6e | 325 | |
b2e465d6 | 326 | if (IsFlag(Pkg,Immediate) == true) |
5e312de7 DK |
327 | Score += ScoreImmediate; |
328 | ||
329 | for (DepIterator D = Cache[Pkg].InstVerIter(Cache).DependsList(); | |
6c139d6e AL |
330 | D.end() == false; D++) |
331 | if (D->Type == pkgCache::Dep::PreDepends) | |
332 | { | |
5e312de7 | 333 | Score += ScorePreDepends; |
6c139d6e AL |
334 | break; |
335 | } | |
5e312de7 | 336 | |
6c139d6e AL |
337 | // Important Required Standard Optional Extra |
338 | signed short PrioMap[] = {0,5,4,3,1,0}; | |
339 | if (Cache[Pkg].InstVerIter(Cache)->Priority <= 5) | |
340 | Score += PrioMap[Cache[Pkg].InstVerIter(Cache)->Priority]; | |
341 | return Score; | |
342 | } | |
343 | /*}}}*/ | |
344 | // OrderList::FileCmp - Compare by package file /*{{{*/ | |
345 | // --------------------------------------------------------------------- | |
346 | /* This compares by the package file that the install version is in. */ | |
347 | int pkgOrderList::FileCmp(PkgIterator A,PkgIterator B) | |
348 | { | |
349 | if (Cache[A].Delete() == true && Cache[B].Delete() == true) | |
350 | return 0; | |
351 | if (Cache[A].Delete() == true) | |
352 | return -1; | |
353 | if (Cache[B].Delete() == true) | |
354 | return 1; | |
355 | ||
356 | if (Cache[A].InstVerIter(Cache).FileList().end() == true) | |
357 | return -1; | |
281daf46 | 358 | if (Cache[B].InstVerIter(Cache).FileList().end() == true) |
6c139d6e AL |
359 | return 1; |
360 | ||
361 | pkgCache::PackageFile *FA = Cache[A].InstVerIter(Cache).FileList().File(); | |
362 | pkgCache::PackageFile *FB = Cache[B].InstVerIter(Cache).FileList().File(); | |
363 | if (FA < FB) | |
364 | return -1; | |
365 | if (FA > FB) | |
366 | return 1; | |
367 | return 0; | |
368 | } | |
369 | /*}}}*/ | |
281daf46 AL |
370 | // BoolCompare - Comparison function for two booleans /*{{{*/ |
371 | // --------------------------------------------------------------------- | |
372 | /* */ | |
373 | static int BoolCompare(bool A,bool B) | |
374 | { | |
375 | if (A == B) | |
376 | return 0; | |
377 | if (A == false) | |
378 | return -1; | |
379 | return 1; | |
380 | } | |
381 | /*}}}*/ | |
6c139d6e AL |
382 | // OrderList::OrderCompareA - Order the installation by op /*{{{*/ |
383 | // --------------------------------------------------------------------- | |
384 | /* This provides a first-pass sort of the list and gives a decent starting | |
385 | point for further complete ordering. It is used by OrderUnpack only */ | |
386 | int pkgOrderList::OrderCompareA(const void *a, const void *b) | |
387 | { | |
388 | PkgIterator A(Me->Cache,*(Package **)a); | |
389 | PkgIterator B(Me->Cache,*(Package **)b); | |
390 | ||
281daf46 AL |
391 | // We order packages with a set state toward the front |
392 | int Res; | |
7834cb57 | 393 | if ((Res = BoolCompare(Me->IsNow(A),Me->IsNow(B))) != 0) |
281daf46 AL |
394 | return -1*Res; |
395 | ||
396 | // We order missing files to toward the end | |
63d3141a | 397 | /* if (Me->FileList != 0) |
281daf46 | 398 | { |
2fd65468 | 399 | if ((Res = BoolCompare(Me->IsMissing(A), |
7834cb57 | 400 | Me->IsMissing(B))) != 0) |
2fd65468 | 401 | return Res; |
63d3141a | 402 | }*/ |
281daf46 | 403 | |
6c139d6e AL |
404 | if (A.State() != pkgCache::PkgIterator::NeedsNothing && |
405 | B.State() == pkgCache::PkgIterator::NeedsNothing) | |
406 | return -1; | |
407 | ||
408 | if (A.State() == pkgCache::PkgIterator::NeedsNothing && | |
409 | B.State() != pkgCache::PkgIterator::NeedsNothing) | |
410 | return 1; | |
411 | ||
412 | int ScoreA = Me->Score(A); | |
413 | int ScoreB = Me->Score(B); | |
5e312de7 | 414 | |
6c139d6e AL |
415 | if (ScoreA > ScoreB) |
416 | return -1; | |
417 | ||
418 | if (ScoreA < ScoreB) | |
419 | return 1; | |
420 | ||
421 | return strcmp(A.Name(),B.Name()); | |
422 | } | |
423 | /*}}}*/ | |
424 | // OrderList::OrderCompareB - Order the installation by source /*{{{*/ | |
425 | // --------------------------------------------------------------------- | |
b2e465d6 | 426 | /* This orders by installation source. This is useful to handle |
6c139d6e AL |
427 | inter-source breaks */ |
428 | int pkgOrderList::OrderCompareB(const void *a, const void *b) | |
429 | { | |
430 | PkgIterator A(Me->Cache,*(Package **)a); | |
431 | PkgIterator B(Me->Cache,*(Package **)b); | |
432 | ||
433 | if (A.State() != pkgCache::PkgIterator::NeedsNothing && | |
434 | B.State() == pkgCache::PkgIterator::NeedsNothing) | |
435 | return -1; | |
436 | ||
437 | if (A.State() == pkgCache::PkgIterator::NeedsNothing && | |
438 | B.State() != pkgCache::PkgIterator::NeedsNothing) | |
439 | return 1; | |
440 | ||
441 | int F = Me->FileCmp(A,B); | |
442 | if (F != 0) | |
443 | { | |
444 | if (F > 0) | |
445 | return -1; | |
446 | return 1; | |
447 | } | |
448 | ||
449 | int ScoreA = Me->Score(A); | |
450 | int ScoreB = Me->Score(B); | |
5e312de7 | 451 | |
6c139d6e AL |
452 | if (ScoreA > ScoreB) |
453 | return -1; | |
454 | ||
455 | if (ScoreA < ScoreB) | |
456 | return 1; | |
457 | ||
458 | return strcmp(A.Name(),B.Name()); | |
459 | } | |
460 | /*}}}*/ | |
6c139d6e AL |
461 | // OrderList::VisitDeps - Visit forward install dependencies /*{{{*/ |
462 | // --------------------------------------------------------------------- | |
463 | /* This calls the dependency function for the normal forwards dependencies | |
464 | of the package */ | |
465 | bool pkgOrderList::VisitDeps(DepFunc F,PkgIterator Pkg) | |
466 | { | |
467 | if (F == 0 || Pkg.end() == true || Cache[Pkg].InstallVer == 0) | |
468 | return true; | |
469 | ||
470 | return (this->*F)(Cache[Pkg].InstVerIter(Cache).DependsList()); | |
471 | } | |
472 | /*}}}*/ | |
473 | // OrderList::VisitRDeps - Visit reverse dependencies /*{{{*/ | |
474 | // --------------------------------------------------------------------- | |
475 | /* This calls the dependency function for all of the normal reverse depends | |
476 | of the package */ | |
477 | bool pkgOrderList::VisitRDeps(DepFunc F,PkgIterator Pkg) | |
478 | { | |
479 | if (F == 0 || Pkg.end() == true) | |
480 | return true; | |
481 | ||
482 | return (this->*F)(Pkg.RevDependsList()); | |
483 | } | |
484 | /*}}}*/ | |
485 | // OrderList::VisitRProvides - Visit provides reverse dependencies /*{{{*/ | |
486 | // --------------------------------------------------------------------- | |
487 | /* This calls the dependency function for all reverse dependencies | |
488 | generated by the provides line on the package. */ | |
489 | bool pkgOrderList::VisitRProvides(DepFunc F,VerIterator Ver) | |
490 | { | |
491 | if (F == 0 || Ver.end() == true) | |
492 | return true; | |
493 | ||
494 | bool Res = true; | |
495 | for (PrvIterator P = Ver.ProvidesList(); P.end() == false; P++) | |
496 | Res &= (this->*F)(P.ParentPkg().RevDependsList()); | |
497 | return true; | |
498 | } | |
499 | /*}}}*/ | |
500 | // OrderList::VisitProvides - Visit all of the providing packages /*{{{*/ | |
501 | // --------------------------------------------------------------------- | |
502 | /* This routine calls visit on all providing packages. */ | |
3fb5f4e4 | 503 | bool pkgOrderList::VisitProvides(DepIterator D,bool Critical) |
25be5a8f | 504 | { |
b2e465d6 | 505 | SPtrArray<Version *> List = D.AllTargets(); |
6c139d6e AL |
506 | for (Version **I = List; *I != 0; I++) |
507 | { | |
508 | VerIterator Ver(Cache,*I); | |
509 | PkgIterator Pkg = Ver.ParentPkg(); | |
25be5a8f AL |
510 | |
511 | if (Cache[Pkg].Keep() == true && Pkg.State() == PkgIterator::NeedsNothing) | |
6c139d6e AL |
512 | continue; |
513 | ||
b2e465d6 | 514 | if (D->Type != pkgCache::Dep::Conflicts && |
308c7d30 | 515 | D->Type != pkgCache::Dep::DpkgBreaks && |
b2e465d6 AL |
516 | D->Type != pkgCache::Dep::Obsoletes && |
517 | Cache[Pkg].InstallVer != *I) | |
6c139d6e AL |
518 | continue; |
519 | ||
b2e465d6 | 520 | if ((D->Type == pkgCache::Dep::Conflicts || |
308c7d30 | 521 | D->Type == pkgCache::Dep::DpkgBreaks || |
b2e465d6 AL |
522 | D->Type == pkgCache::Dep::Obsoletes) && |
523 | (Version *)Pkg.CurrentVer() != *I) | |
6c139d6e AL |
524 | continue; |
525 | ||
3fb5f4e4 | 526 | // Skip over missing files |
140fd43f | 527 | if (Critical == false && IsMissing(D.ParentPkg()) == true) |
3fb5f4e4 | 528 | continue; |
25be5a8f | 529 | |
6c139d6e | 530 | if (VisitNode(Pkg) == false) |
6c139d6e | 531 | return false; |
6c139d6e | 532 | } |
6c139d6e AL |
533 | return true; |
534 | } | |
535 | /*}}}*/ | |
536 | // OrderList::VisitNode - Recursive ordering director /*{{{*/ | |
537 | // --------------------------------------------------------------------- | |
538 | /* This is the core ordering routine. It calls the set dependency | |
539 | consideration functions which then potentialy call this again. Finite | |
540 | depth is achived through the colouring mechinism. */ | |
541 | bool pkgOrderList::VisitNode(PkgIterator Pkg) | |
542 | { | |
543 | // Looping or irrelevent. | |
e1b74f61 | 544 | // This should probably trancend not installed packages |
6c139d6e AL |
545 | if (Pkg.end() == true || IsFlag(Pkg,Added) == true || |
546 | IsFlag(Pkg,AddPending) == true || IsFlag(Pkg,InList) == false) | |
547 | return true; | |
548 | ||
b2e465d6 AL |
549 | if (Debug == true) |
550 | { | |
551 | for (int j = 0; j != Depth; j++) clog << ' '; | |
70ae2409 | 552 | clog << "Visit " << Pkg.FullName() << endl; |
b2e465d6 AL |
553 | } |
554 | ||
6c139d6e AL |
555 | Depth++; |
556 | ||
557 | // Color grey | |
558 | Flag(Pkg,AddPending); | |
559 | ||
560 | DepFunc Old = Primary; | |
561 | ||
562 | // Perform immedate configuration of the package if so flagged. | |
727f18af AL |
563 | if (IsFlag(Pkg,Immediate) == true && Primary != &pkgOrderList::DepUnPackPre) |
564 | Primary = &pkgOrderList::DepUnPackPreD; | |
281daf46 AL |
565 | |
566 | if (IsNow(Pkg) == true) | |
6c139d6e | 567 | { |
281daf46 AL |
568 | bool Res = true; |
569 | if (Cache[Pkg].Delete() == false) | |
570 | { | |
571 | // Primary | |
572 | Res &= Res && VisitDeps(Primary,Pkg); | |
573 | Res &= Res && VisitRDeps(Primary,Pkg); | |
574 | Res &= Res && VisitRProvides(Primary,Pkg.CurrentVer()); | |
575 | Res &= Res && VisitRProvides(Primary,Cache[Pkg].InstVerIter(Cache)); | |
576 | ||
577 | // RevDep | |
578 | Res &= Res && VisitRDeps(RevDepends,Pkg); | |
579 | Res &= Res && VisitRProvides(RevDepends,Pkg.CurrentVer()); | |
580 | Res &= Res && VisitRProvides(RevDepends,Cache[Pkg].InstVerIter(Cache)); | |
581 | ||
582 | // Secondary | |
583 | Res &= Res && VisitDeps(Secondary,Pkg); | |
584 | Res &= Res && VisitRDeps(Secondary,Pkg); | |
585 | Res &= Res && VisitRProvides(Secondary,Pkg.CurrentVer()); | |
586 | Res &= Res && VisitRProvides(Secondary,Cache[Pkg].InstVerIter(Cache)); | |
587 | } | |
588 | else | |
589 | { | |
590 | // RevDep | |
591 | Res &= Res && VisitRDeps(Remove,Pkg); | |
592 | Res &= Res && VisitRProvides(Remove,Pkg.CurrentVer()); | |
593 | } | |
6c139d6e | 594 | } |
281daf46 | 595 | |
6c139d6e AL |
596 | if (IsFlag(Pkg,Added) == false) |
597 | { | |
598 | Flag(Pkg,Added,Added | AddPending); | |
63d3141a AL |
599 | if (IsFlag(Pkg,After) == true) |
600 | *AfterEnd++ = Pkg; | |
601 | else | |
602 | *End++ = Pkg; | |
6c139d6e AL |
603 | } |
604 | ||
605 | Primary = Old; | |
606 | Depth--; | |
6c139d6e | 607 | |
b2e465d6 AL |
608 | if (Debug == true) |
609 | { | |
610 | for (int j = 0; j != Depth; j++) clog << ' '; | |
70ae2409 | 611 | clog << "Leave " << Pkg.FullName() << ' ' << IsFlag(Pkg,Added) << ',' << IsFlag(Pkg,AddPending) << endl; |
b2e465d6 AL |
612 | } |
613 | ||
6c139d6e AL |
614 | return true; |
615 | } | |
616 | /*}}}*/ | |
6c139d6e AL |
617 | // OrderList::DepUnPackCrit - Critical UnPacking ordering /*{{{*/ |
618 | // --------------------------------------------------------------------- | |
619 | /* Critical unpacking ordering strives to satisfy Conflicts: and | |
620 | PreDepends: only. When a prdepends is encountered the Primary | |
621 | DepFunc is changed to be DepUnPackPreD. | |
622 | ||
623 | Loops are preprocessed and logged. */ | |
624 | bool pkgOrderList::DepUnPackCrit(DepIterator D) | |
625 | { | |
626 | for (; D.end() == false; D++) | |
627 | { | |
628 | if (D.Reverse() == true) | |
629 | { | |
630 | /* Reverse depenanices are only interested in conflicts, | |
631 | predepend breakage is ignored here */ | |
b2e465d6 AL |
632 | if (D->Type != pkgCache::Dep::Conflicts && |
633 | D->Type != pkgCache::Dep::Obsoletes) | |
6c139d6e AL |
634 | continue; |
635 | ||
636 | // Duplication elimination, consider only the current version | |
637 | if (D.ParentPkg().CurrentVer() != D.ParentVer()) | |
638 | continue; | |
639 | ||
640 | /* For reverse dependencies we wish to check if the | |
641 | dependency is satisifed in the install state. The | |
642 | target package (caller) is going to be in the installed | |
643 | state. */ | |
644 | if (CheckDep(D) == true) | |
645 | continue; | |
646 | ||
647 | if (VisitNode(D.ParentPkg()) == false) | |
648 | return false; | |
649 | } | |
650 | else | |
651 | { | |
652 | /* Forward critical dependencies MUST be correct before the | |
653 | package can be unpacked. */ | |
b2e465d6 | 654 | if (D->Type != pkgCache::Dep::Conflicts && |
308c7d30 | 655 | D->Type != pkgCache::Dep::DpkgBreaks && |
b2e465d6 AL |
656 | D->Type != pkgCache::Dep::Obsoletes && |
657 | D->Type != pkgCache::Dep::PreDepends) | |
6c139d6e AL |
658 | continue; |
659 | ||
660 | /* We wish to check if the dep is okay in the now state of the | |
661 | target package against the install state of this package. */ | |
662 | if (CheckDep(D) == true) | |
663 | { | |
664 | /* We want to catch predepends loops with the code below. | |
665 | Conflicts loops that are Dep OK are ignored */ | |
666 | if (IsFlag(D.TargetPkg(),AddPending) == false || | |
667 | D->Type != pkgCache::Dep::PreDepends) | |
668 | continue; | |
669 | } | |
670 | ||
671 | // This is the loop detection | |
672 | if (IsFlag(D.TargetPkg(),Added) == true || | |
673 | IsFlag(D.TargetPkg(),AddPending) == true) | |
674 | { | |
675 | if (IsFlag(D.TargetPkg(),AddPending) == true) | |
676 | AddLoop(D); | |
677 | continue; | |
678 | } | |
679 | ||
680 | /* Predepends require a special ordering stage, they must have | |
681 | all dependents installed as well */ | |
682 | DepFunc Old = Primary; | |
683 | bool Res = false; | |
684 | if (D->Type == pkgCache::Dep::PreDepends) | |
727f18af | 685 | Primary = &pkgOrderList::DepUnPackPreD; |
3fb5f4e4 | 686 | Res = VisitProvides(D,true); |
6c139d6e AL |
687 | Primary = Old; |
688 | if (Res == false) | |
689 | return false; | |
690 | } | |
691 | } | |
692 | return true; | |
693 | } | |
92fcbfc1 | 694 | /*}}}*/ |
6c139d6e AL |
695 | // OrderList::DepUnPackPreD - Critical UnPacking ordering with depends /*{{{*/ |
696 | // --------------------------------------------------------------------- | |
697 | /* Critical PreDepends (also configure immediate and essential) strives to | |
698 | ensure not only that all conflicts+predepends are met but that this | |
92fcbfc1 | 699 | package will be immediately configurable when it is unpacked. |
6c139d6e AL |
700 | Loops are preprocessed and logged. */ |
701 | bool pkgOrderList::DepUnPackPreD(DepIterator D) | |
702 | { | |
703 | if (D.Reverse() == true) | |
704 | return DepUnPackCrit(D); | |
705 | ||
706 | for (; D.end() == false; D++) | |
707 | { | |
708 | if (D.IsCritical() == false) | |
709 | continue; | |
710 | ||
711 | /* We wish to check if the dep is okay in the now state of the | |
712 | target package against the install state of this package. */ | |
713 | if (CheckDep(D) == true) | |
714 | { | |
715 | /* We want to catch predepends loops with the code below. | |
716 | Conflicts loops that are Dep OK are ignored */ | |
717 | if (IsFlag(D.TargetPkg(),AddPending) == false || | |
718 | D->Type != pkgCache::Dep::PreDepends) | |
719 | continue; | |
720 | } | |
721 | ||
722 | // This is the loop detection | |
723 | if (IsFlag(D.TargetPkg(),Added) == true || | |
724 | IsFlag(D.TargetPkg(),AddPending) == true) | |
725 | { | |
726 | if (IsFlag(D.TargetPkg(),AddPending) == true) | |
727 | AddLoop(D); | |
728 | continue; | |
729 | } | |
730 | ||
3fb5f4e4 | 731 | if (VisitProvides(D,true) == false) |
6c139d6e AL |
732 | return false; |
733 | } | |
734 | return true; | |
735 | } | |
736 | /*}}}*/ | |
737 | // OrderList::DepUnPackPre - Critical Predepends ordering /*{{{*/ | |
738 | // --------------------------------------------------------------------- | |
739 | /* Critical PreDepends (also configure immediate and essential) strives to | |
740 | ensure not only that all conflicts+predepends are met but that this | |
741 | package will be immediately configurable when it is unpacked. | |
742 | ||
743 | Loops are preprocessed and logged. All loops will be fatal. */ | |
744 | bool pkgOrderList::DepUnPackPre(DepIterator D) | |
745 | { | |
746 | if (D.Reverse() == true) | |
747 | return true; | |
748 | ||
749 | for (; D.end() == false; D++) | |
750 | { | |
751 | /* Only consider the PreDepends or Depends. Depends are only | |
752 | considered at the lowest depth or in the case of immediate | |
753 | configure */ | |
754 | if (D->Type != pkgCache::Dep::PreDepends) | |
755 | { | |
756 | if (D->Type == pkgCache::Dep::Depends) | |
757 | { | |
758 | if (Depth == 1 && IsFlag(D.ParentPkg(),Immediate) == false) | |
759 | continue; | |
760 | } | |
761 | else | |
762 | continue; | |
763 | } | |
b2e465d6 | 764 | |
6c139d6e AL |
765 | /* We wish to check if the dep is okay in the now state of the |
766 | target package against the install state of this package. */ | |
767 | if (CheckDep(D) == true) | |
768 | { | |
769 | /* We want to catch predepends loops with the code below. | |
770 | Conflicts loops that are Dep OK are ignored */ | |
771 | if (IsFlag(D.TargetPkg(),AddPending) == false) | |
772 | continue; | |
773 | } | |
b2e465d6 | 774 | |
6c139d6e AL |
775 | // This is the loop detection |
776 | if (IsFlag(D.TargetPkg(),Added) == true || | |
777 | IsFlag(D.TargetPkg(),AddPending) == true) | |
778 | { | |
779 | if (IsFlag(D.TargetPkg(),AddPending) == true) | |
780 | AddLoop(D); | |
781 | continue; | |
782 | } | |
783 | ||
3fb5f4e4 | 784 | if (VisitProvides(D,true) == false) |
6c139d6e AL |
785 | return false; |
786 | } | |
787 | return true; | |
788 | } | |
789 | /*}}}*/ | |
790 | // OrderList::DepUnPackDep - Reverse dependency considerations /*{{{*/ | |
791 | // --------------------------------------------------------------------- | |
792 | /* Reverse dependencies are considered to determine if unpacking this | |
793 | package will break any existing dependencies. If so then those | |
794 | packages are ordered before this one so that they are in the | |
795 | UnPacked state. | |
796 | ||
797 | The forwards depends loop is designed to bring the packages dependents | |
798 | close to the package. This helps reduce deconfigure time. | |
799 | ||
800 | Loops are irrelevent to this. */ | |
801 | bool pkgOrderList::DepUnPackDep(DepIterator D) | |
802 | { | |
803 | ||
804 | for (; D.end() == false; D++) | |
805 | if (D.IsCritical() == true) | |
806 | { | |
807 | if (D.Reverse() == true) | |
808 | { | |
809 | /* Duplication prevention. We consider rev deps only on | |
810 | the current version, a not installed package | |
811 | cannot break */ | |
812 | if (D.ParentPkg()->CurrentVer == 0 || | |
813 | D.ParentPkg().CurrentVer() != D.ParentVer()) | |
814 | continue; | |
815 | ||
816 | // The dep will not break so it is irrelevent. | |
817 | if (CheckDep(D) == true) | |
818 | continue; | |
819 | ||
3fb5f4e4 AL |
820 | // Skip over missing files |
821 | if (IsMissing(D.ParentPkg()) == true) | |
822 | continue; | |
823 | ||
6c139d6e AL |
824 | if (VisitNode(D.ParentPkg()) == false) |
825 | return false; | |
826 | } | |
827 | else | |
308c7d30 | 828 | { |
6c139d6e | 829 | if (D->Type == pkgCache::Dep::Depends) |
3fb5f4e4 | 830 | if (VisitProvides(D,false) == false) |
6c139d6e | 831 | return false; |
308c7d30 IJ |
832 | |
833 | if (D->Type == pkgCache::Dep::DpkgBreaks) | |
834 | { | |
835 | if (CheckDep(D) == true) | |
836 | continue; | |
837 | ||
838 | if (VisitNode(D.TargetPkg()) == false) | |
839 | return false; | |
840 | } | |
841 | } | |
6c139d6e AL |
842 | } |
843 | return true; | |
844 | } | |
845 | /*}}}*/ | |
846 | // OrderList::DepConfigure - Configuration ordering /*{{{*/ | |
847 | // --------------------------------------------------------------------- | |
848 | /* Configuration only ordering orders by the Depends: line only. It | |
849 | orders configuration so that when a package comes to be configured it's | |
850 | dependents are configured. | |
851 | ||
852 | Loops are ingored. Depends loop entry points are chaotic. */ | |
853 | bool pkgOrderList::DepConfigure(DepIterator D) | |
854 | { | |
855 | // Never consider reverse configuration dependencies. | |
856 | if (D.Reverse() == true) | |
857 | return true; | |
858 | ||
859 | for (; D.end() == false; D++) | |
860 | if (D->Type == pkgCache::Dep::Depends) | |
3fb5f4e4 | 861 | if (VisitProvides(D,false) == false) |
6c139d6e AL |
862 | return false; |
863 | return true; | |
864 | } | |
865 | /*}}}*/ | |
866 | // OrderList::DepRemove - Removal ordering /*{{{*/ | |
867 | // --------------------------------------------------------------------- | |
868 | /* Removal visits all reverse depends. It considers if the dependency | |
869 | of the Now state version to see if it is okay with removing this | |
870 | package. This check should always fail, but is provided for symetery | |
871 | with the other critical handlers. | |
872 | ||
873 | Loops are preprocessed and logged. Removal loops can also be | |
874 | detected in the critical handler. They are characterized by an | |
875 | old version of A depending on B but the new version of A conflicting | |
876 | with B, thus either A or B must break to install. */ | |
877 | bool pkgOrderList::DepRemove(DepIterator D) | |
878 | { | |
879 | if (D.Reverse() == false) | |
880 | return true; | |
881 | for (; D.end() == false; D++) | |
882 | if (D->Type == pkgCache::Dep::Depends || D->Type == pkgCache::Dep::PreDepends) | |
883 | { | |
884 | // Duplication elimination, consider the current version only | |
885 | if (D.ParentPkg().CurrentVer() != D.ParentVer()) | |
886 | continue; | |
887 | ||
888 | /* We wish to see if the dep on the parent package is okay | |
966640d8 DK |
889 | in the removed (install) state of the target pkg. */ |
890 | bool tryFixDeps = false; | |
6c139d6e AL |
891 | if (CheckDep(D) == true) |
892 | { | |
893 | // We want to catch loops with the code below. | |
894 | if (IsFlag(D.ParentPkg(),AddPending) == false) | |
895 | continue; | |
896 | } | |
966640d8 DK |
897 | else |
898 | tryFixDeps = true; | |
6c139d6e AL |
899 | |
900 | // This is the loop detection | |
901 | if (IsFlag(D.ParentPkg(),Added) == true || | |
902 | IsFlag(D.ParentPkg(),AddPending) == true) | |
903 | { | |
904 | if (IsFlag(D.ParentPkg(),AddPending) == true) | |
905 | AddLoop(D); | |
906 | continue; | |
907 | } | |
908 | ||
966640d8 DK |
909 | if (tryFixDeps == true) |
910 | { | |
911 | for (pkgCache::DepIterator F = D.ParentPkg().CurrentVer().DependsList(); | |
912 | F.end() == false; ++F) | |
913 | { | |
914 | if (F->Type != pkgCache::Dep::Depends && F->Type != pkgCache::Dep::PreDepends) | |
915 | continue; | |
916 | // Check the Providers | |
917 | if (F.TargetPkg()->ProvidesList != 0) | |
918 | { | |
919 | pkgCache::PrvIterator Prov = F.TargetPkg().ProvidesList(); | |
920 | for (; Prov.end() == false; ++Prov) | |
921 | { | |
922 | pkgCache::PkgIterator const P = Prov.OwnerPkg(); | |
923 | if (IsFlag(P, InList) == true && | |
924 | IsFlag(P, AddPending) == true && | |
925 | IsFlag(P, Added) == false && | |
926 | Cache[P].InstallVer == 0) | |
927 | break; | |
928 | } | |
929 | if (Prov.end() == false) | |
930 | for (pkgCache::PrvIterator Prv = F.TargetPkg().ProvidesList(); | |
931 | Prv.end() == false; ++Prv) | |
932 | { | |
933 | pkgCache::PkgIterator const P = Prv.OwnerPkg(); | |
934 | if (IsFlag(P, InList) == true && | |
935 | IsFlag(P, AddPending) == false && | |
936 | Cache[P].InstallVer != 0 && | |
937 | VisitNode(P) == true) | |
938 | { | |
685625bd | 939 | Flag(P, Immediate); |
966640d8 DK |
940 | tryFixDeps = false; |
941 | break; | |
942 | } | |
943 | } | |
944 | if (tryFixDeps == false) | |
945 | break; | |
946 | } | |
947 | ||
948 | // Check for Or groups | |
949 | if ((F->CompareOp & pkgCache::Dep::Or) != pkgCache::Dep::Or) | |
950 | continue; | |
951 | // Lets see if the package is part of the Or group | |
952 | pkgCache::DepIterator S = F; | |
953 | for (; S.end() == false; ++S) | |
954 | { | |
955 | if (S.TargetPkg() == D.TargetPkg()) | |
956 | break; | |
957 | if ((S->CompareOp & pkgCache::Dep::Or) != pkgCache::Dep::Or || | |
958 | CheckDep(S)) // Or group is satisfied by another package | |
959 | for (;S.end() == false; ++S); | |
960 | } | |
961 | if (S.end() == true) | |
962 | continue; | |
963 | // skip to the end of the or group | |
964 | for (;S.end() == false && (S->CompareOp & pkgCache::Dep::Or) == pkgCache::Dep::Or; ++S); | |
965 | ++S; | |
966 | // The soon to be removed is part of the Or group | |
967 | // start again in the or group and find something which will serve as replacement | |
968 | for (; F.end() == false && F != S; ++F) | |
969 | { | |
970 | if (F.TargetPkg() == D.TargetPkg() || | |
971 | IsFlag(F.TargetPkg(), InList) == false || | |
972 | VisitNode(F.TargetPkg()) == false) | |
973 | continue; | |
685625bd | 974 | Flag(F.TargetPkg(), Immediate); |
966640d8 DK |
975 | tryFixDeps = false; |
976 | break; | |
977 | } | |
978 | if (tryFixDeps == false) | |
979 | break; | |
980 | } | |
981 | } | |
982 | ||
3fb5f4e4 AL |
983 | // Skip over missing files |
984 | if (IsMissing(D.ParentPkg()) == true) | |
985 | continue; | |
986 | ||
6c139d6e AL |
987 | if (VisitNode(D.ParentPkg()) == false) |
988 | return false; | |
989 | } | |
990 | ||
991 | return true; | |
992 | } | |
993 | /*}}}*/ | |
6c139d6e AL |
994 | // OrderList::AddLoop - Add a loop to the loop list /*{{{*/ |
995 | // --------------------------------------------------------------------- | |
996 | /* We record the loops. This is a relic since loop breaking is done | |
997 | genericaly as part of the safety routines. */ | |
998 | bool pkgOrderList::AddLoop(DepIterator D) | |
999 | { | |
1000 | if (LoopCount < 0 || LoopCount >= 20) | |
1001 | return false; | |
1002 | ||
1003 | // Skip dups | |
1004 | if (LoopCount != 0) | |
1005 | { | |
1006 | if (Loops[LoopCount - 1].ParentPkg() == D.ParentPkg() || | |
1007 | Loops[LoopCount - 1].TargetPkg() == D.ParentPkg()) | |
1008 | return true; | |
1009 | } | |
1010 | ||
1011 | Loops[LoopCount++] = D; | |
1012 | ||
1013 | // Mark the packages as being part of a loop. | |
1014 | Flag(D.TargetPkg(),Loop); | |
1015 | Flag(D.ParentPkg(),Loop); | |
1016 | return true; | |
1017 | } | |
1018 | /*}}}*/ | |
1019 | // OrderList::WipeFlags - Unset the given flags from all packages /*{{{*/ | |
1020 | // --------------------------------------------------------------------- | |
1021 | /* */ | |
1022 | void pkgOrderList::WipeFlags(unsigned long F) | |
1023 | { | |
b2e465d6 | 1024 | unsigned long Size = Cache.Head().PackageCount; |
6c139d6e AL |
1025 | for (unsigned long I = 0; I != Size; I++) |
1026 | Flags[I] &= ~F; | |
1027 | } | |
1028 | /*}}}*/ | |
1029 | // OrderList::CheckDep - Check a dependency for truth /*{{{*/ | |
1030 | // --------------------------------------------------------------------- | |
1031 | /* This performs a complete analysis of the dependency wrt to the | |
1032 | current add list. It returns true if after all events are | |
1033 | performed it is still true. This sort of routine can be approximated | |
1034 | by examining the DepCache, however in convoluted cases of provides | |
1035 | this fails to produce a suitable result. */ | |
1036 | bool pkgOrderList::CheckDep(DepIterator D) | |
1037 | { | |
b2e465d6 | 1038 | SPtrArray<Version *> List = D.AllTargets(); |
63d3141a | 1039 | bool Hit = false; |
6c139d6e AL |
1040 | for (Version **I = List; *I != 0; I++) |
1041 | { | |
1042 | VerIterator Ver(Cache,*I); | |
1043 | PkgIterator Pkg = Ver.ParentPkg(); | |
1044 | ||
1045 | /* The meaning of Added and AddPending is subtle. AddPending is | |
1046 | an indication that the package is looping. Because of the | |
1047 | way ordering works Added means the package will be unpacked | |
1048 | before this one and AddPending means after. It is therefore | |
1049 | correct to ignore AddPending in all cases, but that exposes | |
63d3141a AL |
1050 | reverse-ordering loops which should be ignored. */ |
1051 | if (IsFlag(Pkg,Added) == true || | |
6c139d6e AL |
1052 | (IsFlag(Pkg,AddPending) == true && D.Reverse() == true)) |
1053 | { | |
1054 | if (Cache[Pkg].InstallVer != *I) | |
1055 | continue; | |
1056 | } | |
1057 | else | |
1058 | if ((Version *)Pkg.CurrentVer() != *I || | |
1059 | Pkg.State() != PkgIterator::NeedsNothing) | |
1060 | continue; | |
b2e465d6 | 1061 | |
6c139d6e AL |
1062 | /* Conflicts requires that all versions are not present, depends |
1063 | just needs one */ | |
b2e465d6 | 1064 | if (D->Type != pkgCache::Dep::Conflicts && |
308c7d30 | 1065 | D->Type != pkgCache::Dep::DpkgBreaks && |
b2e465d6 | 1066 | D->Type != pkgCache::Dep::Obsoletes) |
63d3141a AL |
1067 | { |
1068 | /* Try to find something that does not have the after flag set | |
1069 | if at all possible */ | |
1070 | if (IsFlag(Pkg,After) == true) | |
1071 | { | |
1072 | Hit = true; | |
1073 | continue; | |
1074 | } | |
1075 | ||
6c139d6e | 1076 | return true; |
63d3141a | 1077 | } |
6c139d6e | 1078 | else |
63d3141a AL |
1079 | { |
1080 | if (IsFlag(Pkg,After) == true) | |
1081 | Flag(D.ParentPkg(),After); | |
1082 | ||
6c139d6e | 1083 | return false; |
63d3141a | 1084 | } |
6c139d6e | 1085 | } |
63d3141a AL |
1086 | |
1087 | // We found a hit, but it had the after flag set | |
1088 | if (Hit == true && D->Type == pkgCache::Dep::PreDepends) | |
1089 | { | |
1090 | Flag(D.ParentPkg(),After); | |
1091 | return true; | |
1092 | } | |
1093 | ||
6c139d6e AL |
1094 | /* Conflicts requires that all versions are not present, depends |
1095 | just needs one */ | |
b2e465d6 AL |
1096 | if (D->Type == pkgCache::Dep::Conflicts || |
1097 | D->Type == pkgCache::Dep::Obsoletes) | |
6c139d6e AL |
1098 | return true; |
1099 | return false; | |
1100 | } | |
1101 | /*}}}*/ |