wxWidgets.git
14 years agoNo changes, just added comments summarizing the use of style bits.
Vadim Zeitlin [Mon, 10 May 2010 21:09:50 +0000 (21:09 +0000)] 
No changes, just added comments summarizing the use of style bits.

Add comments allowing to see more clearly the styles allocation.

Please make sure to amend them if you change any style values in the future.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64278 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoDon't use wxWindow::ClearBackground() in the image sample and explain why.
Vadim Zeitlin [Mon, 10 May 2010 21:02:30 +0000 (21:02 +0000)] 
Don't use wxWindow::ClearBackground() in the image sample and explain why.

Painting on both wxPaintDC and wxClientDC simultaneously doesn't work well,
e.g. under Windows the client DC can be actually erased after we finished
painting the window contents, overwriting it.

Simply use wxDC::Clear() instead of wxWindow::ClearBackground() to avoid this
and document the danger of using ClearBackground() from EVT_PAINT handler.

Closes #10700.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64277 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoMake text printed by wxGraphicsContext shorter
Jaakko Salli [Mon, 10 May 2010 14:16:07 +0000 (14:16 +0000)] 
Make text printed by wxGraphicsContext shorter

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64274 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoUse wxGraphicsContext to draw some text and a rectangle around it (so that GetTextExt...
Jaakko Salli [Mon, 10 May 2010 14:14:35 +0000 (14:14 +0000)] 
Use wxGraphicsContext to draw some text and a rectangle around it (so that GetTextExtent() can be verified to work correctly)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64273 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoIn wxGDIPlusContext::GetTextExtent(), return more accurate text height if possible
Jaakko Salli [Mon, 10 May 2010 13:54:20 +0000 (13:54 +0000)] 
In wxGDIPlusContext::GetTextExtent(), return more accurate text height if possible

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64272 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoSet wxGraphicsContext page scale, which is required for printing to work properly
Jaakko Salli [Mon, 10 May 2010 13:52:12 +0000 (13:52 +0000)] 
Set wxGraphicsContext page scale, which is required for printing to work properly

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64271 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoReplace public wxEvtHandler::ProcessEventHere() with private TryHere().
Vadim Zeitlin [Sun, 9 May 2010 14:55:46 +0000 (14:55 +0000)] 
Replace public wxEvtHandler::ProcessEventHere() with private TryHere().

ProcessEventHere() doesn't have to be public any more now that we have
ProcessEventLocally() which is safe to call from the outside (i.e. doesn't
forget about the chained event handlers and validators).

Still keep this function because it makes the code more modular and also
because we might want to make it virtual for consistency with TryBefore() and
TryAfter() later. Also rename it to TryHere() to make the symmetry with these
functions more manifest.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64264 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoUse ProcessEventLocally() instead of ProcessEventHere() in docview code.
Vadim Zeitlin [Sun, 9 May 2010 14:55:41 +0000 (14:55 +0000)] 
Use ProcessEventLocally() instead of ProcessEventHere() in docview code.

Use wxEvtHandler::ProcessEventLocally() instead of ProcessEventHere() when
forwarding events in the docview code. This ensures that any event handlers
chained with the objects involved (document manager, document, view) will be
used.

Incidentally the old code didn't work at all as ProcessEventHere() didn't even
call TryBefore() where the (further) forwarding was implemented.

Closes #10640.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64263 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoAdd wxWindow::ProcessWindowEventLocally() and use it in wxMSW MDI code.
Vadim Zeitlin [Sun, 9 May 2010 14:55:33 +0000 (14:55 +0000)] 
Add wxWindow::ProcessWindowEventLocally() and use it in wxMSW MDI code.

Add ProcessWindowEventLocally() which wraps ProcessEventLocally() in the same
way as ProcessWindowEvent() wraps ProcessEvent(). I.e. it allows to process
the event in this window only, without propagating it upwards, but taking into
account any event handlers associated with it.

Use the new method in wxMDIParentFrame code in wxMSW to ensure that event
handlers pushed on MDI children frames are taken into account. Add a test for
this to the MDI sample.

Closes #11225.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64262 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoRefactor the event processing code to add ProcessEventLocally().
Vadim Zeitlin [Sun, 9 May 2010 14:55:28 +0000 (14:55 +0000)] 
Refactor the event processing code to add ProcessEventLocally().

This new method can be used to only process the event in this handler or any
handlers connected to it (unlike ProcessEventHere() which doesn't follow the
chain at all), without propagating the event upwards (unlike ProcessEvent()).

Unfortunately implementing this required a field to wxEvent but there doesn't
seem to be any other way to do what we need.

There should be no user-visible changes after this commit, it just paves the
way for the upcoming fixes.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64261 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoCall wxEvtHandler::TryBefore() only once from ProcessEvent().
Vadim Zeitlin [Sun, 9 May 2010 14:55:21 +0000 (14:55 +0000)] 
Call wxEvtHandler::TryBefore() only once from ProcessEvent().

The event pre-processing hooks associated with the window should be called
only once during the event processing, we don't need to call TryBefore() for
each and every event handler associated with the window too.

This makes the code slightly simpler and faster and shouldn't change the
behaviour of any existing code.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64260 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoSupress SetFocus() warning in wxVListBoxComboPopup
Jaakko Salli [Sun, 9 May 2010 10:29:48 +0000 (10:29 +0000)] 
Supress SetFocus() warning in wxVListBoxComboPopup

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64258 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoPrevent idMenuTitle from being accidentally used as invalid wx ID.
Václav Slavík [Sun, 9 May 2010 10:27:44 +0000 (10:27 +0000)] 
Prevent idMenuTitle from being accidentally used as invalid wx ID.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64257 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoWhitelist wxID_NONE as valid menu item ID.
Václav Slavík [Sun, 9 May 2010 10:27:40 +0000 (10:27 +0000)] 
Whitelist wxID_NONE as valid menu item ID.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64256 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoFixed popup menu's title to be bold regardless of method used.
Václav Slavík [Sun, 9 May 2010 10:27:35 +0000 (10:27 +0000)] 
Fixed popup menu's title to be bold regardless of method used.

Popup menus with title set via SetTitle() had bold font, but menus
created by passing title as ctor argument used normal font. Fixed this
by using the same code (SetTitle) in both cases, instead of having two
independent (and out of sync) implementations of the same functionality.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64255 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agowxMsgCatalog destructor should be public.
Václav Slavík [Sat, 8 May 2010 15:31:12 +0000 (15:31 +0000)] 
wxMsgCatalog destructor should be public.

Fixes #12031.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64248 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoFixed a test in wxTranslations::GetString() to use UINT_MAX instead of -1.
Václav Slavík [Sat, 8 May 2010 15:31:07 +0000 (15:31 +0000)] 
Fixed a test in wxTranslations::GetString() to use UINT_MAX instead of -1.

See #12031.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64247 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoInvalidate wxListBox best size immediately without waiting for idle time.
Vadim Zeitlin [Sat, 8 May 2010 10:28:01 +0000 (10:28 +0000)] 
Invalidate wxListBox best size immediately without waiting for idle time.

Since r53743 the listbox best size was only invalidated during idle time but
this meant that it could be laid out using incorrect old best size. So while
we still defer (expensive) horizontal extent calculation until later, do
invalidate the best size immediately to ensure the listbox is laid out
correctly.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64246 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoFix crash in wxCommandProcessor of capacity N when N-1 commands were undone.
Vadim Zeitlin [Fri, 7 May 2010 23:38:31 +0000 (23:38 +0000)] 
Fix crash in wxCommandProcessor of capacity N when N-1 commands were undone.

Performing N commands (where N is the maximal number of commands stored by
wxCommandProcessor), undoing N-1 of them and performing another command
resulted in a crash because a dangling pointer was left.

Closes #12027.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64245 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoFix assert during separator items creation introduced by r64226.
Vadim Zeitlin [Fri, 7 May 2010 23:38:26 +0000 (23:38 +0000)] 
Fix assert during separator items creation introduced by r64226.

Add separators with correct kind, setting m_kind doesn't work any more because
it's overwritten below.

Also add a comment explaining why is overriding the user-specified kind the
right thing to do here.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64244 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoFix bugs related to two phase creation of wxRibbon classes.
Vadim Zeitlin [Fri, 7 May 2010 23:38:21 +0000 (23:38 +0000)] 
Fix bugs related to two phase creation of wxRibbon classes.

Add missing wxRibbonControl::Create() method. Ensure that member variables are
always initialized by the ctor. Check that we're fully initialized in EVT_SIZE
handler.

Closes #12018.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64243 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoUpdating setup for OpenVMS
Jouk Jansen [Fri, 7 May 2010 13:38:53 +0000 (13:38 +0000)] 
Updating setup for OpenVMS

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64241 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoIntegrate with GNOME's Recent Documents menu.
Václav Slavík [Fri, 7 May 2010 06:45:48 +0000 (06:45 +0000)] 
Integrate with GNOME's Recent Documents menu.

GTK+ provides GtkRecentManager for this purpose since 2.10. Use it in
wxFileHistory if available. Integration is simple, we just add a file to
GtkRecentManager in addition to normal wxFileHistory handling.

A well-behaved GNOME application would use GtkRecentManager as the
primary store for recent files, so that it reflects when the user works
with supported files in another editor(s) too. But for now, this is much
better than no support at all.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64240 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoClarify that wxFileSystem::OpenFile() takes URL, not filename.
Václav Slavík [Thu, 6 May 2010 18:28:31 +0000 (18:28 +0000)] 
Clarify that wxFileSystem::OpenFile() takes URL, not filename.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64239 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoChange wxPGProperty::SetChoices() to accept 'const wxPGChoices&'
Jaakko Salli [Thu, 6 May 2010 17:42:26 +0000 (17:42 +0000)] 
Change wxPGProperty::SetChoices() to accept 'const wxPGChoices&'

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64232 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoModify float/double wxAny testing to use CPPUNIT_ASSERT_EQUAL() instead of CPPUNIT_AS...
Jaakko Salli [Thu, 6 May 2010 17:21:50 +0000 (17:21 +0000)] 
Modify float/double wxAny testing to use CPPUNIT_ASSERT_EQUAL() instead of CPPUNIT_ASSERT_DOUBLES_EQUAL(), so that we know the retrieved values are truly identical.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64231 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoDon't accept focus in the dummy main generic spin control window.
Vadim Zeitlin [Thu, 6 May 2010 12:58:36 +0000 (12:58 +0000)] 
Don't accept focus in the dummy main generic spin control window.

This window is only used as a container for the sub-windows and shouldn't
accept focus, trying to set it to it doesn't work anyhow (see #12004).

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64230 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoDon't send wxEVT_COMMAND_SPINCTRLDOUBLE_UPDATED when nothing changed.
Vadim Zeitlin [Thu, 6 May 2010 12:58:32 +0000 (12:58 +0000)] 
Don't send wxEVT_COMMAND_SPINCTRLDOUBLE_UPDATED when nothing changed.

The generic double spin control sent UPDATED events whenever it lost focus,
whether anything changed or not.

Don't send events unless the controls value has really changed.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64229 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoAlways update the value of generic spin control when leaving it.
Vadim Zeitlin [Thu, 6 May 2010 12:58:27 +0000 (12:58 +0000)] 
Always update the value of generic spin control when leaving it.

We could be left with an invalid value in the control when leaving it. E.g. in
the widgets sample whose double spin control has range from 0 to 10, 123 could
be entered in it and was not replaced by 10 when the control lost focus. This
happened because the code didn't bother to update the text control if its
contents already corresponded to the internally stored value -- but this was
wrong as it could have a different representation.

Just always update the text unconditionally when synchronizing it with the
internal value.

See #12004.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64228 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoMake keyboard navigation in generic wxTreeCtrl more Mac-like under OS X.
Vadim Zeitlin [Thu, 6 May 2010 12:58:22 +0000 (12:58 +0000)] 
Make keyboard navigation in generic wxTreeCtrl more Mac-like under OS X.

In the native OS X tree control right cursor arrow expands the current item
and the left one collapses it if it's expanded, make the generic control work
like this too under Mac.

Closes #12019.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64227 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoCheck that menu ids are limited to MSW-supported range.
Vadim Zeitlin [Thu, 6 May 2010 12:40:18 +0000 (12:40 +0000)] 
Check that menu ids are limited to MSW-supported range.

We already check that positive (i.e. specified by user and not generated by
wx) window ids are in 0..SHRT_MAX range. Now do the same for the menu ids as
ids outside of this range suffer from the same problem under MSW: they get
wrapped and become negative when we receive events for them.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64226 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoAdded wxLANGUAGE_BOSNIAN.
Vadim Zeitlin [Thu, 6 May 2010 12:40:11 +0000 (12:40 +0000)] 
Added wxLANGUAGE_BOSNIAN.

Closes #12016.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64225 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoMention that hatched pens don't work under wxGTK and wxX11.
Vadim Zeitlin [Thu, 6 May 2010 12:22:57 +0000 (12:22 +0000)] 
Mention that hatched pens don't work under wxGTK and wxX11.

See #11983.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64224 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoRefactor wxTranslationsLoader API.
Václav Slavík [Thu, 6 May 2010 12:12:53 +0000 (12:12 +0000)] 
Refactor wxTranslationsLoader API.

Instead of calling back into wxTranslations to actually load the data,
return wxMsgCatalog instance from
wxTranslationsLoader::LoadCatalog(). This requires making wxMsgCatalog
public.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64223 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoMove wxScopedPtr::reset() implementation to wxDEFINE_SCOPED_PTR.
Václav Slavík [Thu, 6 May 2010 05:43:01 +0000 (05:43 +0000)] 
Move wxScopedPtr::reset() implementation to wxDEFINE_SCOPED_PTR.

Just as the destructor, reset() calls delete on T pointer and so can
only be defined when T is fully defined.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64222 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoUse wxCHECKED_DELETE in wxScopedPtr::reset().
Václav Slavík [Thu, 6 May 2010 05:42:57 +0000 (05:42 +0000)] 
Use wxCHECKED_DELETE in wxScopedPtr::reset().

It was only used in delete call in destructor, but the use in  reset()
needs safeguards as well.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64221 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoUse wxCHECKED_DELETE in wxScopedPtr<T>.
Václav Slavík [Thu, 6 May 2010 05:42:52 +0000 (05:42 +0000)] 
Use wxCHECKED_DELETE in wxScopedPtr<T>.

It was only used in macros-based implementation, use it in the template
version too.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64220 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoFix PCH-less compilation after recent changes.
Vadim Zeitlin [Wed, 5 May 2010 13:53:40 +0000 (13:53 +0000)] 
Fix PCH-less compilation after recent changes.

Include wx/sizer.h explicitly when not using PCH.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64219 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoFix incorrect assumptions about locales codes.
Václav Slavík [Wed, 5 May 2010 13:50:15 +0000 (13:50 +0000)] 
Fix incorrect assumptions about locales codes.

wx incorrectly assumes that Unix locale codes have the form of xx_YY,
where both xx and yy are two characters long. This is wrong, xx is
ISO 639 code, which can often have 3 characters ("ast", "gez" etc.);
future ISO 639-6 will have up to 4 chars. Similarly, ISO 3166 has
alpha-3 variant of country codes too (even though they aren't used in
this context today).

For parsing needs, we can just look for '_' in the code. The only place
where a check for xx_YY code was performed was GetSystemLanguage().
Instead of bothering with correct check (or a heuristic), let's simply
assume locale is xx_YY code and only do alternative handling if that
assumption fails. According to the comments, this alternative handling
was for cases such as LANG=german environment on SuSE, but it's safe to
say that no modern systems do that anymore, so it's OK that this patch
is marginally less efficient on such legacy systems.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64218 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoNo changes, just make wxDataViewEditorCtrlEvtHandler private.
Vadim Zeitlin [Wed, 5 May 2010 12:45:14 +0000 (12:45 +0000)] 
No changes, just make wxDataViewEditorCtrlEvtHandler private.

This class is used by wxDataViewCtrl implementation only, there is no need for
it to be in a public header.

Move the class declaration from wx/dataview.h to datavcmn.cpp.

See #11732.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64217 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoPop event handler from wxDVC edit control before destroying it.
Vadim Zeitlin [Wed, 5 May 2010 12:45:09 +0000 (12:45 +0000)] 
Pop event handler from wxDVC edit control before destroying it.

This fixes the assert in wxWindow dtor checking that all event handlers pushed
on the window were removed.

Also fix a memory leak by not creating an unnecessary object of wxKillRef
class. In fact remove this class entirely.

Closes #11732.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64216 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoDon't use size_t for plural forms parameter.
Václav Slavík [Wed, 5 May 2010 12:27:07 +0000 (12:27 +0000)] 
Don't use size_t for plural forms parameter.

size_t should be used for size of objects, which wxGetTranslation() and
wxTranslations::GetString() 'n' argument isn't -- it's just a regular
integer.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64215 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoNotify user less intrusively about overflow when previewing HTML printouts.
Vadim Zeitlin [Wed, 5 May 2010 12:20:15 +0000 (12:20 +0000)] 
Notify user less intrusively about overflow when previewing HTML printouts.

We used to show a modal dialog if the page didn't fit horizontally but this
was too intrusive when the user was just previewing the output and not really
printing it. Moreover, the question of the message box ("Print" or "Cancel")
simply didn't make sense in this case.

Fix both problems by not showing this dialog at all when previewing. Instead,
notify the user with a much less intrusive info bar in the preview window.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64214 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoMove wxInfoBar to core library from adv.
Vadim Zeitlin [Wed, 5 May 2010 12:20:08 +0000 (12:20 +0000)] 
Move wxInfoBar to core library from adv.

This is necessary in order to be able to use it in the print preview (an
upcoming change).

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64213 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoReplace wxPrintout::SetIsPreview() with SetPreview().
Vadim Zeitlin [Wed, 5 May 2010 12:19:59 +0000 (12:19 +0000)] 
Replace wxPrintout::SetIsPreview() with SetPreview().

Unlike the old function just indicating whether a printout is being used for
previewing, the new one associates the preview object with it. This can be
useful if we need to access the window used for the preview, for example.

Also remove a bunch of apparently unnecessary SetIsPreview(false) calls as
printing (and not previewing) is already the default.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64212 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoNo real changes, just clean up wxAbortProc mess.
Vadim Zeitlin [Wed, 5 May 2010 12:19:53 +0000 (12:19 +0000)] 
No real changes, just clean up wxAbortProc mess.

Remove m_lpAbortProc which is not needed at all and just requires ugly casts
because its type was different from the real type of wxAbortProc.

Get rid of the rest of the old Win16 code.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64211 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoRemove GtkPrintOperation preview signal handler.
Vadim Zeitlin [Wed, 5 May 2010 12:19:44 +0000 (12:19 +0000)] 
Remove GtkPrintOperation preview signal handler.

This handler wasn't doing anything useful as we were always using the default
preview based on an external program, so just remove it completely.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64210 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoFix wxScopedCharTypeBuffer<T>::CreateOwned() to match docs.
Václav Slavík [Wed, 5 May 2010 07:45:33 +0000 (07:45 +0000)] 
Fix wxScopedCharTypeBuffer<T>::CreateOwned() to match docs.

The documentation says that it takes ownership of the memory block
passed to it, but the implementation made a copy.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64209 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoIgnore time component of SYSTEMTIME in wxCalendarCtrl.
Vadim Zeitlin [Tue, 4 May 2010 21:59:17 +0000 (21:59 +0000)] 
Ignore time component of SYSTEMTIME in wxCalendarCtrl.

Native month calendar functions doesn't always return correct values in the
time part of SYSTEMTIME so ignore it and use just the date component.

To simplify doing it, add helper (MSW-specific) SetFromMSWSysDate() and
GetAsMSWSysDate() functions which convert between wxDateTime and SYSTEMTIME
but take only date component into account.

This commit partially replaces changes of r63560 and closes #11276.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64208 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoFixed a typo in misc/languages/README.
Václav Slavík [Tue, 4 May 2010 16:38:56 +0000 (16:38 +0000)] 
Fixed a typo in misc/languages/README.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64207 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoMove wxFileHistory out of docview framework, add wxUSE_FILE_HISTORY.
Václav Slavík [Tue, 4 May 2010 12:15:14 +0000 (12:15 +0000)] 
Move wxFileHistory out of docview framework, add wxUSE_FILE_HISTORY.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64205 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoUse wxString::ToCDouble() instead of emulating it.
Vadim Zeitlin [Mon, 3 May 2010 11:19:42 +0000 (11:19 +0000)] 
Use wxString::ToCDouble() instead of emulating it.

No real changes, just replace the code which was working around the absence of
a wxString::ToCDouble() with the call to the real thing now that we have it.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64204 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoUpdate OpenVMS compile support
Jouk Jansen [Mon, 3 May 2010 08:02:02 +0000 (08:02 +0000)] 
Update OpenVMS compile support

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64203 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoFix PCH-less build after changes r64139.
Vadim Zeitlin [Sun, 2 May 2010 12:19:19 +0000 (12:19 +0000)] 
Fix PCH-less build after changes r64139.

As wx/log.h is not included from wx/dynlib.h (via wx/msw/private.h) any
longer, include it from here explicitly.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64202 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoInclude <windows.h> before including <shellapi.h>.
Vadim Zeitlin [Sun, 2 May 2010 12:19:14 +0000 (12:19 +0000)] 
Include <windows.h> before including <shellapi.h>.

Although this is not needed with most compilers (including recent MinGW),
including <shellapi.h> directly apparently doesn't work with some older MinGW
versions.

This fixes compilation after the changes of r64139.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64201 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoAdd wxTreeCtrl::{Clear,Set}FocusedItem().
Vadim Zeitlin [Sun, 2 May 2010 12:01:30 +0000 (12:01 +0000)] 
Add wxTreeCtrl::{Clear,Set}FocusedItem().

Allow changing just the currently focused (not selected) item and also
removing the focus completely.

Closes #11599.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64196 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoSpell contributor name correctly.
Vadim Zeitlin [Sun, 2 May 2010 11:48:39 +0000 (11:48 +0000)] 
Spell contributor name correctly.

Use the spelling preferred by Nikolay himself, see #11599.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64195 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoupdated headers
Stefan Csomor [Fri, 30 Apr 2010 18:29:43 +0000 (18:29 +0000)] 
updated headers

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64187 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agotextctrl impl
Stefan Csomor [Fri, 30 Apr 2010 18:29:17 +0000 (18:29 +0000)] 
textctrl impl

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64186 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoadding wrapper for native UIWindow, using designated initializer for view controller
Stefan Csomor [Fri, 30 Apr 2010 16:55:33 +0000 (16:55 +0000)] 
adding wrapper for native UIWindow, using designated initializer for view controller

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64185 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoadjusting to API change of cocoa and carbon
Stefan Csomor [Fri, 30 Apr 2010 16:53:33 +0000 (16:53 +0000)] 
adjusting to API change of cocoa and carbon

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64184 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agocleanup
Stefan Csomor [Fri, 30 Apr 2010 16:52:43 +0000 (16:52 +0000)] 
cleanup

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64183 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoCheck in samples/dll for WXUSINGDLL.
Václav Slavík [Fri, 30 Apr 2010 16:46:22 +0000 (16:46 +0000)] 
Check in samples/dll for WXUSINGDLL.

If it is set and DLL build of wx is used, emit an error, as the sample
won't work correctly in that case.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64182 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agomoving value setting conformance to impl
Stefan Csomor [Fri, 30 Apr 2010 16:40:44 +0000 (16:40 +0000)] 
moving value setting conformance to impl

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64181 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoiphone implementations
Stefan Csomor [Fri, 30 Apr 2010 16:31:27 +0000 (16:31 +0000)] 
iphone implementations

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64180 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoUse scoped ptrs to managed wxAnyValueType instances. This fixes deallocation issues...
Jaakko Salli [Fri, 30 Apr 2010 13:32:41 +0000 (13:32 +0000)] 
Use scoped ptrs to managed wxAnyValueType instances. This fixes deallocation issues in some dynamic library use cases.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64179 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoadding uifont support
Stefan Csomor [Fri, 30 Apr 2010 09:29:36 +0000 (09:29 +0000)] 
adding uifont support

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64178 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoAlways use active wxTranslations instance via wxLocale.
Václav Slavík [Thu, 29 Apr 2010 08:31:42 +0000 (08:31 +0000)] 
Always use active wxTranslations instance via wxLocale.

Don't use m_translations directly, if the user made changes to
wxTranslations instance, it would be too confusing if calls through
wxLocale compat API did nothing.

Also don't change active wxTranslations object from wxLocale if already
done by user, only call wxTranslations::Set() from wxLocale constructor
if it wasn't already set by the user. Still do if wxTranslations
instance currently in use was set by previous wxLocale on the locale
stack.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64165 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agowxRTC: fixed style selection reset after editing a style.
Julian Smart [Tue, 27 Apr 2010 16:09:22 +0000 (16:09 +0000)] 
wxRTC: fixed style selection reset after editing a style.
wxRTC: can now edit line spacing in .1 increments from 1 to 2.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64161 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoFont output fix
Julian Smart [Tue, 27 Apr 2010 16:07:38 +0000 (16:07 +0000)] 
Font output fix

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64160 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoSafeguard against redundant registration of the same wxAnyValueType instance (by...
Jaakko Salli [Tue, 27 Apr 2010 13:26:45 +0000 (13:26 +0000)] 
Safeguard against redundant registration of the same wxAnyValueType instance (by storing pointers in a set instead of a vector)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64159 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoUse '+' in accelerators, not '-'.
Václav Slavík [Tue, 27 Apr 2010 09:38:17 +0000 (09:38 +0000)] 
Use '+' in accelerators, not '-'.

This was always GTK+ standard and even Windows uses it now, see the
UX Guide.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64157 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoAdd support for storing translations in win32 resources.
Václav Slavík [Mon, 26 Apr 2010 20:51:22 +0000 (20:51 +0000)] 
Add support for storing translations in win32 resources.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64155 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoShorten lang names in wxTranslations, not wxFileTranslationsLoader.
Václav Slavík [Mon, 26 Apr 2010 20:51:16 +0000 (20:51 +0000)] 
Shorten lang names in wxTranslations, not wxFileTranslationsLoader.

If a catalog with full language name ("fr_BE") doesn't exist,
wxFileTranslationsLoader tries to look for just the base language ("fr")
too. This isn't something specific to wxFileTranslationsLoader, it makes
sense to do it regardless of the loader.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64154 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoAdd wxMemoryBuffer::release().
Václav Slavík [Mon, 26 Apr 2010 20:51:07 +0000 (20:51 +0000)] 
Add wxMemoryBuffer::release().

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64153 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoAdd instance argument to wxLoadUserResource().
Václav Slavík [Mon, 26 Apr 2010 20:51:02 +0000 (20:51 +0000)] 
Add instance argument to wxLoadUserResource().

This makes it possible to load resources from other modules than the
main executable.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64152 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoMake wxLoadUserResource() declaration available to wxBase too.
Václav Slavík [Mon, 26 Apr 2010 20:50:57 +0000 (20:50 +0000)] 
Make wxLoadUserResource() declaration available to wxBase too.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64151 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoAdd wxLoadUserResource() overload not copying the resource data.
Vadim Zeitlin [Mon, 26 Apr 2010 16:53:21 +0000 (16:53 +0000)] 
Add wxLoadUserResource() overload not copying the resource data.

The existing wxLoadUserResource() copies the resource data which is often
unnecessary. Add another overload which just returns the pointer directly to
the resource data.

Also move the function into base from core as it can be useful for the console
applications as well.

Finally, define wxUserResourceStr used by this function only in the same file
where the function itself is defined instead of datacmn.cpp.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64150 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoRemove a harmless unused parameter warning in wxOSX/Carbon.
Vadim Zeitlin [Mon, 26 Apr 2010 16:23:42 +0000 (16:23 +0000)] 
Remove a harmless unused parameter warning in wxOSX/Carbon.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64147 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoFix wxGTK1 event loop definition mismatch between base/GUI.
Vadim Zeitlin [Mon, 26 Apr 2010 14:19:31 +0000 (14:19 +0000)] 
Fix wxGTK1 event loop definition mismatch between base/GUI.

We must define wxEventLoopBase in the same way in base and GUI code,
otherwise, even though we fool the compiler into accepting our code, it
crashes or behaves otherwise weirdly during run-time because of vtbl mismatch.

This fixes wxGTK1 which was crashing on startup since the FSWATCHER branch
merge in r62474 and associated changes to support the event loop sources.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64146 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoUse wxMenuBar::Attach/Detach() instead of SetInvokingWindow() in wxGTK1.
Vadim Zeitlin [Mon, 26 Apr 2010 14:19:26 +0000 (14:19 +0000)] 
Use wxMenuBar::Attach/Detach() instead of SetInvokingWindow() in wxGTK1.

This is the same as r64127 for wxGTK.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64145 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoFix wxGTK1 link after toolbar files renaming.
Vadim Zeitlin [Mon, 26 Apr 2010 14:19:22 +0000 (14:19 +0000)] 
Fix wxGTK1 link after toolbar files renaming.

Fix a typo in r62849: tooltip.cpp was used instead of toolbar.cpp resulting in
linking errors for the duplicate symbols in the former and undefined symbols
in the latter.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64144 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoSet popup menu invoking window in wxWindowBase and not in all ports.
Vadim Zeitlin [Mon, 26 Apr 2010 14:19:17 +0000 (14:19 +0000)] 
Set popup menu invoking window in wxWindowBase and not in all ports.

Don't duplicate the code for setting (and unsetting, which was forgotten by at
least wxGTK) the popup menu invoking window in all ports but do it in the base
class PopupMenu() itself.

Also add a helper wxMenuInvokingWindowSetter class which ensures that the
invoking window will be unset in any case.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64143 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoDon't set invoking window recursively in wxGTK wxWindow::PopupMenu().
Vadim Zeitlin [Mon, 26 Apr 2010 14:19:10 +0000 (14:19 +0000)] 
Don't set invoking window recursively in wxGTK wxWindow::PopupMenu().

Setting the invoking window for all submenus is unnecessary as
wxMenu::GetWindow() recurses upwards anyhow and results in assert failures
after recent menu code changes.

Simply don't do this.

OTOH do reset the invoking window to NULL after the menu is dismissed to avoid
storing a dangling pointer in the menu.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64142 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agono real change: just fix RCS-ID so that it reflects the current revision number
Francesco Montorsi [Sun, 25 Apr 2010 21:33:16 +0000 (21:33 +0000)] 
no real change: just fix RCS-ID so that it reflects the current revision number

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64140 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoDon't include wx/msw/private.h from dynlib.h.
Václav Slavík [Sun, 25 Apr 2010 12:07:37 +0000 (12:07 +0000)] 
Don't include wx/msw/private.h from dynlib.h.

Because it's private header and introduces dependency on window.h.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64139 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoDeclare various WXH* handles compatibly with SDK.
Václav Slavík [Sun, 25 Apr 2010 12:07:30 +0000 (12:07 +0000)] 
Declare various WXH* handles compatibly with SDK.

It is no longer necessary to cast between e.g. HINSTANCE and
WXHINSTANCE, they are now declared as the same type (without including
Windows SDK header).

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64138 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoRemove unnecessary duplicate code dealing with invoking window from wxOSX.
Vadim Zeitlin [Sat, 24 Apr 2010 20:39:44 +0000 (20:39 +0000)] 
Remove unnecessary duplicate code dealing with invoking window from wxOSX.

This is roughly the same as r64127 for wxGTK but for wxOSX: don't duplicate
the functionality already present in the base class in Mac-specific way. Just
use wxMenu::GetWindow() instead of painstakingly propagating invoking window
changes via the entire menu hierarchy.

Also attach the root menu used in wxOSX to the menu bar to ensure that the
correct window can be found for all its menus.

Closes #11990.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64136 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoRecurse upwards the menu hierarchy in wxMenu::GetWindow().
Vadim Zeitlin [Sat, 24 Apr 2010 20:39:39 +0000 (20:39 +0000)] 
Recurse upwards the menu hierarchy in wxMenu::GetWindow().

Only the top level menus have non-NULL wxMenuBar pointer too, so recurse
upwards the menu hierarchy in GetWindow() and not (just) GetInvokingWindow().

This fixes event processing for submenus broken by the recent changes.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64135 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoDisable ImageTestCase::LoadFromFile() on build slaves.
Vadim Zeitlin [Sat, 24 Apr 2010 17:52:27 +0000 (17:52 +0000)] 
Disable ImageTestCase::LoadFromFile() on build slaves.

This test case keeps failing erratically resulting in too many bogus build
breakage notifications. Disable it until someone has time to fix it properly.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64134 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoA slightly better compilation fix after PCH-less build breakage in r64126.
Vadim Zeitlin [Sat, 24 Apr 2010 16:59:09 +0000 (16:59 +0000)] 
A slightly better compilation fix after PCH-less build breakage in r64126.

Include wx/frame.h header instead of casting wxFrame to wxWindow using C style
cast. Although this does work now and probably will work later too it seems
better to not use the cast nevertheless.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64130 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoAdded missing @since tags to wxTranslationsLoader classes.
Václav Slavík [Sat, 24 Apr 2010 16:10:30 +0000 (16:10 +0000)] 
Added missing @since tags to wxTranslationsLoader classes.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64129 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agonon-pch build fix
Paul Cornett [Sat, 24 Apr 2010 14:40:58 +0000 (14:40 +0000)] 
non-pch build fix

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64128 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoDon't use invoking window in wxGTK wxMenuBar implementation.
Vadim Zeitlin [Sat, 24 Apr 2010 15:08:00 +0000 (15:08 +0000)] 
Don't use invoking window in wxGTK wxMenuBar implementation.

wxGTK wxMenuBar used its own SetInvokingWindow/UnsetInvokingWindow() and
related functions instead of reusing the base class Attach/Detach() which
exist for exactly the same purpose. This resulted in unnecessary code
duplication and confusion and, since the changes of r64104, resulted in
asserts due to use of SetInvokingWindow() for non-popup menus.

Fix this by removing the wxGTK-specific functions and doing the work they used
to do in (now overridden) Attach() and Detach(). Also call Attach/Detach()
instead of these functions from wxGTK wxFrame and wxMDIParentFrame code.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64127 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoUse wxMenu::GetWindow() instead of GetInvokingWindow() in SendEvent().
Vadim Zeitlin [Sat, 24 Apr 2010 15:07:55 +0000 (15:07 +0000)] 
Use wxMenu::GetWindow() instead of GetInvokingWindow() in SendEvent().

This simplifies the code as we don't need to walk the menu hierarchy upwards
any more (GetInvokingWindow() does it now) and also makes it work for all
menus, not just the popup ones.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64126 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoAvoid code duplication in wxGTK menu events generation code.
Vadim Zeitlin [Sat, 24 Apr 2010 15:07:51 +0000 (15:07 +0000)] 
Avoid code duplication in wxGTK menu events generation code.

Reuse the existing DoCommonMenuCallbackCode() function instead of duplicating
its code in menuitem_select() and menuitem_deselect() GTK callbacks.

No changes in behaviour.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64125 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoNo real changes, just remove empty wxMenuBar dtor in wxGTK.
Vadim Zeitlin [Sat, 24 Apr 2010 15:07:47 +0000 (15:07 +0000)] 
No real changes, just remove empty wxMenuBar dtor in wxGTK.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64124 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoMove wxMSW wxMenu::GetWindow() down to wxMenuBase.
Vadim Zeitlin [Sat, 24 Apr 2010 15:07:39 +0000 (15:07 +0000)] 
Move wxMSW wxMenu::GetWindow() down to wxMenuBase.

GetInvokingWindow() can only be used for the popup menus which have the
invoking window, so add a new function which can be used to get the window
associated with any kind of menu in all ports -- it already existed in wxMSW
but is needed elsewhere too.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64123 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoAllow wxPGProperty::Hide() to be called on unattached property (see #11987)
Jaakko Salli [Sat, 24 Apr 2010 10:13:22 +0000 (10:13 +0000)] 
Allow wxPGProperty::Hide() to be called on unattached property (see #11987)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64121 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

14 years agoIn wxPropertyGrid::DoPropertyChanged(), call GetEditorControl() as late as possible...
Jaakko Salli [Sat, 24 Apr 2010 10:02:25 +0000 (10:02 +0000)] 
In wxPropertyGrid::DoPropertyChanged(), call GetEditorControl() as late as possible so that editor can be changed in wxPGProperty::OnSetValue() (fixes #11987)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64120 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775