wxWidgets.git
11 years agoHandle accelerators earlier in keyboard processing code in wxGTK.
Vadim Zeitlin [Mon, 23 Jul 2012 15:03:21 +0000 (15:03 +0000)] 
Handle accelerators earlier in keyboard processing code in wxGTK.

Translate key presses to accelerators before sending wxEVT_KEY_DOWN.
Also check for accelerators even for the key combinations handled by IM,
normally IM should take precedence but IM seems to intercept common keys such
as Shift+anything which it makes sense to use as accelerators.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72176 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoUse wxGTK platform-specific files in wxAdv under OS X.
Vadim Zeitlin [Mon, 23 Jul 2012 15:03:15 +0000 (15:03 +0000)] 
Use wxGTK platform-specific files in wxAdv under OS X.

Closes #14501.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72175 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix assert in webview sample when viewing pages without a title.
Vadim Zeitlin [Mon, 23 Jul 2012 15:03:09 +0000 (15:03 +0000)] 
Fix assert in webview sample when viewing pages without a title.

Trying to append a menu item with empty label resulted in an assert (at least
under wxGTK but probably elsewhere too), and in any case wasn't very useful,
so use "(untitled)" instead in this case.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72174 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix crash on wxWebViewWebKit window destruction.
Vadim Zeitlin [Mon, 23 Jul 2012 15:03:05 +0000 (15:03 +0000)] 
Fix crash on wxWebViewWebKit window destruction.

We were getting crashes due to using methods of already half-destroyed object
when wxWebView window was destroyed in wxGTK, with the following abbreviated
stack:

 #0  wxgtk_webview_webkit_load_status (widget=0x12eb380, webKitCtrl=0x13ee040) at src/gtk/webview_webkit.cpp:38
...
 #8  0x00007ffff05ca281 in dispatchDidFailLoad (error=..., this=0x7fffe32db900) at ../Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1054
 #9  WebKit::FrameLoaderClient::dispatchDidFailLoad (this=0x7fffe32db900, error=...) at ../Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1049
 #10 0x00007ffff0b0de54 in WebCore::FrameLoader::checkLoadCompleteForThisFrame (this=0x7fffe3221b70) at ../Source/WebCore/loader/FrameLoader.cpp:2128
 #11 0x00007ffff0b0cfde in WebCore::FrameLoader::checkLoadComplete (this=<optimized out>) at ../Source/WebCore/loader/FrameLoader.cpp:2370
 #12 0x00007ffff0b0a3b2 in WebCore::FrameLoader::receivedMainResourceError (this=0x7fffe3221b70, error=..., isComplete=true) at ../Source/WebCore/loader/FrameLoader.cpp:2640
 #13 0x00007ffff0b423b7 in cancel (error=..., this=0x7fffe3279680) at ../Source/WebCore/loader/ResourceLoader.cpp:399
 #14 WebCore::ResourceLoader::cancel (this=0x7fffe3279680, error=...) at ../Source/WebCore/loader/ResourceLoader.cpp:353
 #15 0x00007ffff0b420c0 in WebCore::ResourceLoader::cancel (this=<optimized out>) at ../Source/WebCore/loader/ResourceLoader.cpp:350
 #16 0x00007ffff0afda9e in WebCore::DocumentLoader::stopLoading (this=0x7fffa081d800) at ../Source/WebCore/loader/DocumentLoader.cpp:258
 #17 0x00007ffff0b09561 in stopAllLoaders (clearProvisionalItemPolicy=WebCore::ShouldClearProvisionalItem, this=0x7fffe3221b70) at ../Source/WebCore/loader/FrameLoader.cpp:1523
 #18 WebCore::FrameLoader::stopAllLoaders (this=0x7fffe3221b70, clearProvisionalItemPolicy=WebCore::ShouldClearProvisionalItem) at ../Source/WebCore/loader/FrameLoader.cpp:1501
 #19 0x00007ffff0b0d17a in WebCore::FrameLoader::stopForUserCancel (this=0x7fffe3221b70, deferCheckLoadComplete=false) at ../Source/WebCore/loader/FrameLoader.cpp:1541
 #20 0x00007ffff05f3a36 in webkit_web_view_dispose (object=0x12eb380) at ../Source/WebKit/gtk/webkit/webkitwebview.cpp:1327
 #21 0x00007ffff27ff7a0 in g_object_run_dispose (object=0x12eb380) at /tmp/buildd/glib2.0-2.32.3/./gobject/gobject.c:1061
 #22 0x00007ffff4476c1e in gtk_scrolled_window_forall (container=0x7fff9c007d10, include_internals=0, callback=0x7ffff452cd20 <IA__gtk_widget_destroy>, callback_data=0x0)
     at /tmp/buildd/gtk+2.0-2.24.10/gtk/gtkscrolledwindow.c:1085
 #23 0x00007ffff439872f in gtk_container_destroy (object=0x7fff9c007d10) at /tmp/buildd/gtk+2.0-2.24.10/gtk/gtkcontainer.c:1073
...
 #28 0x00007ffff443cd60 in gtk_object_dispose (gobject=0x7fff9c007d10) at /tmp/buildd/gtk+2.0-2.24.10/gtk/gtkobject.c:421
 #29 0x00007ffff27ff7a0 in g_object_run_dispose (object=0x7fff9c007d10) at /tmp/buildd/glib2.0-2.32.3/./gobject/gobject.c:1061
 #30 0x00007ffff6cb65ac in wxWindow::~wxWindow (this=0x13ee040, __in_chrg=<optimized out>) at src/gtk/window.cpp:2367
 #31 0x00007ffff6d71241 in wxControlBase::~wxControlBase (this=0x13ee040, __in_chrg=<optimized out>) at src/common/ctrlcmn.cpp:49
 #32 0x00000000005cf761 in wxControl::~wxControl (this=0x13ee040, __in_chrg=<optimized out>) at include/wx/gtk/control.h:27
 #33 0x00007ffff7bd1eae in wxWebView::~wxWebView (this=0x13ee040, __in_chrg=<optimized out>) at include/wx/webview.h:96
 #34 0x00007ffff7bd3443 in wxWebViewWebKit::~wxWebViewWebKit (this=0x13ee040, __in_chrg=<optimized out>) at include/wx/gtk/webview_webkit.h:26
 #35 0x00007ffff7bd34ae in wxWebViewWebKit::~wxWebViewWebKit (this=0x13ee040, __in_chrg=<optimized out>) at include/wx/gtk/webview_webkit.h:26

Fix this by setting m_isBeingDeleted flag for wxWebViewWebKit early and
checking it in the callback.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72173 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd missing wxSTDCALL to fix wxWebView compilation with Borland.
Vadim Zeitlin [Mon, 23 Jul 2012 15:03:01 +0000 (15:03 +0000)] 
Add missing wxSTDCALL to fix wxWebView compilation with Borland.

This patch from Guru Kathiresan fixes compilation with Borland C++ Builder
2007 and XE2.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72172 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoDocument wxGTK limitation for accelerators involving Shift.
Vadim Zeitlin [Mon, 23 Jul 2012 15:02:57 +0000 (15:02 +0000)] 
Document wxGTK limitation for accelerators involving Shift.

Using Shift with non-alphabetic characters doesn't work due to GTK+ bug, see
https://bugzilla.gnome.org/show_bug.cgi?id=614146

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72171 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoDon't change client size of TLW when centering it in wxGTK.
Vadim Zeitlin [Mon, 23 Jul 2012 15:02:53 +0000 (15:02 +0000)] 
Don't change client size of TLW when centering it in wxGTK.

Setting the frame client size and then calling Centre() on it resulted in the
frame coming up with a wrong client size in wxGTK because the call to Centre()
resulted in calling wxTopLevelWindow::DoSetSize() which unconditionally reset
m_deferShowAllowed to true, undoing setting it to false in DoSetClientSize().

Only reset m_deferShowAllowed if the size was really changed but not if the
window was only moved, as happens when centering it.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72170 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agofixing capture problem for mouse moved events, fixes #14486
Stefan Csomor [Mon, 23 Jul 2012 13:18:47 +0000 (13:18 +0000)] 
fixing capture problem for mouse moved events, fixes #14486

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72169 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix typo introduced in r72167.
Václav Slavík [Sun, 22 Jul 2012 10:07:40 +0000 (10:07 +0000)] 
Fix typo introduced in r72167.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72168 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoDocument wxWindow::Close() return value.
Václav Slavík [Sun, 22 Jul 2012 09:21:34 +0000 (09:21 +0000)] 
Document wxWindow::Close() return value.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72167 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoturning off undo for setter, otherwise memory gets used up for the undo stack, fixes...
Stefan Csomor [Sat, 21 Jul 2012 05:14:44 +0000 (05:14 +0000)] 
turning off undo for setter, otherwise memory gets used up for the undo stack, fixes #14500

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72166 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoCall Realize() later in XRC toolbar handler (patch #13888).
Václav Slavík [Fri, 20 Jul 2012 20:23:45 +0000 (20:23 +0000)] 
Call Realize() later in XRC toolbar handler (patch #13888).

This is a workaround for a deeper compatibility problem in Cocoa
implementation (see the bug for detailed discussion), but for now, this
simple workaround is much better than not doing nothing.

See #13888.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72164 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoNo changes, just fix some typos in comments.
Vadim Zeitlin [Fri, 20 Jul 2012 11:55:18 +0000 (11:55 +0000)] 
No changes, just fix some typos in comments.

Closes #14494.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72163 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoRemove unnecessary configure options from wxOSX install.txt.
Vadim Zeitlin [Fri, 20 Jul 2012 11:55:14 +0000 (11:55 +0000)] 
Remove unnecessary configure options from wxOSX install.txt.

There is no need to specify --enable-unicode nor --disable-shared. The latter
is mentioned below anyhow.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72162 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoUse both URL-specific and plain text formats in wxGTK wxURLDataObject.
Vadim Zeitlin [Fri, 20 Jul 2012 11:55:10 +0000 (11:55 +0000)] 
Use both URL-specific and plain text formats in wxGTK wxURLDataObject.

Just as in wxMSW, it makes sense to put URLs on clipboard (or drag them) in
both URL-specific and plain text formats to facilitate pasting (or dropping)
them into other applications.

So make wxURLDataObject in wxGTK a composite data object containing both its
old data object and wxTextDataObject.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72161 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoUse proper format in wxGTK clipboard selection handler.
Vadim Zeitlin [Fri, 20 Jul 2012 11:55:04 +0000 (11:55 +0000)] 
Use proper format in wxGTK clipboard selection handler.

For some incomprehensible reason, GDK_SELECTION_TYPE_STRING was hard coded for
all non-text formats even though it was clearly never the right format to use.
Use the correct value specified by the format instead.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72160 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoUse text/uri-list instead of x-moz-url in wxGTK wxURLDataObject.
Vadim Zeitlin [Fri, 20 Jul 2012 11:55:00 +0000 (11:55 +0000)] 
Use text/uri-list instead of x-moz-url in wxGTK wxURLDataObject.

The standard exchange format for URLs is text/uri-list and not the deprecated
and Firefox-specific x-moz-url, support for which was moreover implemented
incorrectly anyhow.

Also add an example of copying URLs to the dnd sample.

See https://developer.mozilla.org/En/DragDrop/Recommended_Drag_Types for more
information.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72159 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoDon't use delayed destruction for sockets in other threads.
Vadim Zeitlin [Fri, 20 Jul 2012 11:54:56 +0000 (11:54 +0000)] 
Don't use delayed destruction for sockets in other threads.

The delayed destruction mechanism is not MT-safe, so using it for wxSocket
objects destroyed from threads other than main resulted in crashes. Luckily,
it is not necessary to use it for such sockets anyhow as they don't risk
receiving any events -- which are only dispatched in the main thread -- and so
can be destroyed immediately.

So do destroy them directly instead of just scheduling for later destruction
when wxSocket::Destroy() is called.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72158 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agosimplify mouse button handling code
Paul Cornett [Fri, 20 Jul 2012 04:59:20 +0000 (04:59 +0000)] 
simplify mouse button handling code

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72157 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoI think the "specific to PostScript" methods have been gone since 2.6, so let's stop...
Robin Dunn [Fri, 20 Jul 2012 00:53:31 +0000 (00:53 +0000)] 
I think the "specific to PostScript" methods have been gone since 2.6, so let's stop saying that they are there but undocumented.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72148 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoimprove appearance of themed borders
Paul Cornett [Thu, 19 Jul 2012 15:39:48 +0000 (15:39 +0000)] 
improve appearance of themed borders

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72146 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoInterface fixes for Phoenix
Robin Dunn [Thu, 19 Jul 2012 06:46:44 +0000 (06:46 +0000)] 
Interface fixes for Phoenix

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72143 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoReverted format changes since 2.9 works differently
Julian Smart [Wed, 18 Jul 2012 15:00:38 +0000 (15:00 +0000)] 
Reverted format changes since 2.9 works differently

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72137 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoString formatting fixes
Julian Smart [Wed, 18 Jul 2012 14:04:34 +0000 (14:04 +0000)] 
String formatting fixes

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72136 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoString formatting fix
Julian Smart [Wed, 18 Jul 2012 14:01:46 +0000 (14:01 +0000)] 
String formatting fix

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72135 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoadapting order to preference
Stefan Csomor [Mon, 16 Jul 2012 19:12:48 +0000 (19:12 +0000)] 
adapting order to preference

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72115 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agocorrect handling of order of preference of formats
Stefan Csomor [Mon, 16 Jul 2012 19:09:34 +0000 (19:09 +0000)] 
correct handling of order of preference of formats

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72114 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoremoving workaround for listbox, finishing drop target support, fixes #14484, see...
Stefan Csomor [Sun, 15 Jul 2012 18:05:17 +0000 (18:05 +0000)] 
removing workaround for listbox, finishing drop target support, fixes #14484, see #14281

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72108 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoA better panel label font size on Mac
Julian Smart [Sun, 15 Jul 2012 10:26:56 +0000 (10:26 +0000)] 
A better panel label font size on Mac

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72098 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdded continuation bullet style for supporting multiple paragraphs in a list item
Julian Smart [Sun, 15 Jul 2012 06:42:15 +0000 (06:42 +0000)] 
Added continuation bullet style for supporting multiple paragraphs in a list item
The user can 'delete' the bullet to create a continuation paragraph

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72096 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agosimplify ifdefs, deferred show and _NET_FRAME_EXTENTS are X11-only
Paul Cornett [Sun, 15 Jul 2012 01:40:39 +0000 (01:40 +0000)] 
simplify ifdefs, deferred show and _NET_FRAME_EXTENTS are X11-only

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72095 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd wxSHOW_EFFECT_MAX
Robin Dunn [Sat, 14 Jul 2012 21:36:44 +0000 (21:36 +0000)] 
Add wxSHOW_EFFECT_MAX

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72087 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd missing Calc[Un]ScrolledPosition overloads taking a wxPoint.
Robin Dunn [Sat, 14 Jul 2012 21:36:38 +0000 (21:36 +0000)] 
Add missing Calc[Un]ScrolledPosition overloads taking a wxPoint.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72086 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd missing wxEVT_COMMAND_TEXT_ENTER
Robin Dunn [Sat, 14 Jul 2012 21:36:31 +0000 (21:36 +0000)] 
Add missing wxEVT_COMMAND_TEXT_ENTER

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72085 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd missing styles
Robin Dunn [Sat, 14 Jul 2012 21:36:25 +0000 (21:36 +0000)] 
Add missing styles

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72084 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd documentation for CURRENCY and SCODE wxVariant classes.
Vadim Zeitlin [Sat, 14 Jul 2012 21:35:04 +0000 (21:35 +0000)] 
Add documentation for CURRENCY and SCODE wxVariant classes.

This should have been part of r72081.

See #14225.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72083 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoRefactor wxMSW helper functions to allow reuse in wxGTK.
Vadim Zeitlin [Sat, 14 Jul 2012 20:11:04 +0000 (20:11 +0000)] 
Refactor wxMSW helper functions to allow reuse in wxGTK.

Extract wxMSW-specific part of src/msw/utilsgui.cpp into a new
src/msw/utilswin.cpp file to allow reuse the rest of the former file in wxGTK.

Closes #14424.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72082 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd support for CURRENCY and SCODE to MSW OLE helpers.
Vadim Zeitlin [Sat, 14 Jul 2012 20:10:58 +0000 (20:10 +0000)] 
Add support for CURRENCY and SCODE to MSW OLE helpers.

This allows to call OLE Automation methods taking parameters or returning
values of these types.

Closes #14225.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72081 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoDisable the recently added wxFileSystemWatcher unit case under Windows.
Vadim Zeitlin [Sat, 14 Jul 2012 20:10:54 +0000 (20:10 +0000)] 
Disable the recently added wxFileSystemWatcher unit case under Windows.

It currently fails there, so don't run it until this is fixed to let the tests
pass globally.

See #14480.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72080 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoMinor fixes to wxGTK3 with Broadway backend build.
Vadim Zeitlin [Sat, 14 Jul 2012 20:10:50 +0000 (20:10 +0000)] 
Minor fixes to wxGTK3 with Broadway backend build.

Reuse some functions for both Broadway and X11 backends. Fix invalid casts
from Broadway screen/display types to X11 ones.

Closes #14469.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72079 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agofix creation of wxBitmapComboBox with GTK3
Paul Cornett [Sat, 14 Jul 2012 05:26:59 +0000 (05:26 +0000)] 
fix creation of wxBitmapComboBox with GTK3

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72076 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAllow building wxGTK3 with Broadway backend.
Vadim Zeitlin [Fri, 13 Jul 2012 18:22:22 +0000 (18:22 +0000)] 
Allow building wxGTK3 with Broadway backend.

Use GDK_WINDOWING_BROADWAY to fix compilation with it.

Closes #14469.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72075 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix for caret positioning bug when selecting content
Julian Smart [Fri, 13 Jul 2012 18:11:24 +0000 (18:11 +0000)] 
Fix for caret positioning bug when selecting content

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72074 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoavoid creating and immediately destroying a wxGraphicsContext when creating a wxDC...
Paul Cornett [Fri, 13 Jul 2012 16:58:37 +0000 (16:58 +0000)] 
avoid creating and immediately destroying a wxGraphicsContext when creating a wxDC with wxGTK3

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72073 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFixed wxRichTextCtrl caret test case
Julian Smart [Fri, 13 Jul 2012 16:38:15 +0000 (16:38 +0000)] 
Fixed wxRichTextCtrl caret test case

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72072 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoRename wxFileSystemWatcherBase::DoAdd() to AddAny() and make it public.
Vadim Zeitlin [Fri, 13 Jul 2012 12:00:14 +0000 (12:00 +0000)] 
Rename wxFileSystemWatcherBase::DoAdd() to AddAny() and make it public.

Make this method public to fix compilation after the recent changes as
traverser classes can't call it otherwise (no idea why did it compile with
g++). And give it a better name just in case people decide to call it even
though it's not documented and described as private in comment (but perhaps we
could make it really public later).

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72071 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd possibility to hide and show again wxRibbonBar pages.
Vadim Zeitlin [Fri, 13 Jul 2012 11:46:43 +0000 (11:46 +0000)] 
Add possibility to hide and show again wxRibbonBar pages.

Added wxRibbonBar::ShowPage(), HidePage() and IsPageShown() methods and show
them in the sample.

Also add GetPageNumber() helper.

Closes #14471.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72070 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoGenerate tags for ribbon headers and sources too.
Vadim Zeitlin [Fri, 13 Jul 2012 11:46:39 +0000 (11:46 +0000)] 
Generate tags for ribbon headers and sources too.

Add the files in {include/wx,src}/ribbon to the list of ctags inputs.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72069 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoTest calling wxFileSystemWatcher::{Add,Remove}Tree().
Vadim Zeitlin [Fri, 13 Jul 2012 11:22:13 +0000 (11:22 +0000)] 
Test calling wxFileSystemWatcher::{Add,Remove}Tree().

Add a test for tree monitoring functions to the unit test.

See #14480.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72068 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoProperly use RemoveTree() in fswatcher sample.
Vadim Zeitlin [Fri, 13 Jul 2012 11:22:10 +0000 (11:22 +0000)] 
Properly use RemoveTree() in fswatcher sample.

We need to use RemoveTree() to remove watches for the paths added with
AddTree().

See #14480.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72067 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd the root and all the files in wxFileSystemWatcherBase::AddTree().
Vadim Zeitlin [Fri, 13 Jul 2012 11:22:06 +0000 (11:22 +0000)] 
Add the root and all the files in wxFileSystemWatcherBase::AddTree().

When watching a tree recursively, add the files and not only the directories.

Also, add -- and remove in RemoveTree() -- the root directory itself and not
only its children.

Closes #14480.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72066 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoalways use calibrated colors, fixes #14482
Stefan Csomor [Fri, 13 Jul 2012 06:51:04 +0000 (06:51 +0000)] 
always use calibrated colors, fixes #14482

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72065 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoInterface fix for Phoenix.
Robin Dunn [Thu, 12 Jul 2012 20:50:31 +0000 (20:50 +0000)] 
Interface fix for Phoenix.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72055 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix bogus asserts in Unix wxFileSystemWatcher for removed files.
Vadim Zeitlin [Thu, 12 Jul 2012 18:34:22 +0000 (18:34 +0000)] 
Fix bogus asserts in Unix wxFileSystemWatcher for removed files.

Store the recently removed file descriptors and don't assert if we get an
event for one of them, this can happen and is normal unlike unexpected events
for completely unknown descriptors for which we still keep an assert.

Closes #14465.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72049 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix item data access in wxDataViewListCtrl.
Vadim Zeitlin [Thu, 12 Jul 2012 18:34:18 +0000 (18:34 +0000)] 
Fix item data access in wxDataViewListCtrl.

Map items to rows correctly, just using wxPtrToUInt()-1 is not the right thing
to do if any items were deleted or changed.

Closes #14479.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72048 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdded more items to the release check list.
Vadim Zeitlin [Thu, 12 Jul 2012 13:18:06 +0000 (13:18 +0000)] 
Added more items to the release check list.

Mention that the change log should be uploaded too (it would be perhaps more
useful to have a change log for just this release but for now upload the
entire file) and that the llatest available version must be update on the web
site.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72047 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoNo changes, just remove TABs from configure.in.
Vadim Zeitlin [Wed, 11 Jul 2012 19:28:46 +0000 (19:28 +0000)] 
No changes, just remove TABs from configure.in.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72040 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoJust like dependency tracking don't disable precompiled headers if there is only...
Robin Dunn [Wed, 11 Jul 2012 19:16:10 +0000 (19:16 +0000)] 
Just like dependency tracking don't disable precompiled headers if there is only one architecture being built.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72039 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agofix some more improper widget casts
Paul Cornett [Wed, 11 Jul 2012 17:08:03 +0000 (17:08 +0000)] 
fix some more improper widget casts

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72033 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoUse GTK_IS_ENTRY() to determine if widget is a GtkEntry.
Paul Cornett [Wed, 11 Jul 2012 16:49:07 +0000 (16:49 +0000)] 
Use GTK_IS_ENTRY() to determine if widget is a GtkEntry.
If widget is not a GtkEntry, using GTK_ENTRY() will result in assertion or crash

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72032 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoRevert "Temporarily disable the failing wxRichTextCtrl case."
Vadim Zeitlin [Wed, 11 Jul 2012 12:16:41 +0000 (12:16 +0000)] 
Revert "Temporarily disable the failing wxRichTextCtrl case."

Revert r71945 which disabled failing wxRichTextCtrl unit test. It fails again
now and hopefully will be fixed before 2.9.5.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72031 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAllow saving images under a different name in the image sample.
Vadim Zeitlin [Wed, 11 Jul 2012 11:42:47 +0000 (11:42 +0000)] 
Allow saving images under a different name in the image sample.

Also allow saving in XPM format.

See #13905.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72030 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoEnsure that names of saved XPMs are valid C identifiers.
Vadim Zeitlin [Wed, 11 Jul 2012 11:42:43 +0000 (11:42 +0000)] 
Ensure that names of saved XPMs are valid C identifiers.

The name of the XPM should be based on the file name but can't always be
exactly equal to it as it's possible (and relatively common, e.g.
"foo-24.xpm") to have characters forbidden in identifiers to appear in the
file names. Ensure that we use a valid C identifier here.

Closes #13905.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72029 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix bug with using invalid date in wxMSW wxCalendarCtrl.
Vadim Zeitlin [Wed, 11 Jul 2012 11:42:39 +0000 (11:42 +0000)] 
Fix bug with using invalid date in wxMSW wxCalendarCtrl.

Fall back to the start date of the native control if our own date was not set
yet.

Closes #14476.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72028 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoActivate OLE ActiveX controls before requesting their window.
Vadim Zeitlin [Wed, 11 Jul 2012 11:42:34 +0000 (11:42 +0000)] 
Activate OLE ActiveX controls before requesting their window.

Change the order of IOkeInPlaceActiveObject::GetWindow() and
DoVerb(OLEIVERB_INPLACEACTIVATE) calls and do the latter first now as
otherwise GetWindow() returned NULL for standard ActiveX controls created by
MFC.

Closes #14209.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72027 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoChange the format of the documentation archives for the release.
Vadim Zeitlin [Wed, 11 Jul 2012 11:42:32 +0000 (11:42 +0000)] 
Change the format of the documentation archives for the release.

Call them wxWidgets-x.y.z-docs-nnn instead of wxWidgets-docs-nnn.x.y.z.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72026 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix compilation of newly added msw/evtloopconsole.cpp without PCH.
Vadim Zeitlin [Wed, 11 Jul 2012 11:42:28 +0000 (11:42 +0000)] 
Fix compilation of newly added msw/evtloopconsole.cpp without PCH.

Include <windows.h> and "wx/log.h" explicitly when not using PCH.

Closes #14475.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72025 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agofake paint events don't work with wxGTK3 either
Paul Cornett [Wed, 11 Jul 2012 07:32:10 +0000 (07:32 +0000)] 
fake paint events don't work with wxGTK3 either

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72021 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoremove code in SetFont which modifies font for no apparent purpose
Paul Cornett [Wed, 11 Jul 2012 07:05:55 +0000 (07:05 +0000)] 
remove code in SetFont which modifies font for no apparent purpose

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72020 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAvoid creating and immediately destroying a wxGraphicsContext for most uses of wxGCDC.
Paul Cornett [Wed, 11 Jul 2012 06:36:38 +0000 (06:36 +0000)] 
Avoid creating and immediately destroying a wxGraphicsContext for most uses of wxGCDC.
This also causes the dummy "measuring context" to be properly initialized with a default font

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72019 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoInterface fixes for Phoenix.
Robin Dunn [Wed, 11 Jul 2012 04:23:58 +0000 (04:23 +0000)] 
Interface fixes for Phoenix.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72013 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoAdd missing wxFRAME_SHAPED
Robin Dunn [Wed, 11 Jul 2012 04:23:52 +0000 (04:23 +0000)] 
Add missing wxFRAME_SHAPED

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72012 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix wxNativeContainerWindowId definition for wxGTK/Windows port.
Vadim Zeitlin [Tue, 10 Jul 2012 23:52:14 +0000 (23:52 +0000)] 
Fix wxNativeContainerWindowId definition for wxGTK/Windows port.

It's a gpointer and not unsigned long as under Unix in this case.

Closes #14447.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72011 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoForbid setting hints for multi-line text controls.
Vadim Zeitlin [Tue, 10 Jul 2012 23:52:10 +0000 (23:52 +0000)] 
Forbid setting hints for multi-line text controls.

This doesn't work anyhow, so make it explicit by asserting if an attempt to do
it is made. And document this.

Also add a test of SetHint() to the text sample to verify it still works.

Closes #14456.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72010 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix German translation for "Shift+" keyboard accelerator prefix.
Vadim Zeitlin [Tue, 10 Jul 2012 23:52:05 +0000 (23:52 +0000)] 
Fix German translation for "Shift+" keyboard accelerator prefix.

Closes #14457.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72009 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoUse the same console event loop in wxBase and wxCore in wxMSW.
Vadim Zeitlin [Tue, 10 Jul 2012 23:52:00 +0000 (23:52 +0000)] 
Use the same console event loop in wxBase and wxCore in wxMSW.

Refactor the console event loop code into separate files to untangle it from
the GUI version and ensure that it doesn't depend on the GUI at all. It can
now be defined in the base library and simply reused by the core one.

This also makes the console event loop usable for other ports under Windows,
e.g. wxGTK.

Closes #14426.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72008 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoIncrease version to 2.9.5.
Vadim Zeitlin [Tue, 10 Jul 2012 23:51:44 +0000 (23:51 +0000)] 
Increase version to 2.9.5.

Rebake all the project/make files.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72007 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

11 years agoFix unit tests compilation in STL build.
Vadim Zeitlin [Tue, 10 Jul 2012 23:50:52 +0000 (23:50 +0000)] 
Fix unit tests compilation in STL build.

Add missing c_str() calls forgotten by r70687.

Closes #14472.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72006 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoremove DoSetSize override, unneeded after r72001
Paul Cornett [Tue, 10 Jul 2012 17:27:41 +0000 (17:27 +0000)] 
remove DoSetSize override, unneeded after r72001

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72004 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoremove STOCKITEM_26 macro, unneeded after r72001
Paul Cornett [Tue, 10 Jul 2012 17:26:40 +0000 (17:26 +0000)] 
remove STOCKITEM_26 macro, unneeded after r72001

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72003 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agono real changes, just remove unnecessary indentation and scoping after r72001
Paul Cornett [Tue, 10 Jul 2012 17:17:53 +0000 (17:17 +0000)] 
no real changes, just remove unnecessary indentation and scoping after r72001

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72002 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoupdate minimum GTK2 version requirement to 2.6
Paul Cornett [Tue, 10 Jul 2012 16:39:44 +0000 (16:39 +0000)] 
update minimum GTK2 version requirement to 2.6

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72001 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoGive the newly added wxGTK trunk STL builder a unique name.
Vadim Zeitlin [Tue, 10 Jul 2012 10:54:48 +0000 (10:54 +0000)] 
Give the newly added wxGTK trunk STL builder a unique name.

It conflicted with the (unused) builder on StellarWerx slave.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72000 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAdd a wxGTK STL buildbot build on brandt32 slave.
Vadim Zeitlin [Tue, 10 Jul 2012 10:50:36 +0000 (10:50 +0000)] 
Add a wxGTK STL buildbot build on brandt32 slave.

Also use --disable-compat28 as we don't have any builds testing this option.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71999 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoMake a couple virtuals protected so they can be overridden.
Robin Dunn [Tue, 10 Jul 2012 06:42:15 +0000 (06:42 +0000)] 
Make a couple virtuals protected so they can be overridden.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71998 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoInterface fixes for Phoenix.
Robin Dunn [Tue, 10 Jul 2012 05:12:05 +0000 (05:12 +0000)] 
Interface fixes for Phoenix.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71989 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAdded a release notes file for binaries.
Vadim Zeitlin [Mon, 9 Jul 2012 20:35:10 +0000 (20:35 +0000)] 
Added a release notes file for binaries.

Also create wxWidgets-x.y.z_Headers.7z file when making the release, it is
used with the binaries.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71988 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoUpdated READMEs &c for 2.9.4 release.
Vadim Zeitlin [Mon, 9 Jul 2012 14:15:37 +0000 (14:15 +0000)] 
Updated READMEs &c for 2.9.4 release.

Updated the text of the announcement posted to wx-announce too and mention it
in the release check list.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71985 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix for scroll position being changed when partial layout is done
Julian Smart [Sun, 8 Jul 2012 10:28:27 +0000 (10:28 +0000)] 
Fix for scroll position being changed when partial layout is done

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71982 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoRevert r71595 for now, as the bug it fixed is the lesser of two evils with the potent...
Robin Dunn [Sun, 8 Jul 2012 03:48:55 +0000 (03:48 +0000)] 
Revert r71595 for now, as the bug it fixed is the lesser of two evils with the potential bugs it causes.  See #14453.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71981 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agofixing double focus ring under 10.7, emulating only for 'NO_' and 'SIMPLE_' border
Stefan Csomor [Sat, 7 Jul 2012 16:34:14 +0000 (16:34 +0000)] 
fixing double focus ring under 10.7, emulating only for 'NO_' and 'SIMPLE_' border

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71980 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoReplace "_amd64" with "_x64" in a few more places.
Vadim Zeitlin [Sat, 7 Jul 2012 15:36:58 +0000 (15:36 +0000)] 
Replace "_amd64" with "_x64" in a few more places.

Fix bakefile presets and MSVC-specific setup.h.

Also document TARGET_CPU=X64 instead of AMD64.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71979 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoUse "_x64" instead of "amd64" for x64 MSW makefile builds.
Vadim Zeitlin [Sat, 7 Jul 2012 13:27:59 +0000 (13:27 +0000)] 
Use "_x64" instead of "amd64" for x64 MSW makefile builds.

Still accept "amd64" as a valid TARGET_CPU value but also accept, and
encourage people to use, "x64".

Add a new section about the build system changes to the change log and added a
mini-TOC to it to make navigating it a bit easier and show what changes are
there at a glance.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71978 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoDon't call HitTest() unnecessarily in MSW wxTreeCtrl code.
Vadim Zeitlin [Sat, 7 Jul 2012 13:27:55 +0000 (13:27 +0000)] 
Don't call HitTest() unnecessarily in MSW wxTreeCtrl code.

We already called TreeView_HitTest() above, there is no need to call
wxTreeCtrl::HitTest() again to retrieve exactly the same information.

This also incidentally fixes a warning about unused variable, see #14459.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71977 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoFix uninitialized variable warning in wxMSW wxFileSystemWatcher code.
Vadim Zeitlin [Sat, 7 Jul 2012 13:27:51 +0000 (13:27 +0000)] 
Fix uninitialized variable warning in wxMSW wxFileSystemWatcher code.

This warning was harmless as the variable was in fact always initialized if
the code where it was used was reached but g++ 4.6.1 is not smart enough to
see it, just as MSVC for which we already had a workaround. So initialize it
explicitly just to suppress the warning.

See #14459.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71976 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAvoid warnings about uninitialized variables in TGA loading code.
Vadim Zeitlin [Sat, 7 Jul 2012 13:27:47 +0000 (13:27 +0000)] 
Avoid warnings about uninitialized variables in TGA loading code.

Initialize the variables containing the colour components: even though they
should normally be always filled by Palette_GetRGB() call below, this
presumably might not happen for a corrupted image with invalid palette table
entries and g++ correctly complains about it.

See #14459.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71975 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAvoid warning about unused variable in wxGetUTCTimeMillis() in wxMSW.
Vadim Zeitlin [Sat, 7 Jul 2012 13:27:44 +0000 (13:27 +0000)] 
Avoid warning about unused variable in wxGetUTCTimeMillis() in wxMSW.

Put the declaration of the variable only used under Unix inside the
corresponding "#if" branch.

See #14459.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71974 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoAvoid unused variable warning in wxPropertyGrid code in non-wxGTK.
Vadim Zeitlin [Sat, 7 Jul 2012 13:27:40 +0000 (13:27 +0000)] 
Avoid unused variable warning in wxPropertyGrid code in non-wxGTK.

Put the variable only used in wxGTK inside "#ifdef __WXGTK__".

This fixes the warning but the real fix would be to get rid of this variable
completely and just fix whatever problem in wxWindow::Navigate() this was
supposed to work around.

See #14459.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71973 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoExplicitly call base class ctor in wxRichTextFieldType copy ctor.
Vadim Zeitlin [Sat, 7 Jul 2012 13:27:36 +0000 (13:27 +0000)] 
Explicitly call base class ctor in wxRichTextFieldType copy ctor.

Failure to do this provokes g++ warnings with -Wextra and is, generally
speaking, wrong, even if it probably doesn't matter in this particular case.

See #14459.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71972 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

12 years agoReturn correct index from wxGenericListCtrl::InsertColumn().
Vadim Zeitlin [Sat, 7 Jul 2012 13:27:31 +0000 (13:27 +0000)] 
Return correct index from wxGenericListCtrl::InsertColumn().

It used to always return 0 in the generic version, return the correct index of
the newly inserted column now.

Closes #13677.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71971 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775